Re: Review Request: Add reply and retweet buttons in each tweet/dent of the microblog applet to quickly reply someone or retweet some message.

2009-11-03 Thread Nicolas Réau
On 2009-11-02 17:34:56, Marco Martin wrote: /trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp, line 554 http://reviewboard.kde.org/r/2032/diff/1/?file=13582#file13582line554 everything in the tweetframe should become a single Anchorlayout. eventually after commit too

Re: Review Request: wetter.com Weather Ion

2009-11-03 Thread Will Stephenson
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2026/#review2901 --- /trunk/kdereview/plasma/dataengines/weather/ions/ion_wettercom.cpp

Re: Review Request: plasmapkg wallpaper

2009-11-03 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2006/#review2903 --- /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp

Re: Review Request: plasmapkg wallpaper

2009-11-03 Thread Petri Damstén
On 2009-11-03 17:07:50, Aaron Seigo wrote: /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp, lines 137-138 http://reviewboard.kde.org/r/2006/diff/2/?file=13546#file13546line137 does this work for zip'd up packages as well? Plasma::PackageStructure reads metadata from zip

Re: Review Request: Digital Clock applet date formatting

2009-11-03 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1877/ --- (Updated 2009-11-04 01:05:16.263057) Review request for Plasma. Changes

Re: Review Request: Add missing functions to RunnerScript

2009-11-03 Thread Petri Damstén
On 2009-11-03 17:06:58, Aaron Seigo wrote: /trunk/KDE/kdelibs/plasma/scripting/runnerscript.h, lines 87-98 http://reviewboard.kde.org/r/2054/diff/1/?file=13668#file13668line87 can't add new virtual members; it's BIC. the prepare and teardown slots are unecessary as the signals

thinking ahead to 4.5: features or polish?

2009-11-03 Thread Aaron J. Seigo
hi all .. i spent some time today thinking about challenges as well as opportunities that exist for our little Plasma baby who is growing up at an amazing pace. just to give you an idea of where we're at in terms of raw code production, here are some sloccount counts: kdelibs: 42,121 runtime:

Re: Review Request: wetter.com Weather Ion

2009-11-03 Thread Thilo-Alexander Ginkel
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2026/ --- (Updated 2009-11-03 19:51:12.510139) Review request for kdelibs, Plasma and

Re: Review Request: Add missing functions to RunnerScript

2009-11-03 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2054/#review2917 --- /trunk/KDE/kdelibs/plasma/abstractrunner.h

Re: Review Request: wetter.com Weather Ion

2009-11-03 Thread Thilo-Alexander Ginkel
On 2009-11-03 17:00:51, Will Stephenson wrote: /trunk/kdereview/plasma/dataengines/weather/ions/ion_wettercom.cpp, line 44 http://reviewboard.kde.org/r/2026/diff/2/?file=13614#file13614line44 By convention, public member variables of pimpl classes are not names with m_ prefixes -