Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)

2012-08-22 Thread Richard Stockton
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106125/ --- (Updated Aug. 23, 2012, 12:28 a.m.) Review request for Plasma, Lamarque Vi

Re: Review Request: Activities KCM

2012-08-22 Thread Ivan Čukić
On Wednesday, 22. August 2012. 22.33.11 David Edmundson wrote: >... Code comments fixed or replied. BTW, thanks for a *very* quick review dude! Cheerio, Ivan -- Progress isn't made by early risers. It's made by lazy men trying to find easier ways to do something. -- Robert Heinlein signatu

Re: Review Request: Activities KCM

2012-08-22 Thread Ivan Čukić
> On Aug. 22, 2012, 10:33 p.m., David Edmundson wrote: > > src/workspace/settings/CMakeLists.txt, line 15 > > > > > > capital letter in class filename isn't typically usual, and doesn't > > match any other cpp in ka

Re: Review Request: Activities KCM

2012-08-22 Thread Ivan Čukić
> Try to avoid nesting GroupBoxes, especially inside a TabWidget, you get this > box inside boxes inside boxes effect. A list of radio buttons should have a > question above. In this case you're using the groupbox title as the > question. > > You may find the first one works better simply as a lab

Re: Review Request: Activities KCM

2012-08-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106130/#review17886 --- UI review based on the screenshots in your email to plasma-deve

Re: Activities KCM

2012-08-22 Thread Ivan Čukić
Officially starting two-week review period: https://git.reviewboard.kde.org/r/106130/ Ch! -- So remember when you're feeling very small and insecure How amazingly unlikely is your birth And pray that there's intelligent life somewhere up in space Because there's bugger all down here on earth.

Review Request: Activities KCM

2012-08-22 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106130/ --- Review request for Plasma. Description --- System settings module for

Re: Review Request: Kickoff-Widget: Add Key_Tab support for navigation from search Bar (4.8)

2012-08-22 Thread Richard Stockton
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106123/ --- (Updated Aug. 22, 2012, 9:06 p.m.) Review request for Plasma, Lamarque Vie

Re: Review Request: Kickoff-Widget: Add Key_Tab support for navigation from search Bar (4.8)

2012-08-22 Thread Richard Stockton
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106123/ --- (Updated Aug. 22, 2012, 9:06 p.m.) Review request for Plasma, Lamarque Vie

Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)

2012-08-22 Thread Richard Stockton
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106125/ --- (Updated Aug. 22, 2012, 7:59 p.m.) Review request for Plasma, Lamarque Vie

Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)

2012-08-22 Thread Richard Stockton
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106125/ --- Review request for Plasma, Lamarque Vieira Souza and Martin Gräßlin. Descr

Re: Review Request: KRunner Bookmarks: implement Chrome/Chromium support

2012-08-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105673/#review17876 --- Ship it! Ship It! - Marco Martin On July 26, 2012, 10:23 a.

Re: Review Request: KRunner Bookmarks: implement Chrome/Chromium support

2012-08-22 Thread Marco Martin
> On July 26, 2012, 10:57 a.m., Marco Martin wrote: > > what i can say quickly looking at it is that it looks cleaner and more > > expandible than the old one. > > of course is a bit big, so will indeed need more testing, but most > > important thing for the first merge is that there aren't sig

Re: Activities KCM

2012-08-22 Thread Ivan Čukić
> and in a kcm is quite confusing (and generates useless chrome) > so i would really not have something like kamdsettings1.png Awesome - I'm now guilt-free for removing that part :) (though, playing again with qml a bit was fun :D) Cheerio! -- So remember when you're feeling very small and

Re: Review Request: KRunner Bookmarks: implement Chrome/Chromium support

2012-08-22 Thread Marco Gulino
> On July 26, 2012, 10:57 a.m., Marco Martin wrote: > > what i can say quickly looking at it is that it looks cleaner and more > > expandible than the old one. > > of course is a bit big, so will indeed need more testing, but most > > important thing for the first merge is that there aren't sig

Re: Activities KCM

2012-08-22 Thread Marco Martin
On Wednesday 22 August 2012, Ivan Čukić wrote: > Hi all, > > What would you like to see configurable in activities? > > > Currently planned (and mostly finished): > - plugins selection > - choosing which applications' documents should be stored in > history (all, none, choosing the specifi

Review Request: Kickoff GUI: Provide Key_Tab to move from search view to other views.

2012-08-22 Thread Richard Stockton
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106123/ --- Review request for Plasma, Lamarque Vieira Souza and Martin Gräßlin. Descr

Activities KCM

2012-08-22 Thread Ivan Čukić
Hi all, What would you like to see configurable in activities? Currently planned (and mostly finished): - plugins selection - choosing which applications' documents should be stored in history (all, none, choosing the specific ones [1]), for how long - clearing the history (like in firefo

Re: Review Request: Dictionary Runner

2012-08-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106068/#review17871 --- Ship it! i am using it since a while and doesn't seem to be pr

Re: Review Request: Dictionary Runner

2012-08-22 Thread Jason A. Donenfeld
Any takers? On Sat, Aug 18, 2012 at 5:57 AM, Jason A. Donenfeld wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106068/ > Review request for Plasma, Jason A. Donenfeld and Aaron J. Seigo. > By Jason A. Donenfeld. > Description > > Jaso

Re: Re: [RFC] Merging LightDM into KDE Workspaces

2012-08-22 Thread David Edmundson
On Wed, Aug 22, 2012 at 2:06 PM, Daniel Nicoletti wrote: > Though I have nothing against this move, I'd like to ask a dumb > question (well maybe not that dumb): > Since lightDM-kde greeter is (AFAIK) pretty much just an interface > for lightDM, and since I myself find the user interface much more

Re: Re: [RFC] Merging LightDM into KDE Workspaces

2012-08-22 Thread Daniel Nicoletti
Though I have nothing against this move, I'd like to ask a dumb question (well maybe not that dumb): Since lightDM-kde greeter is (AFAIK) pretty much just an interface for lightDM, and since I myself find the user interface much more user friendly than KDM's one, isn't it possible to remove the GUI

Re: [RFC] Merging LightDM into KDE Workspaces

2012-08-22 Thread David Edmundson
Sure makes sense. Forwarded. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: [RFC] Merging LightDM into KDE Workspaces

2012-08-22 Thread Martin Gräßlin
Am 22.08.2012 13:43, schrieb Dario Freddi: 2012/8/22 Dario Freddi : As much as I am +1-ing this, I think k-c-d should have been included in the announcement, since this is not something which regards Plasma sorry - regards *only* Plasma I think it was just fine to check with Plasma devs first

Re: [RFC] Merging LightDM into KDE Workspaces

2012-08-22 Thread Aleix Pol
On Wednesday 22 August 2012 13:42:53 Dario Freddi wrote: > As much as I am +1-ing this, I think k-c-d should have been included > in the announcement, since this is not something which regards Plasma > - in general, these kind of things have to go through k-c-d anyway. > > 2012/8/21 Alex Fiestas :

Re: Re: [RFC] Merging LightDM into KDE Workspaces

2012-08-22 Thread Dario Freddi
2012/8/22 Dario Freddi : > As much as I am +1-ing this, I think k-c-d should have been included > in the announcement, since this is not something which regards Plasma sorry - regards *only* Plasma > - in general, these kind of things have to go through k-c-d anyway. > > 2012/8/21 Alex Fiestas :

Re: Re: [RFC] Merging LightDM into KDE Workspaces

2012-08-22 Thread Dario Freddi
As much as I am +1-ing this, I think k-c-d should have been included in the announcement, since this is not something which regards Plasma - in general, these kind of things have to go through k-c-d anyway. 2012/8/21 Alex Fiestas : > Big +1 for me. > > Personally I have switched to lightDM long ag

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

2012-08-22 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/#review17847 --- mainwindow.cpp

Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

2012-08-22 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/ --- Review request for kwin, Plasma, Sebastian Kügler, Martin Gräßlin, and Giorg

Re: Review Request: NepomukRunner: Port to NepomukCore

2012-08-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106117/#review17846 --- This review has been submitted with commit e132740f3e5990bde86

Re: Review Request: Make autohide panel do not intercept events in fullscreen app

2012-08-22 Thread Alexey Shmalko
> On Aug. 21, 2012, 10:24 a.m., Christoph Feck wrote: > > If this "feature" is going to be implemented, it should be configurable. If > > you are only using a mouse (or stylus on a Tablet PC), then you would have > > no way to reach the panel in full-screen mode. The better solution would be >

Re: Review Request: NepomukRunner: Port to NepomukCore

2012-08-22 Thread Sebastian Trueg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106117/#review17834 --- Ship it! Ship It! - Sebastian Trueg On Aug. 22, 2012, 7:05

Review Request: NepomukRunner: Port to NepomukCore

2012-08-22 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106117/ --- Review request for Nepomuk, Plasma and Sebastian Trueg. Description --