Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106965/ --- (Updated Oct. 22, 2012, 9:03 a.m.) Review request for Plasma, Aaron J.

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106965/ --- (Updated Oct. 22, 2012, 9:19 a.m.) Review request for Plasma, Aaron J.

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
On Oct. 20, 2012, 11:18 a.m., Marco Martin wrote: plasma/generic/applets/systemtray/ui/wheelarea.h, line 1 http://git.reviewboard.kde.org/r/106965/diff/1/?file=91357#file91357line1 this implementation is not necessary, a wheelevent was added in org.kde.qtextracomponents in

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Marco Martin
On Oct. 20, 2012, 11:18 a.m., Marco Martin wrote: plasma/generic/applets/systemtray/ui/wheelarea.h, line 1 http://git.reviewboard.kde.org/r/106965/diff/1/?file=91357#file91357line1 this implementation is not necessary, a wheelevent was added in org.kde.qtextracomponents in

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106965/#review20657 --- Ship it! to me is good to go :) - Marco Martin On Oct. 22,

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
On Oct. 21, 2012, 12:14 a.m., Kai Uwe Broulik wrote: plasma/generic/applets/systemtray/package/contents/ui/IconsGrid.qml, line 29 http://git.reviewboard.kde.org/r/106965/diff/1/?file=91322#file91322line29 Can you make the size honour the global KDE icon size settings? This would

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
On Oct. 20, 2012, 11:18 a.m., Marco Martin wrote: plasma/generic/applets/systemtray/ui/wheelarea.h, line 1 http://git.reviewboard.kde.org/r/106965/diff/1/?file=91357#file91357line1 this implementation is not necessary, a wheelevent was added in org.kde.qtextracomponents in

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Kai Uwe Broulik
On Oct. 21, 2012, 12:14 a.m., Kai Uwe Broulik wrote: plasma/generic/applets/systemtray/package/contents/ui/IconsGrid.qml, line 29 http://git.reviewboard.kde.org/r/106965/diff/1/?file=91322#file91322line29 Can you make the size honour the global KDE icon size settings? This would

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Marco Martin
On Oct. 21, 2012, 12:14 a.m., Kai Uwe Broulik wrote: plasma/generic/applets/systemtray/package/contents/ui/IconsGrid.qml, line 29 http://git.reviewboard.kde.org/r/106965/diff/1/?file=91322#file91322line29 Can you make the size honour the global KDE icon size settings? This would

Stackfolder inclusion to 4.10 [attempt#2]

2012-10-22 Thread Ural Mullabaev
Hi Aaron and Marco! I fixed the problems which you specified the last time: - icon decreasing on the panel (attachment - smallicon.png); - empty popup dialog (now it should show correctly) And also I changed path to the qml contents to prefix/plasma/packages/org.kde.stackfolder. Now what else

plans for Plasma Desktop default containment in QML

2012-10-22 Thread Sebastian Kügler
Hi fellow Plasma devs, I've been working on a QML port of our default desktop containment. It's still very immature, and a few feature are lacking, but it lead me to think about how we could go about replacing the default desktop with this eventually. Now it won't be ready (in sufficient

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
On Oct. 21, 2012, 12:14 a.m., Kai Uwe Broulik wrote: plasma/generic/applets/systemtray/package/contents/ui/IconsGrid.qml, line 29 http://git.reviewboard.kde.org/r/106965/diff/1/?file=91322#file91322line29 Can you make the size honour the global KDE icon size settings? This would

Re: Review Request: refactor the package model

2012-10-22 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106742/#review20679 --- one small API issue, otherwise looks great.

Re: Review Request: load the images for the themes correctly

2012-10-22 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106680/#review20680 --- plasmate/packagemodel.cpp

Re: SystemTray: QML version #3

2012-10-22 Thread Luca Beltrame
In data giovedì 18 ottobre 2012 09:50:49, Dmitry Ashkadov ha scritto: Hello, I've made several changes to system tray with interface in QML (plasma/dmitrya/systemtray-qml branch of kde-workspace): I've been playing with this for a bit and I noticed a regression with applications that paint

Re: plans for Plasma Desktop default containment in QML

2012-10-22 Thread todd rme
On Mon, Oct 22, 2012 at 1:33 PM, Sebastian Kügler se...@kde.org wrote: Hi fellow Plasma devs, I've been working on a QML port of our default desktop containment. It's still very immature, and a few feature are lacking, but it lead me to think about how we could go about replacing the default

Re: plans for Plasma Desktop default containment in QML

2012-10-22 Thread Sebastian Kügler
On Monday, October 22, 2012 17:19:32 todd rme wrote: Can you submit it to kde-look.org in the meantime? Does plasma support installing containments through GHNS? Sure, and I don't know. :) I'll roll a package once I've got a few more features in, and when feedback starts making sense (i.e.

kickoff qml

2012-10-22 Thread Marco Martin
Hi all, one thing i would like to have merged for 4.10 is the qml port of kickoff. i have been looking at it past few days, and it seems to have most of the features, even tough is still quite rough, i'm not 100% sure it may be ready yet. i've fixed some things in last couple of days, it still

slc repo as dependency

2012-10-22 Thread Marco Martin
Hi all, since freeze is looming, if we want to use slc in 4.10 by default, its repository should become part of sc and be a dependency of kde-workspace (if a default applet) what is the procedure for that? Cheers, Marco Martin ___ Plasma-devel

slc menu

2012-10-22 Thread Marco Martin
Hi all, at the moment, the share-like-connect menus are done in the following way, the menu is actually an exported component that can be used anywhere with import org.kde.sharelikeconnect this is used by the active containment where there is share-like-connect menus as a context menus for

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106965/#review20690 --- Since 4.9 it is possible to use special property windowId of

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106965/ --- (Updated Oct. 22, 2012, 6:51 p.m.) Review request for Plasma, Aaron J.

Re: Kickoff-qml

2012-10-22 Thread Rick Stockton
On 10/22/2012 10:16 AM, Marco Martin notm...@gmail.com wrote: Hi all, one thing i would like to have merged for 4.10 is the qml port of kickoff. i have been looking at it past few days, and it seems to have most of the features, even tough is still quite rough, i'm not 100% sure it may be

Re: Doxyqml, supporting type

2012-10-22 Thread Aleix Pol
On Mon, Oct 22, 2012 at 5:12 PM, Aurélien Gâteau agat...@kde.org wrote: Hi, I have been working a bit more on Doxyqml, the Doxygen input filter for QML [1]. It now uses a more robust parser, is growing a test-suite and can override types when needed, allowing you to specify types for function

Review Request: Make the Activity Manager's iconButton inside the configuration component to layout correctly in an horizontal layout.

2012-10-22 Thread Diego Casella
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106999/ --- Review request for Plasma and Marco Martin. Description --- When you

Re: Review Request: Make the Activity Manager's iconButton inside the configuration component to layout correctly in an horizontal layout.

2012-10-22 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106999/#review20709 --- Is it tested only with Air or also with other plasma themes?

Re: Review Request: Make the Activity Manager's iconButton inside the configuration component to layout correctly in an horizontal layout.

2012-10-22 Thread Diego Casella
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106999/ --- (Updated Oct. 22, 2012, 11:01 p.m.) Review request for Plasma and Marco

Review Request: Port the Calculator applet to QML

2012-10-22 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107001/ --- Review request for Plasma. Description --- This diff replaces the