Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

> On Nov. 6, 2012, 1:39 p.m., Aaron J. Seigo wrote: > > one small issue with where hiding status is kept. > > > > it may be useful to keep in mind the difference between the data and the > > visualization -> anything that the use can see (e.g. whether an icon is > > hidden or not) is visualiza

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

> On Nov. 6, 2012, 1:39 p.m., Aaron J. Seigo wrote: > > one small issue with where hiding status is kept. > > > > it may be useful to keep in mind the difference between the data and the > > visualization -> anything that the use can see (e.g. whether an icon is > > hidden or not) is visualiza

Re: Review Request: Declarative bindings for ToolBox

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107150/#review21522 --- I've redone this patch, submitted a new review request: https:

Review Request: ToolBox bindings for declarative containments

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107232/ --- Review request for Plasma. Description --- ToolBox bindings for decla

RE: Help

Jeremy, you were right! It was a bug in Oracle VirtualBox. In fact, I just installed VirtualBox version 4.2.4 and the mouse wheel is now working fine, just as one would expect all mouse buttons/wheel should work, without having to tweak any settings. Thanks for your reply. Regards, Mike Vassalott

Re: Review Request: Plasmate: Port QDialog to KDialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107230/#review21519 --- I'm unsure what's the reasoning behind, but isn't that exactly

Re: Review Request: Port the Calculator applet to QML

> On Nov. 7, 2012, 12:02 a.m., Mark Gaiser wrote: > > Actually, i think you can get rid of all the onClicked: someAction in all > > the buttons since you are already catching those events in > > Keys.onSomeAction. ... nevermind this one as well. Those onClicked are for when a user presses the

Re: Review Request: Port the Calculator applet to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107001/#review21516 --- Actually, i think you can get rid of all the onClicked: someAct

Re: Review Request: Port the Calculator applet to QML

> On Nov. 6, 2012, 4:34 p.m., Mark Gaiser wrote: > > applets/calculator/package/contents/ui/calculator.qml, line 231 > > > > > > I guess all the string values need to be wrapped in i18nc("C") .. > > Someone else wo

Re: Review Request: Port the Calculator applet to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107001/ --- (Updated Nov. 6, 2012, 11:36 p.m.) Review request for Plasma. Changes --

Re: Review Request: Port the Calculator applet to QML

> On Nov. 6, 2012, 4:34 p.m., Mark Gaiser wrote: > > applets/calculator/package/contents/ui/calculator.qml, lines 235-240 > > > > > > Again my personal preference, but it cleans up your code. So here it is. > >

Re: Review Request: Plasmate: Add Localisation to timeline

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107231/#review21510 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 6, 2012, 9:59 p.

Re: Review Request: Port the Calculator applet to QML

> On Nov. 6, 2012, 4:34 p.m., Mark Gaiser wrote: > > applets/calculator/package/contents/ui/calculator.qml, lines 235-240 > > > > > > Again my personal preference, but it cleans up your code. So here it is. > >

Review Request: Plasmate: Add Localisation to timeline

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107231/ --- Review request for Plasma. Description --- This patch is add localisa

Re: Review Request: Port the Calculator applet to QML

> On Nov. 6, 2012, 5:53 p.m., Daker Pinheiro wrote: > > You should move the javascript functions to a separated Javascript file. > > It would keep the plasmoid modularized. > > A repeater could be used for creating the digits button. >You should move the javascript functions to a separated Javas

Re: Review Request: Plasmate: Port QDialog to KDialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107230/#review21505 --- Ship it! Ship It! - Sebastian Kügler On Nov. 6, 2012, 8:33

Review Request: Plasmate: Port QDialog to KDialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107230/ --- Review request for Plasma. Description --- Porting QDialog to KDialog

Re: QML style guide

On Tue, Nov 6, 2012 at 8:10 PM, Aaron J. Seigo wrote: > On Tuesday, November 6, 2012 18:26:17 Mark wrote: >> Why can't the style follow the C++ style as close as possible? > > because this is one place where QMl/JS deviates in a consistent fashion. so > we'd be making all of *our* QML look foreign

Re: QML style guide

On Tuesday, November 6, 2012 18:26:17 Mark wrote: > Why can't the style follow the C++ style as close as possible? because this is one place where QMl/JS deviates in a consistent fashion. so we'd be making all of *our* QML look foreign to the QML the rest of the world writes so as to make it con

Re: Review Request: Port the Calculator applet to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107001/#review21493 --- You should move the javascript functions to a separated Javascr

Re: QML style guide

On Tue, Nov 6, 2012 at 2:26 PM, Aaron J. Seigo wrote: > On Tuesday, November 6, 2012 15:08:21 Dmitry A. Ashkadov wrote: >> Please, notify us when QML style guide is approved if it isn't approved yet. > > Indeed... I think it is ready to go now, though it still needs more content > (esp the "best p

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107160/#review21486 --- one small issue with where hiding status is kept. it may be us

Re: Review Request: load the images for the themes correctly

> On Nov. 2, 2012, 10:20 a.m., Aaron J. Seigo wrote: > > plasmate/packagemodel.cpp, lines 546-551 > > > > > > this looks wrong; in the Package definition there is an entry for > > "colors". even if it is not create

Re: QML style guide

On Tuesday, November 6, 2012 15:08:21 Dmitry A. Ashkadov wrote: > Please, notify us when QML style guide is approved if it isn't approved yet. Indeed... I think it is ready to go now, though it still needs more content (esp the "best practices" section) but that's future work. I adjusted the gui

Re: QML Buttons and SVG images

On Tue, Nov 6, 2012 at 12:22 PM, Dmitry A. Ashkadov wrote: > So, if I understand you right, now I shouldn't use QML Button instead of > IconWidget? If I remove IconWidget then: > > * I will have to work with QAction in QML myself (there is thread about > QAction). > * An icon won't be highlighte

Re: QML Buttons and SVG images

Thank you, Sebastian! I think, SvgItem is better than IconWidget even if it isn't possible to implement such highlighting as IconWidget has. > Don't worry, you're doing fine. Nothing wrong with diligent reviews, though, > and sometimes it just takes a bit to make things perfect. :) I worry ab

Re: QML style guide

Hello, Aaron! Please, notify us when QML style guide is approved if it isn't approved yet. I'm waiting for an approved variant of QML style guide to use it. - Исходное сообщение - От: "Aaron J. Seigo" Кому: plasma-devel@kde.org Отправленные: Вторник, 30 Октябрь 2012 г 0:42:18 Тема: QML

Re: KDEREVIEW: share like connect and plasmate

On Tuesday, November 6, 2012 15:03:05 David Edmundson wrote: > Initial code review of Share-Like-Connect: > > from provider.h > > ~Provider(); > > This class is designed to be subclassed, yet the destructor is public > and non virtual. The derived classes will leak everything. it is a QObje

Re: QML Buttons and SVG images

Hey Dmitry On Tuesday, November 06, 2012 14:22:39 Dmitry A. Ashkadov wrote: > So, if I understand you right, now I shouldn't use QML Button instead of > IconWidget? If I remove IconWidget then: IconWidget is something we want to get rid of at some point anyway. > * I will have to work with QActi

Re: Fwd: Help

Hi Mike, The forums at http://forum.kde.org has friendly people who can most likely run you through those steps. On Monday, November 05, 2012 13:33:33 Chani wrote: > From: Mike Vassalotti > I use Linux Open SUSE in Oracle Virtual Box. Everything is working > fine except for one: I cannot get t

Re: QML Buttons and SVG images

So, if I understand you right, now I shouldn't use QML Button instead of IconWidget? If I remove IconWidget then: * I will have to work with QAction in QML myself (there is thread about QAction). * An icon won't be highlighted when user moves mouse cursor over icon. * An animation of icon, if us

Re: QML Buttons and SVG images

On Tue, Nov 6, 2012 at 10:24 AM, Dmitry A. Ashkadov wrote: >> this should be using the Button QML element, which does support using SVG >> files. > > but did you mean that that QML Button is Button from Plasma Components > (org.kde.plasma.components)? I looked at code of QML button but I didn't

QML Buttons and SVG images

Hello, Aaron! You have said that I can use QML Button item instead of IconWidget: > the real fix here is to not use IconWidget :) that's a QGraphicsWidget thing > and will need to be replaced eventually anyways. > this should be using the Button QML element, which does support using SVG > fi