Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/ --- Review request for Plasma. Description --- the upower

Re: Review Request: Reduce runtime warnings

2012-11-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107379/#review22292 --- Ship it! Ship It! - Marco Martin On Nov. 19, 2012, 1:15

Re: Review Request: kconfigxteditor refactor

2012-11-21 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107394/#review22295 --- plasmate/editors/kconfigxt/kconfigxteditor.cpp

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22303 --- Ship it! Ship It! - Sebastian Kügler On Nov. 21, 2012,

Re: Homerun sources and Plasma runners

2012-11-21 Thread Aurélien Gâteau
Le mardi 20 novembre 2012 20:16:17 Aaron J. Seigo a écrit : On Tuesday, November 20, 2012 18:12:47 Aurélien Gâteau wrote: First, I am convinced using Qt models is the right API design for Homerun. I nobody is saying don't use Qt models in homerun. My mistake. Should have written Qt models

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22317 --- Add Dario Freddi as reviewer and wait until he gives the ship

Release Testing for 4.10

2012-11-21 Thread David Edmundson
As you may know the KDE Quality team was set up with the aim of conducting organised testing of KDE just before a release. One of the things we do is to have a specific targeted lists of things to check. This will be from a team of people who have been trained (forced to read a wiki page) on how

Doxygen and QML on api.kde.org

2012-11-21 Thread Aurélien Gâteau
Hi Allen, I wrote a Doxygen input filter for QML, making it possible to document QML classes just like we document C++ classes. You can find it here: http://agateau.com/projects/doxyqml/ Plasma developers are interested in using this to document Plasma QML components. Do you think we can get

Re: Doxygen and QML on api.kde.org

2012-11-21 Thread Allen Winter
On Wednesday 21 November 2012 05:54:39 PM Aurélien Gâteau wrote: Hi Allen, I wrote a Doxygen input filter for QML, making it possible to document QML classes just like we document C++ classes. You can find it here: http://agateau.com/projects/doxyqml/ Plasma developers are interested

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/ --- (Updated Nov. 21, 2012, 5:21 p.m.) Review request for Plasma and Dario

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22330 --- Now that I think about it, ltinkl can review this as well ! -

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/ --- (Updated Nov. 21, 2012, 5:43 p.m.) Review request for Plasma, Dario

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Dario Freddi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22338 --- Ship it! Ship It! - Dario Freddi On Nov. 21, 2012, 5:43

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22339 --- But why does the battery plasmoid always set the old

[RFC] New (QML) Desktop Containment

2012-11-21 Thread Sebastian Kügler
Hi, As you might know, I'm porting our desktop containment to QML. The platformy bits are now nearly complete (and merged into master cq. 4.10. On the UI side, progress has also been rather good. There's a QML ToolBox now, and I've got a proof-of-concept version of the containment itself

Re: [RFC] New (QML) Desktop Containment

2012-11-21 Thread Ivan Čukić
So, what do you think? :) I've never said it before (not that there was no reason for it :) ) but you're my hero now :) Guessing the visuals will need some fixing, but it is my future containment of choice! Ch! -- You know, there are many people in the country today who, through no fault

Re: [RFC] New (QML) Desktop Containment

2012-11-21 Thread Alex Fiestas
On Wednesday 21 November 2012 20:10:06 Sebastian Kügler wrote: Hi, As you might know, I'm porting our desktop containment to QML. The platformy bits are now nearly complete (and merged into master cq. 4.10. On the UI side, progress has also been rather good. There's a QML ToolBox now, and

Re: Homerun sources and Plasma runners

2012-11-21 Thread Marco Martin
On Wednesday 21 November 2012, Aurélien Gâteau wrote: Trying to map the way sources work to runners, instead of having a runner calling RunnerContext::addMatches(), a runner would have a createModel() method which would be called by RunnerContext or RunnerManager to reach the runner data.

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22342 --- This review has been submitted with commit

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22343 --- This review has been submitted with commit

Re: [RFC] New (QML) Desktop Containment

2012-11-21 Thread Marco Martin
On Wednesday 21 November 2012, Sebastian Kügler wrote: I've recorded a ~3 minute movie that shows the current state: http://www.youtube.com/watch?v=zbSuNrn3qoU looks already nice ;) UI-wise, my design goals are: * no regressions compared to current containment * less visual

Re: Doxygen and QML on api.kde.org

2012-11-21 Thread Marco Martin
On Wednesday 21 November 2012, Aurélien Gâteau wrote: Hi Allen, I wrote a Doxygen input filter for QML, making it possible to document QML classes just like we document C++ classes. You can find it here: http://agateau.com/projects/doxyqml/ Plasma developers are interested in using this

Re: [RFC] New (QML) Desktop Containment

2012-11-21 Thread Sebastian Kügler
Hola, On Wednesday, November 21, 2012 20:42:09 Alex Fiestas wrote: On Wednesday 21 November 2012 20:10:06 Sebastian Kügler wrote: As you might know, I'm porting our desktop containment to QML. The platformy bits are now nearly complete (and merged into master cq. 4.10. On the UI side,

Re: [RFC] New (QML) Desktop Containment

2012-11-21 Thread Sebastian Kügler
Ciao Marco, On Wednesday, November 21, 2012 21:13:13 Marco Martin wrote: On Wednesday 21 November 2012, Sebastian Kügler wrote: I've recorded a ~3 minute movie that shows the current state: http://www.youtube.com/watch?v=zbSuNrn3qoU looks already nice ;) Thanks :) UI-wise,

Re: [RFC] New (QML) Desktop Containment

2012-11-21 Thread Marco Martin
On Wednesday 21 November 2012, Sebastian Kügler wrote: one of: - added from add widgets interface (needs unlocking). I'm personally not super happy with the horizontal add widgets dialog and would rather see something vertical (easier to scan and categorize), but that's quite a topic of its

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Greg T
On Nov. 21, 2012, 7:07 p.m., Kai Uwe Broulik wrote: But why does the battery plasmoid always set the old brightness? Now it knows the current brightness and sets it itself to the right value but still aren't these calls not needed and thus a bug also in the plasmoid? the brightness

Re: Review Request: Plasmate: Port QDialog to KDialog

2012-11-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107230/#review22350 --- This review has been submitted with commit

Re: Review Request: Plasmate: Fix typo on remoteinstaller.ui and give more sane names to labels.

2012-11-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107312/#review22351 --- This review has been submitted with commit

Re: [RFC] New (QML) Desktop Containment

2012-11-21 Thread Sebastian Kügler
On Wednesday, November 21, 2012 21:13:13 Marco Martin wrote: * dropping stuff onto the containment doesn't work as far i seen, the items (not sure if they all do, or just mousearea) just eat the dropevent. maybe the containment implementation in the scriptengine should filterChildEvents