Re: Review Request 108700: Make sure Menu.status is set to Closed when the menu closes itself

2013-02-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108700/#review26734 --- This review has been submitted with commit

Re: Review Request 108798: Fix most of the compile issues due to wrong header used and comment out in shell/CMakeLists.txt testapplet which doesn't exist

2013-02-06 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108798/#review26738 --- Ship it! yes, all the camel case headers need to be converted

Re: Review Request 108699: fixes bug 309033

2013-02-06 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108699/#review26739 --- plasmate/editors/metadata/metadataeditor.h

[plasmate] [Bug 309033] Category lists incorrect values for KWin Effects

2013-02-06 Thread Giorgos Tsiapaliokas
https://bugs.kde.org/show_bug.cgi?id=309033 --- Comment #1 from Giorgos Tsiapaliokas terie...@gmail.com --- Git commit bbf6bf83fd3e22d939a9d48c9a60690503217b7f by Giorgos Tsiapaliokas. Committed on 06/02/2013 at 11:35. Pushed by tsiapaliwkas into branch 'master'. Support the right categories for

Re: Review Request 108699: fixes bug 309033

2013-02-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108699/#review26740 --- This review has been submitted with commit

Review Request 108800: don't load the package if the servicetype doesn't exist

2013-02-06 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108800/ --- Review request for Plasma. Description --- Make plasmate to not

Re: Review Request 108800: don't load the package if the servicetype doesn't exist

2013-02-06 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108800/#review26742 --- Ship it! plasmate/mainwindow.cpp

Re: Review Request 108797: Small adjustments in KSMServer UI, fixed error that wouldn't reproduce in default plasma themes

2013-02-06 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108797/#review26744 --- Ship it! Ship It! - Lamarque Vieira Souza On Feb. 6, 2013,

Re: Review Request 108800: don't load the package if the servicetype doesn't exist

2013-02-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108800/#review26745 --- This review has been submitted with commit

Re: Review Request 107600: Keep placeholder text visible when empty and focused

2013-02-06 Thread Aurélien Gâteau
On Dec. 13, 2012, 5:32 p.m., Aaron J. Seigo wrote: as this is indeed a rather widely shifting style (far beyond KDE), as long as it is consistent with kdelibs and Qt i'm ok with this. and consistency is the hard bit. yes, there is 107678 for kdelibs (which is half the battle) but

Slimming and tidying libplasma2

2013-02-06 Thread Marco Martin
Hi all, right now, plasma2 based on frameworks builds again and a minimal shell boots correctly from it: http://wstaw.org/m/2013/02/06/plasma-desktopI10657.png (yes, we have again the esktop Toolbo :D) Of course a lot stil has to be done, from the sides of libplasma, the declarative

Re: Slimming and tidying libplasma2

2013-02-06 Thread Aaron J. Seigo
On Wednesday, February 6, 2013 16:49:40 Marco Martin wrote: About the library, what i would like to do, is to have a little review on yes, this absolutely needs doing. however, i find it difficult to do over email + wiki ... it's the kind of thing that really benefits from conversation and

Re: Slimming and tidying libplasma2

2013-02-06 Thread Marco Martin
On Wednesday 06 February 2013, Aaron J. Seigo wrote: On Wednesday, February 6, 2013 16:49:40 Marco Martin wrote: About the library, what i would like to do, is to have a little review on yes, this absolutely needs doing. however, i find it difficult to do over email + wiki ... it's the kind

Re: Slimming and tidying libplasma2

2013-02-06 Thread Sebastian Kügler
On Wednesday, February 06, 2013 17:39:52 Aaron J. Seigo wrote: On Wednesday, February 6, 2013 16:49:40 Marco Martin wrote: About the library, what i would like to do, is to have a little review on yes, this absolutely needs doing. however, i find it difficult to do over email + wiki ...

Re: Slimming and tidying libplasma2

2013-02-06 Thread Aaron J. Seigo
On Wednesday, February 6, 2013 17:46:11 Marco Martin wrote: anybody else would be in? ;) even more usefully: when? i can't tomorrow ... Friday and Saturday both work for me .. Monday is also open ... of course the big push for it will be the sprint, but would be nice if we arrive there in

Re: Slimming and tidying libplasma2

2013-02-06 Thread Marco Martin
On Wednesday 06 February 2013, Aaron J. Seigo wrote: On Wednesday, February 6, 2013 17:46:11 Marco Martin wrote: anybody else would be in? ;) even more usefully: when? i can't tomorrow ... Friday and Saturday both work for me .. Monday is also open ... What about Kickin' in the front

Re: Slimming and tidying libplasma2

2013-02-06 Thread Aaron J. Seigo
On Wednesday, February 6, 2013 18:28:26 Marco Martin wrote: On Wednesday 06 February 2013, Aaron J. Seigo wrote: On Wednesday, February 6, 2013 17:46:11 Marco Martin wrote: anybody else would be in? ;) even more usefully: when? i can't tomorrow ... Friday and Saturday both work for

Re: Review Request 108797: Small adjustments in KSMServer UI, fixed error that wouldn't reproduce in default plasma themes

2013-02-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108797/#review26764 --- This review has been submitted with commit

Re: Slimming and tidying libplasma2

2013-02-06 Thread Sebastian Kügler
On Wednesday, February 06, 2013 18:37:50 Aaron J. Seigo wrote: On Wednesday, February 6, 2013 18:28:26 Marco Martin wrote: On Wednesday 06 February 2013, Aaron J. Seigo wrote: On Wednesday, February 6, 2013 17:46:11 Marco Martin wrote: anybody else would be in? ;) even more

Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0

2013-02-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108825/ --- Review request for Plasma and Marco Martin. Description --- Whenever

Re: Re: Slimming and tidying libplasma2

2013-02-06 Thread Martin Gräßlin
On Thursday 07 February 2013 01:12:52 Sebastian Kügler wrote: On Wednesday, February 06, 2013 18:37:50 Aaron J. Seigo wrote: On Wednesday, February 6, 2013 18:28:26 Marco Martin wrote: On Wednesday 06 February 2013, Aaron J. Seigo wrote: On Wednesday, February 6, 2013 17:46:11 Marco