Re: Patch Review

2013-05-15 Thread Sinny Kumari
Cool! patch works fine :) On Thu, May 16, 2013 at 2:17 AM, Marco Martin wrote: > On Wednesday 15 May 2013, Akshay Ratan wrote: > > Hi, > > With regard to the bug :: > https://bugs.kde.org/show_bug.cgi?id=319626 , > > I have submitted a patch for review. Its a very minor change as per the >

Re: Patch Review

2013-05-15 Thread Marco Martin
On Wednesday 15 May 2013, Akshay Ratan wrote: > Hi, > With regard to the bug :: https://bugs.kde.org/show_bug.cgi?id=319626 , > I have submitted a patch for review. Its a very minor change as per the > idea suggestion by Shantanu. Please let me know if further changes are to > be discussed :) >

Re: Review Request 110453: Order tasks by activity in tasks applet

2013-05-15 Thread Eike Hein
> On May 15, 2013, 5:36 p.m., José Millán Soto wrote: > > I'm aware that a new version of the tasks applet is being done in QML, but > > most of the changes are done in the library and not in the applet itself > > (the only change made to the applet is to add the ordering in the "Order > > by"

Re: Patch Review

2013-05-15 Thread Akshay Ratan
Hi, With regard to the bug :: https://bugs.kde.org/show_bug.cgi?id=319626 , I have submitted a patch for review. Its a very minor change as per the idea suggestion by Shantanu. Please let me know if further changes are to be discussed :) I have simply removed the visible tag in the Plasma Tool

Re: Using plasma enums from QML2

2013-05-15 Thread Marco Martin
On Tuesday 14 May 2013, Aaron J. Seigo wrote: > > i think they should go > > In a perfect world, yes. In the less perfect world we live in, it means > more porting work. Not sure which is worse. I suppose, at least, that this > kind of porting can be done with a script. i think the branch is pret

Re: Review Request 110453: Order tasks by activity in tasks applet

2013-05-15 Thread José Millán Soto
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110453/#review32589 --- I'm aware that a new version of the tasks applet is being done

Review Request 110453: Order tasks by activity in tasks applet

2013-05-15 Thread José Millán Soto
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110453/ --- Review request for Plasma. Description --- A new ordering strategy Ac

Re: kde-workspace and plasma2

2013-05-15 Thread Marco Martin
On Tuesday 14 May 2013, Aaron J. Seigo wrote: > Even porting a few of the plasmoids wouldn't be the worst of ideas. (I > expect the icon one to be interesting ...) Not everything needs to be > ported right now, however, especially not components that get frequent > activity. > > And what I really

Re: Re: PotD Headers

2013-05-15 Thread David Narvaez
On Wed, May 15, 2013 at 3:50 AM, Martin Gräßlin wrote: > On Wednesday 15 May 2013 08:40:06 Marco Martin wrote: > > that would make it a public library, with the promise of more quality > > and > > absolute binary stability that this brings.. > > would be fine,.. as long someone commits to maintain

Re: Review Request 110413: Show in the tasks applet the activities a task is available on

2013-05-15 Thread José Millán Soto
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110413/ --- (Updated May 15, 2013, 4:04 p.m.) Status -- This change has been mark

Re: Review Request 110413: Show in the tasks applet the activities a task is available on

2013-05-15 Thread José Millán Soto
> On May 15, 2013, 1:43 p.m., Aaron J. Seigo wrote: > > Ship It! Commited in 2ac45a07d6f4d5732219677795d0d280d2549956 (In the commit message instead I made a mistake and use the keyword FEATURE instead of REVIEW, leaving BUG where it should be FEATURE :( ) - José ---

Re: Default activity naming issues

2013-05-15 Thread Ivan Čukić
Kevin> Ahem... Sorry for the ramblings. :-) No need to apologize, sidetracking this theme to discuss nice things is not a crime :) I totally agree with the workflow you'd like to have (I'd like it as well :) ) Aaron> If we want a meangingful default name At this time, until somebody brave enou

Re: Review Request 110431: Improve battery monitor with multiple batteries

2013-05-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110431/ --- (Updated May 15, 2013, 3:04 p.m.) Review request for Plasma and Viranch Me

Re: Review Request 110430: [Taskbar applet] Added actions to be perfomed on middle click

2013-05-15 Thread Albert Vaca Cintora
> On May 15, 2013, 6:06 a.m., Aaron J. Seigo wrote: > > I am not in favour of this patch for a couple of reasons. First, there is a > > port underway to QML which does not need to be delayed further by adding > > more features. More importantly, however, "middle click" is a special case > > of

Re: Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel

2013-05-15 Thread Michał Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/ --- (Updated May 15, 2013, 4:50 p.m.) Review request for Plasma, Aaron J. Seig

Re: Default activity naming issues

2013-05-15 Thread Martin Graesslin
On Wednesday 15 May 2013 16:21:28 Aaron J. Seigo wrote: > On Wednesday, May 15, 2013 15:31:16 Ivan Čukić wrote: > > Welcome is nice, but again, not a real activity (link to Welcome and > > similar). > > If we want a meangingful default name, then I think we have to ask the user > ... which bring

Re: Review Request 110430: [Taskbar applet] Added actions to be perfomed on middle click

2013-05-15 Thread Martin Gräßlin
> On May 15, 2013, 8:06 a.m., Aaron J. Seigo wrote: > > I am not in favour of this patch for a couple of reasons. First, there is a > > port underway to QML which does not need to be delayed further by adding > > more features. More importantly, however, "middle click" is a special case > > of

Re: Default activity naming issues

2013-05-15 Thread Aaron J. Seigo
On Wednesday, May 15, 2013 15:31:16 Ivan Čukić wrote: > Welcome is nice, but again, not a real activity (link to Welcome and > similar). If we want a meangingful default name, then I think we have to ask the user ... which brings us back to how nice it would be to have a first-run welcome app

Re: Default activity naming issues

2013-05-15 Thread Kevin Ottens
On Wednesday 15 May 2013 15:31:16 Ivan Čukić wrote: > Welcome is nice, but again, not a real activity (link to Welcome and > similar). Yeah, I guess it comes from some of the adjustments I have in mind for the overall activity workflow. I'd like a default activity which is the one I get when I l

Re: Review Request 110436: Add an option to disable the dimming of minimized windows

2013-05-15 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110436/ --- (Updated May 15, 2013, 2:16 p.m.) Status -- This change has been disc

Re: Review Request 110436: Add an option to disable the dimming of minimized windows

2013-05-15 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110436/#review32575 --- Sorry, we have a general policy of not supporting such "pixel p

Re: Review Request 110430: [Taskbar applet] Added actions to be perfomed on middle click

2013-05-15 Thread Aaron J. Seigo
> On May 15, 2013, 6:06 a.m., Aaron J. Seigo wrote: > > I am not in favour of this patch for a couple of reasons. First, there is a > > port underway to QML which does not need to be delayed further by adding > > more features. More importantly, however, "middle click" is a special case > > of

Re: Review Request 110431: Improve battery monitor with multiple batteries

2013-05-15 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110431/#review32569 --- "I'm also not sure about the "Show battery percentage for each

Re: Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel

2013-05-15 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/#review32568 --- This version compiles! :) Progress.. Please add a test case to

Re: Review Request 110413: Show in the tasks applet the activities a task is available on

2013-05-15 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110413/#review32563 --- Ship it! Ship It! - Aaron J. Seigo On May 15, 2013, 9:03 a.

Re: Default activity naming issues

2013-05-15 Thread Ivan Čukić
Welcome is nice, but again, not a real activity (link to Welcome and similar). Cheerio On 15 May 2013 11:49, Kevin Ottens wrote: > On Wednesday 15 May 2013 10:54:15 Aaron J. Seigo wrote: > > On Wednesday, May 15, 2013 09:59:40 Ivan Čukić wrote: > > > The default name for the default activity

Re: Review Request 110430: [Taskbar applet] Added actions to be perfomed on middle click

2013-05-15 Thread Albert Vaca Cintora
> On May 15, 2013, 6:06 a.m., Aaron J. Seigo wrote: > > I am not in favour of this patch for a couple of reasons. First, there is a > > port underway to QML which does not need to be delayed further by adding > > more features. More importantly, however, "middle click" is a special case > > of

Re: Review Request 110431: Improve battery monitor with multiple batteries

2013-05-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110431/ --- (Updated May 15, 2013, 10:51 a.m.) Review request for Plasma and Viranch M

Re: Default activity naming issues

2013-05-15 Thread Kevin Ottens
On Wednesday 15 May 2013 10:54:15 Aaron J. Seigo wrote: > On Wednesday, May 15, 2013 09:59:40 Ivan Čukić wrote: > > The default name for the default activity 'Desktop' is causing a few > > problems. > > glad these are the kinds of problems we face these days :) > > hm.. > > Main Activity > Ho

Re: Review Request 110436: Add an option to disable the dimming of minimized windows

2013-05-15 Thread Veeti Paananen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110436/ --- (Updated May 15, 2013, 9:18 a.m.) Review request for Plasma. Description

Review Request 110436: Add an option to disable the dimming of minimized windows

2013-05-15 Thread Veeti Paananen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110436/ --- Review request for Plasma. Description --- The grayscale & dimming ef

Re: Default activity naming issues

2013-05-15 Thread Martin Klapetek
On Wed, May 15, 2013 at 10:54 AM, Aaron J. Seigo wrote: > On Wednesday, May 15, 2013 09:59:40 Ivan Čukić wrote: > > The default name for the default activity 'Desktop' is causing a few > > problems. > > glad these are the kinds of problems we face these days :) > > hm.. > > Main Activity > Hom

Re: Default activity naming issues

2013-05-15 Thread Ivan Čukić
> glad these are the kinds of problems we face these days :) +10 > Main Activity Thinking this would be better than the rest. (link to home could also be expected to create a symlink) Ch! ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail

Re: Review Request 110413: Show in the tasks applet the activities a task is available on

2013-05-15 Thread José Millán Soto
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110413/ --- (Updated May 15, 2013, 9:03 a.m.) Review request for Plasma. Changes ---

Re: Default activity naming issues

2013-05-15 Thread Aaron J. Seigo
On Wednesday, May 15, 2013 09:59:40 Ivan Čukić wrote: > The default name for the default activity 'Desktop' is causing a few > problems. glad these are the kinds of problems we face these days :) hm.. Main Activity Home Home Activity ... -- Aaron J. Seigo signature.asc Description: This i

Re: Re: PotD Headers

2013-05-15 Thread Martin Gräßlin
On Wednesday 15 May 2013 08:40:06 Marco Martin wrote: > On Tuesday 14 May 2013 22:50:00 David Narvaez wrote: > > Hi, > > > > Would it be a goog idea the following two headers from the > > kdeplasma-addons > > repository? > > > > dataengines/potd/plasma_potd_export.h > > dataengines/potd/potdprovi

Re: PotD Headers

2013-05-15 Thread Aaron J. Seigo
On Tuesday, May 14, 2013 22:50:00 David Narvaez wrote: > Would it be a goog idea the following two headers from the kdeplasma-addons > repository? As sebas noted, this would require a maintainer to step up to maintain the API of that class. What I'd much rather see is Javascript glue so that ins

Re: PotD Headers

2013-05-15 Thread Marco Martin
On Tuesday 14 May 2013 22:50:00 David Narvaez wrote: > Hi, > > Would it be a goog idea the following two headers from the kdeplasma-addons > repository? > > dataengines/potd/plasma_potd_export.h > dataengines/potd/potdprovider.h > > This would ease development of new providers. that would make

Re: Default activity naming issues

2013-05-15 Thread Marco Martin
On Wednesday 15 May 2013 09:59:40 Ivan Čukić wrote: > Hi all, > > I know everybody is busy with plasma2 (even I manage to find some time to > play around with it, unfortunately not more than that), but there is one > issue that I'd like to raise regarding the current release. > > The default name

Default activity naming issues

2013-05-15 Thread Ivan Čukić
Hi all, I know everybody is busy with plasma2 (even I manage to find some time to play around with it, unfortunately not more than that), but there is one issue that I'd like to raise regarding the current release. The default name for the default activity 'Desktop' is causing a few problems. Fi

Re: Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel

2013-05-15 Thread Michał Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/ --- (Updated May 15, 2013, 9:47 a.m.) Review request for Plasma, Aaron J. Seig