Review Request 111187: Implement UI navigation using PageStack

2013-06-22 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/87/ --- Review request for Plasma, Akshay Ratan, Fabian Riethmayer, Sinny Kumari, an

Re: plasma-shell and -std=c++0x flag

2013-06-22 Thread Ivan Čukić
> Martin > ovious +1 Heh, I can always count on you when I mention c++11 :D > Aaron > yes, realy good idea. Cool, I promise I will not go overboard like with some kactivities parts :) Cheerio, Ivan -- Acting is merely the art of keeping a large group of people from coughing. -- Sir Ralph R

Re: plasma-shell and -std=c++0x flag

2013-06-22 Thread Aaron J. Seigo
On Saturday, June 22, 2013 16:38:56 Ivan Čukić wrote: > Hi all, > > Following the previous discussions on k-c-d where it was concluded that the > workspace-related code (as opposed to the libs) can use more modern c++ > features as long as those are not introduced after gcc 4.5, I'd like to ask

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/ --- (Updated June 22, 2013, 3:30 p.m.) Status -- This change has been mar

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/#review34884 --- This review has been submitted with commit 49fcb63e705420da8dc

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-22 Thread Marco Martin
> On June 22, 2013, 3:24 p.m., Aaron J. Seigo wrote: > > For absolute completeness, the sortCaseSensitivity property should also > > have a NOTIFY signal .. but i don't see why anyone would ever bind to that > > signal and it would require a reimplementation of the set method, so i'm > > fine

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-22 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/#review34881 --- Ship it! For absolute completeness, the sortCaseSensitivity pr

Re: plasma-shell and -std=c++0x flag

2013-06-22 Thread Ivan Čukić
> obvious +1 (will do the same for KWin once 4.11 is branched). What about > clang? Does it need an additional parameter? Yes, it (fortunately) uses the same one. -- Cheerio, Ivan -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straigh

Re: plasma-shell and -std=c++0x flag

2013-06-22 Thread Martin Graesslin
On Saturday 22 June 2013 16:38:56 Ivan Čukić wrote: > Hi all, > > Following the previous discussions on k-c-d where it was concluded that the > workspace-related code (as opposed to the libs) can use more modern c++ > features as long as those are not introduced after gcc 4.5, I'd like to ask > wh

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-22 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/ --- (Updated June 22, 2013, 2:42 p.m.) Review request for Plasma. Changes --

plasma-shell and -std=c++0x flag

2013-06-22 Thread Ivan Čukić
Hi all, Following the previous discussions on k-c-d where it was concluded that the workspace-related code (as opposed to the libs) can use more modern c++ features as long as those are not introduced after gcc 4.5, I'd like to ask whether there are objections to add the -std=c++0x flag to the

Re: Keyboard detection and a test request

2013-06-22 Thread Reza Shah
On Fri, Jun 21, 2013 at 7:01 PM, Ivan Čukić wrote: > Hi all, > > Hi Ivan, > I (think) I'm now properly detecting regular mice, touch-pads and touch- > screens, based on some X properties of those. > > It would be very nice if people with touch-screens and touch-pads would do > the > following t

Re: Keyboard detection and a test request

2013-06-22 Thread Ben Cooksley
On Fri, Jun 21, 2013 at 10:01 PM, Ivan Čukić wrote: > Hi all, Hi Ivan, > > I (think) I'm now properly detecting regular mice, touch-pads and touch- > screens, based on some X properties of those. > > It would be very nice if people with touch-screens and touch-pads would do the > following test

Re: Keyboard detection and a test request

2013-06-22 Thread Mario Fux KDE ML
Am Freitag 21 Juni 2013, 12.01:26 schrieb Ivan Čukić: > Hi all, Morning Ivan > I (think) I'm now properly detecting regular mice, touch-pads and touch- > screens, based on some X properties of those. > > It would be very nice if people with touch-screens and touch-pads would do > the following t