Re: Review Request 115902: Force backgroundcontrast during slidingpopup animations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115902/#review50300 --- kwin/effects/slidingpopups/slidingpopups.cpp

Re: Review Request 115903: slidingpopups claim windowClosedGrabRole earlier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115903/#review50299 --- moving the GrabRole seems fine to me, but it has two small pro

Review Request 115903: slidingpopups claim windowClosedGrabRole earlier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115903/ --- Review request for kwin and Plasma. Bugs: 329991 http://bugs.kde.org/

Re: Review Request 115902: Force backgroundcontrast during slidingpopup animations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115902/ --- (Updated Feb. 20, 2014, 1:28 a.m.) Review request for kwin and Plasma.

Review Request 115902: Force backgroundcontrast during slidingpopup animations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115902/ --- Review request for kwin and Plasma. Repository: kde-workspace Descripti

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

> On Feb. 19, 2014, 7:06 a.m., Aleix Pol Gonzalez wrote: > > src/notifybypopupgrowl.h, line 37 > > > > > > Is growl still the thing for MacOS X? > > Martin Klapetek wrote: > I'm not sure to be honest...I've h

Re: Minutes Monday Plasma hangout

On Wednesday 19 February 2014, David Edmundson wrote: > On Mon, Feb 17, 2014 at 1:26 PM, Sebastian Kügler wrote: > > Plasma Meeting February, 17th, 2014 > > > > Present: Alex Fiestas, David Edmundson, Giorgos Tsiapaliokas, Marco Martin, > > Martin Grässlin, Martin Klapetek, Jens Reuterberg, Antoni

Re: Minutes Monday Plasma hangout

On Wednesday 19 February 2014 22:24:41 David Edmundson wrote: > My benchmarking showed a massive saving, because everything was shared > from the precache-cache (ThemePrivate::pixmapsToCache) but the real > plasma-desktop only had a saving of 7Mb (still a step in the right > direction, but not ver

Re: Minutes Monday Plasma hangout

On Wed, Feb 19, 2014 at 9:12 PM, David Edmundson wrote: >> no, one needs the QImage to load the data into the QSGTexture (you don't want >> to use the FBO for that). Of course it should be fine to create the QImage on >> the stack and discard it once it's loaded into the QSGTexture and I assume >>

Re: Review Request 115857: Fix flickering of sliding popups while disappearing

> On Feb. 19, 2014, 1:10 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 848dd8c25b3511d89527ff8bd7b7e9125290385e by Sebastian Kügler to branch > > master. Just for the records, the commit is https://git.reviewboard.kde.org/r/115859/ - this review was not submitted

Re: Minutes Monday Plasma hangout

> no, one needs the QImage to load the data into the QSGTexture (you don't want > to use the FBO for that). Of course it should be fine to create the QImage on > the stack and discard it once it's loaded into the QSGTexture and I assume > David is doing exactly that. It doesn't quite get discarded

Re: Minutes Monday Plasma hangout

On Wed, Feb 19, 2014 at 8:10 PM, Mark Gaiser wrote: > On Wed, Feb 19, 2014 at 6:47 PM, Martin Graesslin wrote: >> >> On Wednesday 19 February 2014 18:11:12 David Edmundson wrote: >> > On Mon, Feb 17, 2014 at 1:26 PM, Sebastian Kügler wrote: >> > > Plasma Meeting February, 17th, 2014 >> > > >> >

Re: Minutes Monday Plasma hangout

On Wednesday 19 February 2014 20:10:45 Mark Gaiser wrote: > On Wed, Feb 19, 2014 at 6:47 PM, Martin Graesslin wrote: > > On Wednesday 19 February 2014 18:11:12 David Edmundson wrote: > > > On Mon, Feb 17, 2014 at 1:26 PM, Sebastian Kügler wrote: > > > > Plasma Meeting February, 17th, 2014 > > >

Re: Minutes Monday Plasma hangout

On Wed, Feb 19, 2014 at 6:47 PM, Martin Graesslin wrote: > > On Wednesday 19 February 2014 18:11:12 David Edmundson wrote: > > On Mon, Feb 17, 2014 at 1:26 PM, Sebastian Kügler wrote: > > > Plasma Meeting February, 17th, 2014 > > > > > > Present: Alex Fiestas, David Edmundson, Giorgos Tsiapalioka

Re: Minutes Monday Plasma hangout

On Wednesday 19 February 2014 18:11:12 David Edmundson wrote: > On Mon, Feb 17, 2014 at 1:26 PM, Sebastian Kügler wrote: > > Plasma Meeting February, 17th, 2014 > > > > Present: Alex Fiestas, David Edmundson, Giorgos Tsiapaliokas, Marco > > Martin, > > Martin Grässlin, Martin Klapetek, Jens Reute

Re: Minutes Monday Plasma hangout

On Mon, Feb 17, 2014 at 1:26 PM, Sebastian Kügler wrote: > Plasma Meeting February, 17th, 2014 > > Present: Alex Fiestas, David Edmundson, Giorgos Tsiapaliokas, Marco Martin, > Martin Grässlin, Martin Klapetek, Jens Reuterberg, Antonis Tsiapaliokas, > Sebastian Kügler, Vishesh Handa, > > > Alex: >

Re: Review Request 115870: The plasma-media center displays the time in AM between 12 noon and 1pm.

> On Feb. 19, 2014, 11:36 a.m., Sebastian Kügler wrote: > > Perhaps this would help: http://qt-project.org/doc/qt-4.8/qml-qt.html#formatTime-method It seems to be providing the features needed to display a given time however you want it. In your case the result should probably be something li

Plasma Next Release Plans

Hi all, The Plasma team has settled on a release schedule for the first stable released based on Qt5 and KF5. You can find the schedule here: http://techbase.kde.org/Schedules/Plasma/2014.6_Release_Schedule For those too lazy to click: We'll release .0 on 17th June, two alphas, a beta and an R

Re: Review Request 114260: Port mouse dataengine

> On Feb. 2, 2014, 11:42 a.m., Bhushan Shah wrote: > > Please test it with plasmaengineexplorer in my testing it shows no sources. Any progress on this? - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.

Re: Review Request 115859: Force-allow background contrast while sliding desktops

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115859/ --- (Updated Feb. 19, 2014, 1:12 p.m.) Status -- This change has been ma

Re: Review Request 115857: Fix flickering of sliding popups while disappearing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115857/#review50222 --- This review has been submitted with commit 848dd8c25b3511d895

Re: Review Request 115857: Fix flickering of sliding popups while disappearing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115857/ --- (Updated Feb. 19, 2014, 1:10 p.m.) Status -- This change has been ma

Re: Review Request 115859: Force-allow background contrast while sliding desktops

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115859/#review50221 --- Ship it! Thanks for going through this hard review - Martin

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

> On Feb. 19, 2014, 11:06 a.m., Aleix Pol Gonzalez wrote: > > src/knotificationmanager.cpp, line 180 > > > > > > ? > > Martin Klapetek wrote: > Yet once again the description xD - "it's full of ... FIXMEs to

Re: Review Request 115859: Force-allow background contrast while sliding desktops

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115859/ --- (Updated Feb. 19, 2014, 12:52 p.m.) Review request for kwin and Plasma.

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

> On Feb. 19, 2014, 10:06 a.m., Aleix Pol Gonzalez wrote: > > src/knotificationmanager.cpp, line 180 > > > > > > ? > > Martin Klapetek wrote: > Yet once again the description xD - "it's full of ... FIXMEs to

Re: Review Request 115857: Fix flickering of sliding popups while disappearing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115857/ --- (Updated Feb. 19, 2014, 12:34 p.m.) Status -- This change has been d

Re: Review Request 115859: Force-allow background contrast while sliding desktops

> On Feb. 18, 2014, 2:15 p.m., Thomas Lübking wrote: > > kwin/effects/slide/slide.cpp, line 72 > > > > > > what about setting and removing this with setting the "slide" flag and > > catch windowAdded() while slid

Re: Review Request 115859: Force-allow background contrast while sliding desktops

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115859/ --- (Updated Feb. 19, 2014, 12:06 p.m.) Review request for kwin and Plasma.

Re: Review Request 115859: Force-allow background contrast while sliding desktops

> On Feb. 19, 2014, 6:35 a.m., Martin Gräßlin wrote: > > kwin/effects/slide/slide.cpp, lines 241-245 > > > > > > suggestion: loop over m_backgroundContrastForcedBefore - you are only > > operating on them and th

Re: Review Request 115870: The plasma-media center displays the time in AM between 12 noon and 1pm.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115870/#review50210 --- mediaelements/mediawelcome/HomeScreenFooter.qml

Re: Review Request 115871: Use QStandardPaths for finding plasma shells instead of hardcoding to install prefix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115871/#review50208 --- This review has been submitted with commit dde1da619e94001391

Re: Review Request 115871: Use QStandardPaths for finding plasma shells instead of hardcoding to install prefix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115871/ --- (Updated Feb. 19, 2014, 11:12 a.m.) Status -- This change has been m

Re: Review Request 115870: The plasma-media center displays the time in AM between 12 noon and 1pm.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115870/ --- (Updated Feb. 19, 2014, 11:11 a.m.) Review request for Plasma and Sinny K

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

> On Feb. 19, 2014, 11:06 a.m., Aleix Pol Gonzalez wrote: > > src/knotificationmanager.cpp, line 66 > > > > > > This will be done in the future? Maybe it would be better to commit > > when there are no regression

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

> On Feb. 19, 2014, 11:06 a.m., Aleix Pol Gonzalez wrote: > > src/knotification.cpp, line 333 > > > > > > remove qDebugs? As the description says - "and for now it's full of QDebugs, that will all be removed" -

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/#review50197 --- src/knotification.cpp

Re: Review Request 115871: Use QStandardPaths for finding plasma shells instead of hardcoding to install prefix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115871/#review50196 --- Ship it! Looks ok to me - Ivan Čukić On Feb. 18, 2014, 5:4