Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

2014-06-07 Thread R.Harish Navnit
On June 5, 2014, 8:36 a.m., Thomas Pfeiffer wrote: Usability review: Since I lack the skills to picture it from the diff: When exactly is the notification shown? Is it shown as soon as the media is supposed to be played? If so, I think it could be done in a more subtle way: Grey out

Re: Review Request 118581: Consider Super_L and Super_R as modifiers

2014-06-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118581/#review59507 --- Ship it! Ship It! - David Faure On June 6, 2014, 12:39

Locale Name Primer

2014-06-07 Thread John Layt
Locale Names. A quick primer on Locale Names, seeing as we've had a few issues in the last couple of days. I can't claim perfect knowledge, so feel free to point out where I am wrong :-) TL;DR: * Don't use QLocale::bcp47Name(). * Use QLocale::name(), but may need to modify the results. * You

Re: Review Request 118581: Consider Super_L and Super_R as modifiers

2014-06-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118581/#review59532 --- Ship it! Looks good to me. Can you check if we need to

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

2014-06-07 Thread Aleix Pol
On Fri, Jun 6, 2014 at 10:20 PM, Luca Beltrame lbeltr...@kde.org wrote: In data venerdì 06 giugno 2014 17:22:52, Aleix Pol ha scritto: Can you give it another try? Now works perfectly. Thanks! -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79

Review Request 118613: Prevent crash when requesting icon with negative size

2014-06-07 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118613/ --- Review request for Plasma. Bugs: 335939

Re: Review Request 118613: Prevent crash when requesting icon with negative size

2014-06-07 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118613/ --- (Updated June 8, 2014, 10:15 a.m.) Review request for Plasma. Bugs: