Review Request 119265: Fix rendering of KSignalPlotter

2014-07-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119265/ --- Review request for Plasma and Christoph Feck. Repository: libksysguard

Re: Review Request 119265: Fix rendering of KSignalPlotter

2014-07-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119265/ --- (Updated July 14, 2014, 8:48 a.m.) Review request for Plasma and

Re: Plasma shell - Mediacenter

2014-07-14 Thread Marco Martin
On Saturday 12 July 2014, Shantanu Tushar Jha wrote: Hi folks, The frameworks branch of PMC now contains a Plasma Shell which basically loads the required QML components and looks/works exactly the same[1]. So technically we are good to go if a user wants her desktop to be a media center.

Re: Review Request 119265: Fix rendering of KSignalPlotter

2014-07-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119265/#review62272 --- Ship it! Ship It! - Aleix Pol Gonzalez On July 14, 2014,

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

2014-07-14 Thread Sebastian Kügler
On July 11, 2014, 2:48 p.m., Sebastian Kügler wrote: It would be easier to review, if you made separate patches for the renaming and the actual changes in the code that juggle around the objects. Martin Klapetek wrote: I did the renaming in the middle of this as I got annoyed by

Minutes Monday Plasma Hangout

2014-07-14 Thread Sebastian Kügler
Minutes from 14th of June, weekly Plasma Hangout Present: Aleix, Antonis, Marco, Martin Gräßlin, Jonathan, Ivan, Jens, Sebastian Antonis - worked on Plasma Active launcher, progressing well, but bugs left Ivan - working on window model mutability in kactivities to be able to move windows

Re: Minutes Monday Plasma Hangout

2014-07-14 Thread Eike Hein
From me: - Going to do various little fixes in Folder Kicker. - Optimization work in Folder, there's a bunch of low-hanging fruit to make things speedier, e.g. around mode-switching to unsorted mode on internal DND, and memory usage can be trimmed further as well. - Going to start porting

Re: Review Request 119220: Figure out why my plasma wasn't notifying the startup

2014-07-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119220/ --- (Updated July 14, 2014, 11:24 a.m.) Status -- This change has been

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

2014-07-14 Thread David Edmundson
On July 11, 2014, 2:48 p.m., Sebastian Kügler wrote: It would be easier to review, if you made separate patches for the renaming and the actual changes in the code that juggle around the objects. Martin Klapetek wrote: I did the renaming in the middle of this as I got annoyed by

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

2014-07-14 Thread Martin Klapetek
On July 11, 2014, 4:48 p.m., Sebastian Kügler wrote: It would be easier to review, if you made separate patches for the renaming and the actual changes in the code that juggle around the objects. Martin Klapetek wrote: I did the renaming in the middle of this as I got annoyed by

plasma5 and kde4 settings: what to synchronize

2014-07-14 Thread Marco Martin
Hi all, One thing that seems very requested, is to try to synchronize as much settings as possible between plasma5 (and kf5-based apps) with legacy kde4 applications. Right now it's correctly handling some things when changing settings from plasma 5 systemsettings: * colors * fonts * icon theme

Re: Minutes Monday Plasma Hangout

2014-07-14 Thread Vishesh Handa
On Jul 14, 2014 1:02 PM, Sebastian Kügler se...@kde.org wrote: Sebastian: - last bits of work on release promo, join #kde-promo to help out - long video: https://www.youtube.com/watch?v=4n2dthDSGkc - short video: https://www.youtube.com/watch?v=c8JYt_xkJuY - release notes at:

Re: Minutes Monday Plasma Hangout

2014-07-14 Thread Marco Martin
On Monday 14 July 2014, Vishesh Handa wrote: On Jul 14, 2014 1:02 PM, Sebastian Kügler se...@kde.org wrote: Sebastian: - last bits of work on release promo, join #kde-promo to help out - long video: https://www.youtube.com/watch?v=4n2dthDSGkc - short video:

Review Request 119270: Autotest for corona restore and behavior

2014-07-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119270/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 119155: Make the desktop containment respect minimum sizes

2014-07-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119155/ --- (Updated July 14, 2014, 1:22 p.m.) Status -- This change has been

Re: Review Request 119270: Autotest for corona restore and behavior

2014-07-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119270/#review62294 --- autotests/coronatest.cpp

Re: [kde-promo] Plasma 5 first release

2014-07-14 Thread Jos Poortvliet
On Thursday 10 July 2014 23:00:07 Sebastian Kügler wrote: On Thursday, July 10, 2014 18:40:12 Jonathan Riddell wrote: Who wants to help with Plasma 5 first release promo? Due out on Tuesday. Sebas you said you had a video? Yes, I'm working on a short and a longer video with

Review Request 119274: Use Atlas textures in SvgItem

2014-07-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119274/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 119250: Events and trips according to date ranges

2014-07-14 Thread Shantanu Tushar
On July 12, 2014, 7:39 p.m., R.Harish Navnit wrote: I liked the interface and the idea, +1 for that. Some of the issues that I faced are(brief testing): 1. Create an event - Exit PMC - add new event - unable to do so :( 2. [Logical] Was able to create an event/trip from

Re: Review Request 119270: Autotest for corona restore and behavior

2014-07-14 Thread Marco Martin
On July 14, 2014, 1:40 p.m., David Edmundson wrote: autotests/coronatest.cpp, lines 99-100 https://git.reviewboard.kde.org/r/119270/diff/1/?file=290064#file290064line99 This will wipe the tester's settings, no? yep, that's the intention, other tests do that as well:

Distro Packages Wiki Page

2014-07-14 Thread Jonathan Riddell
Please fill in this wiki page with information on how to get Plasma 5 packages for your distributions https://community.kde.org/Plasma/Packages Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org

Plasma 5.1 Kickoff Meeting

2014-07-14 Thread Jonathan Riddell
Please put in times you can make the 5.1 Kickoff meeting... http://doodle.com/xbqe6m5yw4577gab Make sure it's set to the right timezone for you. Here is the old todo list https://community.kde.org/Plasma/PW2Todo it's a bit unmaintained What tool would people like for the new todo list?

Re: Review Request 119270: Autotest for corona restore and behavior

2014-07-14 Thread Marco Martin
On July 14, 2014, 1:40 p.m., David Edmundson wrote: autotests/coronatest.cpp, line 70 https://git.reviewboard.kde.org/r/119270/diff/1/?file=290064#file290064line70 Why? I thought the overriding the plugin loader was so we don't need real plugins. whithout any sycoca

Re: Review Request 119265: Fix rendering of KSignalPlotter

2014-07-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119265/ --- (Updated July 14, 2014, 4:22 p.m.) Status -- This change has been

Re: Review Request 119233: Do not load system load by default, graphs are broken currently

2014-07-14 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119233/ --- (Updated July 14, 2014, 4:25 p.m.) Status -- This change has been

Re: Review Request 119252: Use KXMLGUI_INSTALL_DIR instead of DATA_INSTALL_DIR for .rc files

2014-07-14 Thread Elias Probst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119252/ --- (Updated July 14, 2014, 5:02 p.m.) Status -- This change has been

Re: Review Request 119270: Autotest for corona restore and behavior

2014-07-14 Thread Marco Martin
On July 14, 2014, 1:40 p.m., David Edmundson wrote: autotests/coronatest.cpp, line 81 https://git.reviewboard.kde.org/r/119270/diff/1/?file=290064#file290064line81 why is this commented out? copy and paste, i guess both using it a or not is fine, since it's waiting for the

Review Request 119276: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'

2014-07-14 Thread Elias Probst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119276/ --- Review request for Plasma. Repository: kinfocenter Description ---

Re: Review Request 119270: Autotest for corona restore and behavior

2014-07-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119270/ --- (Updated July 14, 2014, 5:22 p.m.) Review request for KDE Frameworks and

Re: Plasma 5.0.0!

2014-07-14 Thread Jonathan Riddell
Update to libksysguard for https://bugs.kde.org/336176 ksysguard does not draw graphics in system load libksysguard;master;05c50a62f3f9f41f4b429c0b333e13e302bcbadc;libksysguard-5.0.0.tar.xz;03b4d0eaeb3ba9721393a4fec02fa96e0991de880a34d6fdaf4ab7011c36946d

Re: Review Request 119270: Autotest for corona restore and behavior

2014-07-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119270/#review62312 --- Ship it! autotests/coronatest.cpp

Re: Review Request 119270: Autotest for corona restore and behavior

2014-07-14 Thread Marco Martin
On July 14, 2014, 5:26 p.m., David Edmundson wrote: autotests/coronatest.cpp, line 95 https://git.reviewboard.kde.org/r/119270/diff/2/?file=290134#file290134line95 it might make sense to make all of this in init()/cleanup() rather than initTestCase() that way each test gets

Re: Review Request 119270: Autotest for corona restore and behavior

2014-07-14 Thread David Edmundson
On July 14, 2014, 5:26 p.m., David Edmundson wrote: autotests/coronatest.cpp, line 95 https://git.reviewboard.kde.org/r/119270/diff/2/?file=290134#file290134line95 it might make sense to make all of this in init()/cleanup() rather than initTestCase() that way each test gets

Re: Review Request 119270: Autotest for corona restore and behavior

2014-07-14 Thread Marco Martin
On July 14, 2014, 5:26 p.m., David Edmundson wrote: autotests/coronatest.cpp, line 95 https://git.reviewboard.kde.org/r/119270/diff/2/?file=290134#file290134line95 it might make sense to make all of this in init()/cleanup() rather than initTestCase() that way each test gets

Re: Review Request 119270: Autotest for corona restore and behavior

2014-07-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119270/ --- (Updated July 14, 2014, 6:57 p.m.) Status -- This change has been

Re: Review Request 119250: Events and trips according to date ranges

2014-07-14 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119250/#review62321 --- +1 for this new backend. Other than already mentioned

Review Request 119278: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'

2014-07-14 Thread Elias Probst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119278/ --- Review request for Plasma. Repository: kmenuedit Description ---

Re: Review Request 119278: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'

2014-07-14 Thread Elias Probst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119278/ --- (Updated July 14, 2014, 7:06 p.m.) Review request for Plasma.

Review Request 119279: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'

2014-07-14 Thread Elias Probst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119279/ --- Review request for Documentation and Plasma. Repository: khelpcenter

Re: Review Request 119281: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'

2014-07-14 Thread Elias Probst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119281/ --- (Updated July 14, 2014, 8:48 p.m.) Review request for Plasma.

Review Request 119281: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'

2014-07-14 Thread Elias Probst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119281/ --- Review request for Plasma. Repository: systemsettings Description

Review Request 119282: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'

2014-07-14 Thread Elias Probst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119282/ --- Review request for Plasma. Repository: ksysguard Description ---

Re: Review Request 119278: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'

2014-07-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119278/#review62335 --- Ship it! Ship It! - David Edmundson On July 14, 2014,

Re: Review Request 119282: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'

2014-07-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119282/#review62337 --- Ship it! Ship It! - David Edmundson On July 14, 2014,

Re: Review Request 119281: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'

2014-07-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119281/#review62336 --- Ship it! Ship It! - David Edmundson On July 14, 2014,

Re: Review Request 119279: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'

2014-07-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119279/#review62338 --- Ship it! CMakeLists.txt

Re: Review Request 119278: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'

2014-07-14 Thread Elias Probst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119278/ --- (Updated July 14, 2014, 9:26 p.m.) Status -- This change has been

Re: Review Request 119281: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'

2014-07-14 Thread Elias Probst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119281/ --- (Updated July 14, 2014, 9:28 p.m.) Status -- This change has been

Re: Review Request 119282: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'

2014-07-14 Thread Elias Probst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119282/ --- (Updated July 14, 2014, 9:29 p.m.) Status -- This change has been

Re: Review Request 119279: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'

2014-07-14 Thread Elias Probst
On July 14, 2014, 9:18 p.m., David Edmundson wrote: CMakeLists.txt, line 90 https://git.reviewboard.kde.org/r/119279/diff/1/?file=290222#file290222line90 If you're feeling bored can you tidy up the spacing here before pushing. Done - Elias

Re: Review Request 119279: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'

2014-07-14 Thread Elias Probst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119279/ --- (Updated July 14, 2014, 9:31 p.m.) Status -- This change has been

Review Request 119284: Semantically correct uiReady

2014-07-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119284/ --- Review request for KDE Frameworks and Plasma. Repository:

Review Request 119283: Replace Calendar grid with Canvas

2014-07-14 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119283/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 119283: Replace Calendar grid with Canvas

2014-07-14 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119283/ --- (Updated July 14, 2014, 11:46 p.m.) Review request for Plasma. Changes

Re: Review Request 119274: Use Atlas textures in SvgItem

2014-07-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119274/#review62359 --- Can we get some advertisement about why Atlas is better? /me

Re: Review Request 119276: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'

2014-07-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119276/#review62362 --- Ship it! The DATA_INSTALL_DIR - KXMLGUI_INSTALL_DIR change

Re: Review Request 119283: Replace Calendar grid with Canvas

2014-07-14 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119283/#review62365 --- Ship it! Neato! There's one issue in the dimensions

Re: Review Request 119283: Replace Calendar grid with Canvas

2014-07-14 Thread Sebastian Kügler
On July 15, 2014, 2:04 a.m., Sebastian Kügler wrote: src/declarativeimports/calendar/qml/DaysCalendar.qml, line 58 https://git.reviewboard.kde.org/r/119283/diff/2/?file=290254#file290254line58 + root.borderWidth The last cell has two borders here. Can you verify? Same

Re: Review Request 119274: Use Atlas textures in SvgItem

2014-07-14 Thread Martin Gräßlin
On July 15, 2014, 1:01 a.m., Aleix Pol Gonzalez wrote: Can we get some advertisement about why Atlas is better? /me wants numbers. Faster? Less memory consumption? it means we have one texture instead of many and that reduces state changes which is always a good thing in OpenGL. Tried