Re: Review Request 116722: Allow setTransientParent from an item
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116722/ --- (Updated July 29, 2014, 8:53 a.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-framework Description --- Allow setTransientParent from an item Because QWindow is not exposed as a property of Item in certain cases we may not have access to the owning window in a qml that has menus. For example WidgetExplorer. This patch also fixes crash in setTransientParent is called before a window is set on the menu. Diffs - src/declarativeimports/plasmacomponents/qmenu.h d1a5b73 src/declarativeimports/plasmacomponents/qmenu.cpp a9b41a9 Diff: https://git.reviewboard.kde.org/r/116722/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119522: readlink fails whens the folder does not exist.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119522/#review63393
---
Ship it!
Ship It!
- David Edmundson
On July 28, 2014, 5:17 p.m., Rohan Garg wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119522/
---
(Updated July 28, 2014, 5:17 p.m.)
Review request for Plasma and Àlex Fiestas.
Repository: plasma-workspace
Description
---
https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/f01badb5aa3f76b27955f4fee2cb7281dd490353
introduced a regression in startkde whereby if ~/.config does not exist
readlink will not output the right path.
This leads to startkde trying to write to /startupconfigkeys or /kdeglobals
which obviously won't work.
Since the original commit mentions that relative paths weren't working, I've
taken a alternative approach of using ${HOME} instead.
Diffs
-
startkde/startkde.cmake 281bd43
Diff: https://git.reviewboard.kde.org/r/119522/diff/
Testing
---
Kubuntu Plasma 5 ISO's did not have the right cursor theme before this patch,
after editing startkde by hand, the right files were being correctly written,
and the cursor theme worked as expected.
Thanks,
Rohan Garg
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/#review63396 --- Is this still useful? - David Edmundson On July 17, 2014, 8:17 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/ --- (Updated July 17, 2014, 8:17 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- This is a derivative of https://git.reviewboard.kde.org/r/119330/ It has a much simpler codebase and it doesn't touch framesvg in the library (and doesn't make things public) the important differences are two, that are imo 100% necessary to maintain a pixel perfect rendering (sacrificing that is a regression simply not acceptable in any case, even for non default themes, ever). At the same time avoids duplication of framesvg code in framesvgitem. potential issues: * e037203748 support for tiling still need porting * yes, it uses a qpainter, that means another copy: but again is necessary as framesvg knows how to render the end result pixel perfect, since for many themes the end piece is *not* the simple rendered element id. * yes, the final scaled texture is still uploaded as a whole, it only avoids to do it too often (like in animations) with event compression, again, only way to be sure it's correctly rendered all the time. The latter two points can have the following optimizations: Iff the frame does not have an overlay and does not have composeoverborders set, the following can be done: * use Svg::image() to fetch the pixmap of the piece, since in that case would be valid * resize the framesvg one single time, at a fixed size , like something 256x256 (256 is not random thing, since we have 8 bits per channel, usually gradients will have no more than 256 stops) and disable the resize timer, this way we are even sure that only one image per prefix will be stored in cache I should add regarding the last two optimization points: i would like to see some real benchmarks about them, or i would not consider then necessary until then. Diffs - tests/dialog.qml PRE-CREATION tests/testborders.qml PRE-CREATION examples/applets/widgetgallery/contents/ui/Buttons.qml 379585f examples/applets/widgetgallery/contents/ui/Menu.qml 1336c42 examples/applets/widgetgallery/contents/ui/standalonemain.qml PRE-CREATION src/declarativeimports/core/framesvgitem.h e155f6a src/declarativeimports/core/framesvgitem.cpp 8320212 src/declarativeimports/core/svgitem.cpp 1ed0631 Diff: https://git.reviewboard.kde.org/r/119336/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119404: Use full libexec location
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119404/#review63394 --- Ship it! - David Edmundson On July 22, 2014, 12:09 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119404/ --- (Updated July 22, 2014, 12:09 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- resolves the problem of relative vs. absolute LIBEXEC_INSTALL_DIR var usage. Diffs - ksmserver/config-ksmserver.h.cmake a454a4d startkde/startkde.cmake 281bd43 Diff: https://git.reviewboard.kde.org/r/119404/diff/ Testing --- builds Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 101074: Chime Time Implementation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/101074/ --- (Updated July 29, 2014, 9:06 a.m.) Status -- This change has been discarded. Review request for Plasma. Repository: kde-workspace Description --- Presently I have developed a UI for the setting s in the General part. There are at present 3 radio buttons and according to the user wish, the radiobutton which is clicked would work. There is a bug since the settings gets changed when you again go and see the general settings. Diffs - libs/plasmaclock/CMakeLists.txt 667df3c libs/plasmaclock/clockapplet.h b75f286 libs/plasmaclock/clockapplet.cpp b806792 libs/plasmaclock/generalConfig.ui aae25c0 plasma/generic/applets/analog-clock/clock.cpp 68d0725 Diff: https://git.reviewboard.kde.org/r/101074/diff/ Testing --- Screenshots --- snapshot https://git.reviewboard.kde.org/r/101074/s/122/ Thanks, Sunny Sharma ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115727: Deafult for not executing kwalletmanager once a wallet is open
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115727/#review63398 --- What's the status of this. Can we at least merge this in 5.x? - David Edmundson On Feb. 13, 2014, 5:13 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115727/ --- (Updated Feb. 13, 2014, 5:13 p.m.) Review request for KDE Runtime, kde-workspace and Plasma. Repository: kwallet Description --- Given that in 4.13 we want people to use pam to open the wallet it makes little sense to execute the wallet automatically. Other commits changing the default have been pushed to runtime and kwalletmanager Diffs - src/konfigurator/konfigurator.cpp b9f6edb src/manager/kwalletmanager.cpp 355fda7 Diff: https://git.reviewboard.kde.org/r/115727/diff/ Testing --- Thanks, Àlex Fiestas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 100743: Add a system tray option to always show all items
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/100743/ --- (Updated July 29, 2014, 9:08 a.m.) Status -- This change has been discarded. Review request for Plasma. Repository: kde-workspace Description --- If the user wishes to have all system tray items visible at all times, there is no single setting to allow this. The only option is to go to System Tray Settings - Entries and set all of the Visibility combo boxes to Always Visible, and repeat this whenever a new item appears. All versions of a popular closed source operating system have this option for the system tray. This change adds a check box Always show all system tray items below the list on the Entries page. Checking this sets all items (current and any new ones that may appear in future) to be always visible and disables the Visibility column. It is still possible to access the Keyboard Shortcut column. The default is for this option not to be set, so the system tray operation is the same as before. Diffs - plasma/generic/applets/systemtray/ui/applet.h d6cc509 plasma/generic/applets/systemtray/ui/applet.cpp f3c6d9a plasma/generic/applets/systemtray/ui/autohide.ui 3b6efff plasma/generic/applets/systemtray/ui/taskarea.h 9a47d16 plasma/generic/applets/systemtray/ui/taskarea.cpp f47515f Diff: https://git.reviewboard.kde.org/r/100743/diff/ Testing --- Built kde-workspace with these changes, checked operation of system tray and settings dialogue with this option checked and not checked. Thanks, Jonathan Marten ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/ --- (Updated July 29, 2014, 9:10 a.m.) Status -- This change has been discarded. Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- This is a derivative of https://git.reviewboard.kde.org/r/119330/ It has a much simpler codebase and it doesn't touch framesvg in the library (and doesn't make things public) the important differences are two, that are imo 100% necessary to maintain a pixel perfect rendering (sacrificing that is a regression simply not acceptable in any case, even for non default themes, ever). At the same time avoids duplication of framesvg code in framesvgitem. potential issues: * e037203748 support for tiling still need porting * yes, it uses a qpainter, that means another copy: but again is necessary as framesvg knows how to render the end result pixel perfect, since for many themes the end piece is *not* the simple rendered element id. * yes, the final scaled texture is still uploaded as a whole, it only avoids to do it too often (like in animations) with event compression, again, only way to be sure it's correctly rendered all the time. The latter two points can have the following optimizations: Iff the frame does not have an overlay and does not have composeoverborders set, the following can be done: * use Svg::image() to fetch the pixmap of the piece, since in that case would be valid * resize the framesvg one single time, at a fixed size , like something 256x256 (256 is not random thing, since we have 8 bits per channel, usually gradients will have no more than 256 stops) and disable the resize timer, this way we are even sure that only one image per prefix will be stored in cache I should add regarding the last two optimization points: i would like to see some real benchmarks about them, or i would not consider then necessary until then. Diffs - tests/dialog.qml PRE-CREATION tests/testborders.qml PRE-CREATION examples/applets/widgetgallery/contents/ui/Buttons.qml 379585f examples/applets/widgetgallery/contents/ui/Menu.qml 1336c42 examples/applets/widgetgallery/contents/ui/standalonemain.qml PRE-CREATION src/declarativeimports/core/framesvgitem.h e155f6a src/declarativeimports/core/framesvgitem.cpp 8320212 src/declarativeimports/core/svgitem.cpp 1ed0631 Diff: https://git.reviewboard.kde.org/r/119336/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 102905: ensure activity resources exist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102905/ --- (Updated July 29, 2014, 9:11 a.m.) Status -- This change has been discarded. Review request for Plasma and Ivan Čukić. Repository: kactivities Description --- on the first boot, probably due to the order services are started up, even if all the activities do exist, the corresponding Nepomuk resources don't until a reboot. this tries to ensure resources existence by calling syncActivitiesWithNepomuk(); as soon nepomuk becomes available, since is not sure the nepomuk service exists at the time of the activitymanager ctor Diffs - service/ActivityManager.cpp 86f1152 Diff: https://git.reviewboard.kde.org/r/102905/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 107869: Add a real konquerorsessions plugin for krunner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107869/#review63399 --- The coding style in the entire review is off. File Attachment: the patch - 0002-Add-a-real-konquerorsessions-plugin_1.patch https://git.reviewboard.kde.org//r/107869/#fcomment230 I don't really understand the whole kate comment. - Vishesh Handa On Dec. 23, 2012, 12:27 p.m., Jekyll Wu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107869/ --- (Updated Dec. 23, 2012, 12:27 p.m.) Review request for Plasma. Bugs: 188494 http://bugs.kde.org/show_bug.cgi?id=188494 Repository: kdeplasma-addons Description --- This is a follow-up of https://git.reviewboard.kde.org/r/107868/ . The code is based upon the old and unreal konquerorsessions plugin, with minimal modification (since I'm not familiar with krunner plugins) to make it work in the way as its name implies. The patch can't be uploaded as diff, since it depends upon the patch in https://git.reviewboard.kde.org/r/107868/ and that one has not be committed. See the attached file below. Diffs - Diff: https://git.reviewboard.kde.org/r/107869/diff/ Testing --- File Attachments the patch https://git.reviewboard.kde.org/media/uploaded/files/2012/12/23/0002-Add-a-real-konquerorsessions-plugin_1.patch Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 102464: Add scrollbar support for the Web Slice plasmoid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102464/ --- (Updated July 29, 2014, 9:26 a.m.) Status -- This change has been discarded. Review request for Plasma. Repository: kdeplasma-addons Description --- I have basically added a function to enable/disable the scrollbar on Web Slice. Diffs - applets/webslice/kgraphicswebslice.h dfb60e5b0b3765f8e2324f832f78a1abac0db510 applets/webslice/kgraphicswebslice.cpp 6c976a0f8250e11ffb9dc4e85e122433f86a073a applets/webslice/kwebslice.cpp c1eb9ea8da64129765ad68044f2b7d038387b08b applets/webslice/plasma/webslice.h fbe12420ea372c6f1b073a4f047a6cbb742cc0a0 applets/webslice/plasma/webslice.cpp a1740bfd62dd91401a366a240e83e6b84509f81c applets/webslice/plasma/websliceConfig.ui b3ac77608ec66e1be1ebca04488ae19318163a75 Diff: https://git.reviewboard.kde.org/r/102464/diff/ Testing --- Thanks, Javier Llorente ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 105924: plasma calendar - event system config option
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105924/ --- (Updated July 29, 2014, 9:32 a.m.) Status -- This change has been discarded. Review request for Plasma and Anne-Marie Mahfouf. Bugs: 281464 http://bugs.kde.org/show_bug.cgi?id=281464 Repository: kde-workspace Description --- This patch addresses an usuability issue. The config option 'display events' enables/disables now all events/holidays. The user doesn't distinguish between them and it must be possible to turn off that feature with just one click. Diffs - libs/plasmaclock/calendar.cpp 75bfc31 libs/plasmaclock/calendartable.h 8678593 libs/plasmaclock/calendartable.cpp d2b436e libs/taskmanager/groupmanager.cpp 45c15a9 Diff: https://git.reviewboard.kde.org/r/105924/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 107428: make the DeviceNotifier Plasmoid scale with high-res screens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107428/ --- (Updated July 29, 2014, 9:35 a.m.) Status -- This change has been discarded. Review request for Plasma and Kai Uwe Broulik. Repository: kde-workspace Description --- This adjustst the DeviceNotifier Plasmoid to scale nicely with high resolution screens. The patch changes also one label from wordWrapping to clipping behavior because otherwise it messes up the layout. Diffs - plasma/generic/applets/devicenotifier/package/contents/ui/ActionItem.qml 3087a07 plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml 1fab0ef plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml f8728d0 Diff: https://git.reviewboard.kde.org/r/107428/diff/ Testing --- Tested on High res screen at full DPI and at regular DPI values Thanks, Michael Zanetti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 106448: replace old kickoff with kickoff-qml
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/106448/ --- (Updated July 29, 2014, 9:42 a.m.) Status -- This change has been discarded. Review request for Plasma and Martin Gräßlin. Repository: kde-workspace Description --- I think it's time now to get the new kickoff into master so we can polish it for KDE 4.10. the qml plasmoid is still using the old model code (though slightly adjusted). This could cause issues for the c++ menu launcher simpleapplet...I'm not using it but actually it doesn't even compile. Probably would be better to port it to qml as well...opinions? The qml code resides in the package dir. It's a pure qml widget with c++ model extensions...obviously :) Add to Panel/Desktop is still not supported but overall I think we have reached feature parity with kickoff c++ I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How can we ensure a smooth transition for devs and users? Diffs - plasma/desktop/applets/kickoff/CMakeLists.txt e9e288866ecdcfd7aa35c086dfe78d4252748995 plasma/desktop/applets/kickoff/Messages.sh b1fa03bcfd6254de7697a674a37919724a0a0965 plasma/desktop/applets/kickoff/applet/applet.h f3afe734df993a4fad950068143d84f9e25dedc8 plasma/desktop/applets/kickoff/applet/applet.cpp a6f7379e830ea02c702f492eb94bf489d87314e1 plasma/desktop/applets/kickoff/core/CMakeLists.txt PRE-CREATION plasma/desktop/applets/kickoff/core/applicationmodel.h f0f8872255956321292151cdd82326cdf88c5508 plasma/desktop/applets/kickoff/core/applicationmodel.cpp 57b6ba524255fc59c2ff5b58a64edc1c7f0f82e2 plasma/desktop/applets/kickoff/core/favoritesmodel.h 8ee3e9a9eb16780131d59b150b50641e5a03a34c plasma/desktop/applets/kickoff/core/favoritesmodel.cpp 58c2c5de8defe415d64204c795075e16c23e883c plasma/desktop/applets/kickoff/core/itemhandlers.h ec72cbe51b6e2da604ba6eba96f9e6f3f5935f67 plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37588af1ebab331082e2eaccb40a0f8155c plasma/desktop/applets/kickoff/core/kickoffabstractmodel.cpp 7e2e64d22e9e274ffe3d37fdd0ac2c33a622ea3a plasma/desktop/applets/kickoff/core/kickoffmodel.cpp 8149cac20ce8ab246d8f484ca7567fc6e32d548c plasma/desktop/applets/kickoff/core/kickoffplugin.h PRE-CREATION plasma/desktop/applets/kickoff/core/kickoffplugin.cpp PRE-CREATION plasma/desktop/applets/kickoff/core/kickoffproxymodel.cpp f92bca971e0f9fcb644cadab6aa39a3e36291c00 plasma/desktop/applets/kickoff/core/krunnermodel.h 93a8b152a673eb6233727a82eefd70739ffc5a0f plasma/desktop/applets/kickoff/core/krunnermodel.cpp 452ebbe81311f8e3e95b5eda5fb9217344852d06 plasma/desktop/applets/kickoff/core/leavemodel.h 0676fb9358bdfd5e3cffce7eb3a0ea5e4ff70989 plasma/desktop/applets/kickoff/core/leavemodel.cpp 47559cef7331ac5b37f42ed57c7c9a6668d5d53b plasma/desktop/applets/kickoff/core/models.h 3332ba9608808b353c32d96c37b84ddd82aabddf plasma/desktop/applets/kickoff/core/models.cpp c787df6e2f2c7c88ff97c64c7cd7640cce32365b plasma/desktop/applets/kickoff/core/qmldir PRE-CREATION plasma/desktop/applets/kickoff/core/recentapplications.h a0feddca1cebbeb556623216bcc6c5c30e13a2a4 plasma/desktop/applets/kickoff/core/recentapplications.cpp 3e0538958564ae690e41791bdb5af76fa2ca9a8f plasma/desktop/applets/kickoff/core/recentlyusedmodel.h 841eb2b77aee778a85c76eafa61d38016f6ade58 plasma/desktop/applets/kickoff/core/recentlyusedmodel.cpp 2762d6d63a7b0592a7e87cd99603cc7c418292c5 plasma/desktop/applets/kickoff/core/systemmodel.h 3d7d6e1e6ebb8f3d14f09ff5f2e9c22098f4add2 plasma/desktop/applets/kickoff/core/systemmodel.cpp 11688a10a03a3cdd6ff84bfff65d48bec336afbd plasma/desktop/applets/kickoff/core/urlitemlauncher.h 26b638fc02f42505e29857b5c18736e6778a580e plasma/desktop/applets/kickoff/core/urlitemlauncher.cpp 75bbfb5a5c6df837e7e56de501156b2ca12ed6d7 plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/Breadcrumb.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/KickoffButton.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/MainView.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/SearchView.qml PRE-CREATION plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml PRE-CREATION plasma/desktop/applets/kickoff/package/metadata.desktop PRE-CREATION plasma/desktop/applets/kickoff/simpleapplet/contextmenufactory.h PRE-CREATION plasma/desktop/applets/kickoff/simpleapplet/contextmenufactory.cpp PRE-CREATION plasma/desktop/applets/kickoff/simpleapplet/menuview.cpp 7d2fb7bd0d92c8dcaa31a87ca3fcd0742310e101
Re: Review Request 118180: slideshow BUG patch fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated July 29, 2014, 9:43 a.m.) Status -- This change has been discarded. Review request for kde-workspace and Plasma. Bugs: 327580 http://bugs.kde.org/show_bug.cgi?id=327580 Repository: kde-workspace Description --- bug patch for slideshow dir list missing Diffs - libs/plasmagenericshell/backgrounddialog.cpp 645de3f Diff: https://git.reviewboard.kde.org/r/118180/diff/ Testing --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118180: slideshow BUG patch fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review63401 --- Reviewboard wasn't showing the patch, not sure why. We can't do much without it. Sorry. - David Edmundson On July 29, 2014, 9:43 a.m., TOM Harrison wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated July 29, 2014, 9:43 a.m.) Review request for kde-workspace and Plasma. Bugs: 327580 http://bugs.kde.org/show_bug.cgi?id=327580 Repository: kde-workspace Description --- bug patch for slideshow dir list missing Diffs - libs/plasmagenericshell/backgrounddialog.cpp 645de3f Diff: https://git.reviewboard.kde.org/r/118180/diff/ Testing --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 104603: [KActivityManagerDaemon] Activity Changed On Screen Display
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/104603/ --- (Updated July 29, 2014, 9:45 a.m.) Status -- This change has been discarded. Review request for kwin and Plasma. Bugs: 265456 and 295410 http://bugs.kde.org/show_bug.cgi?id=265456 http://bugs.kde.org/show_bug.cgi?id=295410 Repository: kactivities Description --- Closes: http://bugs.kde.org/show_bug.cgi?id=265456 Partialy closes: https://bugs.kde.org/show_bug.cgi?id=295410 On screen display notification when changing activities. Displays the user icon and the name. It is heavily based on KWin's DesktopChangedOSD and KRunner's Quicksand. This could be as well implemented on KWin, but i did as a kamd plugin for fun :P. For the time being i think it is not correct to force such plugin (it would be cool is kamd's plugins were managed via systemsettings) without an option to enable/disable, but anyways, here goes nothing. Code cleanup is somewhat needed. Diffs - service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858 service/plugins/activitychangedosd/CMakeLists.txt PRE-CREATION service/plugins/activitychangedosd/activitychangeditem.h PRE-CREATION service/plugins/activitychangedosd/activitychangeditem.cpp PRE-CREATION service/plugins/activitychangedosd/activitychangedosd.h PRE-CREATION service/plugins/activitychangedosd/activitychangedosd.cpp PRE-CREATION service/plugins/activitychangedosd/activitychangedosdplugin.h PRE-CREATION service/plugins/activitychangedosd/activitychangedosdplugin.cpp PRE-CREATION service/plugins/activitychangedosd/activitymanager-plugin-activitychangedosd.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/104603/diff/ Testing --- Changed activities and it works. Screenshots --- without kwin effects https://git.reviewboard.kde.org/r/104603/s/531/ with kwin effects https://git.reviewboard.kde.org/r/104603/s/532/ after kwin effects disabledd (possible bug) https://git.reviewboard.kde.org/r/104603/s/533/ Thanks, makis marimpis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 101321: Add QSocket-binding to the Plasma Javascript scriptengine
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/101321/ --- (Updated July 29, 2014, 9:47 a.m.) Status -- This change has been discarded. Review request for Plasma. Repository: kde-runtime Description --- This patch adds bindings for QSocket to the Plasma Javascript engine. The idea is to enable low-level access to QSocket to allow dealing with online- and remote-services. Does there exist a security-/authentification solution this needs to integrate with? Diffs - plasma/scriptengines/javascript/CMakeLists.txt 1451e16 plasma/scriptengines/javascript/plasmoid/simplejavascriptapplet.cpp 0076cd8 plasma/scriptengines/javascript/simplebindings/socket.h PRE-CREATION plasma/scriptengines/javascript/simplebindings/socket.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/101321/diff/ Testing --- Works fine with my testcases. Thanks, Sebastian Sauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110608: Add support for keyboard backlight handling to the powermanagement dataengine
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110608/ --- (Updated July 29, 2014, 9:55 a.m.) Status -- This change has been marked as submitted. Review request for Plasma and Solid. Repository: kde-workspace Description --- This patch adds support for keyboard backlight handling to the powermanagement dataengine. It is similar to the backlight handling. Allows setting and getting they keyboard brightness and checking whether it is supported at all. Diffs - plasma/generic/dataengines/powermanagement/powermanagementengine.h 319a17c plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 4b184fa plasma/generic/dataengines/powermanagement/powermanagementjob.h 3b974ab plasma/generic/dataengines/powermanagement/powermanagementjob.cpp 6f90006 plasma/generic/dataengines/powermanagement/powermanagementservice.operations 533c00a Diff: https://git.reviewboard.kde.org/r/110608/diff/ Testing --- Adjusting keyboard brightness from the battery monitor so col. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110608: Add support for keyboard backlight handling to the powermanagement dataengine
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110608/#review63402 --- submitted with http://quickgit.kde.org/?p=kde-workspace.gita=commith=6d5a1ed09f74d117f336517857d7a9a52a72afbf - David Edmundson On May 23, 2013, 9:13 a.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110608/ --- (Updated May 23, 2013, 9:13 a.m.) Review request for Plasma and Solid. Repository: kde-workspace Description --- This patch adds support for keyboard backlight handling to the powermanagement dataengine. It is similar to the backlight handling. Allows setting and getting they keyboard brightness and checking whether it is supported at all. Diffs - plasma/generic/dataengines/powermanagement/powermanagementengine.h 319a17c plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 4b184fa plasma/generic/dataengines/powermanagement/powermanagementjob.h 3b974ab plasma/generic/dataengines/powermanagement/powermanagementjob.cpp 6f90006 plasma/generic/dataengines/powermanagement/powermanagementservice.operations 533c00a Diff: https://git.reviewboard.kde.org/r/110608/diff/ Testing --- Adjusting keyboard brightness from the battery monitor so col. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 104015: A usable system monitor plasmoid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/104015/ --- (Updated July 29, 2014, 9:57 a.m.) Status -- This change has been discarded. Review request for Plasma. Repository: kdeplasma-addons Description --- A plasmoid intended to be used on a panel. Inspired by gnome-multiload-applet and gkrellm. Before I decided to write this plasmoid, I considered other monitors. Here's what I found: - system-monitor: * not pixel-perfect: it uses antialiasing and Bezier curves * in stacking mode, it adds a few pixels to all values, so a 0 network throughput still shows 2 belts. * impossible to read at a glance due to low contrast and no custom colors * shows only basic properties * graphs change features depending on size * deal-breaker: impossible to set custom height or width - system-load-viewer: almost there, but no history display - The Only Right RAM Monitor: too slow and RAM only This plasmoid attempts to solve all those problems while introducing new ones :) What's fixed in this one: - many graphs in one applet - graphs laid out on a grid - forces graph width or height (depending on mode) - can force row or column number (depending on mode) - arbitrary colors for all graph types - pixel-perfect - handles runtime CPU/network addition/removal (CPU untested) Other stuff: - labels only for network interfaces - resizable labels - network transmit graph stacks on top - C++, a monitor should measure resources, not use them - no way to disable graphs :) - no way to reorder graphs - network interfaces are not sorted - all CPUs are displayed - can't change colors for a distinct graph - will not fit in container if the wrong layout params are selected (forcing a dimension to be more than available) - the original idea was to synchronize all readings, but it seems impossible with plasma data engines It's my first project in Qt, so the code will not be as nice as it could be. I rewrote the plotter and the layout, so those are the most likely to contain errors/memory leaks. Also, I don't know which of the above problems need to be solved and which decisions are acceptable, but I'll happily apply all fixes to make this accepted. Diffs - applets/CMakeLists.txt 1e1ef75 applets/graphmon/CMakeLists.txt PRE-CREATION applets/graphmon/color-config.ui PRE-CREATION applets/graphmon/cpuload.h PRE-CREATION applets/graphmon/cpuload.cpp PRE-CREATION applets/graphmon/general-config.ui PRE-CREATION applets/graphmon/graphmon.h PRE-CREATION applets/graphmon/graphmon.cpp PRE-CREATION applets/graphmon/netthroughput.h PRE-CREATION applets/graphmon/netthroughput.cpp PRE-CREATION applets/graphmon/plasma-applet-graphmon.desktop PRE-CREATION applets/graphmon/ramusage.h PRE-CREATION applets/graphmon/ramusage.cpp PRE-CREATION applets/graphmon/rigidgridlayout.h PRE-CREATION applets/graphmon/rigidgridlayout.cpp PRE-CREATION applets/graphmon/simpleplotter.h PRE-CREATION applets/graphmon/simpleplotter.cpp PRE-CREATION applets/graphmon/swapusage.h PRE-CREATION applets/graphmon/swapusage.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/104015/diff/ Testing --- Display, layout, configuration, persistence. Screenshots --- Graph on panel and general config section https://git.reviewboard.kde.org/r/104015/s/437/ Thanks, rhn rhn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118180: slideshow BUG patch fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 10:04 a.m.) Review request for kde-workspace and Plasma. Bugs: 327580 http://bugs.kde.org/show_bug.cgi?id=327580 Repository: kde-workspace Description --- bug patch for slideshow dir list missing Diffs (updated) - libs/plasmagenericshell/backgrounddialog.cpp 645de3f Diff: https://git.reviewboard.kde.org/r/118180/diff/ Testing --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119524: Force OpenGLES if on Qt 5.4
On jul 28, 2014, 7:03 p.m., Mark Gaiser wrote: If there is one hardware combination that works best on linux, it's OpenGL + Intel. I find it hard to believe that GLES is better and in all cases. That must be a driver/mesa bug that should be investigated and fixed. If this would've been a fix to workaround crappy AMD drivers, then this patch would be understandable. AMD is just slacking. But switching to OpenGL ES on all platforms because intel supposedly performs better is a bit weird. Can't the plasma graphics stack (OpenGL or OpenGL ES) be chosen at runtime like it can with KWin? Perhaps you can even re-use KWin's GL setting in plasma? Aleix Pol Gonzalez wrote: Well, OpenGL ES is a subset of OpenGL, so less things will be available but I'd say it's better to use the small thing until we need the big one rather than the other way around. Especially if we want to think about devices, some day. What's the current state of GLES on desktop platforms anyway? - Intel? - NVidia? - AMD? I think AMD might have better GL support on the desktop. There was something there with EGL, but that was a couple years ago when kwin_gles was brand new. I don't know it's current state. Lastly, what do you think of the idea to use KWin's GL detection stuff for this? - Mark --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/#review63366 --- On jul 28, 2014, 6:09 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/ --- (Updated jul 28, 2014, 6:09 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- When trying to reduce memory usage in plasma shell, we realized that one of the reasons we got such big memory footprint was actually the intel driver (on intel systems, that is). After some investigation, David found out we were going through some memory-consuming path [1]. A way to workaround it is by using only OpenGLES. Everything still works here after this patch, so it seems to be a good change to get in. This change needs Qt 5.4, to get the new API that lets us enforce a QSurfaceFormat, hence having it ifdef'd. I'm quite unaware of problems we might find. Knowing we probably want to work in different embedded devices, suggests that OpenGLES on all platforms sounds like a safe bet. [1] http://comments.gmane.org/gmane.comp.video.mesa3d.devel/60848 Diffs - shell/main.cpp e34578d Diff: https://git.reviewboard.kde.org/r/119524/diff/ Testing --- I'm using it now, without visible problems. Now we see no trace of i915 in the massif reports. File Attachments before https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/5a6beb4f-24c0-4cee-a7a2-038385e35119__plasma-massif-opengl.png after https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/fc301ff5-cb1d-4654-a57f-82990220c8e3__plasma-massif-opengles.png Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118180: slideshow BUG patch fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 10:05 a.m.) Review request for kde-workspace and Plasma. Bugs: 327580 http://bugs.kde.org/show_bug.cgi?id=327580 Repository: kde-workspace Description --- bug patch for slideshow dir list missing Diffs - libs/plasmagenericshell/backgrounddialog.cpp 645de3f Diff: https://git.reviewboard.kde.org/r/118180/diff/ Testing (updated) --- I will fix it soon. something wrong with the patch. Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Reviews
Sorry for flooding the mailing list. I've spent the morning cleaning out some of Plasma's review requests. One was nearly 4 years old. The following reviews are for 4.x but seem to be non-invasive bug fixes that I /think/ we should backport. I'd like a second opinion from people more familiar with the 4.x code. https://git.reviewboard.kde.org/r/105779/ https://git.reviewboard.kde.org/r/109711/ https://git.reviewboard.kde.org/r/109780/ https://git.reviewboard.kde.org/r/113697/ (With comment fixed) https://git.reviewboard.kde.org/r/114910/ There are also some reviews concerning plasma-addons stuff for Plasma 5.x which are probably worth merging now. https://git.reviewboard.kde.org/r/112789/diff/# https://git.reviewboard.kde.org/r/114260/ https://git.reviewboard.kde.org/r/109124/ (ish) There are a /lot/ of Plasma Media Centre reviews open (about half are PMC), I'm not sure what the state of those is, are they awaiting reviews from the non-media centre devs, or just no longer relevant. If someone from PMC pings me I can help go through and discard outdated things. David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119515: Support per-activity favourites
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119515/#review63406 --- applets/kickoff/core/krunnermodel.cpp https://git.reviewboard.kde.org/r/119515/#comment44204 We generally don't want any new code using deprecated classes, such as KUrl. Can you change that? - Sebastian Kügler On July 28, 2014, 5:50 p.m., Ivan Čukić wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119515/ --- (Updated July 28, 2014, 5:50 p.m.) Review request for Plasma, Eike Hein, Marco Martin, and Sebastian Kügler. Repository: plasma-desktop Description --- This patch adds the support to have favourites linked to activities. It uses org.kde.activities.ResourceModel to show favorites. It supports: - adding a favourite to all activities (the previous behaviour) - adding a favourite to the current activity - moving a favourite between 'all activities' and 'current activity' modes (it does not affect non-current activities) - drag-and-drop reordering of items (like the previous one) - sorting A-Z, Z-A (like the previous one) - transitions previously defined favourites to the new system* Context menu item captions could maybe use some improvement. Screenshot available at: http://ivan.fomentgroup.org/blog/2014/07/27/per-activity-favourites-in-kickoff/#/comments * this can also be used for defining the default favourites in a global kickoffrc file - instead of them being hard-coded like they currently are. Diffs - applets/kickoff/CMakeLists.txt 28e7029 applets/kickoff/core/favoritesmodel.h 27a0626 applets/kickoff/core/favoritesmodel.cpp f05588b applets/kickoff/core/kickoffplugin.cpp f549981 applets/kickoff/core/krunnermodel.h 3916829 applets/kickoff/core/krunnermodel.cpp db2adab applets/kickoff/package/contents/ui/ContextMenu.qml 6a67874 applets/kickoff/package/contents/ui/FavoritesView.qml 6c2d5d4 applets/kickoff/package/contents/ui/FullRepresentation.qml 6291b7c Diff: https://git.reviewboard.kde.org/r/119515/diff/ Testing --- Yes Thanks, Ivan Čukić ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 107868: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107868/#review63408 --- Jekyll, ping? - Vishesh Handa On Dec. 31, 2012, 7:12 p.m., Jekyll Wu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107868/ --- (Updated Dec. 31, 2012, 7:12 p.m.) Review request for Plasma. Bugs: 188494 http://bugs.kde.org/show_bug.cgi?id=188494 Repository: kdeplasma-addons Description --- What the current konquerorsessions plugin does is eventually calling konqueror --profile xyz, so it is really for the profile feature of konqueror, not the session feature of konqueoror. The patch just contains various moving and renaming opeations to make its code, name and behavior being consistent. I actually have made a real konquerosessions plugin based upon this unreal plugin. Will post it in another review. Diffs - runners/CMakeLists.txt bb4b491 runners/konquerorprofiles/CMakeLists.txt PRE-CREATION runners/konquerorprofiles/Messages.sh PRE-CREATION runners/konquerorprofiles/konquerorprofiles.cpp PRE-CREATION runners/konquerorprofiles/konquerorprofiles.desktop PRE-CREATION runners/konquerorprofiles/konquerorprofiles.h PRE-CREATION runners/konquerorprofiles/konquerorsessions_renamed_to_konquerorprofiles.upd PRE-CREATION runners/konquerorsessions/CMakeLists.txt be2ea9d runners/konquerorsessions/Messages.sh 0720e1e runners/konquerorsessions/konquerorsessions.cpp f2e437a runners/konquerorsessions/konquerorsessions.desktop df81780 runners/konquerorsessions/konquerorsessions.h 957f976 Diff: https://git.reviewboard.kde.org/r/107868/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 107881: Rename krunner plugin konsolesessions to konsoleprofiles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107881/#review63407 --- Ping. Jekyll, could you please rename the directory as Aaron suggested? - Vishesh Handa On Dec. 31, 2012, 6:58 p.m., Jekyll Wu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107881/ --- (Updated Dec. 31, 2012, 6:58 p.m.) Review request for Plasma. Repository: kdeplasma-addons Description --- Konsole currently does not provide the session feature like in kate and konqueror. That plugin works with konsole profiles, not the not-reimplemented-yet konsole sessions. Also, the equivalent plasmoid is properly named as konsole profiles. Diffs - runners/CMakeLists.txt bb4b491 runners/konsoleprofiles/CMakeLists.txt PRE-CREATION runners/konsoleprofiles/Messages.sh PRE-CREATION runners/konsoleprofiles/konsoleprofiles.cpp PRE-CREATION runners/konsoleprofiles/konsoleprofiles.desktop PRE-CREATION runners/konsoleprofiles/konsoleprofiles.h PRE-CREATION runners/konsoleprofiles/konsolesessions_renamed_to_konsoleprofiles.upd PRE-CREATION runners/konsolesessions/CMakeLists.txt c1d5cea runners/konsolesessions/Messages.sh 5f03904 runners/konsolesessions/konsolesessions.cpp ed7550a runners/konsolesessions/konsolesessions.desktop 7d9ce5a runners/konsolesessions/konsolesessions.h a98c253 Diff: https://git.reviewboard.kde.org/r/107881/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 107869: Add a real konquerorsessions plugin for krunner
On July 29, 2014, 9:17 a.m., Vishesh Handa wrote: File Attachment: the patch - 0002-Add-a-real-konquerorsessions-plugin_1.patch https://git.reviewboard.kde.org/r/107869/#fcomment231 I don't really understand the whole kate comment. I think the code was originally copied from the kate sessions runner, perhaps a leftover? - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107869/#review63399 --- On Dec. 23, 2012, 12:27 p.m., Jekyll Wu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107869/ --- (Updated Dec. 23, 2012, 12:27 p.m.) Review request for Plasma. Bugs: 188494 http://bugs.kde.org/show_bug.cgi?id=188494 Repository: kdeplasma-addons Description --- This is a follow-up of https://git.reviewboard.kde.org/r/107868/ . The code is based upon the old and unreal konquerorsessions plugin, with minimal modification (since I'm not familiar with krunner plugins) to make it work in the way as its name implies. The patch can't be uploaded as diff, since it depends upon the patch in https://git.reviewboard.kde.org/r/107868/ and that one has not be committed. See the attached file below. Diffs - Diff: https://git.reviewboard.kde.org/r/107869/diff/ Testing --- File Attachments the patch https://git.reviewboard.kde.org/media/uploaded/files/2012/12/23/0002-Add-a-real-konquerorsessions-plugin_1.patch Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Reviews
On Tue, Jul 29, 2014 at 12:07 PM, David Edmundson da...@davidedmundson.co.uk wrote: There are a /lot/ of Plasma Media Centre reviews open (about half are PMC), I'm not sure what the state of those is, are they awaiting reviews from the non-media centre devs, or just no longer relevant. If someone from PMC pings me I can help go through and discard outdated things. David Hey guys How about we get a separate group for PMC? It's is a separate mature project after all. The review request emails can still continue coming on the plasma-devel mailing list. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: qml controls and documentation
There are .tags file made for most of Qt but not for qtquickcontrols. In order to make it work automatically we'd have to fix QtDoc first. :( ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 109711: Fixes a bug in the KDE dataengine to use the POST method instead of GET which allows large text to be sent to the server
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109711/#review63410 --- Ship it! this should be done for both 4.x and the 5.x port - Marco Martin On Mar. 25, 2013, 6:50 p.m., Bhaskar Kandiyal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109711/ --- (Updated Mar. 25, 2013, 6:50 p.m.) Review request for Plasma. Bugs: 289647 http://bugs.kde.org/show_bug.cgi?id=289647 Repository: kde-workspace Description --- Fixes a bug where the default text engine 'kde' fails when pasting text longer than 513/741 characters in the PasteBin widget. The problem is that the generic dataengine 'kde' uses a GET request to send data to the http://paste.kde.org server which does not allow large text to be sent to the server. This patch changes the GET request to a POST request which fixes the bug. Bug Report: https://bugs.kde.org/show_bug.cgi?id=289647 Diffs - plasma/generic/dataengines/share/backends/kde/contents/code/main.js 600950d Diff: https://git.reviewboard.kde.org/r/109711/diff/ Testing --- Thanks, Bhaskar Kandiyal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 113697: Return focus to input widget after pressing alt key in the screen locker.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113697/#review63412 --- Ship it! may be pushed to 4.x - Marco Martin On Nov. 27, 2013, 12:27 a.m., Teemu Rytilahti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113697/ --- (Updated Nov. 27, 2013, 12:27 a.m.) Review request for Plasma. Bugs: 314720, 316084, 319935, and 324821 http://bugs.kde.org/show_bug.cgi?id=314720 http://bugs.kde.org/show_bug.cgi?id=316084 http://bugs.kde.org/show_bug.cgi?id=319935 http://bugs.kde.org/show_bug.cgi?id=324821 Repository: kde-workspace Description --- The focus is being stolen from the input field when alt is being pressed in order to make it possible to use keyboard to do unlocking. Unfortunately this causes the focus never to be returned to the input field. This fixes at least 314720, but perhaps other similar bugs such as 324821 too. 324821 is also partially related. Diffs - ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml 66a3bb4 Diff: https://git.reviewboard.kde.org/r/113697/diff/ Testing --- Tested on recent git installation. Thanks, Teemu Rytilahti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114910: Patch for bug 317066 (systray leaves garbage on the panel when resizing )
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review63413 --- this would require some testing before pushing to 4.x, too delicate to just commit - Marco Martin On Gen. 8, 2014, 4:25 p.m., Dmitry Ivanov wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/ --- (Updated Gen. 8, 2014, 4:25 p.m.) Review request for kde-workspace and Plasma. Bugs: 317066 http://bugs.kde.org/show_bug.cgi?id=317066 Repository: kde-workspace Description --- It is a proposed fix for bug 317066. The fix is a very simple one-liner setting FullViewportUpdate mode for FdoGraphicsWidget. I'm aware FullViewportUpdate has negative performance impact but I also know it efficiently leaves out any graphical glitches happening due to no repaint of widget when necessary (which is what the bug is about). I have tested my solution for a couple of days: the bug no longer reproduced and I also didn't see any noticeable performance problems. I'm still not sure what I propose is acceptable since it may seem like a hack to more experienced developers, however I just didn't want my patch attempt to get lost and forgotten in the bugzilla. Please have a look and decide whether the patch is good enough to be applied to the next bugfixing release of KDE 4.x series, thank you. Diffs - plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp 1baa23d Diff: https://git.reviewboard.kde.org/r/114910/diff/ Testing --- I rebuilt plasma_applet_systemtray.so with the patch and replaced the package version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can no longer reproduce bug 317066 and I don't see any noticeable performance problems of system tray applet. Thanks, Dmitry Ivanov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 105779: plasma calendar - order events and todos by start date
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105779/#review63414 --- this would need more testing at this point before eventually pushing to 4.x - Marco Martin On Lug. 29, 2012, 1:31 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105779/ --- (Updated Lug. 29, 2012, 1:31 p.m.) Review request for Plasma. Bugs: 291422 http://bugs.kde.org/show_bug.cgi?id=291422 Repository: kde-workspace Description --- QHash::values returns a list of items in arbitrary order. So I'm using a QMap to sort them by start time. Diffs - libs/plasmaclock/calendartable.h 8678593 libs/plasmaclock/calendartable.cpp d2b436e libs/taskmanager/groupmanager.cpp 45c15a9 Diff: https://git.reviewboard.kde.org/r/105779/diff/ Testing --- works for me Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112789: Enable searchlaunch engine on KF5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112789/#review63415 --- this engine was mostly to expose a service to send queries from a text field in a separate containment to the netbook search and launch containment. It wasn'r even used by default, i think the whole thing may be dropped (since this was still in kde-workspace, tecnically already is) - Marco Martin On Set. 18, 2013, 7:34 a.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112789/ --- (Updated Set. 18, 2013, 7:34 a.m.) Review request for Plasma. Repository: kde-workspace Description --- searchlaunch engine KF5 Diffs - plasma/CMakeLists.txt 3a5bea4 plasma/netbook/CMakeLists.txt 1eff685 plasma/netbook/dataengines/searchlaunch/CMakeLists.txt a4ecc66 plasma/netbook/dataengines/searchlaunch/salengine.cpp a8df7c6 Diff: https://git.reviewboard.kde.org/r/112789/diff/ Testing --- Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114260: Port mouse dataengine
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114260/#review63416 --- Ship it! fine to go - Marco Martin On Feb. 21, 2014, 6:54 a.m., Andrea Scarpino wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114260/ --- (Updated Feb. 21, 2014, 6:54 a.m.) Review request for Plasma. Repository: kde-workspace Description --- = subject. I commented the lines about scheduleSourcesUpdated(). What to do with them? Diffs - plasma/generic/dataengines/mouse/mouseengine.cpp 19a7fb7405647963ebadb4f71104e8164b729df7 plasma/generic/dataengines/mouse/mouseengine.h d55565dc3875b794dce14054d9a8b77cef9b2347 plasma/generic/dataengines/mouse/cursornotificationhandler.cpp 3cb9add2ec1d4cb4d5904a381b8ba8f29279e05b plasma/generic/dataengines/CMakeLists.txt 5e9f11bcef806576946257bdeaa40efb445b7daf plasma/generic/dataengines/mouse/CMakeLists.txt 29cab878bd1fb514d7ac025134fbfb58a5a1376e plasma/generic/dataengines/mouse/cursornotificationhandler.h 3b571f8f5ffe6db4efeef7827acf003911bcd5dc Diff: https://git.reviewboard.kde.org/r/114260/diff/ Testing --- Builds Thanks, Andrea Scarpino ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 109124: qml port currentappcontrol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109124/#review63418 --- This should definitely be ported, since i've seen many people use it in the desktop layout as well. It would need still some code/layout fixes For triggering the present windows effect, i would add a service for it inthe tasks dataengine. - Marco Martin On Feb. 25, 2013, 6:20 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109124/ --- (Updated Feb. 25, 2013, 6:20 p.m.) Review request for Plasma. Repository: kde-workspace Description --- Heya folks, This is a qml port of the netbook applet currentappcontrol. It's ready to use, but not fully complete. Missing features/bugs: - If you click on the title on the task bar, it doesn't show the kwin present windows effect, how to implement that? Is there interest in a 'kwin dataengine' or should I go for a mixed C++/QML applet? - there is an annoyance in the task list(present windows fallback): I can set a minimum height, but if I close a task and re-set the minimum height, the popup won't shrink again, leaving an unpleasant empty space; plasma bug? - the close/restore buttons don't glow on hover. I couldn't load a theme svg using the IconItem. Is that possible? - do you know how to read the size of the containment the widget is contained? Diffs - CMakeLists.txt 6084d7dd7655372506e02abe9f141b73155c5857 plasma/netbook/applets/currentappcontrol/CMakeLists.txt 46178ce3a9351845855e9fccfbc13a9d3946fc95 plasma/netbook/applets/currentappcontrol/Messages.sh 45d44681ae1be43b2d71ca48ab3e77af37ad8861 plasma/netbook/applets/currentappcontrol/package/contents/ui/Task.qml PRE-CREATION plasma/netbook/applets/currentappcontrol/package/contents/ui/main.qml PRE-CREATION plasma/netbook/applets/currentappcontrol/package/metadata.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/109124/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Reviews
On Tuesday 29 July 2014, David Edmundson wrote: Sorry for flooding the mailing list. I've spent the morning cleaning out some of Plasma's review requests. One was nearly 4 years old. good stuff. on the list of reviews you posted, i commented on them, separing those that i think could be just pushed against those that would need more testing. Probably the very old requests, since many are done by authors i don't see around since a while, we should push them ourselves if we want them in. -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119404: Use full libexec location
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119404/ --- (Updated July 29, 2014, 11:05 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- resolves the problem of relative vs. absolute LIBEXEC_INSTALL_DIR var usage. Diffs - ksmserver/config-ksmserver.h.cmake a454a4d startkde/startkde.cmake 281bd43 Diff: https://git.reviewboard.kde.org/r/119404/diff/ Testing --- builds Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112789: Enable searchlaunch engine on KF5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112789/ --- (Updated July 29, 2014, 4:54 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: kde-workspace Description --- searchlaunch engine KF5 Diffs - plasma/CMakeLists.txt 3a5bea4 plasma/netbook/CMakeLists.txt 1eff685 plasma/netbook/dataengines/searchlaunch/CMakeLists.txt a4ecc66 plasma/netbook/dataengines/searchlaunch/salengine.cpp a8df7c6 Diff: https://git.reviewboard.kde.org/r/112789/diff/ Testing --- Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118539: I needed this patch in order to succesfully compile a 20140603 git snapshot of plasma-desktop on top of KDE Frameworks 4.100.0
On June 5, 2014, 1:58 a.m., Marco Martin wrote: what is the stuff that still needs kdelibs4support? it shouldn't depend on it anymore Eric Hameleers wrote: Files in the subdirectories of kcms/kfintinst/ contain includes for stuff that I can only find in kdelibs4support. Like #include KGlobal in kcms/kfontinst/lib/FcEngine.cpp to give one example. SInce all it complains about is the includes, perhaps those can be removed without harm... I don't know and I did not try, I am not a developer but a packager. If I don't apply the patch (just tried) the build fails here at first (and if you gradually apply all the parts of the patch the build will fail in other directories) because of a missing include: [ 77%] Automoc for target kfontinst [ 77%] Built target kfontinst_automoc [ 79%] Built target kfontinst [ 79%] Automoc for target kfontinstui [ 79%] Built target kfontinstui_automoc [ 79%] Building CXX object kcms/kfontinst/lib/CMakeFiles/kfontinstui.dir/FcEngine.cpp.o In file included from /mnt/hd/kde-build/plasma/plasma-desktop-20140604git/kcms/kfontinst/lib/FcEngine.h:32:0, from /mnt/hd/kde-build/plasma/plasma-desktop-20140604git/kcms/kfontinst/lib/FcEngine.cpp:24: /mnt/hd/kde-build/plasma/plasma-desktop-20140604git/kcms/kfontinst/lib/KfiConstants.h:28:28: fatal error: KLocalizedString: No such file or directory #include KLocalizedString ^ compilation terminated. make[2]: *** [kcms/kfontinst/lib/CMakeFiles/kfontinstui.dir/FcEngine.cpp.o] Error 1 make[1]: *** [kcms/kfontinst/lib/CMakeFiles/kfontinstui.dir/all] Error 2 make: *** [all] Error 2 plasma:plasma-desktop failed to build. Ping, whats status on this? can this be required? - Bhushan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118539/#review59240 --- On June 5, 2014, 1:12 a.m., Eric Hameleers wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118539/ --- (Updated June 5, 2014, 1:12 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- I needed this patch in order to succesfully compile a 20140603 git snapshot of plasma-desktop on top of KDE Frameworks 4.100.0 Diffs - kcms/kfontinst/apps/CMakeLists.txt d166d8a kcms/kfontinst/dbus/CMakeLists.txt 5e203eb kcms/kfontinst/kcmfontinst/CMakeLists.txt fe3d2cf kcms/kfontinst/kio/CMakeLists.txt 90c6e4d kcms/kfontinst/lib/CMakeLists.txt 799707d kcms/kfontinst/thumbnail/CMakeLists.txt e19385c kcms/kfontinst/viewpart/CMakeLists.txt f79d7a6 Diff: https://git.reviewboard.kde.org/r/118539/diff/ Testing --- On Slackware-current x86_64 Thanks, Eric Hameleers ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Reviews
Hello, On Tue, Jul 29, 2014 at 3:37 PM, David Edmundson da...@davidedmundson.co.uk wrote: There are a /lot/ of Plasma Media Centre reviews open (about half are PMC), I'm not sure what the state of those is, are they awaiting reviews from the non-media centre devs, or just no longer relevant. If someone from PMC pings me I can help go through and discard outdated things. Following PMC reviews needs to be discarded, https://git.reviewboard.kde.org/r/116460/ (Fixed already) https://git.reviewboard.kde.org/r/116804/ (Ditto) https://git.reviewboard.kde.org/r/116731 (I think, it was discarded long ago, I don't know how it came back? bug was also closed) I'll let you know as I will go through other reviews. Looks like there is no way to filter search by repo name or am I missing something.? Lets see.. -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117139: Make menu strings conform to KDE's usability guidelines. Capitalize menu words.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117139/#review63426 --- Ping, what is status on this? - Bhushan Shah On March 28, 2014, 10:42 p.m., Nikolaos Chatzidakis wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117139/ --- (Updated March 28, 2014, 10:42 p.m.) Review request for Plasma and Shantanu Tushar. Repository: plasma-mediacenter Description --- This patch is created to provide uniform string format to pmc according to our Visual Design Group's guidelines ( http://techbase.kde.org/Projects/Usability/HIG/Capitalization ). All menu strings are converted so words start with capital letter. Diffs - browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.desktop 93b7c62 browsingbackends/localfiles/localvideos/localvideos.desktop 4f22968 browsingbackends/localfiles/localpictures/localpictures.desktop 4ffe275 browsingbackends/localfiles/localmusic/localmusic.desktop ab47666 browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop 9d04068 browsingbackends/onlineservices/youtube/youtubebackend.desktop 4b3ba9c browsingbackends/utility/fullscreen/pmcfullscreen.desktop c992932 browsingbackends/metadatabackends/metadatapicturebackend/metadatapicturebackend.desktop a06a168 Diff: https://git.reviewboard.kde.org/r/117139/diff/ Testing --- Thanks, Nikolaos Chatzidakis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Reviews
This one needs to be discarded as well, https://git.reviewboard.kde.org/r/115865/ On Tue, Jul 29, 2014 at 5:15 PM, Bhushan Shah bhus...@gmail.com wrote: Hello, On Tue, Jul 29, 2014 at 3:37 PM, David Edmundson da...@davidedmundson.co.uk wrote: There are a /lot/ of Plasma Media Centre reviews open (about half are PMC), I'm not sure what the state of those is, are they awaiting reviews from the non-media centre devs, or just no longer relevant. If someone from PMC pings me I can help go through and discard outdated things. Following PMC reviews needs to be discarded, https://git.reviewboard.kde.org/r/116460/ (Fixed already) https://git.reviewboard.kde.org/r/116804/ (Ditto) https://git.reviewboard.kde.org/r/116731 (I think, it was discarded long ago, I don't know how it came back? bug was also closed) I'll let you know as I will go through other reviews. Looks like there is no way to filter search by repo name or am I missing something.? Lets see.. -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118866: Start playing after Play All is used
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118866/#review63427 --- ping? - Bhushan Shah On June 21, 2014, 11:13 p.m., Shantanu Tushar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118866/ --- (Updated June 21, 2014, 11:13 p.m.) Review request for Plasma. Repository: plasma-mediacenter Description --- We should ask the model to start playing once we add all the songs to the playlist as a result of the user using Play All. Diffs - browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.cpp 68eecf3 libs/mediacenter/multipleplaylistmodel.h 1c7731b libs/mediacenter/multipleplaylistmodel.cpp 4b475c7 libs/mediacenter/playlistmodel.h 50157ff libs/mediacenter/playlistmodel.cpp 44abbc1 Diff: https://git.reviewboard.kde.org/r/118866/diff/ Testing --- Thanks, Shantanu Tushar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116460: Footer clock fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116460/ --- (Updated July 29, 2014, 12:10 p.m.) Status -- This change has been discarded. Review request for Plasma, R.Harish Navnit, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- The footer clock in PMC is set to 12Hr format and it was showing 0:00 AM instead of 12:00 AM Diffs - mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 Diff: https://git.reviewboard.kde.org/r/116460/diff/ Testing --- I've tested the diff and its working correctly Thanks, Maulik Kotadia ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116804: Bug Fix for the Footer time
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116804/ --- (Updated July 29, 2014, 12:10 p.m.) Status -- This change has been discarded. Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 330115 http://bugs.kde.org/show_bug.cgi?id=330115 Repository: plasma-mediacenter Description --- Used the Qt::formatTime method to get the time in correct format... Hope it works.. Diffs - mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 Diff: https://git.reviewboard.kde.org/r/116804/diff/ Testing --- Thanks, Atul Dubey ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116731: Bug Fix for Music Stats Labels (Bug 331882)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116731/ --- (Updated July 29, 2014, 12:10 p.m.) Status -- This change has been discarded. Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 331882 http://bugs.kde.org/show_bug.cgi?id=331882 Repository: plasma-mediacenter Description --- Created the labels for the details like artist, album, year etc... We can Browse any music file and we get all the details with orange-colored labels... Diffs - mediaelements/mediaplayer/MusicStats.qml 178a37d Diff: https://git.reviewboard.kde.org/r/116731/diff/ Testing --- Thanks, Atul Dubey ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115865: Adds new components for different sized labels
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115865/ --- (Updated July 29, 2014, 12:11 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-mediacenter Description --- Introduced a new set of components called BigLabel, MediumLabel and SmallLabel which can be used to keep consistency in font sizes throughout the UI. Diffs - components/CMakeLists.txt b085207 components/labels/BigLabel.qml PRE-CREATION components/labels/MediumLabel.qml PRE-CREATION components/labels/SmallLabel.qml PRE-CREATION components/qmldir 3159132 mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 mediaelements/mediawelcome/HomeScreenText.qml 35cd20a mediaelements/playlist/MultiplePlaylists.qml d94fe6e Diff: https://git.reviewboard.kde.org/r/115865/diff/ Testing --- Works as expected. File Attachments The playlist name uses MediumLabel https://git.reviewboard.kde.org/media/uploaded/files/2014/02/18/66cf8d70-0b7a-4a88-8a8e-d913a313a06c__snapshot1.png Thanks, Abhishek Shivanna ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 119534: take defaults from a plasma look and feel package, if available
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/ --- Review request for KDE Frameworks and Plasma. Repository: frameworkintegration Description --- there will be support for some kind of mega theme that besides providing files for splashscreen, lockscreen etc, will define what defaults to use among icons, colors, fonts etc. This is a first start of it for reading the defaults. The theme file is stored in a plasma package, but the patch resolves the correct path by hand, not requiring linking to libplasma. right now only a couple of settings is used, mostly to see if the direction is good. Diffs - src/platformtheme/khintssettings.h 57f1864 src/platformtheme/khintssettings.cpp 104f77c Diff: https://git.reviewboard.kde.org/r/119534/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118866: Start playing after Play All is used
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118866/ --- (Updated July 29, 2014, 12:35 p.m.) Review request for Plasma. Changes --- Consistent behavior for Local Browsing backends as well Repository: plasma-mediacenter Description --- We should ask the model to start playing once we add all the songs to the playlist as a result of the user using Play All. Diffs (updated) - libs/mediacenter/multipleplaylistmodel.h 1c7731b libs/mediacenter/multipleplaylistmodel.cpp 950675e libs/mediacenter/playlistmodel.h 50157ff libs/mediacenter/playlistmodel.cpp 44abbc1 browsingbackends/localfiles/localfilesabstractbackend.cpp bbd511b browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.cpp 8b8e149 Diff: https://git.reviewboard.kde.org/r/118866/diff/ Testing --- Thanks, Shantanu Tushar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114428/#review63431
---
Ping, whats status on this? can this be submitted?
- Bhushan Shah
On Dec. 13, 2013, 8:35 p.m., Heena Mahour wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114428/
---
(Updated Dec. 13, 2013, 8:35 p.m.)
Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith
Haridasan.
Repository: plasma-mediacenter
Description
---
Replaced Text {} by PlasmaComponents.Label {}
Diffs
-
mediaelements/mediawelcome/BackendsListDelegate.qml e76af63
mediaelements/mediawelcome/HomeScreenText.qml 35cd20a
Diff: https://git.reviewboard.kde.org/r/114428/diff/
Testing
---
works fine .
Thanks,
Heena Mahour
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116898: Get rid of unnecessary Q_INVOKABLE declarations
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116898/#review63432 --- Ping, I think this can be closed. - Bhushan Shah On March 19, 2014, 6:19 p.m., Shantanu Tushar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116898/ --- (Updated March 19, 2014, 6:19 p.m.) Review request for Plasma and Sujith Haridasan. Repository: plasma-mediacenter Description --- Methods supposed to be used as READ of Q_PROPERTY properties need not be invokable. Same goes for slots. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mpris2.h 0df64f4 libs/mpris2/mpris2.cpp a8ad3ef shells/newshell/main.cpp bab6915 shells/newshell/mainwindow.cpp d2d71d4 Diff: https://git.reviewboard.kde.org/r/116898/diff/ Testing --- Thanks, Shantanu Tushar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Reviews
On Tue, Jul 29, 2014 at 5:15 PM, Bhushan Shah bhus...@gmail.com wrote: Following PMC reviews needs to be discarded, Some more, https://git.reviewboard.kde.org/r/114055/ - code is already in repo Non PMC, https://git.reviewboard.kde.org/r/117681/ - no review so far https://git.reviewboard.kde.org/r/119175/ - already submitted(!) -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114055: Include translatoins sub-directory to CMakeLists.txt , Fedora Packaging fails searching for translations
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114055/ --- (Updated July 29, 2014, 12:53 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-mediacenter Description --- Include translatoins sub-directory to CMakeLists.txt Diffs - CMakeLists.txt 25b607b Diff: https://git.reviewboard.kde.org/r/114055/diff/ Testing --- While packaging for fedora, it was not getting lang translations, post applying this patch everything worked fine. Thanks, Siddharth Sharma ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119175: Create internal copy of kxmlrpcclient to get drkonqi to report bugs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119175/ --- (Updated July 29, 2014, 12:54 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- Added a internal copy of kxmlrpcclient to plasma-workspace so that the bug reporting button can be used. Diffs - drkonqi/CMakeLists.txt 8224900 drkonqi/config-drkonqi.h.cmake 35b8330 drkonqi/internalkxmlrpcclient/src/query.cpp PRE-CREATION drkonqi/internalkxmlrpcclient/src/client.h PRE-CREATION drkonqi/internalkxmlrpcclient/autotests/testquery.cpp PRE-CREATION drkonqi/internalkxmlrpcclient/autotests/CMakeLists.txt PRE-CREATION drkonqi/internalkxmlrpcclient/src/query.h PRE-CREATION drkonqi/internalkxmlrpcclient/src/client.cpp PRE-CREATION drkonqi/internalkxmlrpcclient/src/Messages.sh PRE-CREATION drkonqi/internalkxmlrpcclient/src/CMakeLists.txt PRE-CREATION drkonqi/internalkxmlrpcclient/autotests/testquery.h PRE-CREATION drkonqi/internalkxmlrpcclient/autotests/testclient.cpp PRE-CREATION drkonqi/internalkxmlrpcclient/autotests/testclient.h PRE-CREATION drkonqi/internalkxmlrpcclient/README PRE-CREATION drkonqi/internalkxmlrpcclient/CMakeLists.txt PRE-CREATION drkonqi/internalkxmlrpcclient/COPYING.BSD PRE-CREATION drkonqi/internalkxmlrpcclient/KF5XmlRpcClientPrivateConfig.cmake.in PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119175/diff/ Testing --- Launched konsole killall -SEGV konsole Drkonqi comes up Report bug button is enabled Thanks, Rohan Garg ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111849: custom first week for plasmaclock.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111849/ --- (Updated July 29, 2014, 12:57 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: kde-workspace Description --- In normal case, the first week is the first week in the year, but the teachers may want to custom the first week, for example, make the 8th week as the first week, then the 9th week will be the second week, and so on. Then the teacher can easily do their work as a custom teaching period! Diffs - Diff: https://git.reviewboard.kde.org/r/111849/diff/ Testing --- cd kde-workspace-4.10.5/libs/plasmaclock patch -p1 customfirstweek.patch The save configuration codes are not very beautiful, but it works fine! File Attachments patch https://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch another patch, use custom config file. https://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/customweek.patch screenshot https://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/customweek.png Thanks, Hu Zheng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116898: Get rid of unnecessary Q_INVOKABLE declarations
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116898/ --- (Updated July 29, 2014, 1:19 p.m.) Status -- This change has been discarded. Review request for Plasma and Sujith Haridasan. Repository: plasma-mediacenter Description --- Methods supposed to be used as READ of Q_PROPERTY properties need not be invokable. Same goes for slots. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mpris2.h 0df64f4 libs/mpris2/mpris2.cpp a8ad3ef shells/newshell/main.cpp bab6915 shells/newshell/mainwindow.cpp d2d71d4 Diff: https://git.reviewboard.kde.org/r/116898/diff/ Testing --- Thanks, Shantanu Tushar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 119535: Move QML bindings for KUser to kdeclarative
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/ --- Review request for Plasma. Repository: kdeclarative Description --- Move QML bindings for KUser to kdeclarative This code has already been released, but privately inside Kickoff. As it is not strictly related (or limited to) Kickoff, I'd like to move it into kdeclarative. There are already other bindings for classes from KCoreAddons there, so this seems like a nice fit. The class is useful as public API since it allows customization of apps, making the user feel more familiar with the program at hand. I want to use the name and face icon of the user in more places (systemsettings redesign comes to mind), so it'd be useful to have it shared. Diffs - src/qmlcontrols/kcoreaddons/CMakeLists.txt 597cc2c src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 3c1a96e src/qmlcontrols/kcoreaddons/kuserproxy.h PRE-CREATION src/qmlcontrols/kcoreaddons/kuserproxy.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119535/diff/ Testing --- Ported an (unreleased) app using this class to the new location, works as expected, no regressions encountered. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119534: take defaults from a plasma look and feel package, if available
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/ --- (Updated July 29, 2014, 1:25 p.m.) Review request for KDE Frameworks and Plasma. Changes --- try to take the colorscheme name from the package Repository: frameworkintegration Description --- there will be support for some kind of mega theme that besides providing files for splashscreen, lockscreen etc, will define what defaults to use among icons, colors, fonts etc. This is a first start of it for reading the defaults. The theme file is stored in a plasma package, but the patch resolves the correct path by hand, not requiring linking to libplasma. right now only a couple of settings is used, mostly to see if the direction is good. Diffs (updated) - src/platformtheme/khintssettings.h 57f1864 src/platformtheme/khintssettings.cpp 104f77c Diff: https://git.reviewboard.kde.org/r/119534/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Reviews
Some more, https://git.reviewboard.kde.org/r/118540/ - Already in codebase https://git.reviewboard.kde.org/r/105319/ - No activity so far https://git.reviewboard.kde.org/r/105932/ - No activity and can't be applied on top of plasma 5 https://git.reviewboard.kde.org/r/106123/ - No activity and 4.8 series patch https://git.reviewboard.kde.org/r/105112/ - looks like attached bug is fixed already https://git.reviewboard.kde.org/r/115192/ - ping https://git.reviewboard.kde.org/r/117041/ - no review and no activity On Tue, Jul 29, 2014 at 6:21 PM, Bhushan Shah bhus...@gmail.com wrote: On Tue, Jul 29, 2014 at 5:15 PM, Bhushan Shah bhus...@gmail.com wrote: Following PMC reviews needs to be discarded, Some more, https://git.reviewboard.kde.org/r/114055/ - code is already in repo Non PMC, https://git.reviewboard.kde.org/r/117681/ - no review so far https://git.reviewboard.kde.org/r/119175/ - already submitted(!) -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118540: Two patches required to build kde-cli-tools 20140603 snapshot on top of KDE Frameworks 4.100.0
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118540/ --- (Updated July 29, 2014, 1:29 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: kde-cli-tools Description --- Two patches were required to build a kde-cli-tools 20140603 snapshot successfully on top of KDE Frameworks 4.100.0 Diffs - kdesu/kdesu.cpp d5c7f72 kioclient/kioclient.cpp 71b11fb kreadconfig/kreadconfig.cpp 532d077 kreadconfig/kwriteconfig.cpp e5597d3 Diff: https://git.reviewboard.kde.org/r/118540/diff/ Testing --- Slackware-current x86_64 File Attachments kde-cli-tools_ecm.patch https://git.reviewboard.kde.org/media/uploaded/files/2014/06/04/3e33b7c2-9ac5-4bdc-8626-cc9ba9fda401__kde-cli-tools_ecm.patch Thanks, Eric Hameleers ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119524: Force OpenGLES if on Qt 5.4
On July 28, 2014, 6:25 p.m., Eike Hein wrote: Can you recompile plasma-desktop with OpenGL ES and test if the drag pixmap for Folder icons works? I wrote the code in a way that ought to work on both desktop GL and ES, but it's worth testing. Aleix Pol Gonzalez wrote: I have it running with OpenGLES at the moment, it seems to work fine the Folder View. If there's anything specific you want me to try, don't hesitate to tell me (here or in IRC, etc.). Nothing at the moment, thanks for testing! - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/#review63362 --- On July 28, 2014, 6:09 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/ --- (Updated July 28, 2014, 6:09 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- When trying to reduce memory usage in plasma shell, we realized that one of the reasons we got such big memory footprint was actually the intel driver (on intel systems, that is). After some investigation, David found out we were going through some memory-consuming path [1]. A way to workaround it is by using only OpenGLES. Everything still works here after this patch, so it seems to be a good change to get in. This change needs Qt 5.4, to get the new API that lets us enforce a QSurfaceFormat, hence having it ifdef'd. I'm quite unaware of problems we might find. Knowing we probably want to work in different embedded devices, suggests that OpenGLES on all platforms sounds like a safe bet. [1] http://comments.gmane.org/gmane.comp.video.mesa3d.devel/60848 Diffs - shell/main.cpp e34578d Diff: https://git.reviewboard.kde.org/r/119524/diff/ Testing --- I'm using it now, without visible problems. Now we see no trace of i915 in the massif reports. File Attachments before https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/5a6beb4f-24c0-4cee-a7a2-038385e35119__plasma-massif-opengl.png after https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/fc301ff5-cb1d-4654-a57f-82990220c8e3__plasma-massif-opengles.png Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 100743: Add a system tray option to always show all items
Either way this patch no longer applies. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119524: Force OpenGLES if on Qt 5.4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/#review63437 --- Ship it! I'm all for this, as it means we reduce the set of features we use from the underlying stack. We're even focusing on the features that will get more testing (since it's mobile, and that's the hype). I consider it an advantage if we can use a more restricted API, and communicate that we don't care about random OpenGL extensions, instead asking make sure the OpenGL-ES implementation is sound and works for us. It would be useful to hear from Martin if there's any technical problem with this strategy. We should also align this kind of decisions with KWin. (Perhaps the same is a serious option for KWin?) From my personal experience, I've tested the OpenGL-ES options we had for some time, and never ran into a regression caused by moving from OpenGL to OpenGL-ES. - Sebastian Kügler On July 28, 2014, 6:09 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/ --- (Updated July 28, 2014, 6:09 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- When trying to reduce memory usage in plasma shell, we realized that one of the reasons we got such big memory footprint was actually the intel driver (on intel systems, that is). After some investigation, David found out we were going through some memory-consuming path [1]. A way to workaround it is by using only OpenGLES. Everything still works here after this patch, so it seems to be a good change to get in. This change needs Qt 5.4, to get the new API that lets us enforce a QSurfaceFormat, hence having it ifdef'd. I'm quite unaware of problems we might find. Knowing we probably want to work in different embedded devices, suggests that OpenGLES on all platforms sounds like a safe bet. [1] http://comments.gmane.org/gmane.comp.video.mesa3d.devel/60848 Diffs - shell/main.cpp e34578d Diff: https://git.reviewboard.kde.org/r/119524/diff/ Testing --- I'm using it now, without visible problems. Now we see no trace of i915 in the massif reports. File Attachments before https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/5a6beb4f-24c0-4cee-a7a2-038385e35119__plasma-massif-opengl.png after https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/fc301ff5-cb1d-4654-a57f-82990220c8e3__plasma-massif-opengles.png Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119524: Force OpenGLES if on Qt 5.4
On July 29, 2014, 2:01 p.m., Sebastian Kügler wrote: I'm all for this, as it means we reduce the set of features we use from the underlying stack. We're even focusing on the features that will get more testing (since it's mobile, and that's the hype). I consider it an advantage if we can use a more restricted API, and communicate that we don't care about random OpenGL extensions, instead asking make sure the OpenGL-ES implementation is sound and works for us. It would be useful to hear from Martin if there's any technical problem with this strategy. We should also align this kind of decisions with KWin. (Perhaps the same is a serious option for KWin?) From my personal experience, I've tested the OpenGL-ES options we had for some time, and never ran into a regression caused by moving from OpenGL to OpenGL-ES. Martin G shares his thoughts here: https://bugreports.qt-project.org/browse/QTBUG-40341 I'm not sure I understand all of it though :) - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/#review63437 --- On July 28, 2014, 6:09 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/ --- (Updated July 28, 2014, 6:09 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- When trying to reduce memory usage in plasma shell, we realized that one of the reasons we got such big memory footprint was actually the intel driver (on intel systems, that is). After some investigation, David found out we were going through some memory-consuming path [1]. A way to workaround it is by using only OpenGLES. Everything still works here after this patch, so it seems to be a good change to get in. This change needs Qt 5.4, to get the new API that lets us enforce a QSurfaceFormat, hence having it ifdef'd. I'm quite unaware of problems we might find. Knowing we probably want to work in different embedded devices, suggests that OpenGLES on all platforms sounds like a safe bet. [1] http://comments.gmane.org/gmane.comp.video.mesa3d.devel/60848 Diffs - shell/main.cpp e34578d Diff: https://git.reviewboard.kde.org/r/119524/diff/ Testing --- I'm using it now, without visible problems. Now we see no trace of i915 in the massif reports. File Attachments before https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/5a6beb4f-24c0-4cee-a7a2-038385e35119__plasma-massif-opengl.png after https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/fc301ff5-cb1d-4654-a57f-82990220c8e3__plasma-massif-opengles.png Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119524: Force OpenGLES if on Qt 5.4
On July 29, 2014, 2:01 p.m., Sebastian Kügler wrote: I'm all for this, as it means we reduce the set of features we use from the underlying stack. We're even focusing on the features that will get more testing (since it's mobile, and that's the hype). I consider it an advantage if we can use a more restricted API, and communicate that we don't care about random OpenGL extensions, instead asking make sure the OpenGL-ES implementation is sound and works for us. It would be useful to hear from Martin if there's any technical problem with this strategy. We should also align this kind of decisions with KWin. (Perhaps the same is a serious option for KWin?) From my personal experience, I've tested the OpenGL-ES options we had for some time, and never ran into a regression caused by moving from OpenGL to OpenGL-ES. David Edmundson wrote: Martin G shares his thoughts here: https://bugreports.qt-project.org/browse/QTBUG-40341 I'm not sure I understand all of it though :) Well, he doesn't answer the question of this RR. :) IMO, we can do two things: - merge, cross fingers, watch out for regressions, when Martin gets to it, ask him if it's a sensible thing - wait for Martin, then decide to merge or not I'm cool with with either strategy. (Would be quite interesting though to see what happens when we switch. :)) - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/#review63437 --- On July 28, 2014, 6:09 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/ --- (Updated July 28, 2014, 6:09 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- When trying to reduce memory usage in plasma shell, we realized that one of the reasons we got such big memory footprint was actually the intel driver (on intel systems, that is). After some investigation, David found out we were going through some memory-consuming path [1]. A way to workaround it is by using only OpenGLES. Everything still works here after this patch, so it seems to be a good change to get in. This change needs Qt 5.4, to get the new API that lets us enforce a QSurfaceFormat, hence having it ifdef'd. I'm quite unaware of problems we might find. Knowing we probably want to work in different embedded devices, suggests that OpenGLES on all platforms sounds like a safe bet. [1] http://comments.gmane.org/gmane.comp.video.mesa3d.devel/60848 Diffs - shell/main.cpp e34578d Diff: https://git.reviewboard.kde.org/r/119524/diff/ Testing --- I'm using it now, without visible problems. Now we see no trace of i915 in the massif reports. File Attachments before https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/5a6beb4f-24c0-4cee-a7a2-038385e35119__plasma-massif-opengl.png after https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/fc301ff5-cb1d-4654-a57f-82990220c8e3__plasma-massif-opengles.png Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119524: Force OpenGLES if on Qt 5.4
On July 29, 2014, 2:01 p.m., Sebastian Kügler wrote: I'm all for this, as it means we reduce the set of features we use from the underlying stack. We're even focusing on the features that will get more testing (since it's mobile, and that's the hype). I consider it an advantage if we can use a more restricted API, and communicate that we don't care about random OpenGL extensions, instead asking make sure the OpenGL-ES implementation is sound and works for us. It would be useful to hear from Martin if there's any technical problem with this strategy. We should also align this kind of decisions with KWin. (Perhaps the same is a serious option for KWin?) From my personal experience, I've tested the OpenGL-ES options we had for some time, and never ran into a regression caused by moving from OpenGL to OpenGL-ES. David Edmundson wrote: Martin G shares his thoughts here: https://bugreports.qt-project.org/browse/QTBUG-40341 I'm not sure I understand all of it though :) Sebastian Kügler wrote: Well, he doesn't answer the question of this RR. :) IMO, we can do two things: - merge, cross fingers, watch out for regressions, when Martin gets to it, ask him if it's a sensible thing - wait for Martin, then decide to merge or not I'm cool with with either strategy. (Would be quite interesting though to see what happens when we switch. :)) Well, Qt 5.4 won't be in for a while, so it only makes sense for wild adventurers like myself. I would suggest to just merge it, given that people need to already opt in to building the dev branch in Qt, so they're probably already looking for some rock and roll. Furthermore, it's quite a slow rock ballad. It's not an awesome switch, it feels a bit like when you turn 18 that you magically become an adult but everything is still the same. Besides the notable difference in massif, that I attached. Regarding Graesslin's response, it's a bit like what Marco said, we should try it on different platforms. If we merge this patch, people will test it eventually. If we don't, they probably won't. Personally I don't have any Radeon or Nvidia systems. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/#review63437 --- On July 28, 2014, 6:09 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/ --- (Updated July 28, 2014, 6:09 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- When trying to reduce memory usage in plasma shell, we realized that one of the reasons we got such big memory footprint was actually the intel driver (on intel systems, that is). After some investigation, David found out we were going through some memory-consuming path [1]. A way to workaround it is by using only OpenGLES. Everything still works here after this patch, so it seems to be a good change to get in. This change needs Qt 5.4, to get the new API that lets us enforce a QSurfaceFormat, hence having it ifdef'd. I'm quite unaware of problems we might find. Knowing we probably want to work in different embedded devices, suggests that OpenGLES on all platforms sounds like a safe bet. [1] http://comments.gmane.org/gmane.comp.video.mesa3d.devel/60848 Diffs - shell/main.cpp e34578d Diff: https://git.reviewboard.kde.org/r/119524/diff/ Testing --- I'm using it now, without visible problems. Now we see no trace of i915 in the massif reports. File Attachments before https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/5a6beb4f-24c0-4cee-a7a2-038385e35119__plasma-massif-opengl.png after https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/fc301ff5-cb1d-4654-a57f-82990220c8e3__plasma-massif-opengles.png Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118180: slideshow BUG patch fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 2:15 p.m.) Review request for kde-workspace and Plasma. Bugs: 327580 http://bugs.kde.org/show_bug.cgi?id=327580 Repository: kde-workspace Description --- bug patch for slideshow dir list missing Diffs - libs/plasmagenericshell/backgrounddialog.cpp 645de3f Diff: https://git.reviewboard.kde.org/r/118180/diff/ Testing (updated) --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119535: Move QML bindings for KUser to kdeclarative
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/ --- (Updated July 29, 2014, 2:31 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- Move QML bindings for KUser to kdeclarative This code has already been released, but privately inside Kickoff. As it is not strictly related (or limited to) Kickoff, I'd like to move it into kdeclarative. There are already other bindings for classes from KCoreAddons there, so this seems like a nice fit. The class is useful as public API since it allows customization of apps, making the user feel more familiar with the program at hand. I want to use the name and face icon of the user in more places (systemsettings redesign comes to mind), so it'd be useful to have it shared. Diffs - src/qmlcontrols/kcoreaddons/CMakeLists.txt 597cc2c src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 3c1a96e src/qmlcontrols/kcoreaddons/kuserproxy.h PRE-CREATION src/qmlcontrols/kcoreaddons/kuserproxy.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119535/diff/ Testing --- Ported an (unreleased) app using this class to the new location, works as expected, no regressions encountered. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119535: Move QML bindings for KUser to kdeclarative
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63441 --- Can we consider including this in KCoreAddons? I know KCoreAddons should only depend on QtCore, but then we can make it an optional dependency. If Qt5::Qml is there, then build the Qml plugin too. - Aleix Pol Gonzalez On July 29, 2014, 2:31 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/ --- (Updated July 29, 2014, 2:31 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- Move QML bindings for KUser to kdeclarative This code has already been released, but privately inside Kickoff. As it is not strictly related (or limited to) Kickoff, I'd like to move it into kdeclarative. There are already other bindings for classes from KCoreAddons there, so this seems like a nice fit. The class is useful as public API since it allows customization of apps, making the user feel more familiar with the program at hand. I want to use the name and face icon of the user in more places (systemsettings redesign comes to mind), so it'd be useful to have it shared. Diffs - src/qmlcontrols/kcoreaddons/CMakeLists.txt 597cc2c src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 3c1a96e src/qmlcontrols/kcoreaddons/kuserproxy.h PRE-CREATION src/qmlcontrols/kcoreaddons/kuserproxy.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119535/diff/ Testing --- Ported an (unreleased) app using this class to the new location, works as expected, no regressions encountered. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119535: Move QML bindings for KUser to kdeclarative
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63443 --- Looks damn good, especially the documentation and example. Minor nitpicks below. src/qmlcontrols/kcoreaddons/kuserproxy.h https://git.reviewboard.kde.org/r/119535/#comment44218 needs to be LGPL for frameworks. src/qmlcontrols/kcoreaddons/kuserproxy.cpp https://git.reviewboard.kde.org/r/119535/#comment44219 indentation (could be just reviewboard) src/qmlcontrols/kcoreaddons/kuserproxy.cpp https://git.reviewboard.kde.org/r/119535/#comment44222 so maybe this should be faceIconUrl? src/qmlcontrols/kcoreaddons/kuserproxy.cpp https://git.reviewboard.kde.org/r/119535/#comment44220 Not really needed, .close() is called in the QFile destructor and if you want to call it explicitly, you should do it on line 114 too. src/qmlcontrols/kcoreaddons/kuserproxy.cpp https://git.reviewboard.kde.org/r/119535/#comment44221 There's a Qt method for this. http://qt-project.org/doc/qt-5/qhostinfo.html#localHostName requires QtNetwork, but I imagine we're pulling that in anyway. - David Edmundson On July 29, 2014, 2:31 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/ --- (Updated July 29, 2014, 2:31 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- Move QML bindings for KUser to kdeclarative This code has already been released, but privately inside Kickoff. As it is not strictly related (or limited to) Kickoff, I'd like to move it into kdeclarative. There are already other bindings for classes from KCoreAddons there, so this seems like a nice fit. The class is useful as public API since it allows customization of apps, making the user feel more familiar with the program at hand. I want to use the name and face icon of the user in more places (systemsettings redesign comes to mind), so it'd be useful to have it shared. Diffs - src/qmlcontrols/kcoreaddons/CMakeLists.txt 597cc2c src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 3c1a96e src/qmlcontrols/kcoreaddons/kuserproxy.h PRE-CREATION src/qmlcontrols/kcoreaddons/kuserproxy.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119535/diff/ Testing --- Ported an (unreleased) app using this class to the new location, works as expected, no regressions encountered. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118180: slideshow BUG patch fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 3:19 p.m.) Status -- This change has been discarded. Review request for kde-workspace and Plasma. Bugs: 327580 http://bugs.kde.org/show_bug.cgi?id=327580 Repository: kde-workspace Description --- bug patch for slideshow dir list missing Diffs - libs/plasmagenericshell/backgrounddialog.cpp 645de3f Diff: https://git.reviewboard.kde.org/r/118180/diff/ Testing --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118180: slideshow BUG patch fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated July 29, 2014, 3:24 p.m.) Review request for kde-workspace and Plasma. Bugs: 327580 http://bugs.kde.org/show_bug.cgi?id=327580 Repository: kde-workspace Description --- bug patch for slideshow dir list missing Diffs (updated) - libs/plasmagenericshell/backgrounddialog.cpp 645de3f Diff: https://git.reviewboard.kde.org/r/118180/diff/ Testing --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118180: slideshow BUG patch fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review63445 --- weird issue when using reviewboard with the chrome. that why the diff are always error. I have upload successfully with the newest fixed patch - TOM Harrison On July 29, 2014, 3:24 p.m., TOM Harrison wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated July 29, 2014, 3:24 p.m.) Review request for kde-workspace and Plasma. Bugs: 327580 http://bugs.kde.org/show_bug.cgi?id=327580 Repository: kde-workspace Description --- bug patch for slideshow dir list missing Diffs - libs/plasmagenericshell/backgrounddialog.cpp 645de3f Diff: https://git.reviewboard.kde.org/r/118180/diff/ Testing --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119524: Force OpenGLES if on Qt 5.4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/ --- (Updated July 29, 2014, 4:15 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- When trying to reduce memory usage in plasma shell, we realized that one of the reasons we got such big memory footprint was actually the intel driver (on intel systems, that is). After some investigation, David found out we were going through some memory-consuming path [1]. A way to workaround it is by using only OpenGLES. Everything still works here after this patch, so it seems to be a good change to get in. This change needs Qt 5.4, to get the new API that lets us enforce a QSurfaceFormat, hence having it ifdef'd. I'm quite unaware of problems we might find. Knowing we probably want to work in different embedded devices, suggests that OpenGLES on all platforms sounds like a safe bet. [1] http://comments.gmane.org/gmane.comp.video.mesa3d.devel/60848 Diffs - shell/main.cpp e34578d Diff: https://git.reviewboard.kde.org/r/119524/diff/ Testing --- I'm using it now, without visible problems. Now we see no trace of i915 in the massif reports. File Attachments before https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/5a6beb4f-24c0-4cee-a7a2-038385e35119__plasma-massif-opengl.png after https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/fc301ff5-cb1d-4654-a57f-82990220c8e3__plasma-massif-opengles.png Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-workspace_master_qt5 #678
See http://build.kde.org/job/plasma-workspace_master_qt5/678/changes Changes: [aleixpol] Force OpenGLES when running on Qt 5.4 -- [...truncated 1265 lines...] Generating moc_fakebacktracegenerator.cpp [ 22%] Built target backtraceparsertest_automoc [ 22%] Scanning dependencies of target kworkspace Generating plasmashelladaptor.cpp, plasmashelladaptor.h Generating debuggerlaunchers.moc http://build.kde.org/job/plasma-workspace_master_qt5/ws/drkonqi/debuggerlaunchers.cpp:0: Note: No relevant classes found. No output generated. [ 23%] [ 23%] Building CXX object libkworkspace/CMakeFiles/kworkspace.dir/kdisplaymanager.cpp.o Generating plasmashelladaptor.moc [ 23%] Generating moc_component.cpp Generating moc_globalshortcutsregistry.cpp Generating kglobalaccel_x11.moc http://build.kde.org/job/plasma-workspace_master_qt5/ws/kglobalaccel/kglobalaccel_x11.cpp:0: Note: No relevant classes found. No output generated. Generating krunner_interface.moc Generating debuggermanager.moc http://build.kde.org/job/plasma-workspace_master_qt5/ws/drkonqi/debuggermanager.cpp:0: Note: No relevant classes found. No output generated. Generating detachedprocessmonitor.moc http://build.kde.org/job/plasma-workspace_master_qt5/ws/drkonqi/detachedprocessmonitor.cpp:0: Note: No relevant classes found. No output generated. Scanning dependencies of target kded_appmenu [ 23%] Scanning dependencies of target plasmawidgetexplorerplugin Generating moc_jobview.cpp Generating moc_progresslistdelegate.cpp Generating moc_progresslistmodel.cpp Generating moc_requestviewcallwatcher.cpp Generating moc_uiserver.cpp Generating moc_uiserver_p.cpp Building CXX object appmenu/CMakeFiles/kded_appmenu.dir/appmenu.cpp.o [ 23%] Built target kdeinit_kuiserver5_automoc [ 23%] [ 23%] Scanning dependencies of target taskmanager Building CXX object libkworkspace/CMakeFiles/kworkspace.dir/kworkspace.cpp.o Building CXX object shell/widgetexplorer/CMakeFiles/plasmawidgetexplorerplugin.dir/kcategorizeditemsviewmodels.cpp.o [ 23%] Generating drkonqibackends.moc http://build.kde.org/job/plasma-workspace_master_qt5/ws/drkonqi/drkonqibackends.cpp:0: Note: No relevant classes found. No output generated. Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/abstractgroupableitem.cpp.o Generating moc_kglobalacceld.cpp Generating moc_kglobalaccel_x11.cpp [ 23%] Built target kdeinit_kglobalaccel5_automoc [ 23%] Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/abstractgroupingstrategy.cpp.o Generating deviceserviceaction.moc Generating soliduiserver.moc Generating moc_deviceactionsdialog.cpp Generating moc_soliduiserver.cpp [ 23%] Built target kded_soliduiserver_automoc [ 23%] Building CXX object appmenu/CMakeFiles/kded_appmenu.dir/menuimporter.cpp.o Scanning dependencies of target plasmashell [ 23%] Building CXX object shell/CMakeFiles/plasmashell.dir/activity.cpp.o [ 23%] [ 23%] Building CXX object appmenu/CMakeFiles/kded_appmenu.dir/appmenu_dbus.cpp.o Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/abstractsortingstrategy.cpp.o [ 23%] Building CXX object shell/CMakeFiles/plasmashell.dir/alternativesdialog.cpp.o http://build.kde.org/job/plasma-workspace_master_qt5/ws/appmenu/menuimporter.cpp: In member function ‘WId MenuImporter::recursiveMenuId(WId)’: http://build.kde.org/job/plasma-workspace_master_qt5/ws/appmenu/menuimporter.cpp:112:45: warning: ‘static WId KWindowSystem::transientFor(WId)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kwindowsystem/inst/include/KF5/KWindowSystem/kwindowsystem.h:238) [-Wdeprecated-declarations] WId tid = KWindowSystem::transientFor(id); ^ http://build.kde.org/job/plasma-workspace_master_qt5/ws/appmenu/menuimporter.cpp:118:46: warning: ‘static WId KWindowSystem::transientFor(WId)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kwindowsystem/inst/include/KF5/KWindowSystem/kwindowsystem.h:238) [-Wdeprecated-declarations] tid = KWindowSystem::transientFor(tid); ^ http://build.kde.org/job/plasma-workspace_master_qt5/ws/appmenu/appmenu.cpp: In destructor ‘virtual AppMenuModule::~AppMenuModule()’: http://build.kde.org/job/plasma-workspace_master_qt5/ws/appmenu/appmenu.cpp:92:16: warning: possible problem detected in invocation of delete operator: [enabled by default] delete m_menubar; ^ http://build.kde.org/job/plasma-workspace_master_qt5/ws/appmenu/appmenu.cpp:92:16: warning: invalid use of incomplete type ‘class TopMenuBar’ [enabled by default] In file included from http://build.kde.org/job/plasma-workspace_master_qt5/ws/appmenu/appmenu.cpp:26:0: http://build.kde.org/job/plasma-workspace_master_qt5/ws/appmenu/appmenu.h:36:7: warning: forward declaration of ‘class TopMenuBar’ [enabled by default] class TopMenuBar; ^
Re: Review Request 119535: Move QML bindings for KUser to kdeclarative
On July 29, 2014, 2:33 p.m., Aleix Pol Gonzalez wrote: Can we consider including this in KCoreAddons? I know KCoreAddons should only depend on QtCore, but then we can make it an optional dependency. If Qt5::Qml is there, then build the Qml plugin too. KCoreAddons can depend from anything in KCore the Qt only one is KQuickControlAddons - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63441 --- On July 29, 2014, 2:31 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/ --- (Updated July 29, 2014, 2:31 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- Move QML bindings for KUser to kdeclarative This code has already been released, but privately inside Kickoff. As it is not strictly related (or limited to) Kickoff, I'd like to move it into kdeclarative. There are already other bindings for classes from KCoreAddons there, so this seems like a nice fit. The class is useful as public API since it allows customization of apps, making the user feel more familiar with the program at hand. I want to use the name and face icon of the user in more places (systemsettings redesign comes to mind), so it'd be useful to have it shared. Diffs - src/qmlcontrols/kcoreaddons/CMakeLists.txt 597cc2c src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 3c1a96e src/qmlcontrols/kcoreaddons/kuserproxy.h PRE-CREATION src/qmlcontrols/kcoreaddons/kuserproxy.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119535/diff/ Testing --- Ported an (unreleased) app using this class to the new location, works as expected, no regressions encountered. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119535: Move QML bindings for KUser to kdeclarative
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63453 --- src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp https://git.reviewboard.kde.org/r/119535/#comment44233 Maybe consider creating it a singleton type? - Bhushan Shah On July 29, 2014, 8:01 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/ --- (Updated July 29, 2014, 8:01 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- Move QML bindings for KUser to kdeclarative This code has already been released, but privately inside Kickoff. As it is not strictly related (or limited to) Kickoff, I'd like to move it into kdeclarative. There are already other bindings for classes from KCoreAddons there, so this seems like a nice fit. The class is useful as public API since it allows customization of apps, making the user feel more familiar with the program at hand. I want to use the name and face icon of the user in more places (systemsettings redesign comes to mind), so it'd be useful to have it shared. Diffs - src/qmlcontrols/kcoreaddons/CMakeLists.txt 597cc2c src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 3c1a96e src/qmlcontrols/kcoreaddons/kuserproxy.h PRE-CREATION src/qmlcontrols/kcoreaddons/kuserproxy.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119535/diff/ Testing --- Ported an (unreleased) app using this class to the new location, works as expected, no regressions encountered. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to normal : plasma-workspace_master_qt5 #679
See http://build.kde.org/job/plasma-workspace_master_qt5/679/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119535: Move QML bindings for KUser to kdeclarative
On July 29, 2014, 2:33 p.m., Aleix Pol Gonzalez wrote: Can we consider including this in KCoreAddons? I know KCoreAddons should only depend on QtCore, but then we can make it an optional dependency. If Qt5::Qml is there, then build the Qml plugin too. Marco Martin wrote: KCoreAddons can depend from anything in KCore the Qt only one is KQuickControlAddons I'm confused. There is a framework called kcoreaddons The kdeclarative framework has a plugin also called kcoreaddons. Which one are you both talking about? - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63441 --- On July 29, 2014, 2:31 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/ --- (Updated July 29, 2014, 2:31 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- Move QML bindings for KUser to kdeclarative This code has already been released, but privately inside Kickoff. As it is not strictly related (or limited to) Kickoff, I'd like to move it into kdeclarative. There are already other bindings for classes from KCoreAddons there, so this seems like a nice fit. The class is useful as public API since it allows customization of apps, making the user feel more familiar with the program at hand. I want to use the name and face icon of the user in more places (systemsettings redesign comes to mind), so it'd be useful to have it shared. Diffs - src/qmlcontrols/kcoreaddons/CMakeLists.txt 597cc2c src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 3c1a96e src/qmlcontrols/kcoreaddons/kuserproxy.h PRE-CREATION src/qmlcontrols/kcoreaddons/kuserproxy.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119535/diff/ Testing --- Ported an (unreleased) app using this class to the new location, works as expected, no regressions encountered. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119535: Move QML bindings for KUser to kdeclarative
On July 29, 2014, 4:34 p.m., Bhushan Shah wrote: src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 44 https://git.reviewboard.kde.org/r/119535/diff/1/?file=294241#file294241line44 Maybe consider creating it a singleton type? Why? In fact, I think it's usually harder to deal with singletons and less explicit. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63453 --- On July 29, 2014, 2:31 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/ --- (Updated July 29, 2014, 2:31 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- Move QML bindings for KUser to kdeclarative This code has already been released, but privately inside Kickoff. As it is not strictly related (or limited to) Kickoff, I'd like to move it into kdeclarative. There are already other bindings for classes from KCoreAddons there, so this seems like a nice fit. The class is useful as public API since it allows customization of apps, making the user feel more familiar with the program at hand. I want to use the name and face icon of the user in more places (systemsettings redesign comes to mind), so it'd be useful to have it shared. Diffs - src/qmlcontrols/kcoreaddons/CMakeLists.txt 597cc2c src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 3c1a96e src/qmlcontrols/kcoreaddons/kuserproxy.h PRE-CREATION src/qmlcontrols/kcoreaddons/kuserproxy.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119535/diff/ Testing --- Ported an (unreleased) app using this class to the new location, works as expected, no regressions encountered. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119535: Move QML bindings for KUser to kdeclarative
On July 29, 2014, 2:33 p.m., Aleix Pol Gonzalez wrote: Can we consider including this in KCoreAddons? I know KCoreAddons should only depend on QtCore, but then we can make it an optional dependency. If Qt5::Qml is there, then build the Qml plugin too. Marco Martin wrote: KCoreAddons can depend from anything in KCore the Qt only one is KQuickControlAddons David Edmundson wrote: I'm confused. There is a framework called kcoreaddons The kdeclarative framework has a plugin also called kcoreaddons. Which one are you both talking about? err, kcoreaddons, right kcoreaddons plugin, depending from KCoreAddons framework (other framework maitainers didn't want the plugins to be in the framework itself to not make everything depend from qml) - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63441 --- On July 29, 2014, 2:31 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/ --- (Updated July 29, 2014, 2:31 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- Move QML bindings for KUser to kdeclarative This code has already been released, but privately inside Kickoff. As it is not strictly related (or limited to) Kickoff, I'd like to move it into kdeclarative. There are already other bindings for classes from KCoreAddons there, so this seems like a nice fit. The class is useful as public API since it allows customization of apps, making the user feel more familiar with the program at hand. I want to use the name and face icon of the user in more places (systemsettings redesign comes to mind), so it'd be useful to have it shared. Diffs - src/qmlcontrols/kcoreaddons/CMakeLists.txt 597cc2c src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 3c1a96e src/qmlcontrols/kcoreaddons/kuserproxy.h PRE-CREATION src/qmlcontrols/kcoreaddons/kuserproxy.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119535/diff/ Testing --- Ported an (unreleased) app using this class to the new location, works as expected, no regressions encountered. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119535: Move QML bindings for KUser to kdeclarative
On July 29, 2014, 10:04 p.m., Bhushan Shah wrote:
src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 44
https://git.reviewboard.kde.org/r/119535/diff/1/?file=294241#file294241line44
Maybe consider creating it a singleton type?
Aleix Pol Gonzalez wrote:
Why? In fact, I think it's usually harder to deal with singletons and
less explicit.
I think, It will be lot cleaner to use,
Image {
id: faceIcon
source: KCoreAddons.KUser.faceIconPath
[...]
}
instead of,
KCoreAddons.KUser {
id: kuser
}
Image {
id: faceIcon
source: kuser.faceIconPath
[...]
}
More cleaner API and we will save creating objects. (ver few but yes)
- Bhushan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119535/#review63453
---
On July 29, 2014, 8:01 p.m., Sebastian Kügler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119535/
---
(Updated July 29, 2014, 8:01 p.m.)
Review request for KDE Frameworks and Plasma.
Repository: kdeclarative
Description
---
Move QML bindings for KUser to kdeclarative
This code has already been released, but privately inside Kickoff. As it is
not strictly related (or limited to) Kickoff, I'd like to move it into
kdeclarative. There are already other bindings for classes from KCoreAddons
there, so this seems like a nice fit.
The class is useful as public API since it allows customization of apps,
making the user feel more familiar with the program at hand. I want to use
the name and face icon of the user in more places (systemsettings redesign
comes to mind), so it'd be useful to have it shared.
Diffs
-
src/qmlcontrols/kcoreaddons/CMakeLists.txt 597cc2c
src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 3c1a96e
src/qmlcontrols/kcoreaddons/kuserproxy.h PRE-CREATION
src/qmlcontrols/kcoreaddons/kuserproxy.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/119535/diff/
Testing
---
Ported an (unreleased) app using this class to the new location, works as
expected, no regressions encountered.
Thanks,
Sebastian Kügler
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Minutes Monday Plasma Hangout
On Tuesday 29 July 2014, Aleix Pol wrote: khintsettings should do something along the lines: * with some heuristics access the lookandfeel package (it's only a folder after all, wouldn't be very difficult) and open a config file with default icons/widget style etc * read the default if available, fallback to an hardcoded internal one if fail Agreed, also fonts could have a place there. so, this is how the experiment is going: https://git.reviewboard.kde.org/r/119534/ it's now getting some settings from the defaults config file in the lf package with the rule: * if the config key is set in kdeglobals, use that, the custom user setting always win * if the config key is not set in kdeglobals, look in the configured lf package * if not set in the configured lf package, look in the default lf package * if still fails, hardcoded default, exactly as before * for colors, it looks also if the lf package is actually shipping a colors file (it's looking for a color file with the same name as the one set in defaults, probably going to change to a file simply called always just colors) apart from that, i wonder if this could also add a subdirectory of the package as a searchpath for kiconloader another thing i wonder, if it should monitor for change in the configured lf package (may need modification in KConfig) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119535: Move QML bindings for KUser to kdeclarative
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63459 --- src/qmlcontrols/kcoreaddons/kuserproxy.h https://git.reviewboard.kde.org/r/119535/#comment44236 why? nameChanged is not related here.. src/qmlcontrols/kcoreaddons/kuserproxy.h https://git.reviewboard.kde.org/r/119535/#comment44237 same. - Bhushan Shah On July 29, 2014, 8:01 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/ --- (Updated July 29, 2014, 8:01 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- Move QML bindings for KUser to kdeclarative This code has already been released, but privately inside Kickoff. As it is not strictly related (or limited to) Kickoff, I'd like to move it into kdeclarative. There are already other bindings for classes from KCoreAddons there, so this seems like a nice fit. The class is useful as public API since it allows customization of apps, making the user feel more familiar with the program at hand. I want to use the name and face icon of the user in more places (systemsettings redesign comes to mind), so it'd be useful to have it shared. Diffs - src/qmlcontrols/kcoreaddons/CMakeLists.txt 597cc2c src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 3c1a96e src/qmlcontrols/kcoreaddons/kuserproxy.h PRE-CREATION src/qmlcontrols/kcoreaddons/kuserproxy.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119535/diff/ Testing --- Ported an (unreleased) app using this class to the new location, works as expected, no regressions encountered. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114910: Patch for bug 317066 (systray leaves garbage on the panel when resizing )
On Июль 29, 2014, 2:31 п.п., Marco Martin wrote: this would require some testing before pushing to 4.x, too delicate to just commit Well, I've been living with this patch for half a year already, since January 8 :) I used it with a number of KDE 4.x versions from 4.11.3 to 4.13.1 (coming with Linux Mint updates). Could it be counted as some testing? - Dmitry --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review63413 --- On Янв. 8, 2014, 8:25 п.п., Dmitry Ivanov wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/ --- (Updated Янв. 8, 2014, 8:25 п.п.) Review request for kde-workspace and Plasma. Bugs: 317066 http://bugs.kde.org/show_bug.cgi?id=317066 Repository: kde-workspace Description --- It is a proposed fix for bug 317066. The fix is a very simple one-liner setting FullViewportUpdate mode for FdoGraphicsWidget. I'm aware FullViewportUpdate has negative performance impact but I also know it efficiently leaves out any graphical glitches happening due to no repaint of widget when necessary (which is what the bug is about). I have tested my solution for a couple of days: the bug no longer reproduced and I also didn't see any noticeable performance problems. I'm still not sure what I propose is acceptable since it may seem like a hack to more experienced developers, however I just didn't want my patch attempt to get lost and forgotten in the bugzilla. Please have a look and decide whether the patch is good enough to be applied to the next bugfixing release of KDE 4.x series, thank you. Diffs - plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp 1baa23d Diff: https://git.reviewboard.kde.org/r/114910/diff/ Testing --- I rebuilt plasma_applet_systemtray.so with the patch and replaced the package version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can no longer reproduce bug 317066 and I don't see any noticeable performance problems of system tray applet. Thanks, Dmitry Ivanov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114910: Patch for bug 317066 (systray leaves garbage on the panel when resizing )
On July 29, 2014, 10:31 a.m., Marco Martin wrote: this would require some testing before pushing to 4.x, too delicate to just commit Dmitry Ivanov wrote: Well, I've been living with this patch for half a year already, since January 8 :) I used it with a number of KDE 4.x versions from 4.11.3 to 4.13.1 (coming with Linux Mint updates). Could it be counted as some testing? ok, let's go for it - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review63413 --- On Jan. 8, 2014, 4:25 p.m., Dmitry Ivanov wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/ --- (Updated Jan. 8, 2014, 4:25 p.m.) Review request for kde-workspace and Plasma. Bugs: 317066 http://bugs.kde.org/show_bug.cgi?id=317066 Repository: kde-workspace Description --- It is a proposed fix for bug 317066. The fix is a very simple one-liner setting FullViewportUpdate mode for FdoGraphicsWidget. I'm aware FullViewportUpdate has negative performance impact but I also know it efficiently leaves out any graphical glitches happening due to no repaint of widget when necessary (which is what the bug is about). I have tested my solution for a couple of days: the bug no longer reproduced and I also didn't see any noticeable performance problems. I'm still not sure what I propose is acceptable since it may seem like a hack to more experienced developers, however I just didn't want my patch attempt to get lost and forgotten in the bugzilla. Please have a look and decide whether the patch is good enough to be applied to the next bugfixing release of KDE 4.x series, thank you. Diffs - plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp 1baa23d Diff: https://git.reviewboard.kde.org/r/114910/diff/ Testing --- I rebuilt plasma_applet_systemtray.so with the patch and replaced the package version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can no longer reproduce bug 317066 and I don't see any noticeable performance problems of system tray applet. Thanks, Dmitry Ivanov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114910: Patch for bug 317066 (systray leaves garbage on the panel when resizing )
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review63466 --- Ship it! Ship It! - Marco Martin On Jan. 8, 2014, 4:25 p.m., Dmitry Ivanov wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/ --- (Updated Jan. 8, 2014, 4:25 p.m.) Review request for kde-workspace and Plasma. Bugs: 317066 http://bugs.kde.org/show_bug.cgi?id=317066 Repository: kde-workspace Description --- It is a proposed fix for bug 317066. The fix is a very simple one-liner setting FullViewportUpdate mode for FdoGraphicsWidget. I'm aware FullViewportUpdate has negative performance impact but I also know it efficiently leaves out any graphical glitches happening due to no repaint of widget when necessary (which is what the bug is about). I have tested my solution for a couple of days: the bug no longer reproduced and I also didn't see any noticeable performance problems. I'm still not sure what I propose is acceptable since it may seem like a hack to more experienced developers, however I just didn't want my patch attempt to get lost and forgotten in the bugzilla. Please have a look and decide whether the patch is good enough to be applied to the next bugfixing release of KDE 4.x series, thank you. Diffs - plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp 1baa23d Diff: https://git.reviewboard.kde.org/r/114910/diff/ Testing --- I rebuilt plasma_applet_systemtray.so with the patch and replaced the package version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can no longer reproduce bug 317066 and I don't see any noticeable performance problems of system tray applet. Thanks, Dmitry Ivanov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119535: Move QML bindings for KUser to kdeclarative
On July 29, 2014, 4:53 p.m., Bhushan Shah wrote: src/qmlcontrols/kcoreaddons/kuserproxy.h, line 96 https://git.reviewboard.kde.org/r/119535/diff/1/?file=294242#file294242line96 why? nameChanged is not related here.. It's not visible API (the signal visible to QML has the name of the property), and this way, we save a bit of footprint (1 signal necessary vs. 3). - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63459 --- On July 29, 2014, 2:31 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/ --- (Updated July 29, 2014, 2:31 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- Move QML bindings for KUser to kdeclarative This code has already been released, but privately inside Kickoff. As it is not strictly related (or limited to) Kickoff, I'd like to move it into kdeclarative. There are already other bindings for classes from KCoreAddons there, so this seems like a nice fit. The class is useful as public API since it allows customization of apps, making the user feel more familiar with the program at hand. I want to use the name and face icon of the user in more places (systemsettings redesign comes to mind), so it'd be useful to have it shared. Diffs - src/qmlcontrols/kcoreaddons/CMakeLists.txt 597cc2c src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 3c1a96e src/qmlcontrols/kcoreaddons/kuserproxy.h PRE-CREATION src/qmlcontrols/kcoreaddons/kuserproxy.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119535/diff/ Testing --- Ported an (unreleased) app using this class to the new location, works as expected, no regressions encountered. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119535: Move QML bindings for KUser to kdeclarative
On July 29, 2014, 4:34 p.m., Bhushan Shah wrote:
src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 44
https://git.reviewboard.kde.org/r/119535/diff/1/?file=294241#file294241line44
Maybe consider creating it a singleton type?
Aleix Pol Gonzalez wrote:
Why? In fact, I think it's usually harder to deal with singletons and
less explicit.
Bhushan Shah wrote:
I think, It will be lot cleaner to use,
Image {
id: faceIcon
source: KCoreAddons.KUser.faceIconPath
[...]
}
instead of,
KCoreAddons.KUser {
id: kuser
}
Image {
id: faceIcon
source: kuser.faceIconPath
[...]
}
More cleaner API and we will save creating objects. (ver few but yes)
I personally prefer explicit as well. I can change it, but I don't see it
having any advantage.
- Sebastian
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119535/#review63453
---
On July 29, 2014, 2:31 p.m., Sebastian Kügler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119535/
---
(Updated July 29, 2014, 2:31 p.m.)
Review request for KDE Frameworks and Plasma.
Repository: kdeclarative
Description
---
Move QML bindings for KUser to kdeclarative
This code has already been released, but privately inside Kickoff. As it is
not strictly related (or limited to) Kickoff, I'd like to move it into
kdeclarative. There are already other bindings for classes from KCoreAddons
there, so this seems like a nice fit.
The class is useful as public API since it allows customization of apps,
making the user feel more familiar with the program at hand. I want to use
the name and face icon of the user in more places (systemsettings redesign
comes to mind), so it'd be useful to have it shared.
Diffs
-
src/qmlcontrols/kcoreaddons/CMakeLists.txt 597cc2c
src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 3c1a96e
src/qmlcontrols/kcoreaddons/kuserproxy.h PRE-CREATION
src/qmlcontrols/kcoreaddons/kuserproxy.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/119535/diff/
Testing
---
Ported an (unreleased) app using this class to the new location, works as
expected, no regressions encountered.
Thanks,
Sebastian Kügler
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119535: Move QML bindings for KUser to kdeclarative
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/ --- (Updated July 29, 2014, 6:04 p.m.) Review request for KDE Frameworks and Plasma. Changes --- Adressed comments. Repository: kdeclarative Description --- Move QML bindings for KUser to kdeclarative This code has already been released, but privately inside Kickoff. As it is not strictly related (or limited to) Kickoff, I'd like to move it into kdeclarative. There are already other bindings for classes from KCoreAddons there, so this seems like a nice fit. The class is useful as public API since it allows customization of apps, making the user feel more familiar with the program at hand. I want to use the name and face icon of the user in more places (systemsettings redesign comes to mind), so it'd be useful to have it shared. Diffs (updated) - src/qmlcontrols/kcoreaddons/CMakeLists.txt 597cc2c src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 3c1a96e src/qmlcontrols/kcoreaddons/kuserproxy.h PRE-CREATION src/qmlcontrols/kcoreaddons/kuserproxy.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119535/diff/ Testing --- Ported an (unreleased) app using this class to the new location, works as expected, no regressions encountered. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114910: Patch for bug 317066 (systray leaves garbage on the panel when resizing )
On jul. 29, 2014, 5:12 p.m., Marco Martin wrote: Ship It! Marco, Dmitry doesn't have an account, can you please push this to 4.11? - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review63466 --- On gen. 8, 2014, 4:25 p.m., Dmitry Ivanov wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/ --- (Updated gen. 8, 2014, 4:25 p.m.) Review request for kde-workspace and Plasma. Bugs: 317066 http://bugs.kde.org/show_bug.cgi?id=317066 Repository: kde-workspace Description --- It is a proposed fix for bug 317066. The fix is a very simple one-liner setting FullViewportUpdate mode for FdoGraphicsWidget. I'm aware FullViewportUpdate has negative performance impact but I also know it efficiently leaves out any graphical glitches happening due to no repaint of widget when necessary (which is what the bug is about). I have tested my solution for a couple of days: the bug no longer reproduced and I also didn't see any noticeable performance problems. I'm still not sure what I propose is acceptable since it may seem like a hack to more experienced developers, however I just didn't want my patch attempt to get lost and forgotten in the bugzilla. Please have a look and decide whether the patch is good enough to be applied to the next bugfixing release of KDE 4.x series, thank you. Diffs - plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp 1baa23d Diff: https://git.reviewboard.kde.org/r/114910/diff/ Testing --- I rebuilt plasma_applet_systemtray.so with the patch and replaced the package version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can no longer reproduce bug 317066 and I don't see any noticeable performance problems of system tray applet. Thanks, Dmitry Ivanov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Using more of our CI, Coverage and cppcheck
On Monday 28 July 2014 15:46:56 Aleix Pol wrote: From the wiki: [1] Do we need special powers to change these? Aleix [1] And add this option in the configuraiotn of your CI build: http://quickgit.kde.org/?p=websites%2Fbuild-kde-org. [DEFAULT] configureExtraArgs=-DBUILD_COVERAGE=ON Yes, you can send patch to ben. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
