---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120298/#review67100
---
libs/mediacenter/lastfmimagefetcher.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119218/#review67101
---
Ship it!
Ship It!
- Shantanu Tushar
On Sept. 20, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120298/#review67102
---
Ship it!
Other than that, this is okay to go in.
- Shantanu
I'm running into a little bit of the inconsistency in systray icon sizes as
we're working to try to improve the systray icons.
http://wstaw.org/m/2014/09/21/5.1_systray_scaling_bug.png
The icons are still a WIP so please ignore that for the moment. All the
icons are 16x16 sitting on a padding
Correction: it's a 30x30 padding rect that gets the icon sizes the same,
not a 32x32 padding rect.
Hope this helps,
Andrew
On Sun, Sep 21, 2014 at 1:17 AM, Andrew Lake wrote:
I'm running into a little bit of the inconsistency in systray icon sizes
as we're working to try to improve the
See http://build.kde.org/job/plasma-workspace_master_qt5/880/changes
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
On Sep 21, 2014 10:39 AM, Andrew Lake jamboar...@gmail.com wrote:
Correction: it's a 30x30 padding rect that gets the icon sizes the same,
not a 32x32 padding rect.
The battery (and possibly metworkmanager) were known for being a bit too
big. I have now added api to make it possible to compute
On Sept. 21, 2014, 12:24 p.m., Shantanu Tushar wrote:
Ship It!
Worth reminding that I lack commit acccess :)
- R.Harish
---
This is an automatically generated e-mail. To reply, visit:
Tangentially related: The icons aren't horizontally centered in a vertical
panel.
Cheers,
Eike
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Btw, since we are refining systray icons, do they work also on a size of
22x22(if not I'll fix the code)? I would love to get rid of the old hack of
24x24, that is just a remnant of the xembed legacy icons
Is that the reason why even if I use units.roundToIconSize on the
batterymonitor the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119218/
---
(Updated Sept. 21, 2014, 1:59 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120298/
---
(Updated Sept. 21, 2014, 2:06 p.m.)
Status
--
This change has been
On Sun, Sep 21, 2014 at 2:06 AM, Marco Martin wrote:
Btw, since we are refining systray icons, do they work also on a size of
22x22(if not I'll fix the code)? I would love to get rid of the old hack of
24x24, that is just a remnant of the xembed legacy icons
I changed the padding rect on
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120306/
---
Review request for KDE Frameworks and Plasma.
Repository:
https://bugs.kde.org/show_bug.cgi?id=158379
Hugo Pereira Da Costa hugo.pere...@free.fr changed:
What|Removed |Added
Resolution|--- |FIXED
startkde has the following code:
# in case we have been started with full pathname spec without being in PATH
bindir=`echo $0 | sed -n 's,^\(/.*\)/[^/][^/]*$,\1,p'`
if [ -n $bindir ]; then
qbindir=`qtpaths --binaries-dir`
qdbus=$qbindir/qdbus
case $PATH in
1. qdbus is a relic of qt4
No it isn't.
qdbus exists in qt5 too.
In my case qt4 and qt5 are in different prefixes.
I suggest either set the qt paths in /etc/profile.d or in .pam_environment.
(see man pam_env)
___
Plasma-devel mailing list
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120306/#review67165
---
Why are we exclusive at compile time?
- David Edmundson
On
Padding inside the SVG?
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
On Sep 21, 2014 3:47 PM, David Edmundson wrote:
Padding inside the SVG?
Yes
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Padding inside the SVG?
Yes
I don't think this is the right long-term approach. We end up with problems
like in the original post where it's difficult to make another item line up
with an icon.
IMHO padding should be applied at a QML level, not inside the component. It
makes the behaviour a
On Sun, Sep 21, 2014 at 5:39 PM, David Edmundson wrote:
Padding inside the SVG?
Yes
I don't think this is the right long-term approach. We end up with
problems like in the original post where it's difficult to make another
item line up with an icon.
IMHO padding should be applied at a
22 matches
Mail list logo
