Review Request 121710: Avoid risk of starting two kscreen_launchers at the same having race conditions

2014-12-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121710/ --- Review request for Plasma, Solid and Daniel Vrátil. Repository:

Re: testing a plasma applet with plasmoid viewer despite PackageUrlInterceptor

2014-12-28 Thread Philipp A.
but then i have to compile the whole plasma framework. that’s far out of scope of a plasma applet :/ 2014-12-28 0:57 GMT+01:00 David Edmundson da...@davidedmundson.co.uk: On Sat, Dec 27, 2014 at 10:11 PM, Philipp A. flying-sh...@web.de wrote: Hi, i’m developing a plasma wiget with C++

Re: testing a plasma applet with plasmoid viewer despite PackageUrlInterceptor

2014-12-28 Thread Philipp A.
code is here btw: https://github.com/flying-sheep/steam-plasmoid 2014-12-28 17:41 GMT+01:00 Philipp A. flying-sh...@web.de: but then i have to compile the whole plasma framework. that’s far out of scope of a plasma applet :/ 2014-12-28 0:57 GMT+01:00 David Edmundson

KHolidays 5 branch

2014-12-28 Thread John Layt
Hi, I've just pushed a new branch called kf5-port to the kholidays repository for people to look at. This contains the set of api changes I wanted to make and attempts to remove the kdelibs4support dependency. Could someone who understands CMake better than me have a look at the last commit, as

Re: [Kde-pim] KHolidays 5 branch

2014-12-28 Thread laurent Montel
Le Sunday 28 December 2014 17:19:48 John Layt a écrit : Hi, I've just pushed a new branch called kf5-port to the kholidays repository for people to look at. This contains the set of api changes I wanted to make and attempts to remove the kdelibs4support dependency. We can't for the moment

Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.

2014-12-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121718/ --- Review request for Plasma. Repository: plasma-workspace Description

Change in plasma-framework[master]: Set visibility on mainItem to match Dialog

2014-12-28 Thread David Edmundson (Code Review)
David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/282 Change subject: Set visibility on mainItem to match Dialog .. Set visibility on mainItem to match Dialog Otherwise we can have an

Review Request 121720: Load wallpaper immediately on startup

2014-12-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121720/ --- Review request for Plasma. Repository: plasma-workspace Description

Review Request 121722: Bring back computer-laptop icon for kickoff

2014-12-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121722/ --- Review request for Plasma and Sebastian Kügler. Repository:

Re: Review Request 121722: Bring back computer-laptop icon for kickoff

2014-12-28 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121722/#review72619 --- Ship it! - Lukáš Tinkl On Pro. 28, 2014, 9:13 odp., Kai

Re: Review Request 121722: Bring back computer-laptop icon for kickoff

2014-12-28 Thread Lukáš Tinkl
On Pro. 28, 2014, 9:14 odp., Lukáš Tinkl wrote: Oh and, for the record, check the Chassis property in http://www.freedesktop.org/wiki/Software/systemd/hostnamed/ - Lukáš --- This is an automatically generated e-mail. To reply,

Review Request 121724: Use rgba color with 0.5 alpha channel for placheolder

2014-12-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121724/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 121722: Bring back computer-laptop icon for kickoff

2014-12-28 Thread Kai Uwe Broulik
On Dez. 28, 2014, 8:14 nachm., Lukáš Tinkl wrote: Lukáš Tinkl wrote: Oh and, for the record, check the Chassis property in http://www.freedesktop.org/wiki/Software/systemd/hostnamed/ Yeah I had that one at the back of my mind :) - Kai Uwe

Re: Review Request 121724: Use rgba color with 0.5 alpha channel for placheolder

2014-12-28 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121724/#review72622 --- Ship it! Ship It! - Lukáš Tinkl On Pro. 28, 2014, 9:17

Re: testing a plasma applet with plasmoid viewer despite PackageUrlInterceptor

2014-12-28 Thread Philipp A.
aha, so the problem seems to be that when loaded via plasmoidviewer m_package.metadata().pluginName() == org.kde.desktopcontainment when using a custom interceptor to circumvent it, i still get strange errors. can someone help? QML debugging is enabled. Only use this in a safe environment.

Re: Review Request 121724: Use rgba color with 0.5 alpha channel for placheolder

2014-12-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121724/ --- (Updated Dec. 28, 2014, 8:34 p.m.) Status -- This change has been

Re: Review Request 121722: Bring back computer-laptop icon for kickoff

2014-12-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121722/ --- (Updated Dec. 28, 2014, 8:35 p.m.) Status -- This change has been

Review Request 121726: Connect Plasma::Theme::themeChanged to ColorScope::colorsChanged

2014-12-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121726/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 121726: Connect Plasma::Theme::themeChanged to ColorScope::colorsChanged

2014-12-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121726/#review72628 --- Ship it! Ship It! - David Edmundson On Dec. 28, 2014,

Re: Review Request 121726: Connect Plasma::Theme::themeChanged to ColorScope::colorsChanged

2014-12-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121726/ --- (Updated Dec. 28, 2014, 10:03 p.m.) Status -- This change has been

Review Request 121728: Fix Label not picking up font changes at runtime

2014-12-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121728/ --- Review request for Plasma. Bugs: 334818

Re: Review Request 121728: Fix Label not picking up font changes at runtime

2014-12-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121728/#review72636 --- Ship it! src/plasma/private/theme_p.cpp

Re: Review Request 121728: Fix Label not picking up font changes at runtime

2014-12-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121728/ --- (Updated Dec. 28, 2014, 10:43 p.m.) Status -- This change has been

Review Request 121732: Port kcm_kded away from kdelibs4support

2014-12-28 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121732/ --- Review request for Plasma. Repository: plasma-desktop Description

Re: Review Request 121710: Avoid risk of starting two kscreen_launchers at the same having race conditions

2014-12-28 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121710/#review72655 --- Unfortunataly it doesn't fix it here, plasmashell starts with

Re: Review Request 121710: Avoid risk of starting two kscreen_launchers at the same having race conditions

2014-12-28 Thread Bhushan Shah
On Dec. 29, 2014, 7:25 a.m., Lukáš Tinkl wrote: Unfortunataly it doesn't fix it here, plasmashell starts with a blank screen. kquitapp5 plasmashell plasmashell brings it back Works for me.. :S which XRandr version you have? - Bhushan

Re: Review Request 121701: Introduce KQuickControls TextField with context menu

2014-12-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121701/#review72657 --- +1 to me, it's something that clearly belongs on our side.

Re: Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.

2014-12-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121718/#review72659 --- Then Qt5Webkit should be marked as optional through the