Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-22 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/ --- (Updated April 22, 2015, 9:47 p.m.) Review request for Plasma, Bhushan

Re: Review Request 123468: Add setting to adjust screen scaling

2015-04-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123468/ --- (Updated April 22, 2015, 3:44 p.m.) Review request for Plasma.

Review Request 123468: Add setting to adjust screen scaling

2015-04-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123468/ --- Review request for Plasma. Repository: kscreen Description ---

Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-22 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/ --- Review request for Plasma, Bhushan Shah, Shantanu Tushar, and Sinny

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-22 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/ --- (Updated April 22, 2015, 7:14 p.m.) Review request for Plasma, Bhushan

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-22 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/#review79349 --- The idea sounds, some nitpicks though.

Re: Review Request 123411: Protect X11 calls in the Pager plasmoid to prevent plasmashell from crashing in Wayland

2015-04-22 Thread Nerdopolis Turfwalker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123411/ --- (Updated April 22, 2015, 5:55 a.m.) Status -- This change has been

Re: Review Request 123411: Protect X11 calls in the Pager plasmoid to prevent plasmashell from crashing in Wayland

2015-04-22 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123411/#review79322 --- Ship it! yep, that worked. - Martin Gräßlin On April 22,

Review Request 123469: Migrate kickoff favourites

2015-04-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123469/ --- Review request for Plasma. Repository: plasma-desktop Description

Re: Review Request 123469: Migrate kickoff favourites

2015-04-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123469/#review79354 --- Ship it! Ship It! - Marco Martin On April 22, 2015, 5:40

[plasma-sdk/Plasma/5.3] /: Use the new DTD for KF5

2015-04-22 Thread Luigi Toscano
Git commit 850d80e612ff33f17bab1e5a58cfe81da6d4da81 by Luigi Toscano. Committed on 22/04/2015 at 22:24. Pushed by ltoscano into branch 'Plasma/5.3'. Use the new DTD for KF5 Otherwise there is an implicit dependency on kdelibs4support. Sorry for the last-minute fix before the tagging day.

Re: Review Request 123468: Add setting to adjust screen scaling

2015-04-22 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123468/#review79363 --- Ship it! Some minor comments inline, otherwise looks good to

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-22 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/#review79364 --- libs/mediacenter/mpris2/mpris2.cpp (line 33)

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-22 Thread Ashish Madeti
On April 23, 2015, 4:05 a.m., Sebastian Kügler wrote: libs/mediacenter/mpris2/mpris2.cpp, line 33 https://git.reviewboard.kde.org/r/123467/diff/3/?file=362527#file362527line33 Actually, this is wrong now. Using the native separator may produce \ (on Windows, for example), which

Re: Review Request 123469: Migrate kickoff favourites

2015-04-22 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123469/#review79362 --- Ship it! Thanks! - Sebastian Kügler On April 22, 2015,

Jenkins build became unstable: plasma-workspace_master_qt5 #1481

2015-04-22 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/1481/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_stable_qt5 #114

2015-04-22 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_stable_qt5/114/changes Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER

Build failed in Jenkins: kinfocenter_stable_qt5 #16

2015-04-22 Thread KDE CI System
See http://build.kde.org/job/kinfocenter_stable_qt5/16/changes Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER