Re: Review Request 124360: [shell] Add Wayland support to PanelShadow

2015-07-15 Thread Martin Gräßlin
On July 15, 2015, 11:01 a.m., Marco Martin wrote: +1 code looks pretty clean, considering what it does, deferring +2 to testing after corresponding parts of kwin are pushed/tested kwayland part pushed with http://commits.kde.org/kwayland/6922d5184037ea6f85d173b027c858c5e9d6b3be -

baloo monitor visibility

2015-07-15 Thread Harald Sitter
ahoy ahoy I have just come across the new baloo monitor and it appears to me that it is supposed to be installed by default which makes it appear by default on all plasma systems. Is that in fact the intended behavior here (i.e. desktop file, visible by default, installed by default)? If so, it

Re: Review Request 124360: [shell] Add Wayland support to PanelShadow

2015-07-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124360/#review82529 --- +1 code looks pretty clean, considering what it does,

Re: Review Request 124351: Update kwindecoration kcm docbook to Plama 5

2015-07-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124351/#review82532 --- Ship it! Ship It! - Marco Martin On July 14, 2015, 7:30

Re: Review Request 124347: Update desktopthemedetails kcm docbook to Plasma 5

2015-07-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124347/#review82533 --- Ship it! Ship It! - Marco Martin On July 14, 2015, 2:57

Re: Review Request 124360: [shell] Add Wayland support to PanelShadow

2015-07-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124360/#review82537 --- Ship it! tested and works - Marco Martin On July 15,

Re: baloo monitor visibility

2015-07-15 Thread Martin Steigerwald
Am Mittwoch, 15. Juli 2015, 09:56:07 schrieb Harald Sitter: ahoy ahoy Hi Harald, I have just come across the new baloo monitor and it appears to me that it is supposed to be installed by default which makes it appear by default on all plasma systems. Is that in fact the intended behavior

Re: baloo monitor visibility

2015-07-15 Thread Mark Gaiser
snip Also just my two cents: IMO it would make contextually more sense to have the utility NoDisplay=true (have it not show up in the actual menu) but a button to launch it in the File Search KCM. At least I would not look for this in the application menu ;) Why would you want to hide a

Review Request 124360: [shell] Add Wayland support to PanelShadow

2015-07-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124360/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 124352: Update kwinsceenedges to Plasma 5

2015-07-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124352/#review82531 --- Ship it! no, screen edges shouldn't need compositor - Marco

Re: Review Request 124360: [shell] Add Wayland support to PanelShadow

2015-07-15 Thread Martin Gräßlin
On July 15, 2015, 11:01 a.m., Marco Martin wrote: +1 code looks pretty clean, considering what it does, deferring +2 to testing after corresponding parts of kwin are pushed/tested Martin Gräßlin wrote: kwayland part pushed with

Re: Review Request 124355: Set notifications to show on all desktops

2015-07-15 Thread David Rosca
On July 14, 2015, 10:48 p.m., Martin Klapetek wrote: What happens with popup notifications now with this patch? That's the reason for the change, so the popup notifications are still visible even when you change desktop. Also, I think this should be made also for OnScreenDisplay window

Review Request 124368: Add KPeople.PersonsSortFilterProxyModel into the qml plugin

2015-07-15 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124368/ --- Review request for Plasma and Telepathy. Repository: kpeople

Re: Review Request 124368: Add KPeople.PersonsSortFilterProxyModel into the qml plugin

2015-07-15 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124368/ --- (Updated July 15, 2015, 10:46 p.m.) Status -- This change has been

[Powerdevil] [Bug 350258] Screen brightness is not remembered

2015-07-15 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=350258 Kai Uwe Broulik k...@privat.broulik.de changed: What|Removed |Added Component|general |general

Re: Review Request 124355: Set notifications to show on all desktops

2015-07-15 Thread Kai Uwe Broulik
On Juli 15, 2015, 9:28 nachm., Kai Uwe Broulik wrote: Is the OSD also affected by this? ah, nvm, yes, please do the same for OSD :) - Kai Uwe --- This is an automatically generated e-mail. To reply, visit:

[Powerdevil] [Bug 350258] Screen brightness is not remembered

2015-07-15 Thread Alex Fiestas
https://bugs.kde.org/show_bug.cgi?id=350258 Alex Fiestas afies...@kde.org changed: What|Removed |Added CC||afies...@kde.org --- Comment #2

Re: Review Request 124368: Add KPeople.PersonsSortFilterProxyModel into the qml plugin

2015-07-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124368/#review82554 --- Ship it! Ship It! - Aleix Pol Gonzalez On July 15, 2015,

Re: Review Request 124355: Set notifications to show on all desktops

2015-07-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124355/#review82551 --- Is the OSD also affected by this? - Kai Uwe Broulik On

[Powerdevil] [Bug 350258] Screen brightness is not remembered

2015-07-15 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=350258 --- Comment #3 from Kai Uwe Broulik k...@privat.broulik.de --- That doesn't stop PowerDevil from overriding it on login :) Also, I hate that systemd messes with brighrness. Yet another service that thinks it knows better. Any way to inhibit that? --

Re: Review Request 124292: [ksmserver] Force QPA platform xcb

2015-07-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124292/ --- (Updated July 15, 2015, 11:32 a.m.) Status -- This change has been

Re: Review Request 124360: [shell] Add Wayland support to PanelShadow

2015-07-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124360/ --- (Updated July 15, 2015, 11:32 a.m.) Status -- This change has been

Re: Review Request 124293: Add a startplasmacompositor and startplasma file

2015-07-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124293/ --- (Updated July 15, 2015, 11:32 a.m.) Status -- This change has been