Re: Review Request 124991: Fix autostart desktop file save location

2015-08-30 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124991/#review84570 --- Sorry I didn't see this request. I fixed it without it. Again

Re: Review Request 124992: Update currentSize in Screen::apply

2015-08-30 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124992/#review84572 --- Ship it! Thanks for the patch! - Daniel Vrátil On Aug.

Re: Review Request 124992: Update currentSize in Screen::apply

2015-08-30 Thread Andrew Chen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124992/ --- (Updated Aug. 30, 2015, 8:46 p.m.) Status -- This change has been

Re: Review Request 124986: [System Tray] Bring back shortcuts configuration

2015-08-30 Thread Kai Uwe Broulik
On Aug. 30, 2015, 6:59 nachm., David Edmundson wrote: applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.h, line 54 https://git.reviewboard.kde.org/r/124986/diff/2/?file=399623#file399623line54 95% sure this won't work from QML However, it's also not used.

Re: Review Request 124986: [System Tray] Bring back shortcuts configuration

2015-08-30 Thread Kai Uwe Broulik
On Aug. 30, 2015, 2:10 nachm., Thomas Pfeiffer wrote: Usability-wise it's fine. Visually, the clear buttons for the shortcuts should be right-aligned Kai Uwe Broulik wrote: They are? Or what are you referring to? David Edmundson wrote: @Thomas, FYI if you click on the

Re: Review Request 124986: [System Tray] Bring back shortcuts configuration

2015-08-30 Thread David Edmundson
On Aug. 30, 2015, 2:10 p.m., Thomas Pfeiffer wrote: Usability-wise it's fine. Visually, the clear buttons for the shortcuts should be right-aligned Kai Uwe Broulik wrote: They are? Or what are you referring to? @Thomas, FYI if you click on the screenshot you can draw a rectangle

Re: Review Request 124986: [System Tray] Bring back shortcuts configuration

2015-08-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124986/#review84598 --- Ship it! code seems fine, ship it when we've sorted out

Re: Review Request 124986: [System Tray] Bring back shortcuts configuration

2015-08-30 Thread Hugo Pereira Da Costa
On Aug. 30, 2015, 2:10 p.m., Thomas Pfeiffer wrote: Usability-wise it's fine. Visually, the clear buttons for the shortcuts should be right-aligned Kai Uwe Broulik wrote: They are? Or what are you referring to? David Edmundson wrote: @Thomas, FYI if you click on the

Re: Review Request 124986: [System Tray] Bring back shortcuts configuration

2015-08-30 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124986/#review84602 --- File Attachment: UI in action - systemtrayshortcuts.png

Re: Review Request 124953: [Appletconfiguration] Prevent binding loop in main stackview

2015-08-30 Thread David Edmundson
On Aug. 30, 2015, 1:28 p.m., David Edmundson wrote: This needs reverting. Check wallpaper configuration now. Explaining this a bit better. What the code was doing before: height is either: the size of the child items filling up all the way to the buttons at the bottom of the

Re: Review Request 124986: [System Tray] Bring back shortcuts configuration

2015-08-30 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124986/#review84584 --- Usability-wise it's fine. Visually, the clear buttons for the

Re: Review Request 124953: [Appletconfiguration] Prevent binding loop in main stackview

2015-08-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124953/#review84578 --- This needs reverting. Check wallpaper configuration now. -

Re: Review Request 124986: [System Tray] Bring back shortcuts configuration

2015-08-30 Thread Kai Uwe Broulik
On Aug. 30, 2015, 2:10 nachm., Thomas Pfeiffer wrote: Usability-wise it's fine. Visually, the clear buttons for the shortcuts should be right-aligned They are? Or what are you referring to? - Kai Uwe --- This is an automatically

Re: Review Request 124981: RFC: Move context menu out of panel

2015-08-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124981/#review84577 --- Ship it! We're quite close to the release, so I'd rather you

[Powerdevil] [Bug 343018] Screen Energy Saving doesn't work at all

2015-08-30 Thread Mark Haase
https://bugs.kde.org/show_bug.cgi?id=343018 --- Comment #3 from Mark Haase meha...@gmail.com --- Nevermind, my problem persists :( -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list

[Powerdevil] [Bug 348082] monitor is randomly powered back on

2015-08-30 Thread Mark Haase
https://bugs.kde.org/show_bug.cgi?id=348082 --- Comment #8 from Mark Haase meha...@gmail.com --- Nevermind, my problem persists :( -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list

Re: Review Request 124986: [System Tray] Bring back shortcuts configuration

2015-08-30 Thread Thomas Pfeiffer
On Aug. 30, 2015, 7:47 p.m., Hugo Pereira Da Costa wrote: File Attachment: UI in action - systemtrayshortcuts.png https://git.reviewboard.kde.org/r/124986/#fcomment435 ... here :) Yes, that's what I meant. Yes, I should have used the direct marking function, sorry I forgot. -

Re: Review Request 124986: [System Tray] Bring back shortcuts configuration

2015-08-30 Thread Thomas Pfeiffer
On Aug. 30, 2015, 2:10 p.m., Thomas Pfeiffer wrote: Usability-wise it's fine. Visually, the clear buttons for the shortcuts should be right-aligned Kai Uwe Broulik wrote: They are? Or what are you referring to? David Edmundson wrote: @Thomas, FYI if you click on the

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-08-30 Thread Hans Chen
On Aug. 27, 2015, 7:04 p.m., Thomas Pfeiffer wrote: Since this is indeed a very often required feature, why do we keep it hidden? If it can have negative side-effects, it we should warn users about them, not hide the whole feature from them. Thomas Lübking wrote: or restricte to