Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 236 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/236/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Oct 2015 06:37:57 + Build duration: 17 min CHANGE SET Revision

Re: Review Request 125618: Fixes to KameraConfigDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125618/#review87485 --- kcontrol/kameraconfigdialog.cpp (line 285)

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 239 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/239/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Oct 2015 08:02:47 + Build duration: 15 min CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 239 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/239/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Oct 2015 08:02:47 + Build duration: 15 min CHANGE SET Revision

Re: Review Request 125618: Fixes to KameraConfigDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125618/ --- (Updated Oct. 27, 2015, 8:45 a.m.) Review request for KDE Graphics,

Re: Review Request 125618: Fixes to KameraConfigDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125618/#review87484 --- Are any changes needed? - Christian Butcher On Oct. 13,

Re: Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/#review87492 --- One more question/idea that just came to my mind: what about

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 237 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/237/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Oct 2015 07:00:30 + Build duration: 17 min CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 238 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/238/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Oct 2015 07:25:27 + Build duration: 17 min CHANGE SET Revision

Re: Review Request 125817: Add plugin system for Calendar events

> On Oct. 26, 2015, 11:05 p.m., Daniel Vrátil wrote: > > src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h, > > line 40 > > > > > > This means that all-day events that span over

Re: Review Request 125811: detect gtk engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125811/ --- (Updated Oct. 27, 2015, 9:22 a.m.) Review request for Plasma and David

Re: Review Request 125825: Add guards for Xlib code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125825/#review87494 --- libkhotkeysprivate/windows_handler.h (line 67)

Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 19 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Oct 2015 10:00:57 + Build duration: 5 min 48 sec CHANGE SET Revision

Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 19 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Oct 2015 10:00:57 + Build duration: 5 min 48 sec CHANGE SET Revision

Re: Review Request 125814: add kconf script to set gtk theme to breeze

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125814/#review87505 --- kconf_update/main.cpp (line 144)

Re: Review Request 125826: kcm_keyboard: Set default debug level to QtWarningMsg

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125826/#review87506 --- Ship it! Ship It! - David Edmundson On Oct. 27, 2015,

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125810/ --- (Updated Oct. 27, 2015, 10:02 a.m.) Status -- This change has been

Review Request 125827: Introduce WaylandLocker for ksld

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125827/ --- Review request for Plasma and Martin Gräßlin. Repository:

Review Request 125825: Add guards for Xlib code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125825/ --- Review request for Plasma and David Edmundson. Repository: khotkeys

Re: Review Request 125825: Add guards for Xlib code

> On Oct. 27, 2015, 10:32 a.m., David Edmundson wrote: > > libkhotkeysprivate/windows_handler.h, line 67 > > > > > > why store this as a member var isntead of just running > > > > isPlatformX11 each

Re: Review Request 125825: Add guards for Xlib code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125825/#review87497 --- Ship it! Ship It! - David Edmundson On Oct. 27, 2015,

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125810/ --- (Updated Oct. 27, 2015, 9:43 a.m.) Review request for Plasma.

Re: Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/#review87500 ---

Re: Review Request 125814: add kconf script to set gtk theme to breeze

> On Oct. 26, 2015, 5:55 p.m., David Edmundson wrote: > > kconf_update/main.cpp, line 171 > > > > > > not needed ok but then how do I turn on debugging? - Jonathan

Re: Review Request 125814: add kconf script to set gtk theme to breeze

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125814/ --- (Updated Oct. 27, 2015, 10:36 a.m.) Review request for Plasma and David

Re: Review Request 125827: Introduce WaylandLocker for ksld

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125827/#review87502 --- ksmserver/screenlocker/ksldapp.cpp (lines 145 - 154)

Re: Review Request 125827: Introduce WaylandLocker for ksld

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125827/#review87503 --- ksmserver/screenlocker/ksldapp.cpp (line 145)

Review Request 125826: kcm_keyboard: Set default debug level to QtWarningMsg

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125826/ --- Review request for Plasma. Repository: plasma-desktop Description

Re: Review Request 125811: detect gtk engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125811/#review87493 --- cmake/FindGTKEngine.cmake (line 17)

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

> On Oct. 26, 2015, 9:12 p.m., Sebastian Kügler wrote: > > applets/notifications/package/metadata.desktop, line 170 > > > > > > We have a special notifications applet for handsets in plasma-mobile, > > so this

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125810/#review87498 --- Ship it! Ship It! - Sebastian Kügler On Oct. 27, 2015,

Re: Review Request 125825: Add guards for Xlib code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125825/ --- (Updated Oct. 27, 2015, 10 a.m.) Status -- This change has been

Re: Review Request 125814: add kconf script to set gtk theme to breeze

> On Oct. 26, 2015, 5:55 p.m., David Edmundson wrote: > > kconf_update/main.cpp, line 171 > > > > > > not needed > > Jonathan Riddell wrote: > ok but then how do I turn on debugging? by default

Re: Review Request 125827: Introduce WaylandLocker for ksld

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125827/ --- (Updated Oct. 27, 2015, 12:55 p.m.) Status -- This change has been

Re: Review Request 125814: add kconf script to set gtk theme to breeze

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125814/ --- (Updated Oct. 27, 2015, 11:16 a.m.) Review request for Plasma and David

Re: Review Request 125827: Introduce WaylandLocker for ksld

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125827/#review87511 --- ksmserver/screenlocker/ksldapp.cpp (lines 575 - 580)

Re: Review Request 125827: Introduce WaylandLocker for ksld

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125827/ --- (Updated Oct. 27, 2015, 5:57 p.m.) Review request for Plasma and Martin

Re: Review Request 125827: Introduce WaylandLocker for ksld

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125827/#review87514 --- Ship it! Ship It! - Martin Gräßlin On Oct. 27, 2015, 1:27

Re: Review Request 125827: Introduce WaylandLocker for ksld

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125827/ --- (Updated Oct. 27, 2015, 4:48 p.m.) Review request for Plasma and Martin

Re: Review Request 125811: detect gtk engine

> On Oct. 27, 2015, 9:26 a.m., David Edmundson wrote: > > cmake/FindGTKEngine.cmake, line 17 > > > > > > what if I have 2.10.1 installed? > > Jonathan Riddell wrote: > No such bugfix ABI bumper were made and

Re: Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/#review87512 --- src/declarativeimports/calendar/daysmodel.cpp (line 62)

Re: Review Request 125811: detect gtk engine

> On Oct. 27, 2015, 9:26 a.m., David Edmundson wrote: > > cmake/FindGTKEngine.cmake, line 17 > > > > > > what if I have 2.10.1 installed? No such bugfix ABI bumper were made and now GTK 3 is the development

Re: Review Request 125814: add kconf script to set gtk theme to breeze

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125814/#review87507 --- Ship it! Ship It! - David Edmundson On Oct. 27, 2015,

Re: Review Request 125811: detect gtk engine

> On Oct. 27, 2015, 9:26 a.m., David Edmundson wrote: > > cmake/FindGTKEngine.cmake, line 17 > > > > > > what if I have 2.10.1 installed? > > Jonathan Riddell wrote: > No such bugfix ABI bumper were made and

Re: Review Request 125826: kcm_keyboard: Set default debug level to QtWarningMsg

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125826/ --- (Updated Oct. 27, 2015, 11:11 a.m.) Status -- This change has been

Re: Review Request 125814: add kconf script to set gtk theme to breeze

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125814/ --- (Updated Oct. 27, 2015, 11:33 a.m.) Status -- This change has been

Re: Review Request 125817: Add plugin system for Calendar events

> On Oct. 26, 2015, 11:05 p.m., Daniel Vrátil wrote: > > src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h, > > line 31 > > > > > > IMO the members here should be hidden in PIMPL.

Re: Review Request 125821: [Kickerdash] Close when opening applet settings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125821/#review87531 --- Ship it! Makes sense. It used to open before the Dash before

[Differential] [Requested Changes To] D409: new mobile components

davidedmundson added a subscriber: davidedmundson. davidedmundson requested changes to this revision. davidedmundson added a reviewer: davidedmundson. This revision now requires changes to proceed. INLINE COMMENTS components/mobilecomponents/ActionGroup.qml:26 to make sure I've got this:

[Differential] [Updated, 916 lines] D409: new mobile components

mart updated this revision to Diff 1066. REPOSITORY rPLASMAMOBILE plasma-mobile CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D409?vs=1009=1066 REVISION DETAIL https://phabricator.kde.org/D409 AFFECTED FILES components/mobilecomponents/ActionGroup.qml

[Differential] [Commented On] D409: new mobile components

mart added inline comments. INLINE COMMENTS components/mobilecomponents/ActionGroup.qml:26 yes, to do a tree-like thing components/mobilecomponents/ContextDrawer.qml:40 I'm still not sure wether the dependencies should be. I think i'll go for using qqc and wrapping the other classes that i

[Differential] [Updated] D409: new mobile components

mart marked 5 inline comments as done. mart added a comment. REPOSITORY rPLASMAMOBILE plasma-mobile REVISION DETAIL https://phabricator.kde.org/D409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, Plasma: Mobile Cc: davidedmundson,

Re: Review Request 125817: Add plugin system for Calendar events

> On Oct. 26, 2015, 11:05 p.m., Daniel Vrátil wrote: > > src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h, > > line 31 > > > > > > IMO the members here should be hidden in PIMPL.

Re: Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/ --- (Updated Oct. 27, 2015, 7:30 p.m.) Review request for KDE Frameworks,

Re: Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/ --- (Updated Oct. 27, 2015, 9:53 p.m.) Review request for Plasma and Daniel

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

> On Oct. 25, 2015, 10:05 p.m., Thomas Pfeiffer wrote: > > As always: If you want design or usability input, please provide a > > screenshot. We cannot read the code. Thanks. > > Eike Hein wrote: > Thomas, all this does is not grey out the text in Task Manager button > labels when a

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

> On Oct. 25, 2015, 10:05 p.m., Thomas Pfeiffer wrote: > > As always: If you want design or usability input, please provide a > > screenshot. We cannot read the code. Thanks. > > Eike Hein wrote: > Thomas, all this does is not grey out the text in Task Manager button > labels when a

[Plasma Workspace Wallpapers] [Bug 354379] Wallpaper fails to rotate 90 on dual screen with external scr. on left. Stays horiz. and spills over onto right scr.

https://bugs.kde.org/show_bug.cgi?id=354379 --- Comment #7 from PhillB --- So now I've tried to drive xrandr directly to get what I need (see below). Results are variable. Sometimes it works other times one or other screen goes black and its desktop stops working. I can

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

> On Oct. 25, 2015, 10:05 p.m., Thomas Pfeiffer wrote: > > As always: If you want design or usability input, please provide a > > screenshot. We cannot read the code. Thanks. > > Eike Hein wrote: > Thomas, all this does is not grey out the text in Task Manager button > labels when a

Re: Review Request 125817: Add plugin system for Calendar events

> On Oct. 27, 2015, 10:22 p.m., Daniel Vrátil wrote: > > src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h, > > line 31 > > > > > > You are missing implementation for this entire

Re: Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/#review87549 --- src/declarativeimports/calendar/daysmodel.cpp (line 67)

Re: Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/#review87556 --- src/declarativeimports/calendar/daysmodel.cpp (line 175)

Re: Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/ --- (Updated Oct. 27, 2015, 9:10 p.m.) Status -- This change has been

Re: Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/#review87550 --- src/declarativeimports/calendar/daysmodel.cpp (line 156)

Re: Review Request 125817: Add plugin system for Calendar events

> On Oct. 27, 2015, 10:20 p.m., Kai Uwe Broulik wrote: > > What did you do submitting this to the 5.4 branch? :O > On Oct. 27, 2015, 10:20 p.m., Kai Uwe Broulik wrote: > > src/declarativeimports/calendar/daysmodel.cpp, line 184 > >

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

> On Oct. 25, 2015, 10:05 p.m., Thomas Pfeiffer wrote: > > As always: If you want design or usability input, please provide a > > screenshot. We cannot read the code. Thanks. > > Eike Hein wrote: > Thomas, all this does is not grey out the text in Task Manager button > labels when a

Re: Review Request 125817: Add plugin system for Calendar events

> On Oct. 27, 2015, 11:01 p.m., Daniel Vrátil wrote: > > src/declarativeimports/calendar/daysmodel.cpp, line 185 > > > > > > Does it maybe make sense to iterate over the entire set and remove > > *all* events

Re: Review Request 125821: [Kickerdash] Close when opening applet settings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125821/ --- (Updated Okt. 27, 2015, 9:23 nachm.) Status -- This change has been

Re: Review Request 125817: Add plugin system for Calendar events

> On Oct. 27, 2015, 11:01 p.m., Daniel Vrátil wrote: > > src/declarativeimports/calendar/daysmodel.cpp, line 185 > > > > > > Does it maybe make sense to iterate over the entire set and remove > > *all* events

Re: Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/#review87551 --- Aw, sorry, I put in the wrong REVIEW number when committing

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 243 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/243/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Oct 2015 23:32:59 + Build duration: 16 min CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 244 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/244/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Oct 2015 02:37:50 + Build duration: 8 min 44 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 244 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/244/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Oct 2015 02:37:50 + Build duration: 8 min 44 sec CHANGE SET Revision

Re: Review Request 125817: Add plugin system for Calendar events

> On Oct. 27, 2015, 9:44 a.m., Daniel Vrátil wrote: > > One more question/idea that just came to my mind: what about some > > configuration interface? For instance in PIM plugin we would definitely > > want to allow users to disable the plugin completely (some people just > > don't like