[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

2015-11-25 Thread Michael Palimaka via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355892 --- Comment #4 from Michael Palimaka --- How do you expect KDE to fix a problem caused by features removed by upower upstream? -- You are receiving this mail because: You are the assignee for the bug.

Review Request 126168: [IconItem] Don't crash on no icon theme

2015-11-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126168/ --- Review request for Plasma. Bugs: 355577

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

2015-11-25 Thread David Rosca
> On Nov. 2, 2015, 12:05 p.m., Sebastian Kügler wrote: > > I don't like this change, as it introduces a magic constant for a value > > that we completely control our own. (Well, to the degree that we say "a > > gridUnit is roughly the height of a line of text". The 1.6 constant looks > >

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

2015-11-25 Thread Mathieu Roy via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355892 Mathieu Roy changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #5 from

Re: Review Request 126168: [IconItem] Don't crash on no icon theme

2015-11-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126168/#review88833 --- Ship it! src/declarativeimports/core/iconitem.cpp (line

Re: Reminder: your window animations belong to KWin

2015-11-25 Thread Martin Klapetek
On Wed, Nov 25, 2015 at 12:34 PM, David Edmundson < da...@davidedmundson.co.uk> wrote: > it's in QWindow which you inherit from > Oh, my qt-assistant tricked me; I thought it's a top-level class. http://paste.opensuse.org/view/raw/33270855 Cheers -- Martin Klapetek | KDE Developer

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

2015-11-25 Thread Eike Hein
> On Nov. 25, 2015, 1:04 p.m., Eike Hein wrote: > > Ship It! > > David Rosca wrote: > Hmm, it no longer works because the tooltip size is not bound by the > available screen size. > So it needs fix in plasma-framework first. > > Marco Martin wrote: > hmm, can you explain what the

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-25 Thread Aditya Dev Sharma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Nov. 25, 2015, 4:31 p.m.) Review request for Plasma, Ashish

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

2015-11-25 Thread Michael Palimaka via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355892 --- Comment #8 from Michael Palimaka --- (In reply to Mathieu Roy from comment #7) > "Which turns it into a distro problem. Your distribution configured the > system in a way that suspend/hibernate is broken" > > This statement

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-25 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126160/ --- (Updated Nov. 25, 2015, 5:03 p.m.) Review request for Plasma and Martin

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

2015-11-25 Thread Martin Gräßlin via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355892 Martin Gräßlin changed: What|Removed |Added Status|VERIFIED|RESOLVED --- Comment #6

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click

2015-11-25 Thread Sebastian Kügler
> On Nov. 25, 2015, 2:35 p.m., Kai Uwe Broulik wrote: > > I would expect middle clicking to paste. > > Marco Martin wrote: > same here > > David Rosca wrote: > I would expect it to paste the content of X selection, not clipboard. That's at least what happens in the desktop containment

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-25 Thread David Rosca
> On Nov. 25, 2015, 2:08 p.m., Sebastian Kügler wrote: > > src/wizard/pages/pairing.cpp, line 111 > > > > > > The *2 seems fairly random. Can't we set the right minimum width > > derived from the pinNumber?

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-25 Thread David Rosca
> On Nov. 25, 2015, 5:35 p.m., Martin Klapetek wrote: > > As you don't implement your own sizeHint() in the wizard - can you be sure > > that QWizard::sizeHint() will always return sensible value? > > > > As an alternative, you could just scale the font to always fit the wizard. > > That

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126160/#review88841 --- Ship it! Ok, I'll trust you. - Martin Klapetek On Nov.

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

2015-11-25 Thread Mathieu Roy via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355892 --- Comment #9 from Mathieu Roy --- > This statement is wrong. As said earlier, pm-suspend and pm-hibernate works > fine, as they do since years. The statement is correct. It is libupower-glib > that has changed. See the commit for

Re: Review Request 126092: Konqui based Emotion pack named eKspression

2015-11-25 Thread andreas kainz
> On Nov. 25, 2015, 2:13 nachm., Sebastian Kügler wrote: > > This has been shipped, no? no cause there was some rework needed. - andreas --- This is an automatically generated e-mail. To reply, visit:

Re: Reminder: your window animations belong to KWin

2015-11-25 Thread Martin Klapetek
Couple questions: - I have a QQuickWindow which, by the docs, is rendered by OpenGL. Does the same assumptions hold as for animating X11 window? - The suggested KWindowEffects::slideWindow() takes WinId as arg but QQuickWindow has no WinId returning method. Can it still be animated

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-25 Thread Aditya Dev Sharma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Nov. 25, 2015, 4:30 p.m.) Review request for Plasma, Ashish

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

2015-11-25 Thread Mathieu Roy via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355892 Mathieu Roy changed: What|Removed |Added Resolution|DOWNSTREAM |UPSTREAM --- Comment #3 from

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

2015-11-25 Thread Mathieu Roy via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355892 Mathieu Roy changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

2015-11-25 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125908/ --- (Updated Nov. 25, 2015, 4:08 p.m.) Status -- This change has been

Re: Review Request 126168: [IconItem] Don't crash on no icon theme

2015-11-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126168/ --- (Updated Nov. 25, 2015, 5:18 p.m.) Status -- This change has been

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126160/#review88839 --- As you don't implement your own sizeHint() in the wizard -

Review Request 126174: [Task Manager] Add support for Jump Lists

2015-11-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126174/ --- Review request for Plasma, KDE Usability and Eike Hein. Bugs: 339750

Re: Review Request 126174: [Task Manager] Add support for Jump Lists

2015-11-25 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126174/#review88858 --- I don't see any usability problems here. If we add this to

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

2015-11-25 Thread Mathieu Roy via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355892 --- Comment #10 from Mathieu Roy --- I posted this https://yeupou.wordpress.com/2015/11/25/getting-back-suspendresume-with-kde-5s-powerdevil-and-no-systemd-by-installing-an-obsolete-version-of-upower/ that describe step by step how to

Re: Reminder: your window animations belong to KWin

2015-11-25 Thread Marco Martin
On Wednesday 25 November 2015, Martin Klapetek wrote: > Yes, my question is however about the "Desktop and Floating won't have > effect" > note in the docs. What is it about? Will the notification popup be > affected? hmm, is probably a leftover from when it was using the plasma's location enum

Re: Reminder: your window animations belong to KWin

2015-11-25 Thread Marco Martin
On Wednesday 25 November 2015, Martin Klapetek wrote: > - The KWindowEffects::slideWindow() docs say "Desktop and Floating >won't have effect". What is that referring to? The location argument >does not offer such values. So I assume it's about a window type? >How about the

Re: Reminder: your window animations belong to KWin

2015-11-25 Thread David Edmundson
On Wed, Nov 25, 2015 at 5:23 PM, Martin Klapetek wrote: > Couple questions: > > - I have a QQuickWindow which, by the docs, is rendered by OpenGL. >Does the same assumptions hold as for animating X11 window? > > - The suggested KWindowEffects::slideWindow() takes

[Breeze] [Bug 355906] New: Please consider unification for themes' data paths.

2015-11-25 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355906 Bug ID: 355906 Summary: Please consider unification for themes' data paths. Product: Breeze Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED

Re: Reminder: your window animations belong to KWin

2015-11-25 Thread Martin Klapetek
On Wed, Nov 25, 2015 at 1:10 PM, Marco Martin wrote: > On Wednesday 25 November 2015, Martin Klapetek wrote: > > - The KWindowEffects::slideWindow() docs say "Desktop and Floating > >won't have effect". What is that referring to? The location argument > >does not

Review Request 126175: Click on item in plasmashell case focus stays on last pointed item

2015-11-25 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126175/ --- Review request for Plasma. Bugs: 354651

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

2015-11-25 Thread David Rosca
> On Nov. 25, 2015, 1:04 p.m., Eike Hein wrote: > > Ship It! Hmm, it no longer works because the tooltip size is not bound by the available screen size. So it needs fix in plasma-framework first. - David --- This is an automatically

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

2015-11-25 Thread Marco Martin
> On Nov. 25, 2015, 1:04 p.m., Eike Hein wrote: > > Ship It! > > David Rosca wrote: > Hmm, it no longer works because the tooltip size is not bound by the > available screen size. > So it needs fix in plasma-framework first. hmm, can you explain what the problem in tooltip management

Re: Review Request 126149: [Icon widget] Bring back properties dialog

2015-11-25 Thread Marco Martin
> On Nov. 23, 2015, 10:04 p.m., Eike Hein wrote: > > The problem with this is that the old applet had the properties widget > > embedded as a page into the applet config dialog. This probably replaces > > the latter, killing the keyboard shortcut page and making it not possible > > to

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

2015-11-25 Thread Martin Gräßlin via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355892 Martin Gräßlin changed: What|Removed |Added Resolution|--- |DOWNSTREAM

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

2015-11-25 Thread Michael Palimaka via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355892 Michael Palimaka changed: What|Removed |Added CC||kensing...@gentoo.org

Re: Review Request 126064: [DragArea] Add dragActive property

2015-11-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126064/#review88818 --- Ship it! I would be in favor of this - Marco Martin On

Re: Review Request 126126: kicker: always show arrows for items with children

2015-11-25 Thread Marco Martin
> On Nov. 23, 2015, 9:41 a.m., Marco Martin wrote: > > I think currently without arrows does look a bit strange with potential > > usability issues, but with arrows always in will probably indeed look a bit > > cluttered.. > > can you please include a screenshot in such reviews that cause a

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

2015-11-25 Thread David Rosca
> On Nov. 25, 2015, 1:04 p.m., Eike Hein wrote: > > Ship It! > > David Rosca wrote: > Hmm, it no longer works because the tooltip size is not bound by the > available screen size. > So it needs fix in plasma-framework first. > > Marco Martin wrote: > hmm, can you explain what the

Re: Review Request 126149: [Icon widget] Bring back properties dialog

2015-11-25 Thread Kai Uwe Broulik
> On Nov. 23, 2015, 10:04 nachm., Eike Hein wrote: > > The problem with this is that the old applet had the properties widget > > embedded as a page into the applet config dialog. This probably replaces > > the latter, killing the keyboard shortcut page and making it not possible > > to

Re: Review Request 126149: [Icon widget] Bring back properties dialog

2015-11-25 Thread Marco Martin
> On Nov. 23, 2015, 10:04 p.m., Eike Hein wrote: > > The problem with this is that the old applet had the properties widget > > embedded as a page into the applet config dialog. This probably replaces > > the latter, killing the keyboard shortcut page and making it not possible > > to

Re: Review Request 126148: [plasma-framework] qstring optimizations

2015-11-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126148/#review88822 --- Ship it! Ship It! - Marco Martin On Nov. 23, 2015, 10:19

Re: Reminder: your window animations belong to KWin

2015-11-25 Thread Martin Graesslin
On Wednesday, November 25, 2015 12:23:28 PM CET Martin Klapetek wrote: > Couple questions: > > - I have a QQuickWindow which, by the docs, is rendered by OpenGL. >Does the same assumptions hold as for animating X11 window? Yes, it's a window. It doesn't matter how you render to the window,

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

2015-11-25 Thread Martin Gräßlin via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355892 Martin Gräßlin changed: What|Removed |Added Resolution|--- |DOWNSTREAM

[Breeze] [Bug 355879] Some hover tool tips in "Breeze" theme have no contrast (barely readable)

2015-11-25 Thread Hugo Pereira Da Costa via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355879 Hugo Pereira Da Costa changed: What|Removed |Added Component|QStyle |general

[Breeze] [Bug 355879] Some hover tool tips in "Breeze" theme have no contrast (barely readable)

2015-11-25 Thread Frederic Mohr via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355879 --- Comment #8 from Frederic Mohr --- Anything I can do to help with this problem? Any information I can provide? -- You are receiving this mail because: You are the assignee for the bug.

Re: Heads-up: Session management issues

2015-11-25 Thread Sebastian Kügler
On Tuesday, November 24, 2015 11:11:05 PM Andreas Hartmetz wrote: > I've started a thread "Causes of session management problems in Plasma > 5" on kde-core-devel about the session management problems affecting > Plasma 5. ksmserver is part of plasma-workspace but the other involved > parts

Re: Review Request 126163: [Widget Explorer] Make it feel a lot quicker

2015-11-25 Thread Marco Martin
> On Nov. 24, 2015, 11:50 p.m., andreas kainz wrote: > > Should we convert the icons from svg to png? nah, I would like to stylesheet the svgs (patch coming about that actually) since i want to eventually have the default theme following the system colors - Marco

Re: Review Request 126163: [Widget Explorer] Make it feel a lot quicker

2015-11-25 Thread andreas kainz
> On Nov. 24, 2015, 11:50 nachm., andreas kainz wrote: > > Should we convert the icons from svg to png? > > Marco Martin wrote: > nah, I would like to stylesheet the svgs (patch coming about that > actually) since i want to eventually have the default theme following the > system colors

Re: Review Request 126162: taskmanager: Fix sometimes not showing labels in tooltip

2015-11-25 Thread Eike Hein
> On Nov. 25, 2015, 1:01 p.m., Eike Hein wrote: > > Ship It! Please commit the patch with GIT_AUTHOR_NAME/GIT_AUTHOR_EMAIL set to Fabian. - Eike --- This is an automatically generated e-mail. To reply, visit:

Review Request 126165: quickshare: Trigger paste from clipboard action on click

2015-11-25 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126165/ --- Review request for Plasma. Repository: kdeplasma-addons Description

Re: Review Request 126013: fix: kacess should not be built if xkb is not present

2015-11-25 Thread Johan Ouwerkerk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126013/ --- (Updated Nov. 25, 2015, 2:04 p.m.) Status -- This change has been

Re: Review Request 126163: [Widget Explorer] Make it feel a lot quicker

2015-11-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126163/#review88797 --- Ship it!

Re: Review Request 126162: taskmanager: Fix sometimes not showing labels in tooltip

2015-11-25 Thread David Rosca
> On Nov. 25, 2015, 1:01 p.m., Eike Hein wrote: > > Ship It! > > Eike Hein wrote: > Please commit the patch with GIT_AUTHOR_NAME/GIT_AUTHOR_EMAIL set to > Fabian. Is this enough, or do you mean anything else? git commmit --author="Fabian Vogt " - David

Re: Review Request 126162: taskmanager: Fix sometimes not showing labels in tooltip

2015-11-25 Thread Eike Hein
> On Nov. 25, 2015, 1:01 p.m., Eike Hein wrote: > > Ship It! > > Eike Hein wrote: > Please commit the patch with GIT_AUTHOR_NAME/GIT_AUTHOR_EMAIL set to > Fabian. > > David Rosca wrote: > Is this enough, or do you mean anything else? > > git commmit --author="Fabian Vogt

Review Request 126166: use stylesheets in breeze icons

2015-11-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126166/ --- Review request for Plasma, andreas kainz and Uri Herrera. Repository:

Re: Review Request 126162: taskmanager: Fix sometimes not showing labels in tooltip

2015-11-25 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126162/#review88793 --- Ship it! Ship It! - Eike Hein On Nov. 24, 2015, 10:15

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

2015-11-25 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125908/#review88795 --- Ship it! Ship It! - Eike Hein On Nov. 5, 2015, 9:05 a.m.,

Re: Review Request 126163: [Widget Explorer] Make it feel a lot quicker

2015-11-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126163/ --- (Updated Nov. 25, 2015, 1:27 p.m.) Status -- This change has been

Re: Review Request 126166: use stylesheets in breeze icons

2015-11-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126166/#review88799 --- Ship it! Ship It! - Sebastian Kügler On Nov. 25, 2015,

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click

2015-11-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126165/#review88801 --- Not so sure about this: Just clicking on it will publish

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click

2015-11-25 Thread David Rosca
> On Nov. 25, 2015, 2:12 p.m., Sebastian Kügler wrote: > > Not so sure about this: Just clicking on it will publish information on an > > online service, that's hardly what a naive user would expect. On > > middle-click I think it would be fine, but a normal click is usually used > > to open

Re: Review Request 126014: fix: kcms/input and kcms/touchpad should not be built if XInput is not present.

2015-11-25 Thread Johan Ouwerkerk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126014/ --- (Updated Nov. 25, 2015, 2:17 p.m.) Status -- This change has been

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click

2015-11-25 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126165/ --- (Updated Nov. 25, 2015, 2:18 p.m.) Status -- This change has been

Re: Review Request 126064: [DragArea] Add dragActive property

2015-11-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126064/#review88807 --- ping, what's the status of this? - Sebastian Kügler On

Re: Reminder: your window animations belong to KWin

2015-11-25 Thread Sebastian Kügler
On Wednesday, November 25, 2015 03:13:28 PM Martin Graesslin wrote: > So if you want to animate any aspect of the window: talk to me. If you have > code which animates: get rid of it. Trigger for this reminder? (I thought we had gotten rid of that kind of nonsense long time ago.) -- sebas

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

2015-11-25 Thread Mathieu Roy via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355892 Mathieu Roy changed: What|Removed |Added Version|unspecified |5.4.2 -- You are receiving this

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126160/#review88800 --- src/wizard/pages/pairing.cpp (line 111)

Re: Review Request 126162: taskmanager: Fix sometimes not showing labels in tooltip

2015-11-25 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126162/ --- (Updated Nov. 25, 2015, 2:09 p.m.) Status -- This change has been

Re: Review Request 126126: kicker: always show arrows for items with children

2015-11-25 Thread Sebastian Kügler
> On Nov. 23, 2015, 9:41 a.m., Marco Martin wrote: > > I think currently without arrows does look a bit strange with potential > > usability issues, but with arrows always in will probably indeed look a bit > > cluttered.. > > can you please include a screenshot in such reviews that cause a

Reminder: your window animations belong to KWin

2015-11-25 Thread Martin Graesslin
Hi Plasma devs, a small reminder: if you want to animate windows use KWin. You should not animate your windows yourself. Why you might ask? X11 sucks. If you animate using X11 you are moving the window. With each animation step you perform a configure event on the X server. This is then sent

Re: Review Request 126092: Konqui based Emotion pack named eKspression

2015-11-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126092/#review88804 --- This has been shipped, no? - Sebastian Kügler On Nov. 16,

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click

2015-11-25 Thread Aleix Pol Gonzalez
> On Nov. 25, 2015, 3:12 p.m., Sebastian Kügler wrote: > > Not so sure about this: Just clicking on it will publish information on an > > online service, that's hardly what a naive user would expect. On > > middle-click I think it would be fine, but a normal click is usually used > > to open

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click

2015-11-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126165/#review88802 --- Ship it! Looks good! - Aleix Pol Gonzalez On Nov. 25,

Re: Review Request 126061: [Menu] Popup above parent if would exceed screen boundaries

2015-11-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126061/#review88808 --- pingeling, status of this? :) - Sebastian Kügler On Nov.

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click

2015-11-25 Thread Sebastian Kügler
> On Nov. 25, 2015, 2:12 p.m., Sebastian Kügler wrote: > > Not so sure about this: Just clicking on it will publish information on an > > online service, that's hardly what a naive user would expect. On > > middle-click I think it would be fine, but a normal click is usually used > > to open

[Powerdevil] [Bug 355892] New: missing suspend/hibernate with upower 0.99.3 and Devuan

2015-11-25 Thread Mathieu Roy via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355892 Bug ID: 355892 Summary: missing suspend/hibernate with upower 0.99.3 and Devuan Product: Powerdevil Version: unspecified Platform: Debian testing OS: Linux

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click

2015-11-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126165/#review88810 --- I would expect middle clicking to paste. - Kai Uwe Broulik

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click

2015-11-25 Thread Marco Martin
> On Nov. 25, 2015, 2:35 p.m., Kai Uwe Broulik wrote: > > I would expect middle clicking to paste. same here - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126165/#review88810

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click

2015-11-25 Thread David Rosca
> On Nov. 25, 2015, 2:35 p.m., Kai Uwe Broulik wrote: > > I would expect middle clicking to paste. > > Marco Martin wrote: > same here I would expect it to paste the content of X selection, not clipboard. - David --- This is an