Re: Review Request 126187: [Kickoff] Extract i18n also from .js files

2015-11-27 Thread Albert Astals Cid
> On nov. 27, 2015, 6:37 p.m., Marco Martin wrote: > > Ship It! As an addendum: This is not "New messages" it's "already existing but untranslatable messages" - Albert --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 126187: [Kickoff] Extract i18n also from .js files

2015-11-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126187/#review88902 --- Ship it! Ship It! - Marco Martin On Nov. 27, 2015, 6:33

Re: RFC: New KWin effect for notifications

2015-11-27 Thread Marco Martin
On Friday 27 November 2015 08:00:32 Martin Graesslin wrote: > > what would kwin need to do to do this third point in the best/smootest way > > possible? (note this would be utterly useful for plasma tooltips as well) > > It's not really difficult. We need an effect which gets hinted that on >

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-11-27 Thread Simon Wächter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review88898 --- Ship it! Thanks for moving the template macro to the ECM

Review Request 126187: [Kickoff] Extract i18n also from .js files

2015-11-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126187/ --- Review request for Localization and Translation (l10n) and Plasma.

Re: Review Request 126178: [Kicker] Add support for Jump Lists

2015-11-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126178/ --- (Updated Nov. 27, 2015, 6:29 p.m.) Status -- This change has been

Re: Review Request 126179: [Kickoff] Move "Add to/remove from Favorites" option to the end of menu

2015-11-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126179/ --- (Updated Nov. 27, 2015, 6:29 p.m.) Status -- This change has been

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-11-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Nov. 27, 2015, 3:55 p.m.) Review request for KDE Frameworks,

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

2015-11-27 Thread Jonathan Riddell
> On Nov. 23, 2015, 11:21 p.m., Thomas Pfeiffer wrote: > > The interaction seems fine, but since it's a user setting, there should not > > be any polkit request. This would confuse users because they don't expect > > to need admin rights to change their own profile picture. it uses

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

2015-11-27 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126151/#review88893 --- thanks for working on this, looking good. why add

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

2015-11-27 Thread Kai Uwe Broulik
> On Nov. 27, 2015, 2:40 nachm., Jonathan Riddell wrote: > > thanks for working on this, looking good. > > > > why add src/pics/CMakeLists.txt ? I thought the idea was to not install > > into kdm? > > > > remember to accompany this with a commit to plasma-desktop to remove the > > existing

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

2015-11-27 Thread Kai Uwe Broulik
> On Nov. 23, 2015, 11:21 nachm., Thomas Pfeiffer wrote: > > The interaction seems fine, but since it's a user setting, there should not > > be any polkit request. This would confuse users because they don't expect > > to need admin rights to change their own profile picture. > > Jonathan

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-11-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review88896 --- `end*()` shouldn't have anything in the parenthesis.

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

2015-11-27 Thread Jonathan Riddell
> On Nov. 23, 2015, 11:21 p.m., Thomas Pfeiffer wrote: > > The interaction seems fine, but since it's a user setting, there should not > > be any polkit request. This would confuse users because they don't expect > > to need admin rights to change their own profile picture. > > Jonathan

Review Request 126185: Make the KAppTemplate CMake module global

2015-11-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez.

[Breeze] [Bug 356006] New: Breeze GTK does not respect the color scheme

2015-11-27 Thread Mircea Kitsune via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356006 Bug ID: 356006 Summary: Breeze GTK does not respect the color scheme Product: Breeze Version: 5.4.3 Platform: Other OS: Linux Status: UNCONFIRMED Severity:

[Breeze] [Bug 356004] No distinction between the different states applications with breeze-dark with the icons-only task manager

2015-11-27 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356004 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org

Re: Review Request 126148: [plasma-framework] qstring optimizations

2015-11-27 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126148/ --- (Updated Nov. 27, 2015, 8:19 p.m.) Status -- This change has been

[Breeze] [Bug 356004] No distinction between the different states applications with breeze-dark with the icons-only task manager

2015-11-27 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356004 --- Comment #1 from raphael.cazen...@gmail.com --- Please notice these glitchs using 'Breeze Dark' with the classic "Task Manager": http://i.imgur.com/MnjJxqk.png :( -- You are receiving this mail because: You are the assignee for the bug.

[Breeze] [Bug 356004] New: No distinction between the different states applications with breeze-dark with the icons-only task manager

2015-11-27 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356004 Bug ID: 356004 Summary: No distinction between the different states applications with breeze-dark with the icons-only task manager Product: Breeze Version: 5.4.3

Re: Review Request 126175: Click on item in plasmashell case focus stays on last pointed item

2015-11-27 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126175/ --- (Updated Ноев. 28, 2015, 5:28 преди обяд) Review request for Plasma,

Re: Review Request 126175: Click on item in plasmashell case focus stays on last pointed item

2015-11-27 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126175/ --- (Updated Ноев. 28, 2015, 5:30 преди обяд) Review request for Plasma,

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 285 - Fixed!

2015-11-27 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/285/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 27 Nov 2015 14:25:57 + Build duration: 15 min CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 285 - Fixed!

2015-11-27 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/285/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 27 Nov 2015 14:25:57 + Build duration: 15 min CHANGE SET Revision