Re: Review Request 126562: Deal properly with symlinks in path to packages

2015-12-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126562/#review90290 --- Ship it! Ship It! - Marco Martin On Dec. 29, 2015, 3:08

Re: Review Request 126149: [Icon widget] Bring back properties dialog

2015-12-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126149/#review90298 --- I completely screwed up my Kate desktop files :( Would it

Re: Review Request 126348: Make it possible to provide the metadata in json

2015-12-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review90303 --- Ship it! Ship It! - Marco Martin On Dec. 15, 2015, 3:24

Re: Review Request 126562: Deal properly with symlinks in path to packages

2015-12-29 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126562/ --- (Updated Dec. 29, 2015, 4:29 p.m.) Status -- This change has been

Re: Review Request 126562: Deal properly with symlinks in path to packages

2015-12-29 Thread Kevin Ottens
> On Dec. 29, 2015, 3:22 p.m., David Edmundson wrote: > > src/plasmaquick/packageurlinterceptor.cpp, line 93 > > > > > > why the +1? > > > > is it that canonicalFilePath not leave a trailing slash which

Re: Review Request 126278: [Icon Widget] Add support for Jump Lists

2015-12-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126278/#review90299 --- Ping - Kai Uwe Broulik On Dez. 8, 2015, 12:29 nachm., Kai

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-12-29 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #82 from mif...@gmail.com --- Created attachment 96361 --> https://bugs.kde.org/attachment.cgi?id=96361=edit bt And another bt... -- You are receiving this mail because: You are the assignee for the bug.

Re: Review Request 126562: Deal properly with symlinks in path to packages

2015-12-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126562/#review90291 --- Ship it! Thanks for looking into this.

Re: Review Request 126348: Make it possible to provide the metadata in json

2015-12-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review90302 --- Ship it! Ship It! - Sebastian Kügler On Dec. 15, 2015,

[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby

2015-12-29 Thread Gregor Mi via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354250 --- Comment #11 from Gregor Mi --- Reproduced on 5.5.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 126461: Use the SkipGrouping flag for the "widget deleted" notification

2015-12-29 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126461/ --- (Updated Dec. 29, 2015, 8:12 p.m.) Status -- This change has been

Re: Review Request 126517: [ShellManager] Make use of StatusNotifier DrKonqi

2015-12-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126517/ --- (Updated Dez. 29, 2015, 11:10 nachm.) Status -- This change has

Re: robots.txt in quickgit.kde.org

2015-12-29 Thread Ben Cooksley
On Tue, Dec 29, 2015 at 11:16 PM, Kevin Funk wrote: > On Tuesday, December 29, 2015 10:39:01 PM Ben Cooksley wrote: >> On Tue, Dec 29, 2015 at 7:59 AM, Lydia Pintscher wrote: >> > On Sun, Dec 27, 2015 at 12:35 PM, Ben Cooksley wrote: >> >>> Is

Review Request 126570: [Notifications] Highlight the actual event when configuring a notification

2015-12-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126570/ --- Review request for Plasma, KDE Usability and Martin Klapetek.

Re: Review Request 126570: [Notifications] Highlight the actual event when configuring a notification

2015-12-29 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126570/#review90315 --- Great idea! No objections from me. - Thomas Pfeiffer On

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-29 Thread Ken Vermette
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/#review90316 --- In regards to the message displayed (as mentioned in your G+

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-29 Thread Kai Uwe Broulik
> On Dez. 29, 2015, 11:56 nachm., Ken Vermette wrote: > > In regards to the message displayed (as mentioned in your G+ post) how > > about: > > > > "Sorry for the inconvenience. Please report the error to help improve this > > software." I'm quite indifferent on the wording:

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-29 Thread Kai Uwe Broulik
> On Dez. 29, 2015, 11:56 nachm., Ken Vermette wrote: > > In regards to the message displayed (as mentioned in your G+ post) how > > about: > > > > "Sorry for the inconvenience. Please report the error to help improve this > > software." > > Kai Uwe Broulik wrote: > I'm quite indifferent

Re: Review Request 126460: Honor SkipGrouping hint from KNotification

2015-12-29 Thread Martin Klapetek
> On Dec. 21, 2015, 9:38 p.m., David Edmundson wrote: > > Stable too? That would require bumping the required frameworks version from 5.15 to 5.18. - Martin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 126567: [ToolButtonStyle] Always indicate activeFocus

2015-12-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126567/ --- (Updated Dec. 29, 2015, 10:43 p.m.) Status -- This change has been

Review Request 126566: Add "applicationcrash" notification event

2015-12-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126566/ --- Review request for Plasma. Repository: frameworkintegration

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-12-29 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #83 from Martin Klapetek --- Can you check if you have 2 kded5 processes running? Your backtrace again shows no activity at all. That said, please compare the backtrace with the previous ones before you upload a new one,

Re: Review Request 124047: Improve clock's tooltip layout

2015-12-29 Thread Martin Klapetek
> On Dec. 22, 2015, 10:53 p.m., Kai Uwe Broulik wrote: > > It still does not shrink if timezones are removed. > > > > Otherwise looking good. Tips for the shrinking issue? - Martin --- This is an automatically generated e-mail. To

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/ --- (Updated Dez. 29, 2015, 9:19 nachm.) Review request for KDE Frameworks,

Re: Review Request 126566: Add "applicationcrash" notification event

2015-12-29 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126566/#review90308 --- Ship it! Ship It! - Martin Klapetek On Dec. 29, 2015,

Re: Review Request 126566: Add "applicationcrash" notification event

2015-12-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126566/#review90309 --- Ship it! Ship It! - David Edmundson On Dec. 29, 2015,

Review Request 126567: [ToolButtonStyle] Always indicate activeFocus

2015-12-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126567/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 126092: Konqui based Emotion pack named eKspression

2015-12-29 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126092/#review90304 --- Are you sure this is the updated pack? I see the exact same

Re: Review Request 126567: [ToolButtonStyle] Always indicate activeFocus

2015-12-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126567/#review90314 --- Ship it! Ship It! - Marco Martin On Dec. 29, 2015, 10:04

Re: Review Request 126278: [Icon Widget] Add support for Jump Lists

2015-12-29 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126278/#review90322 --- Ship it! Ship It! - Bhushan Shah On Dec. 8, 2015, 5:59

Re: Review Request 126548: Kill PowerDevil runner

2015-12-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126548/#review90270 --- i use sleep/hibernate from there too (have neither

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Dec. 29, 2015, 9:34 a.m.) Status -- This change has been

Re: robots.txt in quickgit.kde.org

2015-12-29 Thread Ben Cooksley
On Tue, Dec 29, 2015 at 7:59 AM, Lydia Pintscher wrote: > On Sun, Dec 27, 2015 at 12:35 PM, Ben Cooksley wrote: >>> Is there some place where search engines can easily index our source >>> code or are we shooting ourselves in the foot here? >> >> We could

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 28 - Still Failing!

2015-12-29 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/28/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 29 Dec 2015 13:54:40 + Build duration: 1 min 38 sec CHANGE SET Revision

Review Request 126562: Deal properly with symlinks in path to packages

2015-12-29 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126562/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 126559: dark colorscheme option for cuttlefish

2015-12-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126559/#review90279 --- Ship it! Ship It! - David Edmundson On Dec. 29, 2015,

Re: Review Request 124204: Use proper relative paths to import js code

2015-12-29 Thread David Edmundson
> On Dec. 29, 2015, 1:36 p.m., Marco Martin wrote: > > this still seems to cause issues for some people. > > May this series of patches be worth to push anyways? >this still seems to cause issues for some people. Where have you seen that? I don't recall seeing any bug reports. - David

Re: robots.txt in quickgit.kde.org

2015-12-29 Thread Ashish Bansal
On Tue, Dec 29, 2015 at 3:09 PM, Ben Cooksley wrote: > On Tue, Dec 29, 2015 at 7:59 AM, Lydia Pintscher wrote: > > On Sun, Dec 27, 2015 at 12:35 PM, Ben Cooksley > wrote: > >>> Is there some place where search engines can easily index our

Re: Review Request 124204: Use proper relative paths to import js code

2015-12-29 Thread Marco Martin
> On Dec. 29, 2015, 1:36 p.m., Marco Martin wrote: > > this still seems to cause issues for some people. > > May this series of patches be worth to push anyways? > > David Edmundson wrote: > >this still seems to cause issues for some people. > > Where have you seen that? > I

Re: Review Request 126557: use the new KDEPackageAppTemplates ECM module

2015-12-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126557/ --- (Updated Dec. 29, 2015, 2:42 p.m.) Status -- This change has been

Re: Review Request 126557: use the new KDEPackageAppTemplates ECM module

2015-12-29 Thread Marco Martin
> On Dec. 29, 2015, 2:37 p.m., David Edmundson wrote: > > CMakeLists.txt, line 7 > > > > > > is this still right? hmm, nope, updating to 18 - Marco ---

Re: Review Request 126557: use the new KDEPackageAppTemplates ECM module

2015-12-29 Thread Marco Martin
> On Dec. 29, 2015, 2:37 p.m., David Edmundson wrote: > > CMakeLists.txt, line 7 > > > > > > is this still right? > > Marco Martin wrote: > hmm, nope, updating to 18 aww, shit, mixed up the commit with

Re: Review Request 124205: Use proper relative paths to import js code

2015-12-29 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124205/ --- (Updated Dec. 29, 2015, 3:01 p.m.) Status -- This change has been

Re: Review Request 124204: Use proper relative paths to import js code

2015-12-29 Thread Kevin Ottens
> On Dec. 29, 2015, 1:36 p.m., Marco Martin wrote: > > this still seems to cause issues for some people. > > May this series of patches be worth to push anyways? > > David Edmundson wrote: > >this still seems to cause issues for some people. > > Where have you seen that? > I

Re: Review Request 124204: Use proper relative paths to import js code

2015-12-29 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124204/ --- (Updated Dec. 29, 2015, 3:01 p.m.) Status -- This change has been

Re: Review Request 124206: Use proper relative paths to import js code

2015-12-29 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124206/ --- (Updated Dec. 29, 2015, 3:01 p.m.) Status -- This change has been

Review Request 126557: use the new KDEPackageAppTemplates ECM module

2015-12-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126557/ --- Review request for Plasma. Repository: plasma-framework Description

Re: robots.txt in quickgit.kde.org

2015-12-29 Thread Kåre Särs
On Tuesday, December 29, 2015 10:39:01 PM Ben Cooksley wrote: > On Tue, Dec 29, 2015 at 7:59 AM, Lydia Pintscher wrote: > > On Sun, Dec 27, 2015 at 12:35 PM, Ben Cooksley wrote: > >>> Is there some place where search engines can easily index our source > >>>

Re: Review Request 124204: Use proper relative paths to import js code

2015-12-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124204/#review90278 --- this still seems to cause issues for some people. May this

Re: Review Request 126559: dark colorscheme option for cuttlefish

2015-12-29 Thread Marco Martin
> On Dec. 29, 2015, 2:32 p.m., David Edmundson wrote: > > cuttlefish/package/contents/ui/Tools.qml, line 130 > > > > > > may be better to make the text be more like: ComplementaryColorGroup > > > > > >

Re: Review Request 126559: dark colorscheme option for cuttlefish

2015-12-29 Thread David Edmundson
> On Dec. 29, 2015, 2:32 p.m., David Edmundson wrote: > > cuttlefish/package/contents/ui/Tools.qml, line 130 > > > > > > may be better to make the text be more like: ComplementaryColorGroup > > > > > >

Re: Review Request 124207: Use proper relative paths to import js code

2015-12-29 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124207/ --- (Updated Dec. 29, 2015, 3:01 p.m.) Status -- This change has been

Review Request 126559: dark colorscheme option for cuttlefish

2015-12-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126559/ --- Review request for Plasma. Repository: plasma-sdk Description ---

Re: Review Request 126559: dark colorscheme option for cuttlefish

2015-12-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126559/#review90283 --- cuttlefish/package/contents/ui/Tools.qml (line 130)

Re: Review Request 126557: use the new KDEPackageAppTemplates ECM module

2015-12-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126557/#review90286 --- Ship it! CMakeLists.txt (line 7)

Re: Review Request 126559: dark colorscheme option for cuttlefish

2015-12-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126559/ --- (Updated Dec. 29, 2015, 2:51 p.m.) Status -- This change has been