Re: Review Request 126570: [Notifications] Highlight the actual event when configuring a notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126570/ --- (Updated Dec. 30, 2015, 5:05 p.m.) Status -- This change has been

Re: Review Request 126576: Don't emit signals in another object from panel.

On Dec. 30, 2015, 12:52 p.m., David Edmundson wrote: > > The rest LGTM. Thanks. You're right it's unrelated. Removed for now. - David --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 126570: [Notifications] Highlight the actual event when configuring a notification

> On Dec. 30, 2015, 12:49 p.m., David Edmundson wrote: > > Ship It! This requires frameworks 5.18 (because of the KNotifyConfig changes), so it should bump the required frameworks version, otherwise build failures will happen. - Martin

Re: Review Request 126573: Don't duplicate checking content length is within user set bounds

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126573/ --- (Updated Dec. 30, 2015, 4:11 p.m.) Status -- This change has been

Re: Review Request 126513: Refactor kcm touchpad to fix some issue related to hotplug touchpad

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126513/#review90350 --- ping :) - Xuetian Weng On Dec. 25, 2015, 7:02 p.m.,

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 354 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/354/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 30 Dec 2015 16:10:38 + Build duration: 5 min 1 sec CHANGE SET Revision

Re: Review Request 126579: [Kickoff/Kicker] Extract underlying URL from search result

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126579/#review90359 --- +1 - David Edmundson On Dec. 30, 2015, 7:09 p.m., Kai Uwe

Review Request 126579: [Kickoff/Kicker] Extract underlying URL from search result

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126579/ --- Review request for Plasma and Eike Hein. Repository: plasma-desktop

Review Request 126578: [Kickoff/Kicker] Add context menu actions for search results

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126578/ --- Review request for Plasma, KDE Usability and Eike Hein. Repository:

Re: Review Request 126373: change the taskbar color from blue to gray

> On Dec. 20, 2015, 8:45 p.m., Eike Hein wrote: > > General PSA: I will soon push a fixed-up version of tasks.svgz to the repo > > that cleans up all the random margins and inconsistent corner styles in it > > that currently mess up alignments inside and outside of task buttons as > > well as

Re: Review Request 126356: change minimum size of clipboard

> On Dec. 15, 2015, 2:29 p.m., Martin Gräßlin wrote: > > applets/clipboard/contents/ui/clipboard.qml, line 69 > > > > > > this is not the actual size of the systray, but a hardcoded value which > > might match

Re: Review Request 126092: Konqui based Emotion pack named eKspression

> On Dec. 29, 2015, 7:56 p.m., Martin Klapetek wrote: > > Are you sure this is the updated pack? I see the exact same icons as in the > > first round. Andrea del sarto please upload the updated emoticons or send them to me. thanks - andreas

Re: Review Request 126574: Don't adjust thickness twice

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126574/ --- (Updated Dec. 30, 2015, 4:10 p.m.) Status -- This change has been

Re: Review Request 126576: Don't emit signals in another object from panel.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126576/ --- (Updated Dec. 30, 2015, 4:10 p.m.) Status -- This change has been

Re: Review Request 126575: Add missing emit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126575/ --- (Updated Dec. 30, 2015, 4:10 p.m.) Status -- This change has been

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 356 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/356/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 30 Dec 2015 17:05:34 + Build duration: 5 min 44 sec CHANGE SET Revision

Re: Review Request 126578: [Kickoff/Kicker] Add context menu actions for search results

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126578/#review90361 --- Looks great, no objections! - Thomas Pfeiffer On Dec. 30,

Review Request 126573: Don't duplicate checking content length is within user set bounds

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126573/ --- Review request for Plasma. Repository: plasma-desktop Description

Review Request 126575: Add missing emit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126575/ --- Review request for Plasma. Repository: plasma-workspace Description

Review Request 126574: Don't adjust thickness twice

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126574/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 126570: [Notifications] Highlight the actual event when configuring a notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126570/#review90333 --- Ship it! Ship It! - David Edmundson On Dec. 29, 2015,

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 353 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/353/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 30 Dec 2015 09:43:00 + Build duration: 5 min 4 sec CHANGE SET Revision

Review Request 126577: Update battery.svgz

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126577/ --- Review request for Plasma and Uri Herrera. Bugs: 356380

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 29 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/29/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 30 Dec 2015 12:20:23 + Build duration: 49 sec CHANGE SET Revision

Review Request 126576: Don't emit signals in another object from panel.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126576/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 126573: Don't duplicate checking content length is within user set bounds

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126573/#review90336 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 30, 2015,

kde/workspace repos on phabricator

Hello people, Just quick-ish update that kde/workspace repos are imported into phabricator, so I think its time we should start using phabricator for reviews. Thanks! -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___

Re: Review Request 126575: Add missing emit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126575/#review90337 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 30, 2015,

Re: kde/workspace repos on phabricator

Oh, happy day :) Cheerio, Ivan -- KDE, ivan.cu...@kde.org, http://cukic.co/ gpg key id: 850B6F76 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126576: Don't emit signals in another object from panel.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126576/#review90338 --- shell/panelview.cpp

Re: Review Request 126577: Update battery.svgz

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126577/#review90340 --- Ship it! Ship It! - David Edmundson On Dec. 30, 2015,

Re: Review Request 126577: Update battery.svgz

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126577/#review90342 --- Ship it! Ship It! - Marco Martin On Dec. 30, 2015, 1:39

Re: Review Request 126576: Don't emit signals in another object from panel.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126576/#review90343 --- Ship it! looks good, i'm also not 100% convinced by the

Re: kde/workspace repos on phabricator

On Wednesday 30 December 2015 17:53:36 Bhushan Shah wrote: > Hello people, > > Just quick-ish update that kde/workspace repos are imported into > phabricator, so I think its time we should start using phabricator for > reviews. should them be forcefully removed from reviewboard now? (otherwise,