Review Request 126946: ShowDesktop is not synchronized

2016-02-01 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126946/ --- Review request for Plasma, David Edmundson, Martin Gräßlin, and Marco

Re: Review Request 126952: Set layout in kickoff config properly

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126952/#review91895 --- applets/kickoff/package/contents/ui/ConfigGeneral.qml (line

Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126949/ --- Review request for KDE Frameworks and Plasma. Bugs: 358533

Re: Review Request 126593: [Task Manager] Add Jump List actions to grouped tasks

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126593/#review91872 --- I've seen that I can actually pass a QList to

Re: Review Request 126950: Fix kicker userExtraRunners

2016-02-01 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126950/#review91894 --- Ship it! Ship It! - Martin Klapetek On Feb. 1, 2016,

Review Request 126953: Remove Theme Details KCM

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126953/ --- Review request for Plasma, KDE Usability and Andrew Lake. Repository:

Review Request 126947: [Shell] Make Applet/ContainmentConfig transient for DesktopView

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126947/ --- Review request for Plasma and Martin Gräßlin. Repository:

Review Request 126956: [Desktop Containment] Remove custom tooltip delegate

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126956/ --- Review request for Plasma and Eike Hein. Repository: plasma-desktop

Re: Review Request 126954: [Notifications] Fix Job finished persistency

2016-02-01 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126954/#review91890 --- Ship it! Thanks - Martin Klapetek On Feb. 1, 2016,

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Martin Klapetek
> On Feb. 1, 2016, 8:39 p.m., Boudhayan Gupta wrote: > > +1 > > > > Ideally the default look-n-feel package should include only two themes - > > the default one and a high-contrast counterpart. In fact all other themes > > should reside elsewhere. > > > > If we still want to "officially"

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread andreas kainz
> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > >

Re: KDE papercuts love

2016-02-01 Thread josephk
ok, I filed some of these minor bugs https://bugs.kde.org/show_bug.cgi?id=358532 https://bugs.kde.org/show_bug.cgi?id=358533 https://bugs.kde.org/show_bug.cgi?id=358534 https://bugs.kde.org/show_bug.cgi?id=358535 https://bugs.kde.org/show_bug.cgi?id=358536 Cheers

Review Request 126954: [Notifications] Fix Job finished persistency

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126954/ --- Review request for Plasma and Martin Klapetek. Repository:

Re: Review Request 126954: [Notifications] Fix Job finished persistency

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126954/ --- (Updated Feb. 1, 2016, 9:02 p.m.) Status -- This change has been

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126949/#review91874 --- +1 Ideally the default look-n-feel package should include

Re: Review Request 126953: Remove Theme Details KCM

2016-02-01 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126953/#review91886 --- Ship it! +1 from me! - Andrew Lake On Feb. 1, 2016,

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/#review91889 --- src/declarativeimports/calendar/daysmodel.cpp (line 135)

Re: Review Request 126952: Set layout in kickoff config properly

2016-02-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126952/ --- (Updated Feb. 1, 2016, 11:20 p.m.) Review request for Plasma.

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-01 Thread andreas kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126960/#review91904 --- can you add an screenshot with the week names? - andreas

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126949/#review91878 --- Ship it! Ship It! - David Edmundson On Feb. 1, 2016,

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-02-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/#review91881 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 17,

Re: Review Request 126957: [FolderView] Show title in tooltip

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126957/ --- (Updated Feb. 1, 2016, 10:52 p.m.) Status -- This change has been

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread andreas kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126949/#review91883 --- Hi, I know I say I will keep oxygen-icons5 up to date, and I

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Kai Uwe Broulik
> On Feb. 1, 2016, 8:12 nachm., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > >

Review Request 126957: [FolderView] Show title in tooltip

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126957/ --- Review request for Plasma and Eike Hein. Repository: plasma-desktop

Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126960/ --- Review request for Plasma and KDE Usability. Bugs: 336124, 348362 and

Re: Review Request 126950: Fix kicker userExtraRunners

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126950/#review91896 --- applets/kicker/package/contents/ui/main.qml (line 149)

Review Request 126951: Clone useExtraRunners config option from kicker to kickoff

2016-02-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126951/ --- Review request for Plasma. Repository: plasma-desktop Description

Review Request 126952: Set layout in kickoff config properly

2016-02-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126952/ --- Review request for Plasma. Repository: plasma-desktop Description

Review Request 126950: Fix kicker userExtraRunners

2016-02-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126950/ --- Review request for Plasma. Repository: plasma-desktop Description

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread andreas kainz
> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > >

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-02-01 Thread Aleix Pol Gonzalez
> On Feb. 1, 2016, 10 p.m., Kai Uwe Broulik wrote: > > src/declarativeimports/plasmaextracomponents/plasmaextracomponentsplugin.cpp, > > line 34 > > > > > > I thought QLatin1String was better for comparison? +1

Re: Review Request 126947: [Shell] Make Applet/ContainmentConfig transient for DesktopView

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126947/ --- (Updated Feb. 1, 2016, 9:06 p.m.) Status -- This change has been

Re: Review Request 126951: Clone useExtraRunners config option from kicker to kickoff

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126951/#review91897 --- Ship it! Ship It! - Kai Uwe Broulik On Feb. 1, 2016,

plasma icons and system settings icons

2016-02-01 Thread kainz.a
plasma ship there own icons and as all other kf5 applications the master section for icons are in the system settings defined. The problem is that some distributions ship there own plasma theme (with icons) but use breeze-icons as there icon set. so if they add an distribution specific plasma

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Martin Klapetek
> On Feb. 1, 2016, 9:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > >

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126960/ --- (Updated Feb. 1, 2016, 11:12 nachm.) Review request for Plasma and KDE

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Kai Uwe Broulik
> On Feb. 1, 2016, 7:39 nachm., Boudhayan Gupta wrote: > > +1 > > > > Ideally the default look-n-feel package should include only two themes - > > the default one and a high-contrast counterpart. In fact all other themes > > should reside elsewhere. > > > > If we still want to "officially"

Re: Review Request 126957: [FolderView] Show title in tooltip

2016-02-01 Thread andreas kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126957/#review91901 --- Ship it! Ship It! - andreas kainz On Feb. 1, 2016,

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread andreas kainz
> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > >

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread David Edmundson
> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > >

Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126961/ --- Review request for Plasma. Repository: plasma-workspace Description

Plasma Bugs - a stricter approach

2016-02-01 Thread David Edmundson
I am sick of the current distribution of Plasma bug triage/fixing. [1]. I've brought it up many many times in every meeting and no-one has done anything except talk. Bugs are the most important part of making a quality product, which is our ultimate goal. Bug triage and fixing is a crucial part

Re: Review Request 126946: ShowDesktop is not synchronized

2016-02-01 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126946/#review91909 --- Ship it! Ship It! - Sebastian Kügler On Feb. 1, 2016,

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126961/#review91912 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 2,

Re: Review Request 126956: [Desktop Containment] Remove custom tooltip delegate

2016-02-01 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126956/#review91913 --- > I don't see why we would need this. Eike will be back in

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-01 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126960/#review91907 --- Nice improvement. If the week numbers look ok then +1 from

[Powerdevil] [Bug 345208] OSD not updating when keeping brightness keys pressed.

2016-02-01 Thread Antonis G . via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=345208 Antonis G. changed: What|Removed |Added Resolution|--- |FIXED

Re: Review Request 126957: [FolderView] Show title in tooltip

2016-02-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126957/#review91900 --- Ship it! Ship It! - David Edmundson On Feb. 1, 2016,

Re: Review Request 126953: Remove Theme Details KCM

2016-02-01 Thread andreas kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126953/#review91898 --- Ship it! +1 from me would it be possible to change the

Re: Review Request 126946: ShowDesktop is not synchronized

2016-02-01 Thread Sebastian Kügler
> On Feb. 2, 2016, 12:54 a.m., Sebastian Kügler wrote: > > Ship It! For bonus points, you could check if there's any X11 usage in the applet otherwise, and if not, remove the m_isX11 and HAVE_X11 conditionals. This is nicely abstracted in KWindowSystem now, the code there is a bit dated in

Re: Review Request 126906: Simplified fullscreen blur for Application Dashboard

2016-02-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126906/ --- (Updated Feb. 1, 2016, 8:44 a.m.) Status -- This change has been

KActivitiesStats framework for review

2016-02-01 Thread Ivan Čukić
Hi all, There is a new framework-to-be under review. Until now, it was used in plasma (and shipped with plasma, although it was developed in kactivities repository - strange setup, but we somehow managed). To avoid collisions, it was previously known under the KActivitiesExperimentalStats name,

Re: Review Request 126930: sddm theme: Add keyboard layout button

2016-02-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126930/#review91811 --- >Btw, there is a comment saying that password input must be

Re: Review Request 126937: [KWindowSystemProxy] Add setter for showingDesktop

2016-02-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126937/#review91833 --- Ship it! > but the greeter window stayed there no matter

Re: Review Request 126906: Simplified fullscreen blur for Application Dashboard

2016-02-01 Thread Martin Gräßlin
> On Jan. 27, 2016, 6:22 p.m., Thomas Lübking wrote: > > effects/blur/blur.cpp, line 474 > > > > > > Did you try the behavior on a varying scene? > > > > Generating mipmaps isn't exactly cheap and

Re: Review Request 125793: [Task Manager] Add proper close button to tooltip

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125793/ --- (Updated Feb. 1, 2016, 11:06 vorm.) Status -- This change has been

Review Request 126942: LockScreen: Don't show layout variant in keyboard layout button

2016-02-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126942/ --- Review request for Plasma and Kai Uwe Broulik. Repository:

Re: Review Request 126942: LockScreen: Don't show layout variant in keyboard layout button

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126942/#review91839 --- That would give me "de" and "de" for "de(nodeadkeys)" and

[Differential] [Accepted] D884: Async variant to check whether power management is inhibited

2016-02-01 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Not really happy with 3rd party using InhibitionsChanged signal because I find it quite horrible in retrospect, and will probably need to change it for our future Inhibitions plasmoid

Re: Review Request 126143: [ksmserver] Fall back to session runner if UserSwitcher.qml is broken

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126143/ --- (Updated Feb. 1, 2016, 11:04 vorm.) Status -- This change has been

Re: Review Request 126942: LockScreen: Don't show layout variant in keyboard layout button

2016-02-01 Thread David Rosca
> On Feb. 1, 2016, 11:10 a.m., Kai Uwe Broulik wrote: > > That would give me "de" and "de" for "de(nodeadkeys)" and "de(neo)" Hm, that's true. So it won't be that easy and will need to modify `org.kde.keyboard` api. - David --- This

Re: Review Request 126942: LockScreen: Don't show layout variant in keyboard layout button

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126942/#review91843 --- > but tooltip: "str" has no effect. That's because

Re: Review Request 126938: [Widget Explorer] Show desktop on dragging widget

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126938/#review91844 --- Would it make sense to mark the applet ConfigView transient

Re: Review Request 126942: LockScreen: Don't show layout variant in keyboard layout button

2016-02-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126942/ --- (Updated Feb. 1, 2016, 11:14 a.m.) Status -- This change has been

Re: Review Request 126938: [Widget Explorer] Show desktop on dragging widget

2016-02-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126938/#review91846 --- Ship it! Ship It! - Marco Martin On Feb. 1, 2016,

Re: Review Request 126938: [Widget Explorer] Show desktop on dragging widget

2016-02-01 Thread Marco Martin
> On Feb. 1, 2016, 11:36 a.m., Kai Uwe Broulik wrote: > > Would it make sense to mark the applet ConfigView transient to the > > DesktopView? yes - Marco --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 126944: LockScreen: Use layout display name in KeyboardLayoutButton

2016-02-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126944/ --- (Updated Feb. 1, 2016, 2:02 p.m.) Status -- This change has been

Re: Review Request 126938: [Widget Explorer] Show desktop on dragging widget

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126938/ --- (Updated Feb. 1, 2016, 3:36 p.m.) Status -- This change has been

Re: Review Request 126930: sddm theme: Add keyboard layout button

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126930/#review91835 --- +1 If you're at it, could you perhaps have a look at the

Re: Review Request 126930: sddm theme: Add keyboard layout button

2016-02-01 Thread David Rosca
> On Feb. 1, 2016, 9:45 a.m., Kai Uwe Broulik wrote: > > +1 > > > > If you're at it, could you perhaps have a look at the code that generates > > the label? :) In system tray and OSD it says "neo" and "de" for me whereas > > the lockscreen says "de(nodeadkeys)" which makes the button super

Re: Review Request 126937: [KWindowSystemProxy] Add setter for showingDesktop

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126937/ --- (Updated Feb. 1, 2016, 10:29 a.m.) Status -- This change has been

[Powerdevil] [Bug 358859] New: Screen not always locked when lid closed

2016-02-01 Thread Olivier Churlaud via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358859 Bug ID: 358859 Summary: Screen not always locked when lid closed Product: Powerdevil Version: 5.5.4 Platform: Other OS: Linux Status: UNCONFIRMED Severity:

[Powerdevil] [Bug 358859] Screen not always locked when lid closed

2016-02-01 Thread Olivier Churlaud via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358859 --- Comment #1 from Olivier Churlaud --- next time it happens I'll send the journalctl concerned part.. -- You are receiving this mail because: You are the assignee for the bug. ___

[kscreenlocker] [Bug 358859] Screen not always locked when lid closed

2016-02-01 Thread Martin Gräßlin via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358859 Martin Gräßlin changed: What|Removed |Added Product|Powerdevil |kscreenlocker

[Powerdevil] [Bug 349750] Laptop does not suspend when lid closed in lock screen

2016-02-01 Thread Olivier Churlaud via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=349750 Olivier Churlaud changed: What|Removed |Added CC||oliv...@churlaud.com

[Powerdevil] [Bug 358859] Screen not always locked when lid closed

2016-02-01 Thread Olivier Churlaud via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358859 Olivier Churlaud changed: What|Removed |Added Platform|Other |Archlinux Packages --

[Powerdevil] [Bug 349750] Laptop does not suspend when lid closed in lock screen

2016-02-01 Thread Olivier Churlaud via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=349750 --- Comment #3 from Olivier Churlaud --- Oups wrong thread... please forget this last one... -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel

Re: Review Request 126930: sddm theme: Add keyboard layout button

2016-02-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126930/ --- (Updated Feb. 1, 2016, 10:17 a.m.) Review request for Plasma.

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Hugo Pereira Da Costa
> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > >

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126949/#review91876 --- +1 - Kai Uwe Broulik On Feb. 1, 2016, 7:30 nachm., Martin

Re: Review Request 126947: [Shell] Make Applet/ContainmentConfig transient for DesktopView

2016-02-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126947/#review91870 --- Ship it! Ship It! - David Edmundson On Feb. 1, 2016,

Re: Review Request 126938: [Widget Explorer] Show desktop on dragging widget

2016-02-01 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126938/#review91848 --- Yup, makes sense! - Thomas Pfeiffer On Feb. 1, 2016,

Review Request 126944: LockScreen: Use layout display name in KeyboardLayoutButton

2016-02-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126944/ --- Review request for Plasma. Repository: plasma-workspace Description

Review Request 126943: Add getLayoutDisplayName to keyboard layouts DBus API

2016-02-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126943/ --- Review request for Plasma. Repository: plasma-desktop Description

Re: Review Request 126944: LockScreen: Use layout display name in KeyboardLayoutButton

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126944/#review91849 --- +1 components/keyboardlayout/keyboardlayout.cpp (lines 85

Re: Review Request 126944: LockScreen: Use layout display name in KeyboardLayoutButton

2016-02-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126944/ --- (Updated Feb. 1, 2016, 1:16 p.m.) Review request for Plasma.

Re: Review Request 126944: LockScreen: Use layout display name in KeyboardLayoutButton

2016-02-01 Thread David Rosca
> On Feb. 1, 2016, 1:12 p.m., Kai Uwe Broulik wrote: > > components/keyboardlayout/keyboardlayout.cpp, line 92 > > > > > > You can use a lambda The rest of the file is using slots, so I went with slot too. -

Re: Review Request 126943: Add getLayoutDisplayName to keyboard layouts DBus API

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126943/#review91851 --- Ship it! Ship It! - Kai Uwe Broulik On Feb. 1, 2016,

Re: Review Request 126944: LockScreen: Use layout display name in KeyboardLayoutButton

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126944/#review91852 --- Ship it! Ship It! - Kai Uwe Broulik On Feb. 1, 2016,

Re: Review Request 126943: Add getLayoutDisplayName to keyboard layouts DBus API

2016-02-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126943/ --- (Updated Feb. 1, 2016, 1:57 p.m.) Status -- This change has been

[Differential] [Closed] D884: Async variant to check whether power management is inhibited

2016-02-01 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREENLOCKER4e9dce5f0e07: Async variant to check whether power management is inhibited (authored by graesslin). REPOSITORY rKSCREENLOCKER KScreenLocker CHANGES SINCE LAST UPDATE