[Differential] [Updated] D947: Fix path of kcheckpass when pass to chown

graesslin added a comment. are you installing to $HOME with root? Because I think it fails as you are not allowed to chown to root. Anyway another option could be to just scratch that command as it's no longer needed on modern distros. REPOSITORY rKSCREENLOCKER KScreenLocker

Re: Review Request 127083: Disk Quota: "No quota restrictions found." instead of empty space

> On Feb. 15, 2016, 9:15 p.m., David Edmundson wrote: > > Ship It! David: Can you cherry-pick 71eb4801d1f2771915ae49b0423eef1f6aecf6e1 to older branches as required? Would be awesome! - Dominik --- This is an automatically generated

Re: Review Request 127083: Disk Quota: "No quota restrictions found." instead of empty space

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127083/ --- (Updated Feb. 15, 2016, 9:21 p.m.) Status -- This change has been

Re: Review Request 127083: Disk Quota: "No quota restrictions found." instead of empty space

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127083/#review92416 --- Ship it! Ship It! - David Edmundson On Feb. 15, 2016,

Review Request 127083: Disk Quota: "No quota restrictions found." instead of empty space

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127083/ --- Review request for Plasma and Kai Uwe Broulik. Bugs: 357699

[Differential] [Request, 3 lines] D951: PanelShadow: Don't remove shadows from destroyed windows

drosca created this revision. drosca added reviewers: Plasma, graesslin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY If the window's platform surface was destroyed, there is also no shadow to be removed. Both X and Wayland code will try to

Disk Quota Applet: Icon sizes

Hi all, the disk quota applet's icons are still too big, see http://i.imgur.com/cBVPXuu.png At Akademy 2015, I was asking some developers what do do about it, but noone could give me hint. Since these icons are *really* too big, I think we should do something about it at least now. Obviously

[Differential] [Request, 1 line] D950: Fix size of drop placeholder after moving larger applet

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY placeHolder.syncWithItem() sets minimumWidth/minimumHeight when moving applets, so we must clear it when using placeholder for drop

[Differential] [Updated, 51 lines] D948: Don't show applet handle outside of desktop

drosca updated this revision to Diff 2311. drosca added a comment. x, y coords should be bound by available rect size REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D948?vs=2309=2311 BRANCH handle-position (branched from master)

Re: Review Request 127075: Prefer other containments than desktop in containmentAt()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127075/ --- (Updated Feb. 15, 2016, 6:10 p.m.) Status -- This change has been

Re: Review Request 127072: WindowThumbnail: Discard glx pixmap in stopRedirecting()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127072/ --- (Updated Feb. 15, 2016, 6:10 p.m.) Status -- This change has been

Re: Review Request 127075: Prefer other containments than desktop in containmentAt()

> On Feb. 15, 2016, 5:58 p.m., Kai Uwe Broulik wrote: > > src/scriptengines/qml/plasmoid/containmentinterface.cpp, line 273 > > > > > > Q_NULLPTR in Frameworks Fixed in push - David

[Differential] [Accepted] D948: Don't show applet handle outside of desktop

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH handle-position (branched from master) REVISION DETAIL https://phabricator.kde.org/D948 EMAIL PREFERENCES

Re: Review Request 127075: Prefer other containments than desktop in containmentAt()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127075/#review92412 --- src/scriptengines/qml/plasmoid/containmentinterface.cpp

Re: Review Request 127079: fix uninitialised var

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127079/#review92411 --- src/declarativeimports/platformcomponents/application_p.h

[Differential] [Request, 51 lines] D948: Don't show applet handle outside of desktop

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY This makes sure the applet handle won't be displayed outside of available desktop area (under panels or outside of screen). BUG: 353992

Review Request 127079: fix uninitialised var

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127079/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

> On Feb. 15, 2016, 4:29 p.m., David Edmundson wrote: > > src/plasmaquick/appletquickitem.cpp, line 736 > > > > > > if that's the case, filter on event->child()->metaObject.className() > > > > rather

[Differential] [Updated, 2 lines] D947: Fix path of kcheckpass when pass to chown

kfunk updated this revision to Diff 2307. kfunk added a comment. Fix message REPOSITORY rKSCREENLOCKER KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D947?vs=2306=2307 BRANCH master REVISION DETAIL https://phabricator.kde.org/D947 AFFECTED FILES

Re: Review Request 127075: Prefer other containments than desktop in containmentAt()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127075/#review92410 --- Ship it! Ship It! - Marco Martin On Feb. 14, 2016,

[Differential] [Updated] D947: Fix path of kcheckpass when pass to chown

kfunk added a reviewer: graesslin. REPOSITORY rKSCREENLOCKER KScreenLocker REVISION DETAIL https://phabricator.kde.org/D947 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, graesslin Cc: plasma-devel ___

[Differential] [Request, 2 lines] D947: Fix path of kcheckpass when pass to chown

kfunk created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Now this still fails for me when installing kscreenlocker to $HOME: chown: changing ownership of

Re: Review Request 127075: Prefer other containments than desktop in containmentAt()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127075/#review92407 --- Ship it! Ship It! - David Edmundson On Feb. 14, 2016,

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127073/#review92406 --- src/plasmaquick/appletquickitem.cpp (line 736)

Re: [PATCH] [RFC] make handles obscure less of the screen behind them

On Sunday 14 February 2016, Dirk Hohndel wrote: > I don't think this is the right way to do this. The patch below is the > hack that I used for the last few Subsurface-mobile alpha builds to give > people the idea that the handles really shouldn't be so visually dominant. > > So the background is

Re: [PATCH] make context drawer smaller

On Monday 15 February 2016, Sebastian Kügler wrote: > > I would keep this very big, but on the other hand since it's only an > > "hint", make sire the final overlay is never ~70/80% of the screen width > > I think limiting it to, say, 70% of the root item would make sense. I've > fixed this

Re: repo freeze on Thursday

> We'd best release it then, the final will be after 5.20 is out and distros > will > expect it to work with 5.20. We will also need to make a -1 release for it - if somebody updates frameworks to 20 before 5.6 is released. Before I send the group list, what do you think is the best way (with

Re: Review Request 127072: WindowThumbnail: Discard glx pixmap in stopRedirecting()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127072/#review92400 --- Ship it! Ship It! - Martin Gräßlin On Feb. 14, 2016,

Re: Review Request 127072: WindowThumbnail: Discard glx pixmap in stopRedirecting()

> On Feb. 15, 2016, 8:11 a.m., Martin Gräßlin wrote: > > do you know what exactly crashes if discard is not called? I just tried to > > read the code and also compare it to KWin's code to try to understand why > > it's needed. From all I can see I don't find a reason why it should crash. > >

Re: repo freeze on Thursday

On Mon, Feb 15, 2016 at 01:05:23PM +0100, Ivan Čukić wrote: > For 5.19, ti is not needed (it was split out of the kde:kactivities > repository after 5.19 was tagged). > > I'll send a mail to packagers, plasma and frameworks in a few hours > explaining everything regarding the transition period.

Re: repo freeze on Thursday

For 5.19, ti is not needed (it was split out of the kde:kactivities repository after 5.19 was tagged). I'll send a mail to packagers, plasma and frameworks in a few hours explaining everything regarding the transition period. Cheerio, Ivan p.s. I've added to to be the KDE project manager --

ffmpegthumbs + ffmpeg 2.9

heya, ffmpeg 2.9 sees the removal of previously deprecated API. since ffmpegthumbs hasn't had a proper maintenance pass in a while this needs quite a bit of porting for which there is a review request already, but someone needs to do the review [1]. given ffmpeg's aggressive deprecation policies

Re: repo freeze on Thursday

On Mon, Feb 15, 2016 at 12:54:42PM +0100, Ivan Čukić wrote: > Hi, > > Against which version of frameworks will plasma 5.6 be released? If it > will be released against 5.20, then we will need kde:kactivitymanagerd > repository as well. 5.19 preferably, does that affect it? Can you make me KDE

Re: repo freeze on Thursday

Hi, Against which version of frameworks will plasma 5.6 be released? If it will be released against 5.20, then we will need kde:kactivitymanagerd repository as well. Cheerio, Ivan -- KDE, ivan.cu...@kde.org, http://cukic.co/ gpg key id: 850B6F76 ___

Re: Review Request 127071: ButtonStyle: Fix text alignment with minimumWidth

> On Feb. 14, 2016, 10:34 p.m., Aleix Pol Gonzalez wrote: > > src/declarativeimports/plasmastyle/ButtonStyle.qml, line 83 > > > > > > Looks bound to implode, I'd rather specify the minimumWith as a > > property,

Re: repo freeze on Thursday

On Monday, February 15, 2016 11:46:11 AM CET Jonathan Riddell wrote: > The Plasma 5.6 repo freeze is on Thursday. We can't add new git > repositories to make tars after Thursday. Does anyone have any git > repositories that need added to this release which were not in 5.5? new repo:

Re: [PATCH] make context drawer smaller

On Monday, February 15, 2016 12:00:00 PM Marco Martin wrote: > On Sunday 14 February 2016, Dirk Hohndel wrote: > > This is an odd one. Not sure what the logic was behind that, but with the > > existing code on most phones the context drawer takes up the complete > > screen which makes it look

repo freeze on Thursday

The Plasma 5.6 repo freeze is on Thursday. We can't add new git repositories to make tars after Thursday. Does anyone have any git repositories that need added to this release which were not in 5.5? Jonathan ___ Plasma-devel mailing list

Re: Review Request 127072: WindowThumbnail: Discard glx pixmap in stopRedirecting()

> On Feb. 15, 2016, 7:11 a.m., Martin Gräßlin wrote: > > do you know what exactly crashes if discard is not called? I just tried to > > read the code and also compare it to KWin's code to try to understand why > > it's needed. From all I can see I don't find a reason why it should crash. > >

Minutes Monday Plasma Meeting

Minutes Plasma 'hangout', 15-2-2016, 12:00 CET Present: sebas, mgraesslin, bshah, jensreuterberg, notmart, sitter, Riddell Excused: kbroulik PSA: Repo freeze for Plasma 5.6 is on Thursday! kbroulik: * KDevelop now shows compile progress in the task bar using Unity launcher API *

Re: Review Request 127024: Don't filter names if we have mimetypes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127024/ --- (Updated Feb. 15, 2016, 12:37 p.m.) Status -- This change has been

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

> On Фев. 15, 2016, 12:06 след обяд, Marco Martin wrote: > > src/plasmaquick/appletquickitem.cpp, line 55 > > > > > > why splitting it in a separate method if you don't call it from > > anywhere else? > > David

Re: [PATCH] make context drawer smaller

On Sunday 14 February 2016, Dirk Hohndel wrote: > This is an odd one. Not sure what the logic was behind that, but with the > existing code on most phones the context drawer takes up the complete > screen which makes it look really weird. > not sure about this, we had text in context drawer not

Re: [PATCH] Allow the app to filter the back key even at the top level

On Sunday 14 February 2016, Dirk Hohndel wrote: > The onBackRequested trick didn't work on the top level page. Which seems > odd to me - why shouldn't an application be allowed to prevent the back > key from exiting? thanks, added. REgardless of the reasons should lways be possible to filter. >

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127073/#review92387 --- Fix it, then Ship it! fine with an issue

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

> On Feb. 13, 2016, 11:33 p.m., Kai Uwe Broulik wrote: > > src/plasmaquick/appletquickitem.h, line 149 > > > > > > This looks binary incompatible. > > > > Also, add Q_DECL_OVERRIDE > > David Rosca

Re: Review Request 126775: Use KDE_INSTALL_DATADIR to install lookandfeel directory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126775/ --- (Updated Feb. 15, 2016, 10:07 a.m.) Status -- This change has been

Re: Review Request 127024: Don't filter names if we have mimetypes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127024/#review92384 --- Ship it! Ship It! - David Faure On Feb. 14, 2016,