Re: Review Request 127346: RFC: Some infrastructure for Plasma testing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127346/ --- (Updated March 12, 2016, 1:43 a.m.) Review request for Plasma. Changes

Re: Review Request 127346: RFC: Some infrastructure for Plasma testing

> On March 11, 2016, 11:23 p.m., Sebastian Kügler wrote: > > shell/main.cpp, line 135 > > > > > > We'll have multiple TestCorona's around if the Shell changes more than > > once. Not a big deal, since it's only

Re: Review Request 127349: Fix wrong usage of KDE brand in kcmshell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127349/#review93429 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 12,

Re: Review Request 127345: Make it possible for an applet to offer a test object

> On March 11, 2016, 11:14 p.m., Marco Martin wrote: > > src/plasmaquick/appletquickitem.cpp, line 648 > > > > > > who will be using this? from the shell? Yes, see my patch in plasma-workspace. - Aleix

Review Request 127349: Fix wrong usage of KDE brand in kcmshell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127349/ --- Review request for Plasma. Repository: kde-cli-tools Description

Re: Review Request 127346: RFC: Some infrastructure for Plasma testing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127346/#review93425 --- I quite like it, some comments inline. shell/main.cpp

Re: Review Request 127342: IconItem: Schedule pixmap update when window changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127342/#review93424 --- Ship it! Ship It! - Marco Martin On March 11, 2016,

Re: Review Request 127344: FrameSvg: Fix dangling pointers in sharedFrames when theme changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127344/#review93423 --- Ship it! Ship It! - Marco Martin On March 11, 2016,

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review93422 --- src/plasmaquick/appletquickitem.h (line 130)

[Differential] [Request, 135 lines] D1126: Remove Desktop.SystemSettings import

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Port to Qt.styleHints (Qt >= 5.5) REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH stylehints (branched from master) REVISION DETAIL

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review93419 --- I have a rough idea how you want it to work, but to really

Re: Review Request 127346: RFC: Some infrastructure for Plasma testing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127346/#review93418 --- shell/main.cpp (line 99)

Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/ --- Review request for KDE Frameworks and Plasma. Repository:

Review Request 127346: RFC: Some infrastructure for Plasma testing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127346/ --- Review request for Plasma. Repository: plasma-workspace Description

[Differential] [Updated, 825 lines] D1113: New Desktop Theme KCM

drosca updated this revision to Diff 2721. drosca added a comment. Keep the Plasma::Theme in cache Fix logic of needs save REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1113?vs=2682=2721 BRANCH desktoptheme-kcm (branched from master)

Re: Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 20 - Still Failing!

Hi, Thanks for this, I understood the message as 'the break started with YOUR commit Ivan, FIX IT!' :) Cheers, Ivan -- KDE, ivan.cu...@kde.org, http://cukic.co/ gpg key id: 850B6F76 ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 20 - Still Failing!

Someone did, as you can see here: https://quickgit.kde.org/?p=plasma-desktop.git=blob=358bd7ab8e2f3aabfa77536467079712757430cd=CMakeLists.txt=plain set(QT_MIN_VERSION "5.5.0") CI does not randomly update Cmake files :) Found it: 6 weeks agoRequire Qt 5.5

Review Request 127344: FrameSvg: Fix dangling pointers in sharedFrames when theme changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127344/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 127339: Make QtWebKit optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127339/ --- (Updated March 11, 2016, 8:33 p.m.) Status -- This change has been

Re: Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 20 - Still Failing!

Hi Scarlet, Can you check why the build failed - I haven't changed the required Qt version: 18:16:56 CMake Error at CMakeLists.txt:22 (find_package): 18:16:56 Could not find a configuration file for package "Qt5" that is compatible 18:16:56 with requested version "5.5.0". 18:16:56 18:16:56

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 20 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/20/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 11 Mar 2016 18:15:02 + Build duration: 1 min 42 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 19 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 11 Mar 2016 16:33:55 + Build duration: 1 min 49 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 18 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 11 Mar 2016 15:30:46 + Build duration: 2 min 38 sec CHANGE SET Revision

[Differential] [Closed] D1122: Disabled toggling of act. switcher immediately after it has been toggled

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP174aa2171804: Disabled toggling of act. switcher immediately after it has been toggled (authored by ivan). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Updated, 28 lines] D1122: Disabled toggling of act. switcher immediately after it has been toggled

ivan updated this revision to Diff 2715. ivan added a comment. Updated the commit comment REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1122?vs=2713=2715 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1122 AFFECTED

[Differential] [Updated, 28 lines] D1122: Disabled toggling of act. switcher immediately after it has been toggled

ivan updated this revision to Diff 2713. ivan added a comment. Added the comment regarding the Qt bug: Qt has a bug where invoking a global shortcut steal focus from the current window, which makes the activity switcher hide itself and popup again when the user presses meta+q (instead

[Differential] [Request, 21 lines] D1122: Disabled toggling of act. switcher immediately after it has been toggled

ivan created this revision. ivan added a reviewer: mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY There is a current issue when the user presses meta+q while the switcher is shown. It gets hidden (the switcher lost the focus) and shown again

[Differential] [Closed] D1120: LayoutManager: Restore rotation on remove applet undo

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPa59132ab3eae: LayoutManager: Restore rotation on remove applet undo (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

Re: Review Request 127340: Applet: Stop deleteNotificationTimer when undo is triggered

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127340/ --- (Updated March 11, 2016, 3:14 p.m.) Status -- This change has been

Re: Review Request 127340: Applet: Stop deleteNotificationTimer when undo is triggered

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127340/#review93416 --- Same as https://git.reviewboard.kde.org/r/127318/ Bug is in

Review Request 127342: IconItem: Schedule pixmap update when window changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127342/ --- Review request for Plasma. Repository: plasma-framework Description

Review Request 127341: Change the way SUID bits are managed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127341/ --- Review request for Plasma. Repository: kscreenlocker Description

Review Request 127340: Applet: Stop deleteNotificationTimer when undo is triggered

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127340/ --- Review request for Plasma and Anthony Fieroni. Repository:

[Differential] [Accepted] D1120: LayoutManager: Restore rotation on remove applet undo

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH undo-rotation (branched from Plasma/5.6) REVISION DETAIL https://phabricator.kde.org/D1120 EMAIL PREFERENCES

Re: [kde-doc-english] [kinfocenter] /: Remove all remaining bits of SCSI module

2016-03-11 16:48 GMT+03:00 Sebastian Kügler : > If you're keen on keeping it, feel free to recover the code and put it in your > own KCM. kinfocenter is a plugin-based thing for a reason. Good point. Thanks for your time! -- Alexander Potashev

Re: [kde-doc-english] [kinfocenter] /: Remove all remaining bits of SCSI module

On Friday, March 11, 2016 15:01:19 Alexander Potashev wrote: > 2016-03-10 12:10 GMT+03:00 Sebastian Kügler : > > CC:ing plasma-devel. > > > > On Thursday, March 10, 2016 02:41:16 Alexander Potashev wrote: > >> Next time please clarify in the commit message why you remove > >>

Re: Review Request 127339: Make QtWebKit optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127339/#review93415 --- Ship it! Ship It! - Marco Martin On March 11, 2016,

Re: Review Request 127302: IconItem: Animate active and enabled change even with animations disabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127302/ --- (Updated March 11, 2016, 1:19 p.m.) Status -- This change has been

Re: Review Request 127339: Make QtWebKit optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127339/#review93414 --- +1 - Aleix Pol Gonzalez On March 11, 2016, 11:18 a.m.,

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 14 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/14/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 11 Mar 2016 12:48:16 + Build duration: 54 sec CHANGE SET Revision

[Differential] [Request, 16 lines] D1120: LayoutManager: Restore rotation on remove applet undo

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Undo remove applet now restores rotation REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH undo-rotation (branched from Plasma/5.6)

Re: [kde-doc-english] [kinfocenter] /: Remove all remaining bits of SCSI module

2016-03-10 12:10 GMT+03:00 Sebastian Kügler : > CC:ing plasma-devel. > > On Thursday, March 10, 2016 02:41:16 Alexander Potashev wrote: >> Next time please clarify in the commit message why you remove >> something (reasoning, links to discussions, etc?), SCSI support in >> this

Re: Review Request 127319: [Weather widget] Fix occasional empty widget after configuring a new weather station

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127319/ --- (Updated March 11, 2016, 10:53 a.m.) Status -- This change has been

[Differential] [Request, 4 lines] D1117: Fix assigning undefined to double warning on startup

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Default value for Layout constraints is -1 REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH desktop-preferred-size-warning (branched from

Review Request 127339: Make QtWebKit optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127339/ --- Review request for Plasma. Repository: plasma-sdk Description ---

Re: kdereview: breeze-grub & breeze-plymouth

I think we should remove the kde icon with the plasma one. 2016-03-11 10:59 GMT+01:00 Harald Sitter : > On Thu, Mar 10, 2016 at 6:25 PM, Jonathan Riddell wrote: > > On Thu, Mar 10, 2016 at 05:10:40PM +, Jonathan Riddell wrote: > >> Some queries: > >> -

Re: kdereview: breeze-grub & breeze-plymouth

On Thu, Mar 10, 2016 at 6:25 PM, Jonathan Riddell wrote: > On Thu, Mar 10, 2016 at 05:10:40PM +, Jonathan Riddell wrote: >> Some queries: >> - why does it have a .grub theme file? shouldn't that be in breeze-grub? Actually I think we can drop it, it is some debian

Re: Review Request 127332: [Pager] List minimized windows in the tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127332/#review93411 --- Ship it! Ship It! - Marco Martin On March 10, 2016,

Re: Review Request 127337: [libksysguard] Don't call into QX11Info::connection() on wayland

> On März 11, 2016, 9:07 vorm., Martin Gräßlin wrote: > > processui/ProcessModel.cpp, lines 422-435 > > > > > > This part looks like an unrelated change? (Disregard the other optimization, middle click paste

Re: Review Request 127337: [libksysguard] Don't call into QX11Info::connection() on wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127337/#review93407 --- processui/ProcessModel.cpp (lines 422 - 435)

Re: kdereview: breeze-grub & breeze-plymouth

On Thu, Mar 10, 2016 at 6:27 PM, Jonathan Riddell wrote: > On Fri, Feb 19, 2016 at 09:43:27AM +0100, Harald Sitter wrote: >> GRUB is ready for review. > > error: unknown property 'terminal-color' > https://www.flickr.com/photos/jriddell/25584072671/in/photostream/ > > probably