[Differential] [Updated, 9,257 lines] D1722: Import next-gen libtaskmanager.

hein updated this revision to Diff 4118. hein added a comment. Refresh activity count prop on activity state changes; more explicit prop name. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1722?vs=4117=4118 BRANCH importlibtmng

[Differential] [Updated, 9,218 lines] D1722: Import next-gen libtaskmanager.

hein updated this revision to Diff 4117. hein marked an inline comment as done. hein added a comment. Fix window info cache leak. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1722?vs=4110=4117 BRANCH importlibtmng REVISION DETAIL

[Differential] [Commented On] D1722: Import next-gen libtaskmanager.

graesslin added inline comments. INLINE COMMENTS > TODO.txt:1 > +Larger outstanding tasks: > +- Implement missing kwayland bits (e.g. transient handling, virtual desktop > logic). do you really want to add a TODO.txt? My suggestion would be to add tasks to maniphest here >

[Differential] [Closed] D1714: [server] Don't destroy SlideInterface when parent SurfaceInterface is destroyed

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND7250773cf15d: [server] Don't destroy SlideInterface when parent SurfaceInterface is destroyed (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1711: [server] Don't destroy ShadowInterface when SurfaceInterface gets destroyed

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND4971be582ce7: [server] Don't destroy ShadowInterface when SurfaceInterface gets destroyed (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1713: [server] Properly handle destructor in SlideInterface

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDc7bf5dd0: [server] Properly handle destructor in SlideInterface (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1708: [server] Don't destroy BlurInterface when parent SurfaceInterface is destroyed

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDd2f6665ce355: [server] Don't destroy BlurInterface when parent SurfaceInterface is destroyed (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1710: [server] Don't destroy ServerSideDecorationInterface when parent SurfaceInterface is destroyed

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND73e89530e69e: [server] Don't destroy ServerSideDecorationInterface when parent… (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1709: [server] Don't destroy ContrastInterface when parent SurfaceInterface is destroyed

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND6354bff902a4: [server] Don't destroy ContrastInterface when parent SurfaceInterface is… (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE

[Differential] [Updated] D1722: Import next-gen libtaskmanager.

hein marked an inline comment as done. hein added inline comments. INLINE COMMENTS > hein wrote in tasksmodel.cpp:1220 > Quite possibly, I'll give it a try. I originally had everything in > filterAcceptsRow() and the code then evolved more, and this was kind of left > on the table along the

[Differential] [Updated, 9,210 lines] D1722: Import next-gen libtaskmanager.

hein updated this revision to Diff 4110. hein added a comment. - Move refilter-launcher-on-window insertion out of filterAcceptsRow() to make it lighter. - Move launcher refilter triggers to after grouping to ignore irrelevant sub-level window insertions/removals. - Remove a redundant

[Differential] [Updated, 5,135 lines] D1724: Import Task Manager widgets ports to the new library.

hein updated this revision to Diff 4109. hein marked an inline comment as done. hein added a comment. Adapt to *FullScreen* API change in update to https://phabricator.kde.org/D1722. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Updated, 9,197 lines] D1722: Import next-gen libtaskmanager.

hein updated this revision to Diff 4108. hein added a comment. Fullscreen -> FullScreen for consistency with Qt. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1722?vs=4107=4108 BRANCH importlibtmng REVISION DETAIL

Review Request 128070: Update mouse kcm docbook to 5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128070/ --- Review request for Documentation and Plasma. Repository: plasma-desktop

[Differential] [Updated, 9,197 lines] D1722: Import next-gen libtaskmanager.

hein updated this revision to Diff 4107. hein marked 2 inline comments as done. hein added a comment. Addressed most of David's and Martin's minor requests. Outstanding bigger request: - The ActivityInfo fix - The TasksModel::filterAcceptsRow comment REPOSITORY rPLASMAWORKSPACE

[Differential] [Updated] D1722: Import next-gen libtaskmanager.

hein marked 2 inline comments as done. hein added inline comments. INLINE COMMENTS > davidedmundson wrote in taskfilterproxymodel.cpp:34 > Not that it will make a real difference, but shouldn't this technically > default to 0? > > virtual desktops start at 1 with 0 being invalid. Makes sense

[Differential] [Updated] D1722: Import next-gen libtaskmanager.

hein marked 6 inline comments as done. hein added inline comments. INLINE COMMENTS > hein wrote in xwindowtasksmodel.cpp:756 > Done. Actually not done -- I'll ask you later about this. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1722 EMAIL

[Differential] [Updated] D1722: Import next-gen libtaskmanager.

hein marked 7 inline comments as done. hein added inline comments. INLINE COMMENTS > graesslin wrote in CMakeLists.txt:18-23 > do we want to have X11 conditional? Other areas of Plasma use X11 > unconditionally. Personally as maintainer I do :). From my POV X11 is a legacy windowing system

[Differential] [Updated, 5,135 lines] D1724: Import Task Manager widgets ports to the new library.

hein updated this revision to Diff 4106. hein marked 12 inline comments as done. hein added a comment. Make grouping toggle action actually a toggle action; requested code cleanup. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Updated] D1724: Import Task Manager widgets ports to the new library.

hein marked 2 inline comments as done. hein added inline comments. INLINE COMMENTS > broulik wrote in ContextMenu.qml:123 > can be simplified to > return menu.visualParent && menu.visualParent.virtualDesktop != > virtualDesktopInfo.currentDesktop > same in tons of places below Ok. REPOSITORY

[Differential] [Updated] D1724: Import Task Manager widgets ports to the new library.

hein marked 13 inline comments as done. hein added inline comments. INLINE COMMENTS > broulik wrote in CMakeLists.txt:7 > Why is icon tasks now in plasma-desktop instead of kdeplasma-addons? It's not a case of "now": Icontasks has been in plasma-desktop for a long time now. Please keep in mind

[Differential] [Updated, 5,133 lines] D1724: Import Task Manager widgets ports to the new library.

hein updated this revision to Diff 4105. hein added a comment. Addressed the comments relevant to the purpose of the review, in particular the incorrect install names. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1724?vs=4091=4105

[Differential] [Requested Changes To] D1726: Introduce a test server

bshah requested changes to this revision. bshah added a reviewer: bshah. bshah added a comment. This revision now requires changes to proceed. While looking at cmake, I realized one issue.. and to verify this I tried to build it and it didn't even build.. :\ INLINE COMMENTS >

[Differential] [Accepted] D1726: Introduce a test server

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Aside from @bshah 's request, it looks good to me. INLINE COMMENTS > graesslin wrote in main.cpp:30-33 > right, but then more needs to be changed. All

Re: kscreen daemon race

On Tuesday 31 May 2016 14:29:06 Sebastian Kügler wrote: > Discussed with mgraesslin on IRC, preliminary conclusion below... > > On dinsdag 31 mei 2016 14:05:06 CEST Sebastian Kügler wrote: > > https://bugs.kde.org/show_bug.cgi?id=358011 dual screen not setup after > > reboot > > > > This

Re: kscreen daemon race

On Wednesday 01 June 2016 00:05:10 Mark Gaiser wrote: > Perhaps blockSignals can help you out [1]? > > object->blockSignals(true); > // ... > Write your changes > // ... > object->blockSignals(false); > > Object should be the object that currently receives the notification that > the config file

Review Request 128069: Added keyboard shortcuts to Sticky Notes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128069/ --- Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and

[Differential] [Request, 13 lines] D1730: address race condition around setoperation

sebas created this revision. sebas added a reviewer: graesslin. sebas added a subscriber: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Use a timer to avoid catching configChanged signals after we set changes.

Re: RFC: plasma logo as start menu icon and ksplash logo

On 31.05.2016 22:38, Ivan Čukić wrote: Hi all, There are two main reasons why I'm against this (regardless of what ends up being plasma logo, and regardless of whether it will be pretty or not - the KDE logo would not win any beauty pageants :) ): - (as previously mentioned) the gear-logo is

Re: kscreen daemon race

On Tue, May 31, 2016 at 2:29 PM, Sebastian Kügler wrote: > Discussed with mgraesslin on IRC, preliminary conclusion below... > > On dinsdag 31 mei 2016 14:05:06 CEST Sebastian Kügler wrote: > > https://bugs.kde.org/show_bug.cgi?id=358011 dual screen not setup after > > reboot > >

[Differential] [Updated, 968 lines] D1231: Add Krfb interface to KWayland

Kanedias updated this revision to Diff 4100. Kanedias added a comment. Updated against last M.Graesslin review. Sorry, couldn't find a way to get rid of GbmBuffer struct (removed some redundant fields though). Re-checked with latest KWin and KRfb. REPOSITORY rKWAYLAND KWayland

Re: RFC: plasma logo as start menu icon and ksplash logo

On Tue, May 31, 2016 at 10:38 PM, Ivan Čukić wrote: > Microsoft is not Windows (they share the logo) Not that I feel we need to discuss this further, but they do not share the logo. The actual windows logo changes between iterations and has since forever been the four tiles

[Differential] [Accepted] D1711: [server] Don't destroy ShadowInterface when SurfaceInterface gets destroyed

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH shadow-destroy-surface REVISION DETAIL https://phabricator.kde.org/D1711 EMAIL PREFERENCES

[Differential] [Accepted] D1713: [server] Properly handle destructor in SlideInterface

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH slide-destroy-callback REVISION DETAIL https://phabricator.kde.org/D1713 EMAIL PREFERENCES

[Differential] [Accepted] D1710: [server] Don't destroy ServerSideDecorationInterface when parent SurfaceInterface is destroyed

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH ssd-destroy-surface REVISION DETAIL https://phabricator.kde.org/D1710 EMAIL PREFERENCES

[Differential] [Accepted] D1708: [server] Don't destroy BlurInterface when parent SurfaceInterface is destroyed

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH blur-destroy-surface REVISION DETAIL https://phabricator.kde.org/D1708 EMAIL PREFERENCES

Re: RFC: plasma logo as start menu icon and ksplash logo

Hi all, There are two main reasons why I'm against this (regardless of what ends up being plasma logo, and regardless of whether it will be pretty or not - the KDE logo would not win any beauty pageants :) ): - (as previously mentioned) the gear-logo is a recognizable brand (easy to spot on on

Re: RFC: plasma logo as start menu icon and ksplash logo

On 03.02.2016 18:31, Marco Martin wrote: On Wednesday 03 February 2016 09:10:06 Dirk Hohndel wrote: http://4.bp.blogspot.com/-jwBzU1YZWLI/U8U2E1nDM8I/mfY/jDbBMq9GkP4/ s1600/plasma-5-banner.png As someone with a more "outside" perspective... boy that one is ugly. And really doesn't

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

broulik added inline comments. INLINE COMMENTS > xuetianweng wrote in main_wayland.cpp:449 > Ah, ok, I misunderstood that this will inherit by session since I thought > kwin start the script exit-with-session. > > But then I still have one minor concern, for any window that actually inside >

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

xuetianweng added inline comments. INLINE COMMENTS > graesslin wrote in main_wayland.cpp:449 > I don't understand the concern. The QT_IM_MODULE env variable set here in the > code only affects KWin. It is not passed to any other process. > > Setting QT_IM_MODULE env variables will still

Re: Review Request 128038: [libtaskmanager] Stop highlighted window effect when close window in group item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128038/#review96104 --- Ping, Eike, what you prefer? - Anthony Fieroni On Май 28,

[Differential] [Commented On] D1722: Import next-gen libtaskmanager.

graesslin added a comment. Totally stupid question: why import at all into plasma-workspace? We could also make it a standalone repository or does it depend on something else in plasma-workspace? INLINE COMMENTS > CMakeLists.txt:18-23 > +if (X11_FOUND) > +set(taskmanager_LIB_SRCS > +

[Differential] [Commented On] D1726: Introduce a test server

graesslin added inline comments. INLINE COMMENTS > bshah wrote in main.cpp:30-33 > It might be possible that one want to use executable with command line > option... lets not restrict it to 1? and have >= 1? right, but then more needs to be changed. All positional arguments need to be passed

[Differential] [Changed Subscribers] D1698: A component shouldn't manage it's own geometry

davidedmundson edited subscribers, added: plasma-devel; removed: Plasma. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D1698 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, Plasma Cc: plasma-devel

[Differential] [Changed Subscribers] D1699: Limit BasicListItem width and elide text

davidedmundson edited subscribers, added: plasma-devel; removed: Plasma. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D1699 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, Plasma Cc: plasma-devel

[Differential] [Changed Subscribers] D1697: Don't set the implicitWidth the parent's actual width

bshah added a subscriber: plasma-devel. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D1697 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, Plasma Cc: plasma-devel, Plasma

[Differential] [Changed Subscribers] D1726: Introduce a test server

bshah added inline comments. INLINE COMMENTS > main.cpp:30-33 > +const auto arguments = parser.positionalArguments(); > +if (arguments.size() != 1) { > +return 1; > +} It might be possible that one want to use executable with command line option... lets not restrict it to

[Differential] [Updated] D1726: Introduce a test server

graesslin added a dependent revision: D1727: Add a test case for KIdleTime. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1726 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas

[Differential] [Updated] D1727: Add a test case for KIdleTime

graesslin added a dependency: D1726: Introduce a test server. REPOSITORY rKWAYLANDINTEGRATION Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D1727 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin,

[Differential] [Request, 130 lines] D1727: Add a test case for KIdleTime

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The test uses the new Wayland test server to run the test app. REPOSITORY rKWAYLANDINTEGRATION

[Differential] [Request, 317 lines] D1726: Introduce a test server

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The idea of shipping a test server is to have something like Xvfb for Wayland. To be able to run a

Re: kscreen daemon race

Discussed with mgraesslin on IRC, preliminary conclusion below... On dinsdag 31 mei 2016 14:05:06 CEST Sebastian Kügler wrote: > https://bugs.kde.org/show_bug.cgi?id=358011 dual screen not setup after > reboot > > This bugreport seems to be a common problem, and it's a good example for > what's

kscreen daemon race

Hey, I've been looking into the bug 358011, that is: https://bugs.kde.org/show_bug.cgi?id=358011 dual screen not setup after reboot This bugreport seems to be a common problem, and it's a good example for what's wrong with the screen configuration on startup. TL;DR: We have a race condition

Flaky build behavior when using kded/kcm in tests (was, re: Jenkins-kde-ci: plasma-desktop master kf5-qt5 ..)

Heya people, On Tue, May 31, 2016 at 4:40 PM, wrote: > > BUILD FAILURE > Build URL: > https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/83/ > Project: PLATFORM=Linux,compiler=gcc > Date of build: Tue, 31 May 2016 11:07:31 + > Build

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 84 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/84/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 31 May 2016 11:36:28 + Build duration: 7 min 25 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 84 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/84/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 31 May 2016 11:36:28 + Build duration: 7 min 25 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 108 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/108/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 31 May 2016 11:07:47 + Build duration: 28 min CHANGE SET Revision

[Differential] [Closed] D1672: Add support for touch events in fakeinput protocol and interface.

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND7d460ed00254: Add support for touch events in fakeinput protocol and interface. (authored by bdhruve). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D1672: Add support for touch events in fakeinput protocol and interface.

bdhruve added a comment. Thank you @graesslin and @bshah REPOSITORY rKWAYLAND KWayland BRANCH fake-input-touch REVISION DETAIL https://phabricator.kde.org/D1672 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, Plasma, bshah, graesslin Cc:

[Differential] [Updated, 9,190 lines] D1722: Import next-gen libtaskmanager.

hein updated this revision to Diff 4092. hein added a comment. Addressed: - Most of kbroulik's comments, including API comments REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1722?vs=4090=4092 BRANCH importlibtmng REVISION

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 83 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/83/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 31 May 2016 11:07:31 + Build duration: 1 min 56 sec CHANGE SET Revision

[Differential] [Accepted] D1672: Add support for touch events in fakeinput protocol and interface.

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH fake-input-touch REVISION DETAIL https://phabricator.kde.org/D1672 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve,

[Differential] [Commented On] D1722: Import next-gen libtaskmanager.

hein added inline comments. INLINE COMMENTS > broulik wrote in launchertasksmodel.h:86 > "will fail" sounds like it's dangerous, "will do nothing"? It means it will return false, for failure. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1722

[Differential] [Commented On] D1722: Import next-gen libtaskmanager.

hein added inline comments. INLINE COMMENTS > broulik wrote in taskmanagerplugin.h:32 > Indentation is off No, it's not ...? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1722 EMAIL PREFERENCES

[Differential] [Commented On] D1672: Add support for touch events in fakeinput protocol and interface.

bdhruve added a comment. In https://phabricator.kde.org/D1672#31870, @bshah wrote: > Looks good. Output of arc land fake-input-touch: TARGET Landing onto "master", the default target under git. REMOTE Using remote "origin", the default remote under git. FETCH Fetching

[Differential] [Commented On] D1722: Import next-gen libtaskmanager.

hein added inline comments. INLINE COMMENTS > davidedmundson wrote in abstracttasksmodel.cpp:41-42 > traditionally these are called "display" and "decoration" > lowercase and without the word "Role" > > Also you should be able to do > > roles = QAbstractItemModel::roles() to get them. This

[Differential] [Accepted] D1672: Add support for touch events in fakeinput protocol and interface.

bshah accepted this revision. bshah added a comment. Looks good. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1672 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, graesslin, Plasma, bshah Cc: bshah, graesslin,

[Differential] [Updated, 5,133 lines] D1724: Import Task Manager widgets ports to the new library.

hein updated this revision to Diff 4091. hein added a comment. Switch to changed data role names in update to https://phabricator.kde.org/D1722. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1724?vs=4085=4091 BRANCH importtmng

[Differential] [Updated, 9,191 lines] D1722: Import next-gen libtaskmanager.

hein updated this revision to Diff 4090. hein added a comment. Addressed: - Data role names - Nulling pointers - Removed Messages.sh - Saved lookup in startups model REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 107 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/107/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 31 May 2016 09:59:36 + Build duration: 9 min 18 sec CHANGE SET Revision

[Differential] [Updated, 280 lines] D1672: Add support for touch events in fakeinput protocol and interface.

bdhruve updated this revision to Diff 4089. bdhruve added a comment. Fixed the coding style issue. REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1672?vs=4063=4089 BRANCH fake-input-touch REVISION DETAIL https://phabricator.kde.org/D1672

[Differential] [Commented On] D1722: Import next-gen libtaskmanager.

hein added inline comments. INLINE COMMENTS > davidedmundson wrote in activityinfo.cpp:69 > If I have 4 activities. 2 running, 2 not. > > numberOfActivities returns 2 > > I set one to running: > > the property changes > this signal is not emitted. Good catch. I think the old lib had this

[Differential] [Commented On] D1722: Import next-gen libtaskmanager.

hein added inline comments. INLINE COMMENTS > davidedmundson wrote in concatenatetasksproxymodel.cpp:61 > we could add one? > > sourceModelForIndex() would make sense for a few cases. It's on my todo, the comments are partly so I don't forget :). It's not a vital issue at this moment, and

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 106 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/106/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 31 May 2016 09:25:56 + Build duration: 17 min CHANGE SET Revision

[Differential] [Commented On] D1722: Import next-gen libtaskmanager.

hein added inline comments. INLINE COMMENTS > davidedmundson wrote in Messages.sh:3 > The legacy version is also called this. > > That will cause a breakage on the i18n side. > > Either: > two .pot files > OR > one Messages.sh I'll pick option 3: Remove Messages.sh :-) The new lib doesn't

[Differential] [Commented On] D1722: Import next-gen libtaskmanager.

davidedmundson added a comment. Reviewed up to "libtaskmanager/taskfilterproxymodel.h" Will submit this now, in case phabricator doesn't save it. INLINE COMMENTS > CMakeLists.txt:86 > +endif() > + >

[Differential] [Requested Changes To] D1672: Add support for touch events in fakeinput protocol and interface.

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Looks good, but please fix the coding style. INLINE COMMENTS > fakeinput_interface.cpp:201-202 > +} > +if(touchIds.contains(id)) > +{ > +return; please

[Differential] [Closed] D1705: [System Tray] Don't iterate keys()

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEcc47d2bfca93: [System Tray] Don't iterate keys() (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

Re: Review Request 127975: selected state for Plasma::Svg and PlasmaCore::IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127975/ --- (Updated May 31, 2016, 2:26 a.m.) Status -- This change has been

[Differential] [Closed] D1718: [PanelView] Check whether we're X11 before calling QX11Info::connection()

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEe26f4ee4757c: [PanelView] Check whether we're X11 before calling QX11Info::connection() (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

Re: Review Request 127975: selected state for Plasma::Svg and PlasmaCore::IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127975/ --- (Updated May 31, 2016, 9:13 a.m.) Review request for Plasma.

[Differential] [Request, 5,133 lines] D1724: Import Task Manager widgets ports to the new library.

hein created this revision. hein added a reviewer: Plasma. hein added a subscriber: plasma-devel. hein added dependencies: D1723: Rename Task Manager applets out of the way of rewrites., D1721: Rename libtaskmanager to liblegacytaskmanager to make way for rewrite.. Restricted Application added a

[Differential] [Updated] D1721: Rename libtaskmanager to liblegacytaskmanager to make way for rewrite.

hein added a dependent revision: D1724: Import Task Manager widgets ports to the new library.. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1721 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Updated] D1721: Rename libtaskmanager to liblegacytaskmanager to make way for rewrite.

hein added a dependent revision: D1723: Rename Task Manager applets out of the way of rewrites.. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1721 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Request, 4,516 lines] D1723: Rename Task Manager applets out of the way of rewrites.

hein created this revision. hein added a reviewer: Plasma. hein added a subscriber: plasma-devel. hein added a dependency: D1721: Rename libtaskmanager to liblegacytaskmanager to make way for rewrite.. Restricted Application added a project: Plasma. REVISION SUMMARY Also ports Pager to renamed

[Differential] [Accepted] D1721: Rename libtaskmanager to liblegacytaskmanager to make way for rewrite.

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1721 EMAIL PREFERENCES

[Differential] [Request, 9,194 lines] D1722: Import next-gen libtaskmanager.

hein created this revision. hein added a reviewer: Plasma. hein added a subscriber: plasma-devel. hein added a dependency: D1721: Rename libtaskmanager to liblegacytaskmanager to make way for rewrite.. Restricted Application added a project: Plasma. REVISION SUMMARY Depends on

[Differential] [Updated] D1721: Rename libtaskmanager to liblegacytaskmanager to make way for rewrite.

hein added a dependent revision: D1722: Import next-gen libtaskmanager.. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1721 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, Plasma Cc: plasma-devel, sebas

[Differential] [Request, 1,120 lines] D1721: Rename libtaskmanager to liblegacytaskmanager to make way for rewrite.

hein created this revision. hein added a reviewer: Plasma. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Also ports in-module users of the library. Translation domain and pot file name remain unchanged, as the new lib contains no

Re: Review Request 128040: [shellcorona] Containment can be nullptr

> On May 30, 2016, 11:32 a.m., Aleix Pol Gonzalez wrote: > > Could you look a bit into why is the containment null? > > Anthony Fieroni wrote: > So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i > can't reproduce crash, KScreen is not finish recognazing, which i write

Re: Review Request 128040: [shellcorona] Containment can be nullptr

> On Май 30, 2016, 2:32 след обяд, Aleix Pol Gonzalez wrote: > > Could you look a bit into why is the containment null? > > Anthony Fieroni wrote: > So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i > can't reproduce crash, KScreen is not finish recognazing, which i

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

graesslin added inline comments. INLINE COMMENTS > xuetianweng wrote in main_wayland.cpp:449 > Specifically, I mean X11 app under Wayland. Since kwin_wayland will start the > session I wonder if it will be inherit by the whole desktop session. I don't understand the concern. The QT_IM_MODULE