Re: Plasma 5.9 Kickoff Meeting

[Sebastian Kügler]

On Friday, October 7, 2016 10:19:08 AM UTC Jonathan Riddell wrote:
> Winner is Monday at 11:00UTC, 12:00midday BST and 13:00CEST
> See you then
> http://doodle.com/poll/rp5e7gffkdhf87hs

Argh, I have scheduling problems induced by some private stuff. :(

Can we re-schedule this meeting to next week? I really don't want to miss it. 
(Thursday would also work for me, but that would suck since Kai can't make it 
then. I've updated my availability in the doodle.)

Sorry for the inconvenience this causes.
-- 
sebas

Sebastian Kügler•http://vizZzion.org•http://www.kde.org

Re: Review Request 128956: Make KF5Baloo optional

[Andreas Sturmlechner]

> On Sept. 20, 2016, 12:29 p.m., Marco Martin wrote:
> > -1, would mean one code path/build config option to maintain for us
> 
> Andreas Sturmlechner wrote:
> I would understand if Plasma did much more with Baloo. But I don't see 
> that right now, it enables two rather isolated modules. While the config 
> option can be revoked any time in the future should it become impossible to 
> support, there are machines right now where the presence of Baloo does not 
> make sense at all.
> 
> Sebastian Kügler wrote:
> That may well be the case, but Marco (and I agree with him) argues that 
> we don't want increased maintenance and support burden, since we're already 
> spread thinly. A compile-time option causes this overhead, and that's the 
> reason why it's not popular among developers.

If you have a dependency chain of A—B—C where Baloo is A and its existence 
influences B and C, then I perfectly understand it. But as it stands, this is 
one runner besides other runners, just so happening to be inside the same 
repository, with zero reverse dependencies. Not a single ifdef is going to be 
added. Same for the KCM in plasma-desktop. So basically you're fine if 'build 
all' runs successfully and do not have to do anything in addition to support 
this change.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128956/#review99320
---


On Sept. 20, 2016, 12:06 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128956/
> ---
> 
> (Updated Sept. 20, 2016, 12:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037734.html
> 
> Regardless of the current state of Baloo, it is not very deeply tied into 
> Plasma. Usage in plasma-workspace comes down to providing the baloo runner.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9da918358bd797b8fe00de646b6576ba22976d0e 
>   runners/CMakeLists.txt 48cc3799f834a57031ae387a35f41859178fe317 
> 
> Diff: https://git.reviewboard.kde.org/r/128956/diff/
> 
> 
> Testing
> ---
> 
> Several days of Plasma-5 without any issues. Usage of krunner without any 
> segfaults.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Re: Review Request 128956: Make KF5Baloo optional

[Andreas Sturmlechner]

> On Sept. 20, 2016, 12:10 p.m., David Edmundson wrote:
> > >Usage of krunner without any segfaults.
> > 
> > You can just disable it with the provided checkbox, you don't gain anything 
> > from disabling it at compile time.
> 
> Andreas Sturmlechner wrote:
> That's not quite true; even with runtime-disabled baloo there have been 
> segfaults (due to the fact there was no db).
> 
> David Edmundson wrote:
> Not if you disable the search plugins in krunner.
> 
> Andreas Sturmlechner wrote:
> That should probably be tied to the KCM checkbox as well - you wouldn't 
> expect having to disable it in two places. Regardless, this is all happening 
> after login when baloo is already doing its indexing first-run - and we know 
> that the KCM checkbox does not stop the ongoing indexing.
> 
> Providing it as an option at build time does not mean you are less 
> committed to Baloo as a whole. But it makes it possible to disable it based 
> on architecture (you may argue with the 1GB-segfault-limit it is broken 
> enough on 32 bit) or choice (using a different indexing mechanism).
> 
> Anthony Fieroni wrote:
> I think you can provide backtrace for issue to be resolved, since to 
> disable plugin in compile time.

I could provide a few nice quotes there, but really, the relevant discussion is 
linked in the description above. Basically, Plasma-5 currently hard-depends on 
a Framework that is (knowingly!) broken on 32 bit and has no maintainer. Even 
though given that, it is not the core reason for trying to make it optional.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128956/#review99316
---


On Sept. 20, 2016, 12:06 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128956/
> ---
> 
> (Updated Sept. 20, 2016, 12:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037734.html
> 
> Regardless of the current state of Baloo, it is not very deeply tied into 
> Plasma. Usage in plasma-workspace comes down to providing the baloo runner.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9da918358bd797b8fe00de646b6576ba22976d0e 
>   runners/CMakeLists.txt 48cc3799f834a57031ae387a35f41859178fe317 
> 
> Diff: https://git.reviewboard.kde.org/r/128956/diff/
> 
> 
> Testing
> ---
> 
> Several days of Plasma-5 without any issues. Usage of krunner without any 
> segfaults.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

[kio-extras] [Bug 362988] sftp connection win dolphin hangs/stops working after few seconds

[Emmanuel Pescosta via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362988

Emmanuel Pescosta  changed:

   What|Removed |Added

  Component|general |default
Version|15.12.3 |unspecified
   Assignee|dolphin-bugs-n...@kde.org   |plasma-devel@kde.org
 CC||emmanuelpescosta099@gmail.c
   ||om
Product|dolphin |kio-extras

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 368008] Using a DAV filesystem, Dolphin fails to delete a file containing a µ

[Emmanuel Pescosta via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368008

Emmanuel Pescosta  changed:

   What|Removed |Added

  Component|webdav  |default
   Assignee|kdelibs-b...@kde.org|plasma-devel@kde.org
Product|kio |kio-extras

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Implementing a panel in Plasma 5.8 needs a layout to accompany it?

[Michail Vourlakos]

A small update for this for Plasma 5.8,

removing "NoDisplay=true" from metadata.desktop is not an option for 
me... The panel is appearing in the widgets list but there is the 
following not acceptable behavior.


If the user tries to add the Now Dock Panel from the widgets list then 
the panel is trying to be added in the desktop containment and that 
creates a plasma crash that can not be fixed if the user dont edit its 
plasma configuration files (so the user can not login to plasma at all 
after that).


That creates the following situation:

Now Dock Panel will be installed only through user manual installation 
and not from the 1-click install of store.kde.org which is disappointing 
actually. This is happening because I have to add a default and an empty 
layouts for the Now Dock Panel and these can not be installed from the 
same plasmoid package and correct me if I am wrong but layouts also can 
not be installed at all from 1-click install of store.kde.org



regards,

michail


On 27/09/2016 07:22 μμ, Marco Martin wrote:

On Tuesday 27 September 2016, Michail Vourlakos wrote:

Can you please confirm me the following?

1. NoDisplay=true , in the metadata.desktop, tells to the panel to not
appear in the widgets explorer, but this is a panel so I think it
shouldnt if the user can not add it from there, right?

well, that thing makes sense by itself, not just by containing plasmoids no?
so i think it makes perfectly sense for it to appear in the widget explorer

[Powerdevil] [Bug 366299] System setting "Energy Saving" window is too large for a standard laptop screen

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366299

Wolfgang Bauer  changed:

   What|Removed |Added

 CC||wba...@tmo.at

--- Comment #3 from Wolfgang Bauer  ---
Btw, this seems to be a general problem with kcmshell5, regardless of the
module.
(of course modules with fewer options are unlikely to be larger than the
screen...)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Commented On] D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme

[markuss (Markus Slopianka)]

markuss added a comment.


  This patch modifies an existing file. Removing the original copyright is 
illégal.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2983

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bgupta, davidedmundson
Cc: markuss, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated, 49 lines] D2986: Systray: Move all icon resolution to dataengine

[roberts (Lindsay Roberts)]

roberts updated this revision to Diff 7215.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2986?vs=7214=7215

REVISION DETAIL
  https://phabricator.kde.org/D2986

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: roberts, mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 47 lines] D2986: Systray: Move all icon resolution to dataengine

[roberts (Lindsay Roberts)]

roberts created this revision.
roberts added reviewers: mart, Plasma.
roberts set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
roberts added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Changes triggered by investigation into a long-running high CPU usage bug 
with system tray animations. The systray itself had icon name to icon 
resolution code, which was being triggered (twice) for every icon, every time 
any icon in the systray was updated. This code was spinning up a KIconLoader on 
each of these instances, and throwing it directly away. Each one triggered a 
large quantity of memory allocations and disk scans.
  
  This patch moves the extra bit of "appName" logic from the native part of the 
system tray to the statusnotifieritem datasource, which already had a stored 
'customIconLoader' to handle icon theme paths, and removes the special lookup 
from the sytemtray applet completely. It also prefers icons provided by the 
dataengine to doing another lookup (contentious?). This removes all the extra 
CPU usage outside of the QML scene graph and graphics drivers locally.
  
  This is very much a looking for feedback item - there are things about the 
icon loading paths I almost certainly haven't appreciated yet, and perhaps 
preferring loading by icon name in the applet has a another purpose.
  
  BUG: 356479

TEST PLAN
  Have tested locally with kgpg and steam, the two apps I have that trigger the 
old code path. In neither case, however, did the appName logic produce a 
different result to the code with just the icon search path in 
statusnotifieritem.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2986

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: roberts, mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 7 lines] D2985: Quicklaunch: Listen to external configuration changes

[drosca (David Rosca)]

drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Fixes changing applet config from scripting.
  
  BUG: 370285

TEST PLAN
  Changed default panel layout.js as per bugreport, added new default
  panel and quicklaunch was correctly added with konsole and dolphin launchers
  and 2 maximum rows configured.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D2985

AFFECTED FILES
  applets/quicklaunch/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2833: Quicklaunch: Add support for jumplist actions

[drosca (David Rosca)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKDEPLASMAADDONS5e175a976967: Quicklaunch: Add support for 
jumplist actions (authored by drosca).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2833?vs=6869=7213#toc

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2833?vs=6869=7213

REVISION DETAIL
  https://phabricator.kde.org/D2833

AFFECTED FILES
  applets/quicklaunch/package/contents/ui/IconItem.qml
  applets/quicklaunch/plugin/quicklaunch_p.cpp
  applets/quicklaunch/plugin/quicklaunch_p.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2984: Center the notification label on Breeze's lockscreen and make it use the full width before wrapping

[jensreuterberg (Jens Reuterberg)]

jensreuterberg added a comment.


  True it is a bit of an odd duck that whole area :) Either way, no blockage 
from our POV as far as I can tell

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2984

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: pritambaral, #plasma
Cc: jensreuterberg, pritambaral, plasma-devel, lesliezhai, ali-mohamed, abetts, 
sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 411 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/411/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 08 Oct 2016 09:40:48 +
Build duration: 18 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2275/3386 
(67%)CONDITIONAL 1532/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 411 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/411/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 08 Oct 2016 09:40:48 +
Build duration: 18 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2275/3386 
(67%)CONDITIONAL 1532/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Jenkins-kde-ci: oxygen-icons5 master stable-kf5-qt5 » Linux,gcc - Build # 63 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/oxygen-icons5%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/63/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 08 Oct 2016 09:05:33 +
Build duration: 1 min 31 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 1/1 (100%)FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 
(75%)CONDITIONAL 26/52 (50%)

By packages
  
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)

Jenkins-kde-ci: oxygen-icons5 master stable-kf5-qt5 » Linux,gcc - Build # 63 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/oxygen-icons5%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/63/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 08 Oct 2016 09:05:33 +
Build duration: 1 min 31 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 1/1 (100%)FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 
(75%)CONDITIONAL 26/52 (50%)

By packages
  
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)

Jenkins-kde-ci: oxygen-icons5 master kf5-qt5 » Linux,gcc - Build # 65 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/oxygen-icons5%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/65/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 08 Oct 2016 09:04:03 +
Build duration: 6 min 12 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 1/1 (100%)FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 
(75%)CONDITIONAL 26/52 (50%)

By packages
  
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)

Jenkins-kde-ci: oxygen-icons5 master kf5-qt5 » Linux,gcc - Build # 65 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/oxygen-icons5%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/65/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 08 Oct 2016 09:04:03 +
Build duration: 6 min 12 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 1/1 (100%)FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 
(75%)CONDITIONAL 26/52 (50%)

By packages
  
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)

[Differential] [Commented On] D2984: Center the notification label on Breeze's lockscreen and make it use the full width before wrapping

[pritambaral (Pritam Baral)]

pritambaral added a comment.


  In https://phabricator.kde.org/D2984#55364, @jensreuterberg wrote:
  
  > From a visual standpoint: on the one hand it breaks the "Left Align Text" 
when available
  
  
  But the surrounding visual elements (user's name, password field, 'Unlock' 
button) are all center-aligned. Even this field is normally (read: without this 
patch) center-aligned (auto-sized textbox with `Layout.alignment: 
Qt.AlignHCenter`); it is only when the text wrapping kicks in that the 
alignment switches to an apparent left-alignment, which looks out-of-place 
amidst the center-aligned elements above and below.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2984

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: pritambaral, #plasma
Cc: jensreuterberg, pritambaral, plasma-devel, lesliezhai, ali-mohamed, abetts, 
sebas

[Differential] [Commented On] D2984: Center the notification label on Breeze's lockscreen and make it use the full width before wrapping

[jensreuterberg (Jens Reuterberg)]

jensreuterberg added a comment.


  From a visual standpoint: on the one hand it breaks the "Left Align Text" 
when available, on the other the key feature of it is to inform the user of 
something critical (which trumps visual coherence to the theme). So there is no 
protest from the Visual/Design side of things

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2984

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: pritambaral, #plasma
Cc: jensreuterberg, pritambaral, plasma-devel, lesliezhai, ali-mohamed, abetts, 
sebas

Jenkins-kde-ci: oxygen-icons5 master stable-kf5-qt5 » Linux,gcc - Build # 62 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/oxygen-icons5%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/62/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 08 Oct 2016 06:51:40 +
Build duration: 31 sec

CHANGE SET
No changes

Jenkins-kde-ci: oxygen-icons5 master kf5-qt5 » Linux,gcc - Build # 64 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/oxygen-icons5%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/64/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 08 Oct 2016 06:44:48 +
Build duration: 36 sec

CHANGE SET
No changes