Re: ~Re: lookandfeel and dependencies (and potentially all kde-store related stuff)

2016-10-12 Thread Aleix Pol
On Thu, Oct 13, 2016 at 1:10 AM, Sebastian Kügler wrote: > Hey Marco, > > Sorry it took so long to give some feedback on this thread. > > On Wednesday, October 5, 2016 5:42:20 PM UTC Marco Martin wrote: >> in plasma 5.8 a new option to download look and feel packages from the kde

~Re: lookandfeel and dependencies (and potentially all kde-store related stuff)

2016-10-12 Thread Sebastian Kügler
Hey Marco, Sorry it took so long to give some feedback on this thread. On Wednesday, October 5, 2016 5:42:20 PM UTC Marco Martin wrote: > in plasma 5.8 a new option to download look and feel packages from the kde > store appeared. > since it's possible for a look and feel package to depend from

[Differential] [Commented On] D3034: Lockscreen: New session only on switchSessionPage

2016-10-12 Thread subdiff (Roman Gilg)
subdiff added a comment. > but if we have a design I don't want to just ignore it. Absolutely! I just didn't know about this mockup. Thanks for the link. I was looking at the task right here before: https://phabricator.kde.org/T3364 REPOSITORY rPLASMAWORKSPACE Plasma Workspace

Re: Review Request 129158: [PluginLoader] Use operator<< for finalArgs instead of initializer list

2016-10-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129158/#review99959 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 12,

Re: Review Request 129158: [PluginLoader] Use operator<< for finalArgs instead of initializer list

2016-10-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129158/#review99958 --- Ship it! Ship It! - David Edmundson On Oct. 12, 2016,

[Differential] [Commented On] D3034: Lockscreen: New session only on switchSessionPage

2016-10-12 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. Code is now fine, thanks. (btw if you do any other changes here, you should probably know about /usr/lib64/libexec/kscreenlocker_greet --testing - especially if you're taking screenshots) > So there is already a significant deviation from the

[Differential] [Updated] D3034: Lockscreen: New session only on switchSessionPage

2016-10-12 Thread subdiff (Roman Gilg)
subdiff updated the summary for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3034 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, davidedmundson Cc: colomar, andreask, plasma-devel,

[Differential] [Updated] D3034: Lockscreen: New session only on switchSessionPage

2016-10-12 Thread subdiff (Roman Gilg)
subdiff updated the summary for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3034 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, davidedmundson Cc: colomar, andreask, plasma-devel,

[Differential] [Updated, 27 lines] D3034: Lockscreen: New session only on switchSessionPage

2016-10-12 Thread subdiff (Roman Gilg)
subdiff added a subscriber: colomar. subdiff updated this revision to Diff 7349. subdiff added a comment. - Cleanup of newSession signal - Text on button on switch user page now changes accordingly to action Regarding the VDG: There wasn't a decision until now. But from my point of

[Differential] [Accepted] D3038: [krunner] Make KRunner on Wayland a Panel

2016-10-12 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH krunner-wayland-panel REVISION DETAIL https://phabricator.kde.org/D3038 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Updated] D3038: [krunner] Make KRunner on Wayland a Panel

2016-10-12 Thread Martin Gräßlin
graesslin added a dependency: D3035: Add request to have focus in a PlasmaShellSurface of Role Panel. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3038 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated] D3035: Add request to have focus in a PlasmaShellSurface of Role Panel

2016-10-12 Thread Martin Gräßlin
graesslin added a dependent revision: D3038: [krunner] Make KRunner on Wayland a Panel. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D3035 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland Cc:

[Differential] [Request, 3 lines] D3038: [krunner] Make KRunner on Wayland a Panel

2016-10-12 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Panel is the best matching type which gives us the required behavior like being on all

[Differential] [Commented On] D3037: Support docks which take input

2016-10-12 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D3037#56296, @luebking wrote: > E... this does not allow the dock to control input, ie. the dock can or can not take focus but you want focus if eg. clicking into a lineedit while do certainly not want it when clicking a

[Differential] [Commented On] D3037: Support docks which take input

2016-10-12 Thread Thomas Lübking
luebking added a comment. E... this does not allow the dock to control input, ie. the dock can or can not take focus but you want focus if eg. clicking into a lineedit while do certainly not want it when clicking a button that will activate a window (FSP trouble) With the stateful

[Differential] [Updated] D3035: Add request to have focus in a PlasmaShellSurface of Role Panel

2016-10-12 Thread Martin Gräßlin
graesslin added a dependent revision: D3037: Support docks which take input. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D3035 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland Cc: plasma-devel,

[Differential] [Updated] D3037: Support docks which take input

2016-10-12 Thread Martin Gräßlin
graesslin added a dependency: D3035: Add request to have focus in a PlasmaShellSurface of Role Panel. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3037 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin,

[Differential] [Request, 70 lines] D3037: Support docks which take input

2016-10-12 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY On X11 one needs to force activate a panel to pass it focus. This

[Differential] [Updated] D3036: Support forceActiveWindow for Panels

2016-10-12 Thread Martin Gräßlin
graesslin added a dependency: D3035: Add request to have focus in a PlasmaShellSurface of Role Panel. REPOSITORY rKWAYLANDINTEGRATION Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D3036 EMAIL PREFERENCES

[Differential] [Updated] D3035: Add request to have focus in a PlasmaShellSurface of Role Panel

2016-10-12 Thread Martin Gräßlin
graesslin added a dependent revision: D3036: Support forceActiveWindow for Panels. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D3035 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland Cc:

Review Request 129158: [PluginLoader] Use operator<< for finalArgs instead of initializer list

2016-10-12 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129158/ --- Review request for Plasma and Aleix Pol Gonzalez. Repository:

[Differential] [Request, 12 lines] D3036: Support forceActiveWindow for Panels

2016-10-12 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a project: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY On X11 a panel can be activated by setting it to type dock and then force

[Differential] [Updated, 79 lines] D3035: Add request to have focus in a PlasmaShellSurface of Role Panel

2016-10-12 Thread Martin Gräßlin
graesslin updated this revision to Diff 7344. graesslin added a comment. Fix unit test REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3035?vs=7343=7344 BRANCH panel-takes-focus REVISION DETAIL https://phabricator.kde.org/D3035 AFFECTED FILES

[Differential] [Updated] D3035: Add request to have focus in a PlasmaShellSurface of Role Panel

2016-10-12 Thread Martin Gräßlin
graesslin added a dependency: D3007: Add auto-hiding panel support to PlasmaShellSurface interface. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D3035 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin,

[Differential] [Updated] D3007: Add auto-hiding panel support to PlasmaShellSurface interface

2016-10-12 Thread Martin Gräßlin
graesslin added a dependent revision: D3035: Add request to have focus in a PlasmaShellSurface of Role Panel. REPOSITORY rKWAYLAND KWayland BRANCH panel-auto-hide REVISION DETAIL https://phabricator.kde.org/D3007 EMAIL PREFERENCES

[Differential] [Request, 77 lines] D3035: Add request to have focus in a PlasmaShellSurface of Role Panel

2016-10-12 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY By default a panel does not take focus. But there are panels which should get

[Differential] [Updated] D3034: Lockscreen: New session only on switchSessionPage

2016-10-12 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. Makes sense to me, but can you check that all the VDG involved in the lock screen support this as it's a deviation from the design. Also please clean up newSession signal in MainBlock.qml REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Request, 8 lines] D3034: Lockscreen: New session only on switchSessionPage

2016-10-12 Thread subdiff (Roman Gilg)
subdiff created this revision. subdiff added a reviewer: davidedmundson. subdiff added a subscriber: andreask. subdiff set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. subdiff added a project: VDG. Restricted Application added a project: Plasma. Restricted Application

Review Request 129157: Desktop Settings Tweaks

2016-10-12 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129157/ --- Review request for Plasma. Repository: plasma-desktop Description

Re: Review Request 129102: Don't enforce metadata.desktop, cleanup constructor

2016-10-12 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129102/#review99953 --- Either this patch or some other patch in the kplugin series

[Differential] [Request, 5 lines] D3033: Cancel the Switch-user-overlay by clicking on empty space

2016-10-12 Thread subdiff (Roman Gilg)
subdiff created this revision. subdiff added a reviewer: davidedmundson. subdiff set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Small patch

[Differential] [Closed] D2979: Support for relative pointer motion events

2016-10-12 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINcc2f4e324051: Support for relative pointer motion events (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2979?vs=7199=7338 REVISION DETAIL

[Differential] [Updated, 34 lines] D2953: [tabbox] Intercept QWheelEvents on QQuickWindow for scrolling

2016-10-12 Thread Martin Gräßlin
graesslin updated this revision to Diff 7337. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Updated to Thomas's suggestions as far as the code allowed to. Changed fixed-in to 5.8.2 REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Updated] D2953: [tabbox] Intercept QWheelEvents on QQuickWindow for scrolling

2016-10-12 Thread Martin Gräßlin
graesslin marked 2 inline comments as done. graesslin added inline comments. INLINE COMMENTS > luebking wrote in tabboxhandler.cpp:626 > draw the indev var out, find the last one and if it's in the end valid, set > it only once? just checked - doesn't work as nextPrev doesn't update the

[Differential] [Updated, 290 lines] D3007: Add auto-hiding panel support to PlasmaShellSurface interface

2016-10-12 Thread Martin Gräßlin
graesslin updated this revision to Diff 7335. graesslin added a comment. Added a request to show the auto-hidden panel from client side REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3007?vs=7264=7335 BRANCH panel-auto-hide REVISION DETAIL