[Differential] [Commented On] D3097: Changed the launcher modification API

2016-10-22 Thread Ivan Čukić
ivan added a comment. Just to reiterate - there should be no ABI incompatibilities compared to the previous version of the library. The API I changed was never in master (and thus never released). REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Updated] D3134: Bring back usericon region selection

2016-10-22 Thread davidk (David Kahles)
davidk updated the test plan for this revision. REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D3134 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidk, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Request, 35 lines] D3134: Bring back usericon region selection

2016-10-22 Thread davidk (David Kahles)
davidk created this revision. davidk added a reviewer: Plasma. davidk added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Also, improve error checking. TEST PLAN - selected an new icon, got the region selector - without the resize, saving

[Differential] [Closed] D3071: Port away from KDELibs4Support

2016-10-22 Thread davidk (David Kahles)
This revision was automatically updated to reflect the committed changes. Closed by commit rUSERMANAGER4aafaf4e5fea: Port away from KDELibs4Support (authored by davidk). REPOSITORY rUSERMANAGER User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3071?vs=7421=7603 REVISION

[Differential] [Commented On] D3130: Improve Activity Pager Layout for horizontal and vertical cases

2016-10-22 Thread mvourlakos (Michail Vourlakos)
mvourlakos added a comment. updated the diff in order to correspond correctly... REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3130 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, #plasma, hein Cc:

[Differential] [Updated, 47 lines] D3130: Improve Activity Pager Layout for horizontal and vertical cases

2016-10-22 Thread mvourlakos (Michail Vourlakos)
mvourlakos updated the summary for this revision. mvourlakos updated this revision to Diff 7602. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3130?vs=7596=7602 REVISION DETAIL https://phabricator.kde.org/D3130 AFFECTED FILES

[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-22 Thread antlarr (Antonio Larrosa Jimenez)
antlarr added a comment. > How many frames do we need to detect the freeze? I think 30 frames is too much by default. It's adding quite some stress on startup (lots of write to config, lots of additional threads started). Assuming we freeze with tripple buffer when trying to get the next

[Differential] [Abandoned] D3127: [platformx/x11] Add a freeze protection against OpenGL

2016-10-22 Thread Martin Gräßlin
graesslin abandoned this revision. graesslin added a comment. Abandoned for newer revision REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3127 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, davidedmundson,

[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-22 Thread Martin Gräßlin
graesslin added a comment. How many frames do we need to detect the freeze? I think 30 frames is too much by default. It's adding quite some stress on startup (lots of write to config, lots of additional threads started). Assuming we freeze with tripple buffer when trying to get the next