[Differential] [Request, 15 lines] D3195: Make task manager ignore events it can't handle

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Currently if I drag an item from widget explorer onto the panel and hover over most applets

Re: macro_bool_to_01 macro in plasma-workspace/ConfigureChecks.cmake

On Friday October 28 2016 20:24:10 Martin Gräßlin wrote: >Am 2016-10-28 19:25, schrieb René J.V. Bertin: >Sorry, I think there was a misunderstanding. I checked all the variables >set by macro_bool_to_01 in ConfigureChecks.cmake. In other files it's >not used. Indeed, and no, that wasn't what

Re: macro_bool_to_01 macro in plasma-workspace/ConfigureChecks.cmake

Am 2016-10-28 19:25, schrieb René J.V. Bertin: On Friday October 28 2016 14:00:54 Martin Graesslin wrote: Hi, I wouldn't exclude the possibility that this is old and dead/non-functional code. I just did a git grep for every of the CMake variables se through the macro_bool_to_01 and only

Re: Breakout: 10 minute test

What for me is also now confuse is that most config stuff is in syse but some not. E.g. network manager, desktop wallpaper I know there are technical reasons, but I didn't understand that when I don't use activities (one function that is nowhere described what it is used for, and hidden by

Re: Breakout: 10 minute test

On the other hand when we give the user some stuff to do. Most user will start with the windows way and say it doesn`t work cause its not the same than in win. I for example want switch to win10 cause it will fail the 10min test. So we have to shaw also in the first 10 min why kde is awesome

Review Request 129276: Make sure we're looking both for json and desktop metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129276/ --- Review request for Plasma. Repository: plasma-workspace Description

Review Request 129278: Don't reparse the metadata file if it's already loaded

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129278/ --- Review request for KDE Frameworks and Plasma. Repository:

Review Request 129279: Make sure we're looking both for json and desktop metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129279/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage

Re: macro_bool_to_01 macro in plasma-workspace/ConfigureChecks.cmake

On Friday October 28 2016 14:00:54 Martin Graesslin wrote: Hi, >>I wouldn't exclude the possibility that this is old and dead/non-functional >code. I just did a git grep for every of the CMake variables se through the >macro_bool_to_01 and only found: >dataengines/mouse/CMakeLists.txt:if

[Differential] [Updated] D3188: Modified distance function to keep aspect ratio as close as possible

antlarr marked 3 inline comments as done. antlarr added a comment. Converted the test to use QTest REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3188 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D3131: Show full scrollbar only on mouse over

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Ship it ! thanks REPOSITORY rBREEZE Breeze BRANCH arcpatch-D3131 REVISION DETAIL https://phabricator.kde.org/D3131 EMAIL PREFERENCES

[Differential] [Updated, 173 lines] D3188: Modified distance function to keep aspect ratio as close as possible

antlarr updated this revision to Diff 7737. antlarr added a comment. - Converted the test to use QTest REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3188?vs=7719=7737 BRANCH Plasma/5.8 REVISION DETAIL

Re: Breakout: UI and user vision for cloud services

On Fri, Oct 28, 2016 at 5:00 AM, Martin Klapetek wrote: > On Wed, Oct 19, 2016 at 4:54 AM, Elvis Angelaccio > wrote: >> >> >> Hi Martin, >> I'm planning to integrate KAccounts with kio-gdrive, so your email is >> very much appreciated. >> What

[Differential] [Updated, 162 lines] D3131: Show full scrollbar only on mouse over

mart updated this revision to Diff 7736. mart added a comment. - adress comments REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3131?vs=7725=7736 BRANCH arcpatch-D3131 REVISION DETAIL https://phabricator.kde.org/D3131 AFFECTED FILES

[Differential] [Updated] D3192: The combobox needs to be 2 pixels wider for contents to fit

antlarr added a reviewer: Plasma: Design. antlarr added a project: Plasma: Design. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3192 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #plasma, #plasma:_design Cc:

[Differential] [Commented On] D3191: guard against dataengine missing

davidedmundson added a comment. So why is PluginLoader::loadDataEngine returning something? REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3191 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc:

[Differential] [Request, 3 lines] D3192: The combobox needs to be 2 pixels wider for contents to fit

antlarr created this revision. antlarr added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When the size of the combo box adjusts to its contents, the dropdown listbox isn't large enough to fit the

[Differential] [Commented On] D3188: Modified distance function to keep aspect ratio as close as possible

antlarr added inline comments. INLINE COMMENTS > mart wrote in image.cpp:196 > dead code The commented out qDebug a couple of lines below shows that variable (when uncommented). Should I remove it from the qDebug line below? or just keep both? (the same for the case above) > mart wrote in

[Differential] [Request, 46 lines] D3191: guard against dataengine missing

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY this should never happen, but weird distribution packaging policies can make this happen. At least don't crash

[Differential] [Commented On] D3131: Show full scrollbar only on mouse over

hpereiradacosta added a comment. Just added a couple of comments inline. Also, (and somewhat out of topic), playing with the scrollbar width is rather easy: just change ScrollBar_Extend, ScrollBar_SliderWidth, ScrollBar_MinSliderHeight In breeze.h I experienced with

[Differential] [Commented On] D3131: Show full scrollbar only on mouse over

hpereiradacosta added a comment. In https://phabricator.kde.org/D3131#59314, @hpereiradacosta wrote: > Just added a couple of comments inline. > Also, (and somewhat out of topic), playing with the scrollbar width is rather easy: just change > > ScrollBar_Extend, >

[Differential] [Updated, 381 lines] D3089: Restore global menu support

broulik retitled this revision from "WIP: Restore global menu support" to "Restore global menu support". broulik updated this revision to Diff 7732. broulik added a comment. Restricted Application edited projects, added KWin; removed Plasma. - Rebase to QtPlatformSupport cmake changes -

[Differential] [Closed] D3190: [effects/translucency] Cancel existing animations before starting new

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN94c5704af74d: [effects/translucency] Cancel existing animations before starting new (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D3120: [kwineffects] Add hide/show cursor to EffectsHandler

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH effects-show-hide-cursor REVISION DETAIL https://phabricator.kde.org/D3120 EMAIL PREFERENCES

[Differential] [Accepted] D3168: Use microphone volume icon for capture devices/streams in applet

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D3168 EMAIL PREFERENCES

[Differential] [Requested Changes To] D3188: Modified distance function to keep aspect ratio as close as possible

mart requested changes to this revision. mart added a reviewer: mart. This revision now requires changes to proceed. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3188 EMAIL PREFERENCES

[Differential] [Changed Subscribers] D3188: Modified distance function to keep aspect ratio as close as possible

mart added inline comments. INLINE COMMENTS > image.cpp:186 > > -//qDebug() << "wanted" << m_targetSize << "options" << images; > - > -// choose the nearest resolution, always preferring images with the same > aspect ratio > +//float targetAspectRatio = (m_targetSize.height() > 0

[Differential] [Changed Subscribers] D3086: RFC: Clean up KAppMenu

graesslin added inline comments. INLINE COMMENTS > appmenu.cpp:88-89 > +auto setWindowProperty = [c](WId id, const QByteArray , const > QByteArray ) { > +const xcb_intern_atom_cookie_t cookie = xcb_intern_atom(c, > false, name.length(), name.constData()); > +

[Differential] [Commented On] D3085: RFC: Use DBusMenu if available

graesslin added inline comments. INLINE COMMENTS > CMakeLists.txt:10-13 > + find_package(XCB COMPONENTS XCB) > + set_package_properties(XCB PROPERTIES DESCRIPTION "Required for exposing > the global menu on X11" > + TYPE REQUIRED > +) HAVE_X11

[Differential] [Updated, 483 lines] D3089: WIP: Restore global menu support

broulik updated the test plan for this revision. broulik updated this revision to Diff 7730. broulik added a comment. Restricted Application edited projects, added Plasma; removed KWin. - Cleanup a bit - Listen to menuShown signal rather than assuming a showMenu call will be successful -

[Differential] [Commented On] D3166: make sure containment actions config is up to date

mart added a comment. In https://phabricator.kde.org/D3166#59071, @davidedmundson wrote: > It's still a bodge round broken user code. it is, but the thing is, that's the way is supported by the api right now, and there are users for it, so it has to work, regardless if it's quite

[Differential] [Closed] D3151: Trigger resize of input window when deco size changes

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN2e3c6c92e94e: Trigger resize of input window when deco size changes (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3151?vs=7634=7728

[Differential] [Closed] D3186: Ensure the complete decoration texture gets repainted on recreation

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN37067f538ec0: Ensure the complete decoration texture gets repainted on recreation (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Updated, 2,660 lines] D3086: RFC: Clean up KAppMenu

broulik updated the summary for this revision. broulik updated this revision to Diff 7727. broulik added a comment. - Remove GtkIcons, it's not like GTK applications support this stuff anymore... - Introduce showMenu signal so KWin can reliably know whether the menu actually showed

[Differential] [Accepted] D3151: Trigger resize of input window when deco size changes

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH input-window-maximize-5.8 REVISION DETAIL https://phabricator.kde.org/D3151 EMAIL PREFERENCES

[Differential] [Updated] D3085: RFC: Use DBusMenu if available

graesslin added a comment. you will need the change from https://phabricator.kde.org/rKWIN052fa2e4ee329810f62c29e546254fb45bf8a375 as well I fear. Otherwise it won't compile with Qt 5.8. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL

[Differential] [Updated, 1,679 lines] D3085: RFC: Use DBusMenu if available

broulik updated the summary for this revision. broulik updated the test plan for this revision. broulik updated this revision to Diff 7726. broulik added a comment. - Move setWindowProperty to x11/wayland integration to unclutter the code a bit - Adds an Alt key listener which, on

[Differential] [Updated, 168 lines] D3131: Show full scrollbar only on mouse over

mart updated this revision to Diff 7725. mart added a comment. - try harder to figure out the widget is under mouse when drawing the arrow we can't know if the widget is under mouse by the style option, and we can't access the widget when using the qstyle over QML, so check either the

[Differential] [Accepted] D3190: [effects/translucency] Cancel existing animations before starting new

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH effects-translucency-cancel-animations-5.8 REVISION DETAIL https://phabricator.kde.org/D3190 EMAIL PREFERENCES

[Differential] [Commented On] D3131: Show full scrollbar only on mouse over

mart added a comment. In https://phabricator.kde.org/D3131#59229, @hpereiradacosta wrote: > > also should be minimized since iirc their intention is also to make the scrollbar a bit slimmer by default (painted around as wide as progressbars, maybe still with wider blank working mouse

[Differential] [Request, 6 lines] D3190: [effects/translucency] Cancel existing animations before starting new

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY It can happen that startAnimation is invoked multiple times for a window. In case it was

[Differential] [Commented On] D3131: Show full scrollbar only on mouse over

hpereiradacosta added a comment. > also should be minimized since iirc their intention is also to make the scrollbar a bit slimmer by default (painted around as wide as progressbars, maybe still with wider blank working mouse area but overall smaller Just for my curiosity, where

[Differential] [Commented On] D3131: Show full scrollbar only on mouse over

mart added a comment. In https://phabricator.kde.org/D3131#59205, @mart wrote: > In https://phabricator.kde.org/D3131#59202, @hpereiradacosta wrote: > > > 3/ I agree that the animation looks good on views like dolphin and systemsettings. However for views with a header, or when you

[Differential] [Commented On] D3131: Show full scrollbar only on mouse over

hpereiradacosta added a comment. Awesome ! I just need some more time to look at the code, but as far as the visual aspect is concerned, I think its pretty cool. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3131 EMAIL PREFERENCES

[Differential] [Commented On] D3131: Show full scrollbar only on mouse over

mart added a comment. In https://phabricator.kde.org/D3131#59202, @hpereiradacosta wrote: > Hi Marco, > > Couple of comments on the look of it > > 1/ if you set the animation time to somehting long (500ms), then hover on a scrollbar, in the groove, and not on the handle, while

Re: macro_bool_to_01 macro in plasma-workspace/ConfigureChecks.cmake

On Friday, October 28, 2016 11:24:35 AM CEST René J.V. Bertin wrote: > Hi, > > Where exactly is plasma-workspace's build system supposed to find the > macro_bool_to_01 macro? Apparently it's been obsolete for quite some time > and it doesn't seem to be provided by any of the listed dependencies

[Differential] [Updated, 162 lines] D3131: Show full scrollbar only on mouse over

mart updated this revision to Diff 7720. mart added a comment. - don't draw the handle separatedly REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3131?vs=7701=7720 BRANCH arcpatch-D3131 REVISION DETAIL https://phabricator.kde.org/D3131 AFFECTED

[Differential] [Commented On] D3188: Modified distance function to keep aspect ratio as close as possible

antlarr added inline comments. INLINE COMMENTS > testfindpreferredimage.cpp:91 > + if (preferred != expected) failed++; > + std::cout << "For a screen size of " << > qPrintable(formatResolution(resolution)) > + << " the " << qPrintable(formatResolution(preferred)) << "

[Differential] [Request, 172 lines] D3188: Modified distance function to keep aspect ratio as close as possible

antlarr created this revision. antlarr added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This new version of the distance function simplifies the findPreferredImageInPackage method by using the

[Differential] [Commented On] D3131: Show full scrollbar only on mouse over

mart added a comment. In https://phabricator.kde.org/D3131#59202, @hpereiradacosta wrote: > Hi Marco, > > Couple of comments on the look of it > > 1/ if you set the animation time to somehting long (500ms), then hover on a scrollbar, in the groove, and not on the handle, while

[Differential] [Commented On] D3131: Show full scrollbar only on mouse over

hpereiradacosta added a comment. Hi Marco, Couple of comments on the look of it 1/ if you set the animation time to somehting long (500ms), then hover on a scrollbar, in the groove, and not on the handle, while making sure that the view in which you hove does not have focus, in

Re: Breakout: 10 minute test

On 10/28/2016 07:16 PM, Aleix Pol wrote: > Most issues we'd find are possibly already reported somewhere. There's a disconnect between "reported" and "developers are aware of it, and moreover its impact". > Aleix Cheers, Eike

Re: Breakout: 10 minute test

On Fri, Oct 28, 2016 at 10:35 AM, Marco Martin wrote: > On Friday 28 October 2016 03:01:47 Aleix Pol wrote: >> What do you have in mind? >> Are these things reported? >> Are the things all these people try the same things? >> >> It doesn't sound like a very stable metric to me.

Re: Breakout: UI and user vision for cloud services

On Wed, Oct 19, 2016 at 10:54 AM, Elvis Angelaccio wrote: > On Wed, Oct 19, 2016 at 5:17 AM, Martin Klapetek > wrote: >> On Mon, Oct 17, 2016 at 12:54 PM, Jonathan Riddell wrote: >>> >>> * Services integration - I see more

[Differential] [Accepted] D3186: Ensure the complete decoration texture gets repainted on recreation

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH fix-decoration-repaint-opengl-5.8 REVISION DETAIL https://phabricator.kde.org/D3186 EMAIL PREFERENCES

[Differential] [Request, 5 lines] D3186: Ensure the complete decoration texture gets repainted on recreation

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY When the decoration size changes the textures get recreated and need to be properly filled. So

macro_bool_to_01 macro in plasma-workspace/ConfigureChecks.cmake

Hi, Where exactly is plasma-workspace's build system supposed to find the macro_bool_to_01 macro? Apparently it's been obsolete for quite some time and it doesn't seem to be provided by any of the listed dependencies (= I get a not-found error). Thanks, René

[Differential] [Updated] D3183: Port potd (picture of the day) dataengine to KF5.

mart added a comment. code looks good. I tested the urls, annotated inline those that work and those that don't. Unfortunately there are still two that don't, in flickr, where a no longer valid api key is used and the wikipedia one. INLINE COMMENTS > apodprovider.cpp:83 > { > -KUrl

[Differential] [Accepted] D3184: Bring potd wallpaper back to life.

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D3184 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng,

Re: Breakout: 10 minute test

On Friday, 28 October 2016 10:35:43 BST Marco Martin wrote: > On Friday 28 October 2016 03:01:47 Aleix Pol wrote: > > What do you have in mind? > > Are these things reported? > > Are the things all these people try the same things? > > > > It doesn't sound like a very stable metric to me. > >

Re: Breakout: 10 minute test

On Friday 28 October 2016 03:01:47 Aleix Pol wrote: > What do you have in mind? > Are these things reported? > Are the things all these people try the same things? > > It doesn't sound like a very stable metric to me. for this i fear the only good way is real life user testing, which

[Differential] [Accepted] D3175: Install desktop file name on X11 windows

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH desktop-file-name-x11 REVISION DETAIL https://phabricator.kde.org/D3175 EMAIL PREFERENCES

[Differential] [Accepted] D3177: Add support for desktopFileName provided by NETWinInfo

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH desktop-file-name-x11 REVISION DETAIL https://phabricator.kde.org/D3177 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin,