[Differential] [Request, 27 lines] D3374: [effects] Introduce kcfg for FallApart effect

2016-11-15 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REPOSITORY rKWIN KWin BRANCH fall-apart-kcfgc REVISION DETAIL https://phabricator.kde.org/D3374 AFFECTED

[Differential] [Accepted] D3335: Move resolving glxSwapIntervalMesa into platform plugin

2016-11-15 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH glx-resolve-in-platform REVISION DETAIL https://phabricator.kde.org/D3335 EMAIL PREFERENCES

[Differential] [Accepted] D3296: [effects] Improve interaction between Glide and SlidingPopups effect

2016-11-15 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. sounds sane. REPOSITORY rKWIN KWin BRANCH glide-no-atom REVISION DETAIL https://phabricator.kde.org/D3296 EMAIL PREFERENCES

[Differential] [Closed] D3332: Move querying glx extensions into the platform plugin

2016-11-15 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN730fd05f58f9: Move querying glx extensions into the platform plugin (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3332?vs=8076=8192

[Differential] [Closed] D3362: Port KillWindow to X11EventFilter

2016-11-15 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN52cf47ff53bc: Port KillWindow to X11EventFilter (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3362?vs=8149=8194 REVISION DETAIL

[Differential] [Closed] D3361: Support multiple event types in X11EventFilter

2016-11-15 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN9f976a4b8dd7: Support multiple event types in X11EventFilter (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3361?vs=8148=8193 REVISION

[Differential] [Closed] D3298: [libkwineffects] Delete EffectsHandler::deleteRootProperty

2016-11-15 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN3041b871ea2c: [libkwineffects] Delete EffectsHandler::deleteRootProperty (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3298?vs=7981=8190

[Differential] [Commented On] D3329: Move glx version check functionality to platform plugin

2016-11-15 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D3329#62981, @bshah wrote: > With @broulik 's comment addressed.. +1 for the record: I'm not going to port the code to QVersionNumber. Internally KWin has the kVersionNumber which is used quite a lot in the code base.

[Differential] [Commented On] D3298: [libkwineffects] Delete EffectsHandler::deleteRootProperty

2016-11-15 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D3298#62976, @bshah wrote: > Assuming this doesn't break any other 3rd party effects(?) To my knowledge there are no 3rd party effects. And even if: we broke the ABI in 5.9 already, so at least a recompile is needed. Given

[Differential] [Accepted] D3329: Move glx version check functionality to platform plugin

2016-11-15 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. With @broulik 's comment addressed.. +1 REPOSITORY rKWIN KWin BRANCH glx-version-check-platform REVISION DETAIL https://phabricator.kde.org/D3329 EMAIL

[Differential] [Accepted] D3298: [libkwineffects] Delete EffectsHandler::deleteRootProperty

2016-11-15 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. Assuming this doesn't break any other 3rd party effects(?) REPOSITORY rKWIN KWin BRANCH effectshandler-drop-delete-root-property REVISION DETAIL

[Differential] [Commented On] D3370: KillWindow support for Wayland windows

2016-11-15 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D3370#62908, @cfeck wrote: > 5 seconds seems long in the face of a user. But if the application does actually handle the termination signal, and needs more than 5 seconds for cleanup, does it mean the cleanup procedure will be

[Differential] [Commented On] D3365: Implement interactive window selection for Wayland platforms

2016-11-15 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > broulik wrote in input.cpp:488 > Can this happen? You check for buttons being NoButton and then for button > being RightButton? Yes of course. QMouseEvent::buttons contains the buttons currently hold. So we test that no buttons are currently

[Differential] [Commented On] D3361: Support multiple event types in X11EventFilter

2016-11-15 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > broulik wrote in x11eventfilter.cpp:58 > m_eventTypes could be empty here, maybe add a Q_ASSERT in the QVector > constructor? no, it cannot be empty. just two lines above there is a check for m_eventTypes having exactly one element.

[Differential] [Updated] D3296: [effects] Improve interaction between Glide and SlidingPopups effect

2016-11-15 Thread Martin Gräßlin
graesslin added a dependent revision: D3297: [libkwineffects] Remove EffectsHandler::registerPropertyType. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3296 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin,

[Differential] [Updated] D3297: [libkwineffects] Remove EffectsHandler::registerPropertyType

2016-11-15 Thread Martin Gräßlin
graesslin added a dependency: D3296: [effects] Improve interaction between Glide and SlidingPopups effect. REPOSITORY rKWIN KWin BRANCH kwineffects-drop-register-property-type REVISION DETAIL https://phabricator.kde.org/D3297 EMAIL PREFERENCES

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-15 Thread colomar (Thomas Pfeiffer)
colomar added a comment. I haven't had the chance to play with it and I think we should still have a plan B if we get negative feedback on it during beta tests, but the concept as it is described in the latest comments makes sense to me. REPOSITORY rBREEZE Breeze REVISION DETAIL

[Differential] [Changed Subscribers] D3372: Remove Webkit usage in potd data engine.

2016-11-15 Thread xuetianweng (Xuetian Weng)
xuetianweng added a subscriber: Plasma. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3372 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart, hein, broulik Cc: #plasma, plasma-devel, lesliezhai,

[Differential] [Request, 114 lines] D3372: Remove Webkit usage in potd data engine.

2016-11-15 Thread xuetianweng (Xuetian Weng)
xuetianweng created this revision. xuetianweng added reviewers: mart, hein, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY For natgeoprovider, since the page it can be accepted by QXmlStreamReader to get

Re: Affenfels: Plasma Sprint 6-12 Feb 2017

2016-11-15 Thread Albert Astals Cid
El dimarts, 15 de novembre de 2016, a les 14:43:04 CET, Marco Martin va escriure: > On Thu, Nov 3, 2016 at 4:12 PM, Jonathan Riddell wrote: > > Come one and all and sign up for the Plasma Sprint, 6-12 Feb 2017 in > > Stuttgart. > > >

[Differential] [Commented On] D3183: Port potd (picture of the day) dataengine to KF5.

2016-11-15 Thread broulik (Kai Uwe Broulik)
broulik added a comment. I have to agree with Eike here and also apologies for chiming in at this late step. From what I can tell a full-blown web-engine isn't needed here at all. The NOAA one just looks for all script tags and extracts the URL from the _curPic call and the NatGeo

[Differential] [Commented On] D3183: Port potd (picture of the day) dataengine to KF5.

2016-11-15 Thread hein (Eike Hein)
hein added a comment. Sorry to react to this late, but I'm not happy about adding a non-optional build dependency on QtWebkit at this stage ... REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3183 EMAIL PREFERENCES

[Differential] [Commented On] D3370: KillWindow support for Wayland windows

2016-11-15 Thread cfeck (Christoph Feck)
cfeck added a comment. 5 seconds seems long in the face of a user. But if the application does actually handle the termination signal, and needs more than 5 seconds for cleanup, does it mean the cleanup procedure will be interrupted/aborted, or is only the GUI connection disconnected?

Re: Affenfels: Plasma Sprint 6-12 Feb 2017

2016-11-15 Thread Lydia Pintscher
On Nov 15, 2016 14:43, "Marco Martin" wrote: > > On Thu, Nov 3, 2016 at 4:12 PM, Jonathan Riddell wrote: > > Come one and all and sign up for the Plasma Sprint, 6-12 Feb 2017 in > Stuttgart. > > > > https://community.kde.org/Plasma/Affenfels > > > >

[Differential] [Closed] D3184: Bring potd wallpaper back to life.

2016-11-15 Thread xuetianweng (Xuetian Weng)
This revision was automatically updated to reflect the committed changes. Closed by commit rKDEPLASMAADDONS8f1310dd1e9a: Bring potd wallpaper back to life. (authored by xuetianweng). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3184?vs=7712=8180#toc REPOSITORY rKDEPLASMAADDONS

[Differential] [Closed] D3183: Port potd (picture of the day) dataengine to KF5.

2016-11-15 Thread xuetianweng (Xuetian Weng)
xuetianweng closed this revision. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3183 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Changed Subscribers] D3365: Implement interactive window selection for Wayland platforms

2016-11-15 Thread broulik (Kai Uwe Broulik)
broulik added inline comments. INLINE COMMENTS > input.cpp:488 > +if (event->buttons() == Qt::NoButton) { > +if (event->button() == Qt::RightButton) { > +cancel(); Can this happen? You check for buttons being NoButton and then for button being

[Differential] [Changed Subscribers] D3361: Support multiple event types in X11EventFilter

2016-11-15 Thread broulik (Kai Uwe Broulik)
broulik added inline comments. INLINE COMMENTS > x11eventfilter.cpp:58 > +} > +return m_eventTypes.first() == XCB_GE_GENERIC; > +} m_eventTypes could be empty here, maybe add a Q_ASSERT in the QVector constructor? REPOSITORY rKWIN KWin BRANCH x11-event-filter-multiple-types

[Differential] [Request, 131 lines] D3370: KillWindow support for Wayland windows

2016-11-15 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY AbstractClient gains a new pure virtual killWindow method and this

[Differential] [Updated] D3370: KillWindow support for Wayland windows

2016-11-15 Thread Martin Gräßlin
graesslin added a dependency: D3365: Implement interactive window selection for Wayland platforms. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3370 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin,

[Differential] [Updated] D3365: Implement interactive window selection for Wayland platforms

2016-11-15 Thread Martin Gräßlin
graesslin added a dependent revision: D3370: KillWindow support for Wayland windows. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3365 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc:

[Differential] [Commented On] D3355: add maskArea in panel view

2016-11-15 Thread mvourlakos (Michail Vourlakos)
mvourlakos added a comment. In https://phabricator.kde.org/D3355#62804, @mart wrote: > In https://phabricator.kde.org/D3355#62769, @mvourlakos wrote: > > > In https://phabricator.kde.org/D3355#62728, @mart wrote: > > > > > another thing, even if the input mask is correct, it would

[Differential] [Closed] D3341: add connector name to screen model

2016-11-15 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINc304c0a69cc0: add connector name to screen model (authored by mart). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3341?vs=8166=8167 REVISION DETAIL

[Differential] [Updated, 34 lines] D3341: add connector name to screen model

2016-11-15 Thread mart (Marco Martin)
mart updated this revision to Diff 8166. mart added a comment. Restricted Application edited projects, added KWin; removed Plasma. - shorter form of s_connectorNames.value() REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3341?vs=8157=8166 BRANCH

[Differential] [Accepted] D3341: add connector name to screen model

2016-11-15 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH arcpatch-D3341 REVISION DETAIL https://phabricator.kde.org/D3341 EMAIL PREFERENCES

[Differential] [Commented On] D3355: add maskArea in panel view

2016-11-15 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D3355#62769, @mvourlakos wrote: > In https://phabricator.kde.org/D3355#62728, @mart wrote: > > > another thing, even if the input mask is correct, it would still not work correctly: both window maximizing and snapping would go to

[Differential] [Request, 108 lines] D3367: [effects] Add interactive window selection mode to ScreenshotEffect

2016-11-15 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY EffectsHandler gains a new method to

[Differential] [Commented On] D3341: add connector name to screen model

2016-11-15 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > drm_output.cpp:196 > > +QString connectorName = > s_connectorNames.contains(connector->connector_type) ? > s_connectorNames.value(connector->connector_type) : > QByteArrayLiteral("Unknown"); > +QString modelName; QString

[Differential] [Updated] D3363: Support interactive window selection through the Platform

2016-11-15 Thread Martin Gräßlin
graesslin added a dependent revision: D3367: [effects] Add interactive window selection mode to ScreenshotEffect. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3363 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin,

[Differential] [Updated] D3367: [effects] Add interactive window selection mode to ScreenshotEffect

2016-11-15 Thread Martin Gräßlin
graesslin added a dependency: D3363: Support interactive window selection through the Platform. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3367 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland

[Differential] [Accepted] D3297: [libkwineffects] Remove EffectsHandler::registerPropertyType

2016-11-15 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH kwineffects-drop-register-property-type REVISION DETAIL https://phabricator.kde.org/D3297 EMAIL PREFERENCES

[Differential] [Commented On] D3355: add maskArea in panel view

2016-11-15 Thread mvourlakos (Michail Vourlakos)
mvourlakos added a comment. In https://phabricator.kde.org/D3355#62728, @mart wrote: > another thing, even if the input mask is correct, it would still not work correctly: both window maximizing and snapping would go to the real geometry of the window, making the "trick" obvious. window

Minutes Monday Plasma Meeting

2016-11-15 Thread Sebastian Kügler
Minutes from Monday's weekly Plasma meeting -- sebas http://www.kde.org | http://vizZzion.orgPlasma Meeting minutes 14-11-2016 Present: notmart, kbroulik, d_ed, bshah, Sho, romangg, sebas notmart: * triaging * wednesday passed in effort to iron out multiscreen problems * Kirigami2 ** side

Re: Review Request 129400: Avoid potential access of .last() on empty list

2016-11-15 Thread Marco Martin
> On Nov. 14, 2016, 1:40 p.m., Aleix Pol Gonzalez wrote: > > src/kpackagetool/kpackagetool.cpp, line 502 > > > > > > Then just change to `QStandardPath::locate`? > > David Edmundson wrote: > Sounds sensible

Re: Review Request 129400: Avoid potential access of .last() on empty list

2016-11-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129400/#review100858 --- Fix it, then Ship it! other than that, ship it

Re: Affenfels: Plasma Sprint 6-12 Feb 2017

2016-11-15 Thread Marco Martin
On Thu, Nov 3, 2016 at 4:12 PM, Jonathan Riddell wrote: > Come one and all and sign up for the Plasma Sprint, 6-12 Feb 2017 in Stuttgart. > > https://community.kde.org/Plasma/Affenfels > > https://reimbursements.kde.org/events/25 > > Includes the option of a road trip from

[Differential] [Updated] D3363: Support interactive window selection through the Platform

2016-11-15 Thread Martin Gräßlin
graesslin added a dependent revision: D3365: Implement interactive window selection for Wayland platforms. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3363 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma

[Differential] [Updated] D3365: Implement interactive window selection for Wayland platforms

2016-11-15 Thread Martin Gräßlin
graesslin added a dependency: D3363: Support interactive window selection through the Platform. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3365 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland

[Differential] [Request, 248 lines] D3365: Implement interactive window selection for Wayland platforms

2016-11-15 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The interactive window selection is implemented in InputRedirection

Re: Review Request 129400: Avoid potential access of .last() on empty list

2016-11-15 Thread David Edmundson
> On Nov. 14, 2016, 1:40 p.m., Aleix Pol Gonzalez wrote: > > src/kpackagetool/kpackagetool.cpp, line 502 > > > > > > Then just change to `QStandardPath::locate`? Sounds sensible to me. Though I don't really

[Differential] [Commented On] D3341: add connector name to screen model

2016-11-15 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > drm_output.cpp:196 > > +QString connectorName(s_connectorNames[connector->connector_type]); > +QString modelName; what if connector_type returns a number we don't know yet? Maybe a find would be better here with a fallback to unknown

[Differential] [Commented On] D3355: add maskArea in panel view

2016-11-15 Thread mart (Marco Martin)
mart added a comment. looking more into it, i see that qregions are not directly supported by qml, it should become a qvariantlist of rectangles, that's quite ugly, so scratch that. another thing, even if the input mask is correct, it would still not work correctly: both window

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

2016-11-15 Thread broulik (Kai Uwe Broulik)
broulik added a comment. We could do the same hack we have with Kickoff, where the first task manager it finds with a global shortcut will be invoked. But that's not really discoverable how to change/why it broke when you created a new panel manually, etc etc. REPOSITORY rPLASMADESKTOP

[Differential] [Updated, 34 lines] D3341: add connector name to screen model

2016-11-15 Thread mart (Marco Martin)
mart updated this revision to Diff 8154. mart added a comment. Restricted Application edited projects, added KWin; removed Plasma. - use a Qt QHash instead REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3341?vs=8153=8154 BRANCH arcpatch-D3341 REVISION

[Differential] [Commented On] D3341: add connector name to screen model

2016-11-15 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > drm_output.cpp:141-159 > +static const char * const s_connector_type_names[] = { > +[DRM_MODE_CONNECTOR_Unknown] = "Unknown", > +[DRM_MODE_CONNECTOR_VGA] = "VGA", > +[DRM_MODE_CONNECTOR_DVII]= "DVI-I", > +

[Differential] [Accepted] D3337: Remove KWin::display from kwinglobals

2016-11-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH kwinglobals-drop-display REVISION DETAIL https://phabricator.kde.org/D3337 EMAIL PREFERENCES

[Differential] [Updated, 34 lines] D3341: add connector name to screen model

2016-11-15 Thread mart (Marco Martin)
mart updated this revision to Diff 8153. mart added a comment. Restricted Application edited projects, added Plasma; removed KWin. - use a static map, like weston REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3341?vs=8090=8153 BRANCH arcpatch-D3341

[Differential] [Commented On] D3355: add maskArea in panel view

2016-11-15 Thread mart (Marco Martin)
mart added a comment. i kindof like it (snapping of windows will always be wrong but i don't think there is anything that can be done about) tough i would try passing qregions instead, in case an implementation wants something with a fancy shape INLINE COMMENTS > panelview.h:85 > + */

[Differential] [Accepted] D3361: Support multiple event types in X11EventFilter

2016-11-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH x11-event-filter-multiple-types REVISION DETAIL https://phabricator.kde.org/D3361 EMAIL PREFERENCES

[Differential] [Accepted] D3362: Port KillWindow to X11EventFilter

2016-11-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH kill-window-x11eventfilter REVISION DETAIL https://phabricator.kde.org/D3362 EMAIL PREFERENCES

[Differential] [Updated, 93 lines] D3210: make scrollbar size configurable

2016-11-15 Thread mart (Marco Martin)
mart updated this revision to Diff 8152. mart added a comment. - bigger hit area REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3210?vs=8151=8152 BRANCH arcpatch-D3210 REVISION DETAIL https://phabricator.kde.org/D3210 AFFECTED FILES

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

2016-11-15 Thread broulik (Kai Uwe Broulik)
broulik added a comment. How would I tell the "primary monitor task manager" applet? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2680 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-15 Thread hpereiradacosta (Hugo Pereira Da Costa)
hpereiradacosta added a comment. In https://phabricator.kde.org/D3210#62696, @mart wrote: > this version always has a small scrollbar, show on hover enabled when animations are enabled +1 for me. Personally, I would leave the _scrollBar_Extend to 20, to have the same hit

[Differential] [Changed Subscribers] D3341: add connector name to screen model

2016-11-15 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > drm_output.cpp:177-228 > +switch (connector->connector_type) { > +case DRM_MODE_CONNECTOR_VGA: > +connectorName = QStringLiteral("VGA"); > +break; > +case DRM_MODE_CONNECTOR_DVII: > +

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-15 Thread mart (Marco Martin)
mart added a comment. this version always has a small scrollbar, show on hover enabled when animations are enabled REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3210 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart,

[Differential] [Updated, 93 lines] D3210: make scrollbar size configurable

2016-11-15 Thread mart (Marco Martin)
mart updated this revision to Diff 8151. mart added a comment. - always small scrollbar REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3210?vs=8094=8151 BRANCH arcpatch-D3210 REVISION DETAIL https://phabricator.kde.org/D3210 AFFECTED FILES

[Differential] [Updated] D3363: Support interactive window selection through the Platform

2016-11-15 Thread Martin Gräßlin
graesslin added a dependency: D3362: Port KillWindow to X11EventFilter. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3363 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, lesliezhai,

[Differential] [Request, 367 lines] D3363: Support interactive window selection through the Platform

2016-11-15 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY A new virtual method is added to Platform: startInteractiveWindowSelection The

[Differential] [Updated] D3362: Port KillWindow to X11EventFilter

2016-11-15 Thread Martin Gräßlin
graesslin added a dependent revision: D3363: Support interactive window selection through the Platform. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3362 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma

[Differential] [Accepted] D3183: Port potd (picture of the day) dataengine to KF5.

2016-11-15 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH arcpatch-D3183 REVISION DETAIL https://phabricator.kde.org/D3183 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Re: Review Request 129404: [AppletInterface] Never pull focus away from fullRepresentation

2016-11-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129404/ --- (Updated Nov. 15, 2016, 9:31 a.m.) Status -- This change has been

[Differential] [Abandoned] D3242: Add an option to context menu to launch the application on a discrete graphics card

2016-11-15 Thread jgrulich (Jan Grulich)
jgrulich abandoned this revision. jgrulich added a comment. Closing this review, there are new ones made into kio, kservice and kinit submitted to reviewboard. REVISION DETAIL https://phabricator.kde.org/D3242 EMAIL PREFERENCES

[Differential] [Updated] D3362: Port KillWindow to X11EventFilter

2016-11-15 Thread Martin Gräßlin
graesslin updated the test plan for this revision. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3362 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, lesliezhai, ali-mohamed,

[Differential] [Updated] D3362: Port KillWindow to X11EventFilter

2016-11-15 Thread Martin Gräßlin
graesslin added a dependency: D3361: Support multiple event types in X11EventFilter. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3362 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma Cc: plasma-devel,

[Differential] [Updated] D3361: Support multiple event types in X11EventFilter

2016-11-15 Thread Martin Gräßlin
graesslin added a dependent revision: D3362: Port KillWindow to X11EventFilter. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3361 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin,