[Differential] [Closed] D3779: Fix pageStack.push("string.qml") while loading

2016-12-21 Thread apol (Aleix Pol Gonzalez)
This revision was automatically updated to reflect the committed changes. Closed by commit R169:ec2840a8998d: Fix pageStack.push("string.qml") while loading (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3779?vs=9265=9281 REVISION DETAIL

[Breeze] [Bug 373668] Lock Screen should warn when the keyboard status is not default (layout/capslock)

2016-12-21 Thread Anton
https://bugs.kde.org/show_bug.cgi?id=373668 Anton changed: What|Removed |Added Summary|Tiny keyboard layout|Lock Screen should warn

[Breeze] [Bug 373668] Tiny keyboard layout indicator is the Lock Screen

2016-12-21 Thread Anton
https://bugs.kde.org/show_bug.cgi?id=373668 Anton changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED

Re: [KWin Question] - KWin authorize external docks to manipulate tasks and windows

2016-12-21 Thread Michail Vourlakos
Στις 21 Δεκ 2016 23:17, ο χρήστης "Martin Gräßlin" έγραψε: Am 21. Dezember 2016 21:19:02 MEZ, schrieb Michail Vourlakos < mvourla...@gmail.com>: > > >On 21/12/2016 09:16 μμ, Martin Gräßlin wrote: >> send from wrong address...(or kmail is broken) >> >> Am 2016-12-21 20:15,

[Differential] [Accepted] D3779: Fix pageStack.push("string.qml") while loading

2016-12-21 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D3779 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc:

Re: [KWin Question] - KWin authorize external docks to manipulate tasks and windows

2016-12-21 Thread Martin Gräßlin
Am 21. Dezember 2016 21:19:02 MEZ, schrieb Michail Vourlakos : > > >On 21/12/2016 09:16 μμ, Martin Gräßlin wrote: >> send from wrong address...(or kmail is broken) >> >> Am 2016-12-21 20:15, schrieb Martin Gräßlin: >>> Hi, >>> >>> currently every window gets access. This

Re: [KWin Question] - KWin authorize external docks to manipulate tasks and windows

2016-12-21 Thread Michail Vourlakos
On 21/12/2016 09:16 μμ, Martin Gräßlin wrote: send from wrong address...(or kmail is broken) Am 2016-12-21 20:15, schrieb Martin Gräßlin: Hi, currently every window gets access. This will change soon. The implementation for authorization is already on the whiteboard left to me :-) nice to

[Differential] [Accepted] D3495: Scale QPainter x11 windowed backend

2016-12-21 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D3495 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, graesslin, #plasma Cc:

Re: [KWin Question] - KWin authorize external docks to manipulate tasks and windows

2016-12-21 Thread Martin Gräßlin
send from wrong address...(or kmail is broken) Am 2016-12-21 20:15, schrieb Martin Gräßlin: Hi, currently every window gets access. This will change soon. The implementation for authorization is already on the whiteboard left to me :-) Basically the required interface will be restricted. The

[Differential] [Closed] D3723: Introduce a KWin internal on-screen-notification service

2016-12-21 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:07c6878ff079: Introduce a KWin internal on-screen-notification service (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3723?vs=9267=9269

[Differential] [Closed] D3780: Show notification when pointer gets confined/locked

2016-12-21 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:696ce96e9b45: Show notification when pointer gets confined/locked (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3780?vs=9268=9271 REVISION

[Differential] [Closed] D3724: Use OnScreenNotification in kill window

2016-12-21 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:444ce02d8d7c: Use OnScreenNotification in kill window (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3724?vs=9140=9270 REVISION DETAIL

[Differential] [Accepted] D3780: Show notification when pointer gets confined/locked

2016-12-21 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH pointer-constraint-notification REVISION DETAIL https://phabricator.kde.org/D3780 EMAIL PREFERENCES

[Differential] [Updated] D3723: Introduce a KWin internal on-screen-notification service

2016-12-21 Thread Martin Gräßlin
graesslin added a dependent revision: D3780: Show notification when pointer gets confined/locked. REPOSITORY R108 KWin BRANCH on-screen-notification REVISION DETAIL https://phabricator.kde.org/D3723 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated] D3780: Show notification when pointer gets confined/locked

2016-12-21 Thread Martin Gräßlin
graesslin added a dependency: D3723: Introduce a KWin internal on-screen-notification service. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D3780 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma, #kwin Cc:

[Differential] [Request, 11 lines] D3780: Show notification when pointer gets confined/locked

2016-12-21 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: Plasma, KWin. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Inform user how the pointer constraint can be ended. REPOSITORY R108 KWin BRANCH

[Differential] [Accepted] D3723: Introduce a KWin internal on-screen-notification service

2016-12-21 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH on-screen-notification REVISION DETAIL https://phabricator.kde.org/D3723 EMAIL PREFERENCES

[Differential] [Updated, 604 lines] D3723: Introduce a KWin internal on-screen-notification service

2016-12-21 Thread Martin Gräßlin
graesslin updated this revision to Diff 9267. graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. Remove KQuickControlsAddons include REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3723?vs=9266=9267 BRANCH

[Differential] [Updated, 605 lines] D3723: Introduce a KWin internal on-screen-notification service

2016-12-21 Thread Martin Gräßlin
graesslin updated this revision to Diff 9266. graesslin marked an inline comment as done. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. - Changed the qml to use PlasmaCore.IconItem - remove useless QPointer usage - override instead of

[Differential] [Updated] D3723: Introduce a KWin internal on-screen-notification service

2016-12-21 Thread Martin Gräßlin
graesslin marked 3 inline comments as done. graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in onscreennotification.h:47 > Not an actual issue, but technically, this isn't a new virtual, but an > override we need to update the template in kdevelop ;-) That was generated

[Differential] [Request, 10 lines] D3779: Fix pageStack.push("string.qml") while loading

2016-12-21 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It wouldn't start otherwise, with an error such as:

[Differential] [Closed] D3720: Place OSD windows again on size changes

2016-12-21 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:6383f8304711: Place OSD windows again on size changes (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3720?vs=9135=9264 REVISION DETAIL

[Differential] [Closed] D3778: Add some indication that the element is highlighted

2016-12-21 Thread apol (Aleix Pol Gonzalez)
This revision was automatically updated to reflect the committed changes. Closed by commit R169:2e38274c3221: Add some indication that the element is highlighted (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3778?vs=9262=9263 REVISION

[Differential] [Accepted] D3778: Add some indication that the element is highlighted

2016-12-21 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D3778 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc:

[Differential] [Request, 2 lines] D3778: Add some indication that the element is highlighted

2016-12-21 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Shows a dim blue shade REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL

[KWin Question] - KWin authorize external docks to manipulate tasks and windows

2016-12-21 Thread Michail Vourlakos
Hello everyone, as it appears, in the following versions of Now Dock the dock will try to live outside plasmashell as a standalone separate executable. It will still use all plasma technologies from frameworks etc. but there is an issue with that design decision change as the plasma

[Differential] [Commented On] D3769: expose immutable through dbus

2016-12-21 Thread mvourlakos (Michail Vourlakos)
mvourlakos added a comment. In https://phabricator.kde.org/D3769#70551, @davidedmundson wrote: > > why? isnt kwayland independent of plasmashell? > > Sort of. > > Wayland core protocols (by design) do not allow a window to position itself, as a security measure, > Plasma needs

[Differential] [Closed] D3764: Make sure that triggering a menu action keeps respecting its action value

2016-12-21 Thread apol (Aleix Pol Gonzalez)
This revision was automatically updated to reflect the committed changes. Closed by commit R169:1a217b53d010: Make sure that triggering a menu action keeps respecting its action value (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D3764: Make sure that triggering a menu action keeps respecting its action value

2016-12-21 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D3764 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc:

[Differential] [Request, 27 lines] D3777: notice when the only screen changes

2016-12-21 Thread mart (Marco Martin)
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY in a corner case that is used a lot, the internal laptop screen gets automatically disabled when an external

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

2016-12-21 Thread Martin Klapetek
> On Dec. 21, 2016, 12:25 a.m., Aleix Pol Gonzalez wrote: > > +0 > > > > Note the correct patch would possibly be to port it to > > http://doc.qt.io/qt-5/qtimezone.html and drop that list... Btw. this list exists because there is(/was) no way to get localized list of all countries from

[Differential] [Commented On] D3495: Scale QPainter x11 windowed backend

2016-12-21 Thread davidedmundson (David Edmundson)
davidedmundson added inline comments. INLINE COMMENTS > graesslin wrote in scene_qpainter_test.cpp:202-203 > A surface is something you can attach a buffer to. It's not a window but a > wrapper for anything which might need a buffer. E.g. a cursor image. That's > what you use in this test. >

[Differential] [Updated, 53 lines] D3495: Scale QPainter x11 windowed backend

2016-12-21 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 9258. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. Fix autotest REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3495?vs=9197=9258 REVISION DETAIL

Re: Review Request 129679: Give names to knsrc files

2016-12-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129679/ --- (Updated Dec. 21, 2016, 3:07 p.m.) Status -- This change has been

Re: Review Request 129680: Give names to knsrc files

2016-12-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129680/ --- (Updated Dec. 21, 2016, 5:05 p.m.) Status -- This change has been

Re: Is it possible to add a different panel implementation for plasma?

2016-12-21 Thread Michail Vourlakos
On 21/12/2016 03:01 μμ, Marco Martin wrote: On Wednesday 21 December 2016 14:48:46 Michail Vourlakos wrote: Now Dock as it was decided by the plasma developers provides its masking and its contents through a secondary window not the original of the plasma one (when the widgets are unlocked).

[Differential] [Updated, 976 lines] D3706: WIP: Global Menu Applet

2016-12-21 Thread chinmoyr (Chinmoy Ranjan Pradhan)
chinmoyr updated the summary for this revision. chinmoyr updated this revision to Diff 9257. chinmoyr marked 8 inline comments as done. chinmoyr added a comment. Changes: - wo view REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

Re: Is it possible to add a different panel implementation for plasma?

2016-12-21 Thread Marco Martin
On Wednesday 21 December 2016 14:48:46 Michail Vourlakos wrote: > Now Dock as it was decided by the plasma developers provides its masking > and its contents through a secondary window not the original of the > plasma one (when the widgets are unlocked). So Now Dock must take care > two windows

Re: Is it possible to add a different panel implementation for plasma?

2016-12-21 Thread Michail Vourlakos
On 21/12/2016 02:30 μμ, Marco Martin wrote: On Wednesday 21 December 2016 13:48:50 Michail Vourlakos wrote: What an alternative panel needs and is not there: 1. must be able to access all the options from plasma's PanelView (strange thing is that this is already there for the

Re: Is it possible to add a different panel implementation for plasma?

2016-12-21 Thread Marco Martin
On Wednesday 21 December 2016 13:48:50 Michail Vourlakos wrote: >What an alternative panel needs and is not there: > 1. must be able to access all the options from plasma's PanelView > (strange thing is that this is already there for the javascript layout > scripts and not for qml).

[Breeze] [Bug 373668] Tiny keyboard layout indicator is the Lock Screen

2016-12-21 Thread Jens Reuterberg
https://bugs.kde.org/show_bug.cgi?id=373668 Jens Reuterberg changed: What|Removed |Added CC||jens...@kolabnow.com

[Differential] [Accepted] D3745: [Folder View] Prevent stealing drop events on Compact Representation

2016-12-21 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. checked at droparea sources, preventstealing is only used in drop events, no mouse events, so all is fine :) REPOSITORY R119 Plasma Desktop REVISION DETAIL

[Differential] [Commented On] D3769: expose immutable through dbus

2016-12-21 Thread mvourlakos (Michail Vourlakos)
mvourlakos added a comment. I have responded in the mailing list into the topic "Is it possible to add a different panel implementation for plasma?" in order to justify more the design decision taken. We can continue there if you want to. I am not negative to reconsider and I am here to

Re: Is it possible to add a different panel implementation for plasma?

2016-12-21 Thread Michail Vourlakos
please reconsider this. Is not a good idea for several reasons * will duplicate bugs I know, it feels like a fork and it's not of my own taste either... I have put so much energy and faith in Now Dock, the only thing I want is the foundations of my architecture to be able to provide what is

[Differential] [Accepted] D3743: [Folder View] Show proper trash icon when it points to trash:/

2016-12-21 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > foldermodel.cpp:235 > + > +const KFileItem rootItem(url); > I wonder if KFileItem itself should return proper trash icons? REPOSITORY

[Differential] [Commented On] D3745: [Folder View] Prevent stealing drop events on Compact Representation

2016-12-21 Thread broulik (Kai Uwe Broulik)
broulik added a comment. Such as? This is a DropArea. (Dunno why Phab never shows context) Right-clicking still invokes the FolderView menu. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3745 EMAIL PREFERENCES

[Differential] [Accepted] D3756: [Folder View] Add "Restore" from trash option

2016-12-21 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3756 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Accepted] D3755: [Folder View] Offer "Empty Trash" whenever we're in "trash" scheme

2016-12-21 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3755 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Changed Subscribers] D3745: [Folder View] Prevent stealing drop events on Compact Representation

2016-12-21 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS > CompactRepresentation.qml:30 > onDrop: folderView.model.dropCwd(event) > +preventStealing: true > did you test if this wouldn't also block some normal mouse events (that you wouldn't want blocked)? REPOSITORY R119 Plasma Desktop

[Differential] [Updated] D3769: expose immutable through dbus

2016-12-21 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. > why? isnt kwayland independent of plasmashell? Sort of. Wayland core protocols (by design) do not allow a window to position itself, as a security measure, Plasma needs to so, as you've pointed out KWayland contains a protocol to speak to kwin to

[Differential] [Commented On] D3769: expose immutable through dbus

2016-12-21 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D3769#70547, @mvourlakos wrote: > > note that if it becomes an outside application there is no way it would ever work under wayland > > why? isnt kwayland independent of plasmashell? the plasma wayland protocol, that has

Re: Please cleanup your scratch and clone repositories

2016-12-21 Thread Tomaz Canabrava
Done. On Sun, Nov 27, 2016 at 9:39 AM, Ben Cooksley wrote: > On Sat, Nov 26, 2016 at 7:53 AM, Ben Cooksley wrote: > > Hi all, > > Hi all, > > > > > To help Sysadmin assess how these types of repositories would be used > > under Phabricator, it would be

[Differential] [Commented On] D3754: expose toggleWidgetExplorer through dbus

2016-12-21 Thread mart (Marco Martin)
mart added a comment. expanding of why it should be reverted Its only use case is for another process that wants to pretend it's part of the shell, which is not a supported use case neither should be, both for sake of maintainability and of course wayland. REPOSITORY R120 Plasma

Re: Is it possible to add a different panel implementation for plasma?

2016-12-21 Thread Marco Martin
On Monday 19 December 2016 15:24:00 Michail Vourlakos wrote: > > what does dbus have to do with this? > > I am going to change the implementation and instead of a plasmashell > plugin I will provide my own shell... please reconsider this. Is not a good idea for several reasons * will duplicate

[Differential] [Commented On] D3769: expose immutable through dbus

2016-12-21 Thread mvourlakos (Michail Vourlakos)
mvourlakos added a comment. In https://phabricator.kde.org/D3769#70526, @mart wrote: > In https://phabricator.kde.org/D3769#70449, @mvourlakos wrote: > > > It's for Now Dock's next version, a discussion can be found here: > > https://phabricator.kde.org/D3754 in next version Now

[Differential] [Accepted] D3775: [KPropertiesDialog] Kill "Place in system tray" option

2016-12-21 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D3775 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, dfaure, #plasma,

[Differential] [Request, 72 lines] D3775: [KPropertiesDialog] Kill "Place in system tray" option

2016-12-21 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: dfaure, Plasma, Plasma: Design. broulik set the repository for this revision to R241 KIO. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - ksystraycmd is dead -

[Differential] [Reopened] D3754: expose toggleWidgetExplorer through dbus

2016-12-21 Thread mart (Marco Martin)
mart reopened this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3754 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, davidedmundson, #plasma, mart

[Differential] [Updated] D3754: expose toggleWidgetExplorer through dbus

2016-12-21 Thread mart (Marco Martin)
mart added a comment. I disagree, this commit should be reverted REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3754 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, davidedmundson, #plasma, mart Cc:

[Differential] [Commented On] D3769: expose immutable through dbus

2016-12-21 Thread mart (Marco Martin)
mart added a comment. no, this kind of stuff should not be ever exported trough dbus REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3769 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, #plasma,

[Differential] [Commented On] D3769: expose immutable through dbus

2016-12-21 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D3769#70449, @mvourlakos wrote: > It's for Now Dock's next version, a discussion can be found here: > https://phabricator.kde.org/D3754 in next version Now Dock will be a Dock > outside plasmashell but I want the user to have a

Re: Review Request 129680: Give names to knsrc files

2016-12-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129680/#review101532 --- Ship it! Ship It! - Marco Martin On Dec. 20, 2016,

Re: Review Request 129679: Give names to knsrc files

2016-12-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129679/#review101531 --- Ship it! Ship It! - Marco Martin On Dec. 20, 2016,