Re: Review Request 129736: KHoliday update - reworked holidays for Poland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129736/#review101691 --- holidays/plan2/holiday_pl_pl (line 171)

[Differential] [Request, 21 lines] D3897: [Panel Containment] Explicitly bind visible on both the container and the applet

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY While trying to fix a random

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

xuetianweng added a comment. In https://phabricator.kde.org/D3829#71988, @graesslin wrote: > In https://phabricator.kde.org/D3829#71877, @xuetianweng wrote: > > > In https://phabricator.kde.org/D3829#71714, @graesslin wrote: > > > > > Could you explain the relationship to global

[Differential] [Updated] D3892: [Icon Item] Support non-square icons

broulik added a dependent revision: D3893: [Folder View] Let IconItem take entire delegate width. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3892 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, hein

[Differential] [Request, 2 lines] D3893: [Folder View] Let IconItem take entire delegate width

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to R119 Plasma Desktop. broulik added a dependency: D3892: [Icon Item] Support non-square icons. Restricted Application added a project: Plasma. Restricted Application added a

[Differential] [Request, 60 lines] D3892: [Icon Item] Support non-square icons

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 355592 TEST

Review Request 129736: KHoliday update - reworked holidays for Poland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129736/ --- Review request for Plasma. Repository: kholidays Description ---

[Differential] [Closed] D3821: Add a manual test for unity launchers

This revision was automatically updated to reflect the committed changes. Closed by commit R289:ed01d6958ebe: Add a manual test for Unity launchers (authored by broulik). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3821?vs=9384=9549 REVISION DETAIL

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 504 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/504/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 31 Dec 2016 12:45:49 + Build duration: 7 min 21 sec CHANGE SET Revision

[Differential] [Closed] D3775: [KPropertiesDialog] Kill "Place in system tray" option

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a3c9ae735f63: [KPropertiesDialog] Kill "Place in system tray" option (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3775?vs=9251=9547 REVISION

[Differential] [Closed] D3834: [Panel Containment] Replace restore order logic by "algorithms"

This revision was automatically updated to reflect the committed changes. Closed by commit R119:efd188db5838: [Panel Containment] Replace restore order logic by "algorithms" (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3828: [Plasma ScrollViewStyle] Show scroll bar background only on hover

This revision was automatically updated to reflect the committed changes. Closed by commit R242:8675a31d2a99: [Plasma ScrollViewStyle] Show scroll bar background only on hover (authored by broulik). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE

[Differential] [Updated, 8 lines] D3885: Minor fix for plasma folder view filename editor

chinmoyr updated this revision to Diff 9540. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3885?vs=9537=9540 REVISION DETAIL https://phabricator.kde.org/D3885 AFFECTED FILES containments/desktop/package/contents/ui/FolderView.qml EMAIL

[Differential] [Commented On] D3885: Minor fix for plasma folder view filename editor

subdiff added a comment. Good find but why does it need to compare `_height` with `contentHeight` in the beginning at all? Normally what should imo happen is simply: - Compare `realHeight` with max possible height `maxHeight` - If larger, set `_height = realHeight`, else `_height =

Re: Review Request 129732: Fix regression in which the save dialog appears as an Open dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129732/ --- (Updated Dec. 31, 2016, 10:56 a.m.) Status -- This change has been

Re: Review Request 129732: Fix regression in which the save dialog appears as an Open dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129732/#review101686 --- Fix it, then Ship it!

Re: Review Request 129732: Fix regression in which the save dialog appears as an Open dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129732/#review101685 --- Ship it! Looks good from my POV (+ changes to comment as

Re: Review Request 129731: man: generate gperf output at build time

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129731/ --- (Updated Dec. 31, 2016, 10:30 a.m.) Status -- This change has been

[Differential] [Request, 10 lines] D3885: Minor fix for plasma folder view filename editor

chinmoyr created this revision. chinmoyr added a reviewer: Plasma. chinmoyr set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In filename editor(when wrap mode is

Re: Review Request 129732: Fix regression in which the save dialog appears as an Open dialog

> On Dec. 31, 2016, 8:40 a.m., David Faure wrote: > > autotests/kfiledialog_unittest.cpp, line 106 > > > > > > A better approach would be > >QTRY_VERIFY(findFileWidget()); > > > > This will

Re: Review Request 129732: Fix regression in which the save dialog appears as an Open dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129732/ --- (Updated Dec. 31, 2016, 9:42 a.m.) Review request for Plasma, David

Re: Review Request 129732: Fix regression in which the save dialog appears as an Open dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129732/#review101681 --- Fix still works also this morning :)

Re: Review Request 129732: Fix regression in which the save dialog appears as an Open dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129732/#review101680 --- Thanks for the fix! I did notice something strange with