[Powerdevil] [Bug 348529] Turn off screen after lock screen

2017-01-01 Thread Martin Gräßlin
https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #13 from Martin Gräßlin --- Some thoughts from using my system. I often listen to music provided by the computer. The computer's audio is connected through HDMI to one of my screens. When the screen goes into DPMS the

[Differential] [Updated] D3743: [Folder View] Show proper trash icon when it points to trash:/

2017-01-01 Thread hein (Eike Hein)
hein added a comment. I agree with mart's review comment ... why did we need to hardcode this in FV code, Kai? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3743 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

Re: Review Request 129736: KHoliday update - reworked holidays for Poland

2017-01-01 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129736/#review101714 --- Ship it! Seems ok. Ship it. Regards - Laurent Montel

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

2017-01-01 Thread S
https://bugs.kde.org/show_bug.cgi?id=340063 --- Comment #19 from S --- Hmm I see. So I guess what I was requesting with this bug report is what mate-screensaver does, ~5 second fade to black which gives the user a chance to interrupt it before the screen goes completely black.

[Differential] [Accepted] D3902: Fix X-Plasma-Drop* types

2017-01-01 Thread apol (Aleix Pol Gonzalez)
apol accepted this revision. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3902 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson, apol Cc: plasma-devel, lesliezhai, ali-mohamed,

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

2017-01-01 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=340063 --- Comment #18 from Kai Uwe Broulik --- The fade animation is pretty quick, it's not a long fade. The "black screen with cursor still on" is indicates you actually have it working. (I was thinking about fading the entire

[Differential] [Request, 21 lines] D3915: Sync startplasma with a startkde change

2017-01-01 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY https://phabricator.kde.org/R120:bc1324ceebbd71d1571d3adb51371b17391ab425 in startkde had a

[Differential] [Request, 2 lines] D3914: Rename expander icon tooltip to "close popup" to close the popup

2017-01-01 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Quoting Thomas from the bug report: > The tooltip over the triangle button when the popup

[Breeze] [Bug 374255] Notes widget icons not visible depending on Notes background and Plasma Shell Dark/Light variant

2017-01-01 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=374255 Kai Uwe Broulik changed: What|Removed |Added Resolution|--- |DUPLICATE

[Powerdevil] [Bug 348529] Turn off screen after lock screen

2017-01-01 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=348529 Kai Uwe Broulik changed: What|Removed |Added CC||mgraess...@kde.org

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

2017-01-01 Thread S
https://bugs.kde.org/show_bug.cgi?id=340063 --- Comment #17 from S --- (In reply to Kai Uwe Broulik from comment #16) > A couple of seconds before the screen turns off, no matter what is currently > shown (desktop or lock screen) OK, thanks for the explanation. So I can

[Differential] [Request, 5 lines] D3911: [Containment Appearance] Make sure to always load a config view

2017-01-01 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If StackView is empty, currentItem will

[Powerdevil] [Bug 348529] Turn off screen after lock screen

2017-01-01 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=348529 k...@web.de changed: What|Removed |Added CC||k...@web.de --- Comment #11 from k...@web.de ---

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

2017-01-01 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=340063 --- Comment #16 from Kai Uwe Broulik --- A couple of seconds before the screen turns off, no matter what is currently shown (desktop or lock screen) -- You are receiving this mail because: You are the assignee for the bug.

[Differential] [Closed] D3901: Applet: Toggle mute of items with middle mouse button

2017-01-01 Thread drosca (David Rosca)
This revision was automatically updated to reflect the committed changes. Closed by commit R115:8acf4e6a78c8: Applet: Toggle mute of items with middle mouse button (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3900: Set mute when changing volume to 0 with slider

2017-01-01 Thread drosca (David Rosca)
This revision was automatically updated to reflect the committed changes. Closed by commit R115:db9f523a03c2: Set mute when changing volume to 0 with slider (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3899: Applet: Make sure to never show empty icon

2017-01-01 Thread drosca (David Rosca)
This revision was automatically updated to reflect the committed changes. Closed by commit R115:26dfed1e5df8: Applet: Make sure to never show empty icon (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3899?vs=9573=9593

[Differential] [Closed] D3898: Applet: Don't delete delegates while drag is active

2017-01-01 Thread drosca (David Rosca)
This revision was automatically updated to reflect the committed changes. Closed by commit R115:f21aa35e9946: Applet: Don't delete delegates while drag is active (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D3898: Applet: Don't delete delegates while drag is active

2017-01-01 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. That's clever, we could do with a similar fix in kicker somewhere. REPOSITORY R115 Plasma Audio Volume Applet BRANCH

[Differential] [Changed Subscribers] D3892: [Icon Item] Support non-square icons

2017-01-01 Thread davidedmundson (David Edmundson)
davidedmundson added inline comments. INLINE COMMENTS > iconitem.cpp:325 > +const QSize = > m_iconPixmap.size().scaled(actualContainerSize, Qt::KeepAspectRatio); > +return QSize(Units::roundToIconSize(paintedSize.width()), > Units::roundToIconSize(paintedSize.height())); > } This

[Differential] [Accepted] D3900: Set mute when changing volume to 0 with slider

2017-01-01 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH mute-slider (branched from master) REVISION DETAIL https://phabricator.kde.org/D3900 EMAIL

[Differential] [Accepted] D3899: Applet: Make sure to never show empty icon

2017-01-01 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH no-empty-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D3899 EMAIL

[Differential] [Commented On] D3900: Set mute when changing volume to 0 with slider

2017-01-01 Thread drosca (David Rosca)
drosca added a comment. That's what changing volume with hotkeys is already doing. Also, we show mute icon when volume is 0, so we should also actually mute it. And at last, some hw have leds indicating mute, so this makes it light up when moving the slider to zero. REPOSITORY R115

[Differential] [Accepted] D3902: Fix X-Plasma-Drop* types

2017-01-01 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3902 EMAIL PREFERENCES

[Differential] [Commented On] D3900: Set mute when changing volume to 0 with slider

2017-01-01 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. You've not said why REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D3900 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma Cc: davidedmundson, plasma-devel,

[Differential] [Requested Changes To] D3908: [Look and feel KCM] Notify PaletteChange on DBus

2017-01-01 Thread davidedmundson (David Edmundson)
davidedmundson requested changes to this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision now requires changes to proceed. Check the "setColors" method you call on line 299 It ends with:

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

2017-01-01 Thread xuetianweng (Xuetian Weng)
xuetianweng added a comment. In https://phabricator.kde.org/D3829#72924, @graesslin wrote: > I would say the overall problem is that this here still uses an XLib event queue. But Qt uses an xcb connection. I would say this needs a porting away from the XLib code and use Qt's XCB

Re: Plasma 5.9 Release Announcement

2017-01-01 Thread Marco Martin
On Sunday 01 January 2017, Martin Gräßlin wrote: > > ‎https://share.kde.org/index.php/s/BNY8F9IuC1PT6dH > > I'm not able to edit it at all. If I click that link all I have is a > read-only document. Tried with both Firefox and Chrome and I was logged > into share.kde.org at the same time. same

Re: Plasma 5.9 Release Announcement

2017-01-01 Thread Martin Gräßlin
Am 2017-01-01 17:48, schrieb Kai Uwe Broulik: Hi all, Happy new year! ‎ Plasma 5.9 beta is approaching fast, so I setup a document for the release announcement. Please fill in all the exciting new features you awesome people have worked on, so we can get a good release announcement for the

[Differential] [Request, 11 lines] D3910: [Kicker] Don't nuke favorites on startup

2017-01-01 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Likely race introduced by using

Plasma 5.9 Release Announcement

2017-01-01 Thread Kai Uwe Broulik
Hi all, Happy new year! ‎ Plasma 5.9 beta is approaching fast, so I setup a document for the release announcement. Please fill in all the exciting new features you awesome people have worked on, so we can get a good release announcement for the Beta and a kick-ass video for the final! I

[Differential] [Changed Subscribers] D3822: use a native event filter to notice the screen was swapped

2017-01-01 Thread broulik (Kai Uwe Broulik)
broulik added inline comments. INLINE COMMENTS > screenpool.cpp:37 > { > +qApp->installNativeEventFilter(this); > + No need to install if not on X? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3822 EMAIL PREFERENCES

[Differential] [Commented On] D3908: [Look and feel KCM] Notify PaletteChange on DBus

2017-01-01 Thread broulik (Kai Uwe Broulik)
broulik added a comment. Hmm, still able to reproduce the bug at times :/ No idea why it only affects plasmashell context menus, though. Other apps like Dolphin pick up the color right away. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3908 EMAIL

[Differential] [Request, 9 lines] D3908: [Look and feel KCM] Notify PaletteChange on DBus

2017-01-01 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Code taken from Colors KCM. BUG:

[Differential] [Request, 9 lines] D3906: [Icon Applet] Fully re-populate when user changes Link URL

2017-01-01 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, dfaure. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When applying

[Differential] [Updated, 5 lines] D3904: MediaController: Stop queuedPositionUpdate timer when receiving mpris position change

2017-01-01 Thread drosca (David Rosca)
drosca updated this revision to Diff 9581. drosca added a comment. Also don't call SetPosition when slider value equals position REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3904?vs=9579=9581 BRANCH mediacontroller-fix1 (branched from

[Differential] [Commented On] D3904: MediaController: Stop queuedPositionUpdate timer when receiving mpris position change

2017-01-01 Thread drosca (David Rosca)
drosca added a comment. It's wrong, sorry. Removing the timer.running check from if is correct, but stopping it is not. In that state, it now fixes issue with seeking to 0 but it still seeks to *current* position - so you may hear pause in the playing song. REPOSITORY R120 Plasma

[Differential] [Accepted] D3904: MediaController: Stop queuedPositionUpdate timer when receiving mpris position change

2017-01-01 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH mediacontroller-fix1 (branched from Plasma/5.8) REVISION DETAIL https://phabricator.kde.org/D3904 EMAIL PREFERENCES

[Differential] [Request, 119 lines] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

2017-01-01 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This adds the "Open

[Differential] [Request, 3 lines] D3904: MediaController: Stop queuedPositionUpdate timer when receiving mpris position change

2017-01-01 Thread drosca (David Rosca)
drosca created this revision. drosca added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fixes sometimes reseting position to 0 after expanding applet. TEST PLAN No longer resets to start

[Differential] [Updated, 62 lines] D3892: [Icon Item] Support non-square icons

2017-01-01 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 9577. REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3892?vs=9561=9577 REVISION DETAIL https://phabricator.kde.org/D3892 AFFECTED FILES autotests/iconitemtest.cpp autotests/iconitemtest.h

[Differential] [Request, 10 lines] D3902: Fix X-Plasma-Drop* types

2017-01-01 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, apol. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY They are supposed to

[Differential] [Accepted] D3901: Applet: Toggle mute of items with middle mouse button

2017-01-01 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH middle-mute (branched from master) REVISION DETAIL https://phabricator.kde.org/D3901 EMAIL

[Differential] [Request, 6 lines] D3901: Applet: Toggle mute of items with middle mouse button

2017-01-01 Thread drosca (David Rosca)
drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R115 Plasma Audio Volume Applet BRANCH middle-mute (branched from master) REVISION DETAIL

[Differential] [Request, 4 lines] D3900: Set mute when changing volume to 0 with slider

2017-01-01 Thread drosca (David Rosca)
drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R115 Plasma Audio Volume Applet BRANCH mute-slider (branched from master) REVISION DETAIL

[Differential] [Request, 12 lines] D3899: Applet: Make sure to never show empty icon

2017-01-01 Thread drosca (David Rosca)
drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Streams needs to have icon to be possible to drag them to different devices. Show "unknown" icon when icon

[Differential] [Request, 2 lines] D3898: Applet: Don't delete delegates while drag is active

2017-01-01 Thread drosca (David Rosca)
drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 374288 TEST PLAN No crash, delegates are still correctly deleted REPOSITORY R115 Plasma Audio

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

2017-01-01 Thread Martin Gräßlin
graesslin added a comment. I would say the overall problem is that this here still uses an XLib event queue. But Qt uses an xcb connection. I would say this needs a porting away from the XLib code and use Qt's XCB connection and event handling. REPOSITORY R119 Plasma Desktop REVISION

Re: Review Request 129736: KHoliday update - reworked holidays for Poland

2017-01-01 Thread Roman Standzikowski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129736/ --- (Updated Jan. 1, 2017, 8:38 a.m.) Review request for Plasma.

Re: Review Request 129736: KHoliday update - reworked holidays for Poland

2017-01-01 Thread Roman Standzikowski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129736/ --- (Updated Jan. 1, 2017, 8:37 a.m.) Review request for Plasma.