Re: Review Request 129851: JpegCreator: Use Qt's support for fast downscaling and auto-rotation

> On Jan. 19, 2017, 1:17 a.m., Christoph Feck wrote: > > Good idea. Did you test the rotation part? I don't know if the rotation > > options expected by Qt are the same as returned by the settings. Yes, it works. There is only one rotation option in the settings - whether to auto-rotate or

[Differential] [Accepted] D4197: Delete KCModule before deleting QApplication

jgrulich accepted this revision. jgrulich added a reviewer: jgrulich. jgrulich added a comment. This revision is now accepted and ready to land. I just tested it and it works perfectly and the kcm doesn't crash anymore. Thank you David!!. Close this bug please with this review

[Differential] [Changed Subscribers] D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

graesslin added inline comments. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:365-370 > +#if QT_VERSION < QT_VERSION_CHECK(5, 7, 1) > +// Qt 5 at least <= 5.7.1 does not derive the directory from the passed > url > // and set the initialDirectory option accordingly, also not for

[Differential] [Commented On] D4198: Require Qt 5.7

graesslin added a comment. Do we have 5.7 on the CI? If not we should tell sysadmins. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4198 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc:

Re: Review Request 129835: [IconDialog] Set proper icons group

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129835/#review102090 --- Ping - Anthony Fieroni On Ян. 15, 2017, 12:27 след обяд,

[Differential] [Commented On] D4197: Delete KCModule before deleting QApplication

jsalatas added a comment. Seems to work. It also fixes another (maybe related) issue in network mananager: 1. Right Click the nm applet and choose "Configure Network Connections" 2. Click "Add new connection" 3. Having the "Choose a connection type" window open, click

[Differential] [Request, 2 lines] D4198: Require Qt 5.7

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We want to rely on some Qt5.7 features in upcoming Plasma for example qAsConst REPOSITORY

Re: Crash in new connections KCM

Possible fix: https://phabricator.kde.org/D4197 It's a bit of a guess, so I'm not 100% confident. Can you test and report back. Note this only fixes Jan's crash, and not CFeck's which I think is different. David

[Differential] [Request, 1 line] D4197: Delete KCModule before deleting QApplication

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Currently the dialog just leaks. As a top level window it should get cleaned up by the

[Differential] [Accepted] D4196: Fix clang address sanitiser error in SNI memcpy.

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4196 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Request, 4 lines] D4196: Fix clang address sanitiser error in SNI memcpy.

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If an image is created with no size, QImage::data() points to nullptr. We then pass this as

[Differential] [Request, 4 lines] D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

arichardson created this revision. arichardson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We currently get the following sequence of calls: KDEPlatformFileDialogHelper::setDirectory

Re: Review Request 129851: JpegCreator: Use Qt's support for fast downscaling and auto-rotation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129851/#review102089 --- Good idea. Did you test the rotation part? I don't know if

[Differential] [Commented On] D4188: Suppress warning message "No metadata file in the package..." when using desktop slideshow

davidedmundson added a comment. A commented out warning doesn't make much sense. Either it's a valid warning at which point the root cause needs fixing not hiding, or it's wrong and should be removed. The hard part of doing this change is working out which of those is correct.

[Differential] [Closed] D4181: Sonnet: segfault in trigrams generation

This revision was automatically updated to reflect the committed changes. Closed by commit R246:c7f0b1453720: Fix segfault in trigrams generation and expose MAXGRAMS constant in the header (authored by jsalatas). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D4191: Only use Qt's DBusMenuBar in Qt >= 5.7

graesslin added a comment. Sorry David, it failed again: 19:20:10 [ 56%] Built target kfontsettingsdata_unittest 19:20:10 [ 58%] Building CXX object autotests/CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/qdbusmenubar.cpp.o 19:20:11 In file included from

Review Request 129851: JpegCreator: Use Qt's support for fast downscaling and auto-rotation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129851/ --- Review request for Plasma. Repository: kio-extras Description ---

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 691 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/691/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 Jan 2017 19:29:17 + Build duration: 6 min 32 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 18 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 Jan 2017 19:24:29 + Build duration: 4 min 55 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 690 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/690/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 Jan 2017 19:10:14 + Build duration: 15 min CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 689 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/689/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 Jan 2017 18:48:09 + Build duration: 18 min CHANGE SET Revision

[Differential] [Commented On] D4191: Only use Qt's DBusMenuBar in Qt >= 5.7

davidedmundson added a comment. I deliberately left them in because they were just normal DBus calls that wouldn't do any harm (or be used) and didn't require any extra deps. However it meant nothing was implicitly including and failed. It's rebuildling now. REPOSITORY R135

[Differential] [Commented On] D4191: Only use Qt's DBusMenuBar in Qt >= 5.7

graesslin added a comment. It looks like it wasn't the only usage... [ 58%] Building CXX object autotests/CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/kfontsettingsdata.cpp.o 18:46:32 [ 60%]

Re: plasma-integration/5.9 fails on build.kde.org

Am 2017-01-18 18:05, schrieb David Edmundson: I'm on it. Thank!

[Differential] [Closed] D4191: Only use Qt's DBusMenuBar in Qt >= 5.7

This revision was automatically updated to reflect the committed changes. Closed by commit R135:9bc4c8280db5: Only use Qt's DBusMenuBar in Qt >= 5.7 (authored by davidedmundson). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D4191: Only use Qt's DBusMenuBar in Qt >= 5.7

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D4191 EMAIL PREFERENCES

[Differential] [Closed] D4135: Split implementation of keyboard layout handling into a dedicated class

This revision was automatically updated to reflect the committed changes. Closed by commit R108:d6c0a5414eb2: Split implementation of keyboard layout handling into a dedicated class (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 17 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 Jan 2017 16:57:22 + Build duration: 12 min CHANGE SET Revision

[Differential] [Request, 13 lines] D4191: Only use Qt's DBusMenuBar in Qt >= 5.7

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It didn't exist in Qt 5.6 TEST PLAN Compiled on master and still had a working menu CI

Re: plasma-integration/5.9 fails on build.kde.org

I'm on it. David

[Differential] [Accepted] D4135: Split implementation of keyboard layout handling into a dedicated class

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH keyboard-layout REVISION DETAIL https://phabricator.kde.org/D4135 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

plasma-integration/5.9 fails on build.kde.org

Hi all, I just had a look at build.kde.org and noticed that plasma-integration for 5.9 is red: 16:54:01 [ 7%] Building CXX object src/platformtheme/CMakeFiles/KDEPlasmaPlatformTheme.dir/kdeplatformtheme.cpp.o 16:54:02 In file included from

[Differential] [Updated, 229 lines] D4135: Split implementation of keyboard layout handling into a dedicated class

graesslin updated this revision to Diff 10330. graesslin added a comment. Rebased to master REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4135?vs=10323=10330 BRANCH keyboard-layout REVISION DETAIL https://phabricator.kde.org/D4135 AFFECTED FILES

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 688 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/688/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 Jan 2017 16:32:30 + Build duration: 19 min CHANGE SET Revision

[Differential] [Closed] D4128: Use an InputEventSpy to notify about key and modifier state changes

This revision was automatically updated to reflect the committed changes. Closed by commit R108:437edb45ca84: Use an InputEventSpy to notify about key and modifier state changes (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D4135: Split implementation of keyboard layout handling into a dedicated class

graesslin added inline comments. INLINE COMMENTS > bshah wrote in keyboard_input.cpp:502 > Makes kinda hard to see actual change, can you perhaps redo this RR? I'll push the other change then it hopefully solves by updating REPOSITORY R108 KWin REVISION DETAIL

[Differential] [Commented On] D4135: Split implementation of keyboard layout handling into a dedicated class

bshah added inline comments. INLINE COMMENTS > graesslin wrote in keyboard_input.cpp:502 > yeah, arc fail on my side. Please ignore :-) Makes kinda hard to see actual change, can you perhaps redo this RR? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4135 EMAIL

[Differential] [Commented On] D4135: Split implementation of keyboard layout handling into a dedicated class

graesslin added inline comments. INLINE COMMENTS > bshah wrote in keyboard_input.cpp:502 > This code seems to be from https://phabricator.kde.org/D4128? yeah, arc fail on my side. Please ignore :-) REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4135 EMAIL PREFERENCES

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 16 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 Jan 2017 16:32:00 + Build duration: 11 min CHANGE SET Revision

[Differential] [Commented On] D4171: [Task Manager] Remove arbitrary sizes from tooltip

broulik added inline comments. INLINE COMMENTS > mart wrote in ToolTipInstance.qml:92 > try to restore this spacing, maybe is the reson the tooltip is still a bit > larger I don't understand. Column (in contrast to ColumnLayout) has a default spacing of 0 REPOSITORY R119 Plasma Desktop

Topics for sprint

Hello people, I guess it is time to start thinking about the topics we are going to discuss at Plasma Sprint. For that I've started a etherpad [1], and added the ideas that Martin pointed in his earlier email. Please add topics you would like to discuss. Thanks [1]

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 15 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/15/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 Jan 2017 15:55:48 + Build duration: 7 min 19 sec CHANGE SET Revision

[Differential] [Closed] D4189: Set wrapMode to Text.WrapAnywhere.

This revision was automatically updated to reflect the committed changes. Closed by commit R242:593f8183dd4e: Set wrapMode to Text.WrapAnywhere. (authored by hein). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4189?vs=10326=10327

[Differential] [Accepted] D4189: Set wrapMode to Text.WrapAnywhere.

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D4189 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma,

[Differential] [Updated, 1 line] D4189: Set wrapMode to Text.WrapAnywhere.

hein updated this revision to Diff 10326. hein added a comment. Better pick. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4189?vs=10325=10326 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4189 AFFECTED FILES

[Differential] [Request, 1 line] D4189: Set wrapMode to Text.WrapAnywhere.

hein created this revision. hein added reviewers: Plasma, mart. hein added a subscriber: plasma-devel. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Means long main texts don't get truncated. One of the main

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 687 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/687/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 Jan 2017 15:41:37 + Build duration: 5 min 33 sec CHANGE SET Revision

[Differential] [Updated] D4135: Split implementation of keyboard layout handling into a dedicated class

bshah added inline comments. INLINE COMMENTS > keyboard_input.cpp:502 > > +class KeyStateChangedSpy : public InputEventSpy > +{ This code seems to be from https://phabricator.kde.org/D4128? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4135 EMAIL PREFERENCES

[Differential] [Accepted] D4128: Use an InputEventSpy to notify about key and modifier state changes

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH event-spy-for-key-changes REVISION DETAIL https://phabricator.kde.org/D4128 EMAIL PREFERENCES

[Differential] [Commented On] D4128: Use an InputEventSpy to notify about key and modifier state changes

graesslin added a comment. ping! REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4128 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening,

[Differential] [Updated, 295 lines] D4135: Split implementation of keyboard layout handling into a dedicated class

graesslin updated this revision to Diff 10323. graesslin added a comment. - Rebased to current master - Removed dependency to InputRedirection as no longer needed REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4135?vs=10169=10323 BRANCH keyboard-layout

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 686 - Still unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/686/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 Jan 2017 15:11:25 + Build duration: 7 min 21 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 14 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/14/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 Jan 2017 14:48:06 + Build duration: 2 min 13 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 685 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/685/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 Jan 2017 14:28:45 + Build duration: 2 min 16 sec CHANGE SET Revision

[Plasma Workspace Wallpapers] [Bug 363860] Slideshow does not cycle if only one image in set directory

https://bugs.kde.org/show_bug.cgi?id=363860 --- Comment #3 from Pit --- So the other bugreport (368955) is marked as 'solved (duplicate)', and this one here still stays unconfirmed (despite Comment 1)? Yes, I can confirm that this is a bug, and it is a very annoying

[Plasma Workspace Wallpapers] [Bug 363860] Slideshow does not cycle if only one image in set directory

https://bugs.kde.org/show_bug.cgi?id=363860 Jonathan Marten changed: What|Removed |Added CC|

[Differential] [Request, 2 lines] D4188: Suppress warning message "No metadata file in the package..." when using desktop slideshow

marten created this revision. marten added reviewers: Frameworks, Plasma. marten set the repository for this revision to R290 KPackage. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As described in

[Differential] [Commented On] D3459: Add top_left_arrow cursor symlinks

elvisangelaccio added a comment. In https://phabricator.kde.org/D3459#78342, @elvisangelaccio wrote: > In https://phabricator.kde.org/D3459#78340, @broulik wrote: > > > Are there other cursors that Mono might use? In Unity's 3D editor I get the same ugly (but mirrored) cursor. I

[Differential] [Commented On] D3459: Add top_left_arrow cursor symlinks

elvisangelaccio added a comment. In https://phabricator.kde.org/D3459#78340, @broulik wrote: > Are there other cursors that Mono might use? In Unity's 3D editor I get the same ugly (but mirrored) cursor. I tried symlinking top_right_arrow but that didn't help. Your best bet is

[Differential] [Commented On] D3459: Add top_left_arrow cursor symlinks

broulik added a comment. Are there other cursors that Mono might use? In Unity's 3D editor I get the same ugly (but mirrored) cursor. I tried symlinking top_right_arrow but that didn't help. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D3459 EMAIL PREFERENCES

[Differential] [Closed] D4118: if is not an archive, always copy

This revision was automatically updated to reflect the committed changes. Closed by commit R304:1388fb14b9d9: if is not an archive, always copy (authored by mart). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4118?vs=10313=10314 REVISION DETAIL

[Differential] [Updated, 6 lines] D4118: if is not an archive, always copy

mart updated this revision to Diff 10313. mart added a comment. - more comments REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4118?vs=10132=10313 BRANCH phab/isarchive REVISION DETAIL https://phabricator.kde.org/D4118 AFFECTED FILES

[Differential] [Accepted] D4118: if is not an archive, always copy

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Right. I think we can sensibly pick this. I would like a comment added, though, that future "don't simply install things" logic should go into the section above this one, rather than into

[Differential] [Closed] D4156: sort alphabetically category list

This revision was automatically updated to reflect the committed changes. Closed by commit R304:6393cd598bb7: sort alphabetically category list (authored by mart). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4156?vs=10274=10312 REVISION DETAIL

[Differential] [Accepted] D4156: sort alphabetically category list

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. LGTM :) REPOSITORY R304 KNewStuff BRANCH phab/sort REVISION DETAIL https://phabricator.kde.org/D4156 EMAIL PREFERENCES

[Differential] [Accepted] D4181: Sonnet: segfault in trigrams generation

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D4181 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jsalatas, #plasma, mart

[Differential] [Updated] D4178: The welcome message is better written now

mart added a comment. I also think that's a bit too verbose REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4178 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, mart Cc: broulik, plasma-devel, lesliezhai,

[Differential] [Changed Subscribers] D4171: [Task Manager] Remove arbitrary sizes from tooltip

mart added inline comments. INLINE COMMENTS > ToolTipInstance.qml:92 > Column { > -spacing: 0.75 * units.smallSpacing > -PlasmaComponents.Label { > +PlasmaExtras.Heading { > width: isWin ? textWidth : undefined try to restore this