Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 60 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/60/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 10 Feb 2017 06:31:56 +
Build duration: 8 min 19 sec

CHANGE SET
Revision e7f3d6627d9a0944ee1db06b29a19125821acfef by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit applets/appmenu/package/metadata.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2332/5964 
(39%)CONDITIONAL 1631/5912 (28%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Accepted] D4533: Avoid a crash on Kwin decoration KCM teardown

[Martin Gräßlin]

graesslin accepted this revision.
graesslin added a reviewer: graesslin.
graesslin added a comment.
This revision is now accepted and ready to land.


  Hero!

BRANCH
  scaling_final

REVISION DETAIL
  https://phabricator.kde.org/D4533

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, graesslin
Cc: graesslin, cfeck, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 740 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/740/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 10 Feb 2017 04:47:21 +
Build duration: 6 min 35 sec

CHANGE SET
Revision ce1b5f4ed8071be6ec935a2adc014094dfca7f51 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit applets/appmenu/package/metadata.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2332/5964 
(39%)CONDITIONAL 1631/5912 (28%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Commented On] D4540: fix bug with git after update to Plasma 5.9 in neon

[Idekel Santana]

idekels added a comment.


  I could not tell, I've tried changing git's language/locale but apparently 
there is no easy way to do that.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D4540

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: idekels, whiting, mpyne
Cc: cfeck, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Commented On] D4540: fix bug with git after update to Plasma 5.9 in neon

[Christoph Feck]

cfeck added a comment.


  One issue: The comments for the change that broke this state that 
'sshaskpass' has no translations, so the prompt is the same in any locale.
  
  Could you verify if 'git' uses the same prompt in any language/locale?

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D4540

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: idekels, whiting, mpyne
Cc: cfeck, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Updated] D4540: fix bug with git after update to Plasma 5.9 in neon

[Christoph Feck]

cfeck added reviewers: whiting, mpyne.
cfeck added a comment.


  Thanks, this looks good so far, but adding more eyes, because it touches 
privacy sensitive code.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D4540

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: idekels, whiting, mpyne
Cc: cfeck, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Request, 11 lines] D4540: fix bug with git after update to Plasma 5.9 in neon

[Idekel Santana]

idekels created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  After an update to Plasma 5.9 in KDE Neon, ksshaskpass stop working.
  After diging a little on the web, I found that this bug 
"https://www.mail-archive.com/kde-bugs-dist@kde.org/msg117934.html;
  was the problem and I fixed.

REPOSITORY
  R105 KDE SSH Password Dialog

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4540

AFFECTED FILES
  src/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: idekels
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Updated] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

[John Salatas]

jsalatas updated the summary for this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4538

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #frameworks, #plasma
Cc: plasma-devel, kwrite-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 739 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/739/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 09 Feb 2017 22:17:01 +
Build duration: 8 min 0 sec

CHANGE SET
Revision e32b68ed614be99b5222ca6d05e83d38741e0035 by Elvis Angelaccio: 
([kioslave/remote] Use kf5 coding style)
  change: edit kioslave/remote/remoteimpl.h
  change: edit kioslave/remote/kio_remote.h
  change: edit kioslave/remote/remoteimpl.cpp
  change: edit kioslave/remote/kdedmodule/remotedirnotify.h
  change: edit kioslave/remote/kdedmodule/remotedirnotify.cpp
  change: edit kioslave/remote/kio_remote.cpp
  change: edit kioslave/remote/kdedmodule/remotedirnotifymodule.h
  change: edit kioslave/remote/kdedmodule/remotedirnotifymodule.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2332/5964 
(39%)CONDITIONAL 1631/5912 (28%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Closed] D4489: [kioslave/remote] Use kf5 coding style

[Elvis Angelaccio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e32b68ed614b: [kioslave/remote] Use kf5 coding style 
(authored by elvisangelaccio).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4489?vs=11036=11138

REVISION DETAIL
  https://phabricator.kde.org/D4489

AFFECTED FILES
  kioslave/remote/kdedmodule/remotedirnotify.cpp
  kioslave/remote/kdedmodule/remotedirnotify.h
  kioslave/remote/kdedmodule/remotedirnotifymodule.cpp
  kioslave/remote/kdedmodule/remotedirnotifymodule.h
  kioslave/remote/kio_remote.cpp
  kioslave/remote/kio_remote.h
  kioslave/remote/remoteimpl.cpp
  kioslave/remote/remoteimpl.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Request, 6 lines] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

[John Salatas]

jsalatas created this revision.
jsalatas added reviewers: Frameworks, Plasma.
jsalatas set the repository for this revision to R39 KTextEditor.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: kwrite-devel, plasma-devel.

REVISION SUMMARY
  This patch addresses 3 issues
  
  1. Currently if you try to convert the cursor to coordinates and then convert 
these coordinates back to a cursor again, it produces an invalid cursor (-1, 
-1) when the original cursor is located at the end of line
  
  2. Converting back to cursor coordinates that have been produced by 
`cursorToCoordinate(view->cursorPosition())` and 
`coordinatesToCursor(view->cursorPositionCoordinates())` doesn't always produce 
the same results as the `includeBorder` option doesn't seem to be used 
consistently.
  
  3. Although I cannot find a test case for this, it doen't seem to make any 
sense the line `scrollPos(max, max.column(), calledExternally);` in 
`KateViewInternal::makeVisible` function.   Was it supposed to be that way (ie 
force when the last line is not empty and not force when it is), or is it just 
a typo? :\  I would appreciate any reasoning about this!

TEST PLAN
  1. Create a new app with a single `KTextEditor::View` widget (similar to 
kwrite).
  
  2. connect the view's `cursorPositionChanged` signal with a slot in the 
window which contains the following code
  
qDebug() << " original cursor" << view->cursorPosition();
QPoint p1 = view->cursorToCoordinate(view->cursorPosition());
KTextEditor::Cursor c1 = view->coordinatesToCursor(p1);
qDebug() << "converted cursor" << c1;
qDebug() << "converted cursor 2" << 
view->coordinatesToCursor(view->cursorPositionCoordinates());
  
  
  
  3. Run the application and start typing (I typed 52 characters in the first 
line) and then pressed the  key sometimes)
  
  4. Press Back Arrow key until you are in the beginning of the document.
  
  In steps 3 and 4 the three cursors are the same (this wasn't the case before).
  
  Before you get something like the following
  
original cursor (0, 1)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 2)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 3)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 4)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 5)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 6)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 7)
converted cursor (-1, -1)
..
 original cursor (0, 48)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 49)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 50)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 51)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 52)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (1, 0)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (2, 0)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (3, 0)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
.
 original cursor (0, 52)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 51)
converted cursor (0, 51)
converted cursor 2 (-1, -1)
 original cursor (0, 50)
converted cursor (0, 50)
converted cursor 2 (-1, -1)
 original cursor (0, 49)
converted cursor (0, 49)
converted cursor 2 (-1, -1)
 original cursor (0, 48)
converted cursor (0, 48)
converted cursor 2 (-1, -1)
 original cursor (0, 47)
converted cursor (0, 47)
converted cursor 2 (0, 51)
 original cursor (0, 46)
converted cursor (0, 46)
converted cursor 2 (0, 50)
 original cursor (0, 45)
converted cursor (0, 45)
converted cursor 2 (0, 49)
 original cursor (0, 44)
converted cursor (0, 44)
converted cursor 2 (0, 48)
 original cursor (0, 43)
converted cursor (0, 43)
converted cursor 2 (0, 47)
 original cursor (0, 42)
converted cursor (0, 42)
converted cursor 2 (0, 46)
 original cursor (0, 41)
converted cursor (0, 41)
converted cursor 2 (0, 45)
.
 original cursor (0, 6)
converted cursor (0, 6)
converted cursor 2 (0, 10)
 original cursor (0, 5)
converted cursor (0, 5)
converted cursor 2 (0, 9)
 original cursor (0, 4)
converted cursor (0, 4)
converted cursor 2 (0, 8)
 original cursor (0, 3)
converted cursor (0, 3)
converted cursor 2 (0, 7)
 original cursor (0, 2)
converted cursor (0, 2)
converted cursor 2 (0, 6)
 original cursor (0, 1)
converted 

[Differential] [Commented On] D4533: Avoid a crash on Kwin decoration KCM teardown

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> kcm.cpp:103
>  m_quickView->rootContext()->setContextProperty("_borderSizesIndex", 3); 
> // 3 is normal
> -m_quickView->rootContext()->setContextProperty("configurationModule", 
> this);
> +m_quickView->rootContext()->setContextProperty("leftButtons", 
> m_leftButtons);
> +m_quickView->rootContext()->setContextProperty("rightButtons", 
> m_rightButtons);

while you are at it, QStringLiteral?

REVISION DETAIL
  https://phabricator.kde.org/D4533

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: cfeck, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Commented On] D4533: Avoid a crash on Kwin decoration KCM teardown

[Christoph Feck]

cfeck added a comment.


  Be my hero!
  
  +1

REVISION DETAIL
  https://phabricator.kde.org/D4533

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: cfeck, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 58 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/58/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 09 Feb 2017 18:44:38 +
Build duration: 7 min 56 sec

CHANGE SET
Revision 5eb79cf68eb7883da4a4b8d132b70f032157d802 by bvbfan: ([ContextMenu] 
Ungrab mouse in taskmanager)
  change: edit applets/taskmanager/package/contents/ui/ContextMenu.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1566/3802 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

[Differential] [Closed] D4491: Let make taskmanager tooltip readable again

[Anthony Fieroni]

anthonyfieroni closed this revision.
anthonyfieroni added a comment.


  
https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.9=4c7022b936da587aa081cddbd419e32597718954

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4491

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma:_design, #plasma, hein
Cc: broulik, subdiff, hein, plasma-devel, davidedmundson, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Closed] D4518: Ungrab mouse in taskmanager context menu

[Anthony Fieroni]

anthonyfieroni closed this revision.
anthonyfieroni added a comment.


  
https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.9=5eb79cf68eb7883da4a4b8d132b70f032157d802

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4518

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, davidedmundson, broulik, hein
Cc: plasma-devel, #plasma, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Accepted] D4534: [Folder View] Don't show script execution prompt on desktop:/

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Oh I see.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4534

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hein, fvogt, #plasma, davidedmundson, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4534: [Folder View] Don't show script execution prompt on desktop:/

[Kai Uwe Broulik]

broulik added a comment.


  The "untrusted non-executable desktop file" and "script execution prompt" are 
completely orthogonal (for some reason).
  
  With this patch I still get the security warning:
  
  - non-executable .desktop file on some random location: → "would you like to 
run or open this file?" → Run → "If you don't trust this application, click 
Cancel"
  - executable .desktop file on some random location: → "If you don't trust 
this application, click Cancel"
  
  - non-executable .desktop file on desktop: → "If you don't trust this 
application, click Cancel"
  - executable .desktop file on desktop → runs right away
  
  What I changed is that I no longer get the "would you like to run or open 
this file?" prompt for executable .desktop files on desktop:/ which breaks the 
workflow of many.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4534

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hein, fvogt, #plasma, davidedmundson, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4534: [Folder View] Don't show script execution prompt on desktop:/

[David Faure]

dfaure added a comment.


  The code that creates the application shortcuts that you mention, should make 
them executable.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4534

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hein, fvogt, #plasma, davidedmundson, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Requested Changes To] D4534: [Folder View] Don't show script execution prompt on desktop:/

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  This reintroduces the security bug that this whole thing was about in the 
first place.
  
  Download some file from the internet, save on desktop, click on it - boom.
  The Unix principle is that you must make the file executable first before it 
will actually execute anything.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4534

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hein, fvogt, #plasma, davidedmundson, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Accepted] D4534: [Folder View] Don't show script execution prompt on desktop:/

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4534

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hein, fvogt, dfaure, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Updated, 6 lines] D4534: [Folder View] Don't show script execution prompt on desktop:/

[Kai Uwe Broulik]

broulik updated this revision to Diff 11130.
broulik added a comment.


  - Check for the location of the URL we're trying to run instead of the main 
folder view url (indirectly through parseDesktopFile), this way when opening a 
subfolder in desktop:/ through cascading it will again ask for confirmation

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4534?vs=11127=11130

REVISION DETAIL
  https://phabricator.kde.org/D4534

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein, fvogt, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Request, 40 lines] D4535: Fix crash in Screen Locker KCM on teardown

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  As described in https://bugreports.qt.io/browse/QTBUG-57714  exposing a
  QWidget as a context item to QtQuick can crash. Especially as the
  engine's context property gets deleted whilst deleting the parent item.
  
  This patch reworks the code so that exposed properties go through a
  proxy QObject.
  
  CCBUG: 373628

TEST PLAN
  Pressing back whilst in the screenlocker KCM used to crash every time,
  now it doesn't.
  
  Also changed the wallpaper type, new settings appeared, I went from flat
  image to a specific wallpaper, and then locked my screen.

REPOSITORY
  R133 KScreenLocker

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4535

AFFECTED FILES
  kcm/kcm.cpp
  kcm/kcm.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Request, 4 lines] D4534: [Folder View] Don't show script execution prompt on desktop:/

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein, fvogt, dfaure.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This utterly breaks the workflow of users when you have a default desktop 
containment and then some application shortcuts on there.

TEST PLAN
  No longer get that prompt for when I have a regular folderview containment 
but still have it for other places where I wouldn't expect executable things.
  We still have the prompt for non-executable "untrusted" desktop files (which 
btw comes even if you accepted the first prompt...)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4534

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein, fvogt, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 738 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/738/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 09 Feb 2017 17:28:13 +
Build duration: 13 min

CHANGE SET
Revision 4c7335230f90b288fa875ba5d1a589e14bbc86fe by Marco Martin: (turn the 
NotificationItem in a MouseArea)
  change: edit applets/notifications/package/contents/ui/NotificationItem.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2332/5964 
(39%)CONDITIONAL 1631/5912 (28%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 59 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/59/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 09 Feb 2017 17:28:12 +
Build duration: 6 min 14 sec

CHANGE SET
Revision 4c7335230f90b288fa875ba5d1a589e14bbc86fe by Marco Martin: (turn the 
NotificationItem in a MouseArea)
  change: edit applets/notifications/package/contents/ui/NotificationItem.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2332/5964 
(39%)CONDITIONAL 1631/5912 (28%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Request, 33 lines] D4533: Avoid a crash on Kwin decoration KCM teardown

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  As described in https://bugreports.qt.io/browse/QTBUG-57714  exposing a
  QWidget as a context item to QtQuick can crash. Especially as the
  engine's context property gets deleted whilst deleting the parent item.
  
  This patch reworks the code so that the models are exposed to QML
  directly rather than going through a QWidget.
  
  CCBUG: 373628

TEST PLAN
  Pressing back whilst in the decoration KCM used to crash every time, now it 
doesn't.
  I still have the buttons.

BRANCH
  scaling_final

REVISION DETAIL
  https://phabricator.kde.org/D4533

AFFECTED FILES
  kcmkwin/kwindecoration/kcm.cpp
  kcmkwin/kwindecoration/kcm.h
  kcmkwin/kwindecoration/qml/Buttons.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Request, 2 lines] D4532: fix discover desktopid in favorties

[Harald Sitter]

sitter created this revision.
sitter added reviewers: hein, apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4532

AFFECTED FILES
  applets/kickoff/package/contents/config/main.xml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, hein, apol
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Request, 2 lines] D4531: add discover to the system application tab in kickoff

[Harald Sitter]

sitter created this revision.
sitter added reviewers: hein, apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4531

AFFECTED FILES
  applets/kickoff/package/contents/config/main.xml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, hein, apol
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 737 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/737/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 09 Feb 2017 16:09:46 +
Build duration: 13 min

CHANGE SET
Revision 1750080bdd95452a5552d10bed0fdf43b6baaae7 by Bhushan Shah: (Fix 
wallpaper configuration for plasma mobile)
  change: edit 
wallpapers/image/imagepackage/platformcontents/phone/ui/config.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2332/5964 
(39%)CONDITIONAL 1631/5912 (28%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 606 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/606/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 09 Feb 2017 16:06:31 +
Build duration: 5 min 34 sec

CHANGE SET
Revision f94e31e08ab28af3e5bacf2844bc85f3c9286dda by kde: ([Containment 
Configuration] Hide containment type drop-down if there#039;s)
  change: edit 
desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 736 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/736/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 09 Feb 2017 15:54:31 +
Build duration: 14 min

CHANGE SET
Revision d6aad9eb710441f246e8c2718a56e0974641a780 by Bhushan Shah: (Port image 
wallpaper code to use qCDebug)
  change: edit wallpapers/image/CMakeLists.txt
  change: edit wallpapers/image/backgroundlistmodel.cpp
  change: edit wallpapers/image/image.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2332/5964 
(39%)CONDITIONAL 1631/5912 (28%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Closed] D4523: [Containment Configuration] Hide containment type drop-down if there's only one containment to choose from

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:f94e31e08ab2: [Containment Configuration] Hide 
containment type drop-down if there's only one… (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4523?vs=11109=11121

REVISION DETAIL
  https://phabricator.kde.org/D4523

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Closed] D4528: Fix wallpaper configuration for plasma mobile

[Bhushan Shah]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1750080bdd95: Fix wallpaper configuration for plasma 
mobile (authored by bshah).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4528?vs=6=11120

REVISION DETAIL
  https://phabricator.kde.org/D4528

AFFECTED FILES
  wallpapers/image/imagepackage/platformcontents/phone/ui/config.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Accepted] D4528: Fix wallpaper configuration for plasma mobile

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-wp-config-mobile

REVISION DETAIL
  https://phabricator.kde.org/D4528

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Request, 32 lines] D4530: WIP: Don't re-show auto-hidden client on geometry change if they're still at a screen edge

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, KWin.
broulik set the repository for this revision to R131 Plasma Wallpapers.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When you have an applet whose size changes (e.g. global menu) it will cause 
the panel to re-show.
  
  BUG: 376239

TEST PLAN
  TODO:
  
  - Wayland
  - Unittests
  
  (Patch to see whether I'm at least somewhat on the right track with this)
  
  Put a panel at the bottom (and top), added global menu, centered the panel, 
switched between different windows, panel didn't re-show but was still 
accessible by touching the screen edge with my mouse

REPOSITORY
  R131 Plasma Wallpapers

REVISION DETAIL
  https://phabricator.kde.org/D4530

AFFECTED FILES
  client.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #kwin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Closed] D4529: Port image wallpaper code to use qCDebug

[Bhushan Shah]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d6aad9eb7104: Port image wallpaper code to use qCDebug 
(authored by bshah).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4529?vs=7=8

REVISION DETAIL
  https://phabricator.kde.org/D4529

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.cpp
  wallpapers/image/image.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Accepted] D4529: Port image wallpaper code to use qCDebug

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  imagewallpaper/qcdebug

REVISION DETAIL
  https://phabricator.kde.org/D4529

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Request, 44 lines] D4529: Port image wallpaper code to use qCDebug

[Bhushan Shah]

bshah created this revision.
bshah added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  And remove some useless debug statements as well

TEST PLAN
  no more useless debug statment

REPOSITORY
  R120 Plasma Workspace

BRANCH
  imagewallpaper/qcdebug

REVISION DETAIL
  https://phabricator.kde.org/D4529

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.cpp
  wallpapers/image/image.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Request, 5 lines] D4528: Fix wallpaper configuration for plasma mobile

[Bhushan Shah]

bshah created this revision.
bshah added reviewers: Plasma, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  https://phabricator.kde.org/R120:f6ce91499a16cd9e8fa4b56fdadf254e3ab79bd1 
replace the height/width property of Image with
  targetSize, and phone image configuraiton was not adopted for that
  change resulting in broken configuration window for plasma mobile

TEST PLAN
  tested on phone

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-wp-config-mobile

REVISION DETAIL
  https://phabricator.kde.org/D4528

AFFECTED FILES
  wallpapers/image/imagepackage/platformcontents/phone/ui/config.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Closed] D4521: Activate minimise all plasmoid on mouse enter if the user is dragging mimedata

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:5fb9a2585d9f: Activate minimise all plasmoid on mouse 
enter if the user is dragging mimedata (authored by davidedmundson).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4521?vs=11104=5

REVISION DETAIL
  https://phabricator.kde.org/D4521

AFFECTED FILES
  applets/minimizeall/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, anthonyfieroni
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 58 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/58/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 09 Feb 2017 14:43:03 +
Build duration: 17 min

CHANGE SET
Revision bcb9ede5caabac3d5086dbcdcccfd7bc44211704 by kde: ([System Tray 
Containment] Ungrab mouse before opening context menu)
  change: edit applets/systemtray/systemtray.cpp
Revision 172ab88346683fcc0f1dff6b05b3a50b85659e98 by kde: ([System Tray 
Containment] Drop useless Q_INVOKABLE from .cpp file)
  change: edit applets/systemtray/systemtray.cpp
Revision 92601876d18c0974aa524a84c3765f279c581ed9 by kde: ([DesktopView] show() 
ConfigView when it is already opened)
  change: edit shell/desktopview.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2332/5964 
(39%)CONDITIONAL 1631/5912 (28%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 735 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/735/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 09 Feb 2017 14:44:18 +
Build duration: 5 min 44 sec

CHANGE SET
Revision bcb9ede5caabac3d5086dbcdcccfd7bc44211704 by kde: ([System Tray 
Containment] Ungrab mouse before opening context menu)
  change: edit applets/systemtray/systemtray.cpp
Revision 172ab88346683fcc0f1dff6b05b3a50b85659e98 by kde: ([System Tray 
Containment] Drop useless Q_INVOKABLE from .cpp file)
  change: edit applets/systemtray/systemtray.cpp
Revision 6a19978f1dadd5490e0a911a402807db26aee31d by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit applets/appmenu/package/metadata.desktop
Revision 1e9a3875e5bda036bd2060aaedc57932edface72 by David Edmundson: (Match 
QtQuick import to minimum Qt version)
  change: edit applets/digital-clock/package/contents/ui/DigitalClock.qml
Revision 92601876d18c0974aa524a84c3765f279c581ed9 by kde: ([DesktopView] show() 
ConfigView when it is already opened)
  change: edit shell/desktopview.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2332/5964 
(39%)CONDITIONAL 1631/5912 (28%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Updated] D4525: Fix crash when invoking Present Windows with the group dialog open.

[Anthony Fieroni]

anthonyfieroni added a comment.


  This is needed
  
  1. Enable highlight windows
  2. Hover group item
  3. Left click on effect is stopped
  4. Move mouse over window list
  5. Ugly highlight window effect
  
  So add a guard
  
if (m_taskManagerItem) {
KWindowEffects::presentWindows(m_taskManagerItem->window()->winId(), 
winIds);
}

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4525

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, anthonyfieroni
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Request, 8 lines] D4526: Lazy QUrl::fromUserInput in web browser

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  So typing bbc.co.uk  loads http://bbc.co.uk   not just appending
  /bbc.co.uk as a relative URL to the current site.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4526

AFFECTED FILES
  applets/webbrowser/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Closed] D4524: rename wireless power saving to wireless

[Sebastian Kügler]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:f211aabfaf24: rename wireless power saving to wireless 
(authored by sebas).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4524?vs=0=2

REVISION DETAIL
  https://phabricator.kde.org/D4524

AFFECTED FILES
  daemon/actions/bundled/powerdevilwirelesspowersavingaction.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, davidedmundson, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Request, 2 lines] D4525: Fix crash when invoking Present Windows with the group dialog open.

[Eike Hein]

hein created this revision.
hein added reviewers: Plasma, anthonyfieroni.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  This fixes a regression from 
https://phabricator.kde.org/R119:aeec4ae8869b487fe516a920b49a1fde4ea48c06 which 
unsets the taskManagerItem
  prop when the group dialog is shown for unclear reasons.
  
  Anthony, can you comment on why you added this? It seems to be
  unnecessary in my testing.
  
  CCMAIL:bvb...@abv.bg
  BUG:376205

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4525

AFFECTED FILES
  applets/taskmanager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, anthonyfieroni
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Accepted] D4523: [Containment Configuration] Hide containment type drop-down if there's only one containment to choose from

[Eike Hein]

hein accepted this revision.
hein added a reviewer: hein.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4523

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Powerdevil] [Bug 376037] Plasma ignores screen lid action settings

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=376037

Christoph Feck  changed:

   What|Removed |Added

   Assignee|k...@davidedmundson.co.uk|plasma-devel@kde.org
   Target Milestone|1.0 |---
Product|plasmashell |Powerdevil
  Component|general |general

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Accepted] D4524: rename wireless power saving to wireless

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R122 Powerdevil

BRANCH
  sebas/wps

REVISION DETAIL
  https://phabricator.kde.org/D4524

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Accepted] D4524: rename wireless power saving to wireless

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a reviewer: broulik.

REPOSITORY
  R122 Powerdevil

BRANCH
  sebas/wps

REVISION DETAIL
  https://phabricator.kde.org/D4524

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, davidedmundson, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Updated] D4524: rename wireless power saving to wireless

[Sebastian Kügler]

sebas updated the summary for this revision.
sebas updated the test plan for this revision.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D4524

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Request, 2 lines] D4524: rename wireless power saving to wireless

[Sebastian Kügler]

sebas created this revision.
sebas added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This option is too easily confused with Wireless power saving of 801.11x
  adapters, where you can turn the feature "wireless power saving" on and
  off. I enabled this option, and expected wireless power saving on my
  wifi card to go on and off, not my wifi to be disabled.
  
  Since this label is in context of energy saving anyway, simplify the
  label to make it more clear.

REPOSITORY
  R122 Powerdevil

BRANCH
  sebas/wps

REVISION DETAIL
  https://phabricator.kde.org/D4524

AFFECTED FILES
  daemon/actions/bundled/powerdevilwirelesspowersavingaction.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Request, 1 line] D4523: [Containment Configuration] Hide containment type drop-down if there's only one containment to choose from

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  I still get the ComboBox but I dont get it if I remove one

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4523

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Accepted] D4518: Ungrab mouse in taskmanager context menu

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4518

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, davidedmundson, broulik, hein
Cc: plasma-devel, #plasma, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Accepted] D4521: Activate minimise all plasmoid on mouse enter if the user is dragging mimedata

[Anthony Fieroni]

anthonyfieroni accepted this revision.
anthonyfieroni added a reviewer: anthonyfieroni.
This revision is now accepted and ready to land.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4521

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, anthonyfieroni
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 57 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/57/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 09 Feb 2017 10:05:43 +
Build duration: 25 min

CHANGE SET
Revision 5bbedd2c9f61dace6ffc62d993d03adff3063b4d by kde: ([Task Manager] 
Don#039;t import QtQuick 2.7)
  change: edit applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
  change: edit applets/taskmanager/package/contents/ui/ToolTipInstance.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1566/3802 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

[Differential] [Request, 12 lines] D4521: Activate minimise all plasmoid on mouse enter if the user is dragging mimedata

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This allows the user to easily drag a file from dolphin into a
  folderview on a desktop even if windows are in the way.
  
  BUG: 376212

TEST PLAN
  Dragged an item, things minimised
  Normal mouse enter, nothing happened
  Click still works as normal

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4521

AFFECTED FILES
  applets/minimizeall/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 605 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/605/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 09 Feb 2017 10:07:58 +
Build duration: 5 min 42 sec

CHANGE SET
Revision 5bbedd2c9f61dace6ffc62d993d03adff3063b4d by kde: ([Task Manager] 
Don#039;t import QtQuick 2.7)
  change: edit applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
  change: edit applets/taskmanager/package/contents/ui/ToolTipInstance.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 57 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/57/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 09 Feb 2017 09:58:28 +
Build duration: 9 min 26 sec

CHANGE SET
Revision 1e9a3875e5bda036bd2060aaedc57932edface72 by David Edmundson: (Match 
QtQuick import to minimum Qt version)
  change: edit applets/digital-clock/package/contents/ui/DigitalClock.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2332/5964 
(39%)CONDITIONAL 1631/5912 (28%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Closed] D4520: [Task Manager] Don't import QtQuick 2.7

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5bbedd2c9f61: [Task Manager] Don't import QtQuick 2.7 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D4520?vs=11101=11103#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4520?vs=11101=11103

REVISION DETAIL
  https://phabricator.kde.org/D4520

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, subdiff
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Closed] D4519: [Digital Clock] Don't import QtQuick 2.7

[Kai Uwe Broulik]

broulik closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4519

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, subdiff, #plasma, bshah
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Request, 6 lines] D4520: [Task Manager] Don't import QtQuick 2.7

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, subdiff.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We don't make use of any new properties and we still support Qt 5.6 in Plasma 
5.9 apparently.
  
  CCBUG: 376199

TEST PLAN
  - Group dialog still works
  - Tooltips still work, both single window and groups

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4520

AFFECTED FILES
  applets/taskmanager/package/contents/ui/GroupDialog.qml
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, subdiff
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Updated, 2 lines] D4518: Ungrab mouse in taskmanager context menu

[Anthony Fieroni]

anthonyfieroni set the repository for this revision to R119 Plasma Desktop.
anthonyfieroni updated this revision to Diff 11102.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4518?vs=11100=11102

REVISION DETAIL
  https://phabricator.kde.org/D4518

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, davidedmundson, broulik, hein
Cc: plasma-devel, #plasma, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Updated, 2 lines] D4518: Ungrab mouse in taskmanager context menu

[Anthony Fieroni]

anthonyfieroni removed R119 Plasma Desktop as the repository for this revision.
anthonyfieroni updated this revision to Diff 11100.
anthonyfieroni added a comment.


  Remove call to ungrabMouse in show()

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4518?vs=11097=11100

REVISION DETAIL
  https://phabricator.kde.org/D4518

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, davidedmundson, broulik, hein
Cc: plasma-devel, #plasma, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Accepted] D4519: [Digital Clock] Don't import QtQuick 2.7

[Bhushan Shah]

bshah accepted this revision.
bshah added a reviewer: bshah.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4519

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, subdiff, #plasma, bshah
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Request, 2 lines] D4519: [Digital Clock] Don't import QtQuick 2.7

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, subdiff.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We don't make use of any new properties and we still support Qt 5.6 in Plasma 
5.9 apparently.
  
  CCBUG: 376199

TEST PLAN
  Digital Clock still works

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4519

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, subdiff
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4508: [WIP] Plasma controls based on QtQuickControls2

[David Edmundson]

davidedmundson added a comment.


  I want to do another full review next week when I'm home; but I'd be happy 
with doing that after we merge it, as it'll only be small things, and nothing 
which will affect API.
  
  In general it all looks very good, I like that you split out ButtonShadow and 
all the rest seems neat. Good stuff.

INLINE COMMENTS

> Button.qml:28
> +
> +implicitWidth: Math.max(background ? background.implicitWidth : 0,
> +contentItem.implicitWidth + leftPadding + 
> rightPadding)

I don't get why we check background here and in other places. It would only be 
null if a user subclassed this and then overwrote the property to undefined, at 
which point they deserve errors.

> Button.qml:51
> +//retrocompatibility with old controls
> +implicitWidth: units.gridUnit * 6
> +Private.ButtonShadow {

we do someting differently for widths and heights which isn't ideal, can we 
move the units.gridUnit * 1.6 into here as an implicitHeight?

> CheckIndicator.qml:32
>  opacity: control.enabled ? 1 : 0.6
>  property int checkState: control.checkState
>  

why?

> GroupBox.qml:34
>  
>  padding: 6
>  topPadding: padding + (label && label.implicitWidth > 0 ? 
> label.implicitHeight + spacing : 0)

booo!

> Label.qml:27
>  
>  height: Math.round(Math.max(paintedHeight, units.gridUnit * 1.6))
>  verticalAlignment: lineCount > 1 ? Text.AlignTop : Text.AlignVCenter

Now we have an API break, lets fix this.

As soon as you put this in a layout it won't do anything, so it's quite 
inconsistent.
If anything it should be an implicitHeight, or just set the lineHeight?

But I'd rather we didn't have it at all, we have to work round it in lots of 
places.

If we want a padded Label, we can make a new subclass in the import with all 
the other headings.

> Label.qml:31
>  activeFocusOnTab: false
>  renderType: Text.NativeRendering
>  

Bhushan did a patch for P-F that changed this on the current label if we're on 
mobile, is that still possible?

> TextField.qml:60
>  
>  background: Item {
>  Private.TextFieldFocus {

can we kill an item here?

background: FrameSvgItem {

  TextFiledFocus {
  anchors.fill:parent
   }

}

> qmldir:39
> +ToolButton 3.0 ToolButton.qml
> +ToolTip 3.0 ToolTip.qml

maybe we don't want:

ToolTip, Popup, Dialog, DialogButtonBox here and only in the style?

Also which is the "correct" ItemDelegate we have one of them in PlasmaExtras

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4508

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, broulik, plasma-devel, #frameworks, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Updated] D4518: Ungrab mouse in taskmanager context menu

[Eike Hein]

hein added a comment.


  Then maybe you can remove the call in show() ...?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4518

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, davidedmundson, broulik, hein
Cc: plasma-devel, #plasma, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Accepted] D4491: Let make taskmanager tooltip readable again

[Eike Hein]

hein accepted this revision.
hein added a reviewer: hein.
hein added a comment.
This revision is now accepted and ready to land.


  Kai is correct here, we always want to (a) be consistent, (b) push flaws up 
into lib code so they can be addressed centrally.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4491

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma:_design, #plasma, hein
Cc: broulik, subdiff, hein, plasma-devel, davidedmundson, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol