[Differential] [Changed Subscribers] D4617: Track the actual pressed keys in ModifierOnlyShortcuts

graesslin added a subscriber: subdiff. graesslin added a comment. @subdiff Can you please try whether this change fixes the problem with your external keyboard? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4617 EMAIL PREFERENCES

[Differential] [Request, 16 lines] D4617: Track the actual pressed keys in ModifierOnlyShortcuts

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY With this change the ModifierOnlyShortcut starts to track the actual pressed keys instead

[Differential] [Updated] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

jsalatas added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4538 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jsalatas, #frameworks, #plasma, #ktexteditor Cc: plasma-devel, kwrite-devel, lesliezhai,

[Differential] [Request, 129 lines] D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

broulik created this revision. broulik added reviewers: Plasma, VDG, dfaure, aacid. broulik set the repository for this revision to R824 Baloo Widgets. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This allows to view

[Differential] [Abandoned] D4587: [ContainmentInterface] Ungrab mouse on context menu close

anthonyfieroni abandoned this revision. anthonyfieroni added a comment. https://phabricator.kde.org/D4455 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4587 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Plasma 5.9.2

Plasma 5.9.2 has now been released https://www.kde.org/announcements/plasma-5.9.2.php

[Differential] [Closed] D4611: Check the background is valid when choosing background type

This revision was automatically updated to reflect the committed changes. Closed by commit R123:1c77df276e45: Check the background is valid when choosing background type (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4611?vs=11343=11344#toc REPOSITORY

[Differential] [Accepted] D4611: Check the background is valid when choosing background type

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH master REVISION DETAIL https://phabricator.kde.org/D4611 EMAIL PREFERENCES

[Differential] [Request, 10 lines] D4611: Check the background is valid when choosing background type

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I rushed in an emergency fix for 5.9.1 that added support for setting the background type,

[Differential] [Closed] D4578: Split modifier only handling into a dedicated InputEventSpy

This revision was automatically updated to reflect the committed changes. Closed by commit R108:65ddd32d1a78: Split modifier only handling into a dedicated InputEventSpy (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4578?vs=11239=11340

[Differential] [Commented On] D4578: Split modifier only handling into a dedicated InputEventSpy

graesslin added inline comments. INLINE COMMENTS > subdiff wrote in keyboard_input.cpp:686 > Somewhat unrelated to this diff, but can't we get rid of all these `m_inited` > conditions by setting up LibInput via `InputRedirection::setupLibInput()` and > connecting the functions in

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 67 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/67/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Feb 2017 15:54:14 + Build duration: 5 min 38 sec CHANGE SET Revision

[Differential] [Closed] D4608: Fix manually reordering launchers.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:dda4d42e891a: Fix manually reordering launchers. (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4608?vs=11337=11338 REVISION DETAIL

[Differential] [Commented On] D3805: Per-activity favorites (WIP)

hein added a comment. I finally had time to look at this. The approach looks good to me, and I don't see anything wrong on a quick read. Please rebase as you plammed and I'll fine-comb it (quicker this time). Thanks! REVISION DETAIL https://phabricator.kde.org/D3805 EMAIL PREFERENCES

[Differential] [Accepted] D4608: Fix manually reordering launchers.

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4608 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, ivan,

[Differential] [Request, 6 lines] D4608: Fix manually reordering launchers.

hein created this revision. hein added reviewers: Plasma, ivan, davidedmundson. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY syncLaunchers() is called after drag operations end to write the order of launchers in the all-capping

[Differential] [Request, 22 lines] D4607: finish support for opening compressed packages

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY it's possible to do setPath(zipfile path) and open a compressed package as it was a real

[Differential] [Updated] D3684: Media Controls on lock screen

broulik retitled this revision from "WIP: Media Controls on lock screen" to "Media Controls on lock screen". broulik updated the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3684 EMAIL PREFERENCES

[Differential] [Updated] D4575: add a popupmenuabouttoshow version that exposes the menu

hein added a comment. In the review comment you write that users of the API can use the MIME data to decide whether to call setApplicationActions, but in https://phabricator.kde.org/D4576 you end up manipulating the provided QMenu instance directly, including code written in awareness of

[Breeze] [Bug 348603] Small mouse size (24 size too small, 48 too big)

https://bugs.kde.org/show_bug.cgi?id=348603 Roman Gilg changed: What|Removed |Added CC||subd...@gmail.com --- Comment

[Differential] [Accepted] D4574: [WIP]: unify file drop menu and containment

hein accepted this revision. hein added a reviewer: hein. hein added a comment. This revision is now accepted and ready to land. Modulo the 'mimeDataCopy' name change we mentioned on IRC. REPOSITORY R119 Plasma Desktop BRANCH phab/dropmenu REVISION DETAIL

[Differential] [Updated] D4358: [cursors] Add 36px (1.5 scaling) size for Breeze and Breeze Snow Cursors

subdiff updated the summary for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D4358 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,

[Differential] [Updated, 338 lines] D4358: [cursors] Add 36px (1.5 scaling) size for Breeze and Breeze Snow Cursors

subdiff updated this revision to Diff 11333. subdiff added a comment. - Now doesn't reverts changes of https://phabricator.kde.org/D3459 anymore (and supports it in build script instead of adding the symlink directly). - Doesn't change mode for build scripts anymore. REPOSITORY R31

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 620 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/620/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Feb 2017 14:46:50 + Build duration: 7 min 59 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 619 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/619/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Feb 2017 14:18:47 + Build duration: 26 min CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 71 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/71/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Feb 2017 14:18:47 + Build duration: 22 min CHANGE SET Revision

[Differential] [Closed] D4569: [ConfigurationContainmentActions] Pass Info button as context for showAbout

This revision was automatically updated to reflect the committed changes. Closed by commit R119:690e6f2e21fa: [ConfigurationContainmentActions] Pass Info button as context for showAbout (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

Re: Resigning Plasma Notifications Maintainership

On Tue, Feb 14, 2017 at 12:34 PM, Kai Uwe Broulik wrote: > Hi all, > > in July I took over maintainership of Plasma Notifications from Martin > Klapetek and slowly started revamping them to be suited for the current > decade, adding productivity features, making them more

[Differential] [Accepted] D4569: [ConfigurationContainmentActions] Pass Info button as context for showAbout

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4569 EMAIL PREFERENCES

[Differential] [Closed] D4590: [PanelView] Emit availableScreenRegionChanged in resizeEvent, not when setting a new length

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d67aea401703: [PanelView] Emit availableScreenRegionChanged in resizeEvent, not when setting… (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Updated, 66 lines] D4599: Allow for a header outside of the page in a ScrollablePage, with flexible height

apol updated this revision to Diff 11332. apol added a comment. Use the strictly required version of Qt REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4599?vs=11316=11332 BRANCH arcpatch-D4599 REVISION DETAIL https://phabricator.kde.org/D4599

[Differential] [Updated] D4599: Allow for a header outside of the page in a ScrollablePage, with flexible height

apol marked an inline comment as done. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D4599 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel, apol

[Differential] [Closed] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ad78eed5be08: [Task Manager] Add "Places" for entries belonging to a file manager (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3815?vs=11026=11331#toc REPOSITORY

[Differential] [Accepted] D4578: Split modifier only handling into a dedicated InputEventSpy

subdiff accepted this revision. subdiff added a reviewer: subdiff. subdiff added a comment. This revision is now accepted and ready to land. Didn't find any obvious issues in code plus tested it on X and Wayland. INLINE COMMENTS > keyboard_input.cpp:686 >

[Differential] [Accepted] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Accepted, but please make the minor mods I suggested if you can. INLINE COMMENTS > ContextMenu.qml:38 > > +property bool showAllPlaces > + Maybe a dated C++ mindset, but I don't like

[Differential] [Accepted] D4590: [PanelView] Emit availableScreenRegionChanged in resizeEvent, not when setting a new length

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4590 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

Re: Resigning Plasma Notifications Maintainership

On Tuesday 14 February 2017, Kai Uwe Broulik wrote: > There's no point in me being the maintainer if I'm not consulted. I'll > still do the occasional bugfixing there as part of my overall Plasma work > but don't expect any groundbreaking new features [1], I'm tired of > constantly having to clean

[Differential] [Commented On] D4606: don't show 0% when no battery

broulik added a comment. Does it even make sense to show this thing if there's no battery? We already show a cross on the icon then, don't we? Makes it a bit redundant. On the other hand it could be confusing to have the option checked but then have it not do anything – maybe the check box

[Differential] [Changed Subscribers] D4606: don't show 0% when no battery

broulik added inline comments. INLINE COMMENTS > CompactRepresentation.qml:74 > anchors.fill: batteryIcon > -text: i18nc("battery percentage below battery icon", > "%1%", percent) > +text: batteryContainer.hasBattery ? i18nc("battery

[Differential] [Changed Subscribers] D4606: don't show 0% when no battery

davidedmundson added inline comments. INLINE COMMENTS > BadgeOverlay.qml:36 > color: theme.backgroundColor > -width: label.width + units.devicePixelRatio * 2 > +width: Math.max(units.gridUnit, label.width + units.devicePixelRatio > * 2) > height: label.height

[Differential] [Request, 4 lines] D4606: don't show 0% when no battery

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY if there is no battery don't show 0%, but a - on the badge. still show the badge to show the option is not

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 66 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/66/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Feb 2017 12:24:07 + Build duration: 10 min CHANGE SET Revision

Jenkins-kde-ci: plasma-tests Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 5 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-tests%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/5/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Feb 2017 12:23:25 + Build duration: 6 min 58 sec CHANGE SET Revision

Re: Look and Feel in 5.8

On Wed, Feb 8, 2017 at 11:39 PM, Łukasz Sawicki wrote: > However what saddens me the most is the fact that I warned you guys > about potential issues before Plasma 5.8 release in September. [2]. > Either way it is up to you how are going to solve this "problem". In > any case, I

Re: Kirigami: failing labels

On Tue, Feb 14, 2017 at 11:10 AM, Marco Martin wrote: > On Tuesday 14 February 2017, Aleix Pol wrote: >> Hey Marco, Plasma, >> I've been investigating the issue I mentioned before leaving the >> sprint. As you can see, QQC1.Label stops rendering eventually. >>

Resigning Plasma Notifications Maintainership

(Re-sent, sorry BlackBerry Hub keeps insisting to send stupid html emails) ‎Hi all, in July I took over maintainership of Plasma Notifications from Martin Klapetek and slowly started revamping them to be suited for the current decade, adding productivity features, making them more usable for

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 753 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/753/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Feb 2017 11:18:32 + Build duration: 14 min CHANGE SET Revision

Resigning Plasma Notifications Maintainership

Hi all,in July I took over maintainership of Plasma Notifications from Martin Klapetek and slowly started revamping them to be suited for the current decade, adding productivity features, making them more usable for enterprises, etc. My personal highlight is the draggable previews feature I

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 753 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/753/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Feb 2017 11:18:32 + Build duration: 14 min CHANGE SET Revision

[Differential] [Updated] D4342: Use texture atlas for static icon item

drosca added a comment. Yes. Latest master https://phabricator.kde.org/R242:263f119e17df7c24f8372710c555486429b57971 - broken. Latest master https://phabricator.kde.org/R242:263f119e17df7c24f8372710c555486429b57971 with this change reverted - fixed. REPOSITORY R242 Plasma

[Differential] [Closed] D4447: Add missing summaries

This revision was automatically updated to reflect the committed changes. Closed by commit R120:034bf8087875: Add missing summaries (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4447?vs=10939=11327#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D4342: Use texture atlas for static icon item

davidedmundson added a comment. This shouldn't have any impact to it being pixelated, it just changes where the texture is stored, it can't make it any smaller. Are you sure it's definitely this change? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

[Differential] [Updated] D4599: Allow for a header outside of the page in a ScrollablePage, with flexible height

mart added a comment. i get only a white empty area where the headers should be? INLINE COMMENTS > ListViewGallery.qml:21 > import QtQuick 2.0 > +import QtQuick.Controls 2.1 > import QtQuick.Layouts 1.2 we can depend only from Qt 5.7, so would be import QtQuick.Controls 2.0 REPOSITORY

Re: Kirigami: failing labels

On Tuesday 14 February 2017, Aleix Pol wrote: > Hey Marco, Plasma, > I've been investigating the issue I mentioned before leaving the > sprint. As you can see, QQC1.Label stops rendering eventually. > https://bugreports.qt.io/browse/QTBUG-58852 > > I'm sending this e-mail because Kirigami.Label

[Differential] [Closed] D4594: Don't break compatibility with old configs

This revision was automatically updated to reflect the committed changes. Closed by commit R99:0a7fafc7e2f4: Don't break compatibility with old configs (authored by elvisangelaccio). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D4342: Use texture atlas for static icon item

drosca added a comment. This broke rendering of icons in Quicklaunch plasmoid for me (Sandy Bridge GPU), you can see on the screenshot that it is pixelated. Also the image slightly moves during the active animation, as texture atlas is used only when animation is not running. I can only