abondrov created this revision.
abondrov added a project: Plasma: Workspaces.
Restricted Application edited projects, added Plasma; removed Plasma:
Workspaces.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We need to add ~/.local/share/icons to icons search paths in
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:a347d009d111: [DrmBackend] Straighten out EGL surface
buffer release logic on page flip (authored by subdiff).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:6ef78dc09dad: Require PAM by default and provide an
option to not require it (authored by graesslin).
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
bshah accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
wayland-platform-gestures
REVISION DETAIL
https://phabricator.kde.org/D5059
To: graesslin, #kwin, #plasma, bshah
Cc: plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed,
apol created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5088
AFFECTED FILES
CMakeLists.txt
bshah accepted this revision.
bshah added a comment.
This revision is now accepted and ready to land.
Looks good to me, please have packagers and distributions list in CCMAIL of
commit.
REPOSITORY
R133 KScreenLocker
BRANCH
require-pam-default
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:948ff63d65d2: when the padding aroun the window changes,
update (authored by mart).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5078?vs=12567=12568
REVISION
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
phab/updateshadowchanges
REVISION DETAIL
https://phabricator.kde.org/D5078
To: mart, #plasma, davidedmundson, graesslin
Cc: plasma-devel, kwin, #kwin, progwolff, lesliezhai,
mart updated this revision to Diff 12567.
mart added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
- just update m_visibleRectBeforeGeometryUpdate
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5078?vs=12566=12567
BRANCH
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5060
To: subdiff, #kwin, graesslin
Cc: kwin, plasma-devel, progwolff, lesliezhai, ali-mohamed, hardening,
jensreuterberg, abetts, sebas, apol
mart added a comment.
ok, so, push https://phabricator.kde.org/D5061, then i can play on top of it
:)
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5063
To: graesslin, #plasma
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
graesslin added a comment.
In https://phabricator.kde.org/D5078#95680, @mart wrote:
> In https://phabricator.kde.org/D5078#95679, @graesslin wrote:
>
> > So if I understand correctly on the paddingChanged we do not need to
repaint, you are only interested in the update of the
mart added a comment.
In https://phabricator.kde.org/D5078#95674, @graesslin wrote:
> I'm not sure whether this is the right solution. This yells side-effect and
potential breakage in other areas to me.
>
> Also I don't like the idea of having decoration specific workarounds in the
graesslin added a comment.
In https://phabricator.kde.org/D5063#95576, @mart wrote:
> if you are ok, i would give its layouting the same treatment of
https://phabricator.kde.org/D4893
sure!
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5063
mart added a comment.
In https://phabricator.kde.org/D5078#95679, @graesslin wrote:
> So if I understand correctly on the paddingChanged we do not need to
repaint, you are only interested in the update of the
m_visibleRectBeforeGeometryUpdate? In that case I suggest to update it
graesslin added a comment.
So if I understand correctly on the paddingChanged we do not need to repaint,
you are only interested in the update of the m_visibleRectBeforeGeometryUpdate?
In that case I suggest to update it whenever the shadow changes.
REPOSITORY
R108 KWin
REVISION DETAIL
mart updated this revision to Diff 12566.
mart added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
- just connect the method
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5078?vs=12552=12566
BRANCH
phab/updateshadowchanges
graesslin added inline comments.
INLINE COMMENTS
> mart wrote in abstract_client.cpp:88-90
> it's not a slot
so what? you can connect to any method
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5078
To: mart, #plasma, davidedmundson, graesslin
Cc: plasma-devel, kwin,
graesslin added a comment.
I'm not sure whether this is the right solution. This yells side-effect and
potential breakage in other areas to me.
Also I don't like the idea of having decoration specific workarounds in the
core.
REPOSITORY
R108 KWin
REVISION DETAIL
mart added inline comments.
INLINE COMMENTS
> graesslin wrote in abstract_client.cpp:88-90
> why are you putting that into a lambda?
it's not a slot
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5078
To: mart, #plasma, graesslin, davidedmundson
Cc: plasma-devel, kwin,
graesslin added inline comments.
INLINE COMMENTS
> abstract_client.cpp:88-90
> +connect(this, ::paddingChanged, this, [this]() {
> +addRepaintDuringGeometryUpdates();
> +});
why are you putting that into a lambda?
REPOSITORY
R108 KWin
REVISION DETAIL
Am 2017-03-17 10:01, schrieb René J.V. Bertin:
On Friday March 17 2017 05:48:36 Duncan wrote:
Replying with CC to the plasma-devel list as this appears to be
relevant:
Getting these mails without any context is extremely difficult to parse.
Something I didn't yet notice: KWin doesn't seem
drosca updated this revision to Diff 12564.
drosca added a comment.
Fix stepSize
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5086?vs=12563=12564
BRANCH
raise-max-volume (branched from master)
REVISION DETAIL
drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Allows to raise maximum volume to 150% only for selected stream.
TEST PLAN
Works as described.
There is a visual bug when raising volume,
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9fd5fbd95465: fix a crash caused by bad disconnects
during debug install cancellation (authored by sitter).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Since we no longer show that dialog right away but only if the user already
chose "Report Bug" from the notification (or clicked the tray
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
drkonqi-cancel-crash
REVISION DETAIL
https://phabricator.kde.org/D5084
To: sitter, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:78199d3f3938: rip out ancient compat code which was meant
to have disappeared in 4.11 (authored by sitter).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
sitter created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
the processFinished disconnect would not actually work, change it to
function pointer syntax instead which makes the disconnect work as
mart added a comment.
something like https://paste.kde.org/pgelr0lc5
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5063
To: graesslin, #plasma
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol
broulik added a comment.
You mean when I chose "None" that it ungroups on middle click? Or rather
replace "None" by "ToggleGrouping"?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5065
To: broulik, #plasma, hein, #vdg
Cc: mart, plasma-devel, progwolff,
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
gcc 4.8.5 (opensuse leap) fails building modeltest with
CMakeFiles/testHistoryModel.dir/modeltest.cpp.o: In function
`ModelTest::data()':
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5064
To: broulik, #plasma, hein, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
mart added a comment.
as it was the default behavior in plasma 4, could it be tried to just having
it enabled for 5.010 and add the option only if people complain?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5065
To: broulik, #plasma, hein, #vdg
Cc:
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5082
To: sitter, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
hola
as it turns out drkonqi has a (hidden) feature with which it can
launch a terminal with a debugger (e.g. gdb) attached to the crashed
process.
This was broken for a year and no one noticed ([1] fixes it)
drkonqi(13498)/(default) DefaultDebuggerLauncher::start: "konsole
--nofork -e gdb -nw
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/96/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 17 Mar 2017 12:21:47 +
Build duration: 5 min 59 sec
CHANGE SET
Revision
sitter created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5082
AFFECTED FILES
drkonqi/debuggermanager.cpp
To:
sitter closed this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5080
To: sitter, broulik, bshah, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
apol accepted this revision.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5080
To: sitter, broulik, bshah, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
bshah accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5080
To: sitter, broulik, bshah
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas,
sitter created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
QDBBox explicitly calls show() and hide() all over the place ultimately
resulting in the button being visible when in fact we do not want it
mart added a comment.
if you are ok, i would give its layouting the same treatment of
https://phabricator.kde.org/D4893
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5063
To: graesslin, #plasma
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed,
mart edited the test plan for this revision.
mart added a reviewer: davidedmundson.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5078
To: mart, #plasma, graesslin, davidedmundson
Cc: plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening,
mart abandoned this revision.
mart added a comment.
replaced by https://phabricator.kde.org/D5078
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D4989
To: mart, #plasma, graesslin
Cc: anthonyfieroni, plasma-devel, kwin, #kwin, progwolff, lesliezhai,
ali-mohamed,
mart edited the test plan for this revision.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5078
To: mart, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening,
jensreuterberg, abetts, sebas, apol
mart created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
update m_visibleRectBeforeGeometryUpdate when the padding
change signal gets emitted: aurorae updates its shadow
and postentially
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:412f19df9cbb: Port Kate Sessions Runner (authored by
broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D5077?vs=12549=12550#toc
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST
volkov added a comment.
Looks good to me.
powerdevilpowermanagement.{h,cpp} should be extracted into a library, but it
can be done in a separate commit.
Since they deal with org.freedesktop.PowerManagement interface which is
obsolete and implemented only by
PowerDevil, I suppose
dhaumann accepted this revision.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D5077
To: broulik, #plasma, dhaumann, cullmann, mart
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
<3
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D5077
To: broulik, #plasma, dhaumann, cullmann, mart
Cc: mart, plasma-devel, progwolff, lesliezhai,
mart added a comment.
this happens for aurorae themes, but *not* for oxygen or breeze
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D4989
To: mart, #plasma, graesslin
Cc: anthonyfieroni, plasma-devel, kwin, #kwin, progwolff, lesliezhai,
ali-mohamed, jensreuterberg,
mart added a comment.
in
void AbstractClient::addRepaintDuringGeometryUpdates()
the first time a window moves, that's when the bug occurs, i get a smaller
geometry.
that's a debug of the values m_visibleRectBeforeGeometryUpdate and deco_rect
QRect(274,423 1062x552) QRect(256,410
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This brings back the ability to find and launch Kate sessions through
KRunner, e.g. "kate foo" will show the "foo" Kate session if there is
mart added a comment.
another interestng thing i noted in the bug that occurs when moving a window:
it happens only the first time a particular window is moved, after that time,
for the whole lifecycle of the window, the problem is not reproducible
REPOSITORY
R108 KWin
REVISION DETAIL
leinir closed this revision.
leinir added a comment.
Closed by commit
https://commits.kde.org/discover/eb8f4ae2b46a0516a99d26b25f120a5be28e910c
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D5046
To: leinir, #discover_software_store, apol
Cc: apol,
On Friday March 17 2017 05:48:36 Duncan wrote:
Replying with CC to the plasma-devel list as this appears to be relevant:
>> Something I didn't yet notice: KWin doesn't seem to respect the setting
>> when I restart the application. It's still there, and applied when I
>> click through the app
57 matches
Mail list logo
