date:20170320

Re: Kirigami 1.1 / QML problem (Subsurface-mobile)

2017-03-20 Thread Dirk Hohndel

Hi Marco,

Thanks for the response!

On Mon, Mar 20, 2017 at 11:16:40AM +0100, Marco Martin wrote:
> On Monday 20 March 2017, Dirk Hohndel wrote:
> > Hi there,
> > 
> > After taking a pause for a while, I tried to address a couple of the bug
> > reports for Subsurface-mobile on Android and iOS.
> > 
> > Right now we are building with Kirigami 1.1 and Qt 5.7.1. If we have to
> > upgrade to Kirigami 2.0 and/or Qt 5.8 in order to make it easier for
> > people to help us, please let me know... I tried with Qt 5.8.0 on the
> > desktop and the two problems are still there. But I haven't tried Kirigami
> > 2.0.
> 
> as far i understood of the problems, the version of kirigami shouldn't really 
> matter, as they're related with models and stock qml listviews.
> 
> If I'll get around this week i'll try to build subsurface again (do those 
> problems happen only since recently or always happened as far you know?)

That's a question that should be easy to answer but oddly it isn't. We've
had a few reports in the initial release of Subsurface-mobile where people
were reporting the first problem (with the details showing one dive
further down in the list than the one that you tapped on), but a couple of
the developers (including myself) weren't able to reproduce it. But now
with the current version it seems fairly easy to reproduce the problem.

> In the meantime, especially since you say some problems happen with the full 
> app as well,

No, I don't think I said that. Or I should say, I wasn't planning to say
this. I haven't seen this problem in Subsurface - I can easily reproduce
both problems when building Subsurface-mobile (the QML app) on the desktop
and running it there under Linux. Maybe I didn't phrase this clearly
enough - in both cases it is the QML app that shows the problem, not the
Qt app.

> I may suspect some problem to the main model of the application? 
> (before gets sorted by the qfilterproxymodel)

Given that we have more than 10k users of the desktop app (and all of the
developers constantly work on that) I am near certain that the model isn't
broken.

> Have you ever tried ModelTest? https://wiki.qt.io/Model_Test
> Not sure how easy to detach that model to make it fully work in a minimal 
> application, but having that test that is normally built and ran routinely 
> may 
> save quite some future headaches.

Regardless, I will definitely do that, just in case.

Please let me know if you run into trouble building the current
Subsurface-mobile. There is a silly cmake issue when cross building for
Android. We have a shell script that should do this pretty much
fully-automated (this is reasonably well tested), but with Qt5.7.1 and
Qt5.8.0 there is a bug that requires a small fix to
android_armv7/lib/cmake/Qt5Core/Qt5CoreConfigExtras.cmake

This is explained in the comments at the beginning of
packaging/android/android-build-wrapper.sh

If you are bulding on a Linux box to run Subsurface-mobile on the desktop,
you should be able to do this quite easily by running
scripts/build.sh -mobile
That also should build everything on a recent Linux distro.

Thanks again for your willingness to look into this!

/D

Re: style not drawing menu section/separator if 1st in menu

2017-03-20 Thread René J . V . Bertin

Christoph Feck wrote:

> Always test with Fusion style. If it works there, the bug is in QtCurve.

Evidently, but that was never the question. I'm trying to find the bug or 
whatever it is in QtCurve...

Re: style not drawing menu section/separator if 1st in menu

2017-03-20 Thread Christoph Feck


On 20.03.2017 18:45, René J. V. Bertin wrote:

The style I use (QtCurve) renders texted separators just fine, but not at the
top of a menu.


Always test with Fusion style. If it works there, the bug is in QtCurve.

D4899: [Folder View] Workaround label eliding bug

2017-03-20 Thread Eike Hein

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4899

To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Re: style not drawing menu section/separator if 1st in menu

2017-03-20 Thread René J . V . Bertin

Kai Uwe Broulik wrote:

> Separators cannot be at the beginning or end of a menu and there can't be two
> next to each other. Section is what you want to use for labeled entries but
> for styles that don't implement that they'll be regular separators.

I know, those are the functional differences. At the implementation level, 
sections are texted separators, and styles that don't implement those will (a 
priori) render just the separator.

The style I use (QtCurve) renders texted separators just fine, but not at the 
top of a menu. That's the issue I'm trying to understand. It's as it it has 
told 
Qt that it doesn't do texted separators and that there's thus no need to 
process 
sections (texted separators) at the menu top.

The annoying bit here is that I'm fly fishing in a muddy pool. QtCurve is quite 
a mess code-wise (most styles I've seen are but not to this extent), and I have 
yet to find a clear, succinct but complete tutorial how to write a style.

R.

D5106: Add support for activating screenedges through touch swipe gestures

2017-03-20 Thread Martin Gräßlin

graesslin updated this revision to Diff 12653.
graesslin added a comment.


  Change to doFoo pattern as noted by David

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5106?vs=12618=12653

BRANCH
  screenedge-touch

REVISION DETAIL
  https://phabricator.kde.org/D5106

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/test_gestures.cpp
  gestures.cpp
  gestures.h
  input.cpp
  plugins/platforms/x11/standalone/edge.cpp
  plugins/platforms/x11/standalone/edge.h
  screenedge.cpp
  screenedge.h

To: graesslin, #kwin, #plasma_on_wayland
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol

Re: style not drawing menu section/separator if 1st in menu

2017-03-20 Thread Kai Uwe Broulik

Separator vs Section?

Separators cannot be at the beginning or end of a menu and there can't be two 
next to each other. Section is what you want to use for labeled entries but for 
styles that don't implement that they'll be regular separators.

style not drawing menu section/separator if 1st in menu

2017-03-20 Thread René J . V . Bertin

Hello,

I just noticed that my usual widget style fails to draw menu sections and 
separators if they're the 1st item in a menu. Not a big deal for regular 
separators, more so for texted separators aka menu sections.

It seems that Style::sizeFromContents() and Style::drawControl() aren't even 
called for such elements. They are (and the items are drawn) normally for all 
separators that come after other menu items.

I'm sure I must be overlooking something; is there a global style option to 
make Qt ignore separators at the top and/or bottom of menus maybe?

Thanks,
René

D5009: add functions for locking/unlocking the corona

2017-03-20 Thread Marco Martin

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c64aa75c90f0: add functions for locking/unlocking the 
corona (authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D5009?vs=12371=12652#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5009?vs=12371=12652

REVISION DETAIL
  https://phabricator.kde.org/D5009

AFFECTED FILES
  shell/scripting/scriptengine.cpp
  shell/scripting/scriptengine_v1.cpp
  shell/scripting/scriptengine_v1.h

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5093: Add ~/.local/share/icons to icons search paths

2017-03-20 Thread Andrey Bondrov

abondrov added a comment.


  In https://phabricator.kde.org/D5093#96405, @broulik wrote:
  
  > I have various icons in ~/.local/share/icons/hicolor and .desktop files 
referencing them just by name and that works fine.
  
  
  Likely KF5 application running from KDE 4 Workspace with icon theme set to 
XXX in KF5's kdeglobals (Theme=XXX) won't see ~/.local/share/icons/XXX theme.
  
  Take a look at KHintsSettings::xdgIconThemePaths() function: 
https://cgit.kde.org/plasma-integration.git/tree/src/platformtheme/khintssettings.cpp#n167
  
  The only path it takes in account in user's home is ~/.icons

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D5093

To: abondrov, jriddell, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5114: support for high dpi in aurorae

2017-03-20 Thread Marco Martin

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:bfbcd0197181: support for high dpi in aurorae (authored 
by mart).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5114?vs=12648=12651

REVISION DETAIL
  https://phabricator.kde.org/D5114

AFFECTED FILES
  plugins/kdecorations/aurorae/src/lib/themeconfig.cpp

To: mart, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol

D5083: fix compilation with old gcc

2017-03-20 Thread Marco Martin

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:2f22f0a935b6: fix compilation with old gcc (authored by 
mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D5083?vs=12557=12650#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5083?vs=12557=12650

REVISION DETAIL
  https://phabricator.kde.org/D5083

AFFECTED FILES
  klipper/autotests/modeltest.cpp

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5114: support for high dpi in aurorae

2017-03-20 Thread Martin Gräßlin

graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  phab/auroraedpi

REVISION DETAIL
  https://phabricator.kde.org/D5114

To: mart, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol

D5115: [Logout Greeter] Properly fullscreen window and don't bypass WM

2017-03-20 Thread Martin Gräßlin

graesslin accepted this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5115

To: broulik, #plasma, graesslin, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5093: Add ~/.local/share/icons to icons search paths

2017-03-20 Thread Kai Uwe Broulik

broulik added a comment.


  I have various icons in ~/.local/share/icons/hicolor and .desktop files 
referencing them just by name and that works fine.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D5093

To: abondrov, jriddell, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5115: [Logout Greeter] Properly fullscreen window and don't bypass WM

2017-03-20 Thread Kai Uwe Broulik

broulik added a comment.


  I love that comment - is it still relevant?
  
  > // this is a WType_Popup on purpose. Do not change that! Not
  >  // having a popup here has severe side effects.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5115

To: broulik, #plasma, graesslin, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5115: [Logout Greeter] Properly fullscreen window and don't bypass WM

2017-03-20 Thread Marco Martin

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5115

To: broulik, #plasma, graesslin, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5115: [Logout Greeter] Properly fullscreen window and don't bypass WM

2017-03-20 Thread Kai Uwe Broulik

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Otherwise the window isn't fullscreen as far as kwin is concerned and then 
fast blur code path isn't executed.

TEST PLAN
  I now get fastblur and magnitudes more FPS in the logout dialog in 
multiscreen setup. Both windows are still properly positioned.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5115

AFFECTED FILES
  ksmserver/shutdowndlg.cpp

To: broulik, #plasma, graesslin
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5114: support for high dpi in aurorae

2017-03-20 Thread Marco Martin

mart added a comment.


  F2991743: LiLiUid.png 

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5114

To: mart, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol

D5114: support for high dpi in aurorae

2017-03-20 Thread Marco Martin

mart created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.

REVISION SUMMARY
  aurorae themes have hardoded sizes in pixels in their config files,
  but the framesvgs scale by themselves based on font dpi leading
  to corrupt results
  
  scale all sizes using the same logic(that's also used in c++ based
  kdecorations), gives correct looking scaled decorations
  BUG:375868

TEST PLAN
  see screenshot

REPOSITORY
  R108 KWin

BRANCH
  phab/auroraedpi

REVISION DETAIL
  https://phabricator.kde.org/D5114

AFFECTED FILES
  plugins/kdecorations/aurorae/src/lib/themeconfig.cpp

To: mart, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol

D5093: Add ~/.local/share/icons to icons search paths

2017-03-20 Thread Andrey Bondrov

abondrov added a comment.


  In https://phabricator.kde.org/D5093#96379, @broulik wrote:
  
  > Why? Also, shouldn't it use `QStandardPaths` as XDG locations can change.
  
  
  At least some users expect it to be user's path for /usr/share/icons and 
place icons there.
  
  BTW, shouldn't plasma integration also search for icons in 
~/.kde4/share/icons? KDE4 installs icon themes to this location and it should 
be possible for Qt5/KF5 applications to use such themes, IMHO.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D5093

To: abondrov, jriddell, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2017-03-20 Thread Kai Uwe Broulik

broulik added a comment.


  Ping

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D4614

To: broulik, #plasma, #vdg, dfaure, aacid
Cc: fabianr, ltoscano, davidedmundson, plasma-devel, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D5113: add colour scheme chooser to oxygen-demo

2017-03-20 Thread René J . V . Bertin

rjvbb created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This is a split-off of https://phabricator.kde.org/D5111 , proposing the 
addition of a colour scheme chooser to the Oxygen demo application.
  
  Screenshots:
  
https://phabricator.kde.org/file/data/3p3ojesf6x6u3psaldn7/PHID-FILE-hwpoh2rgdam6fbzyawel/oxydemo-qtcurve-menu.png
  
https://phabricator.kde.org/file/data/bi7rwuxqa3dxpehemhxg/PHID-FILE-33avytvqsdtnuygaywso/oxydemo-oxygen-menu.png

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D5113

AFFECTED FILES
  kstyle/demo/CMakeLists.txt
  kstyle/demo/oxygendemodialog.cpp
  kstyle/demo/oxygenschemechooser.cpp
  kstyle/demo/oxygenschemechooser.h

To: rjvbb, hpereiradacosta
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5093: Add ~/.local/share/icons to icons search paths

2017-03-20 Thread Kai Uwe Broulik

broulik added a comment.


  > We need to add
  
  Why? Also, shouldn't it use `QStandardPaths` as XDG locations can change.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D5093

To: abondrov, jriddell, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Jenkins-kde-ci: khotkeys Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 16 - Fixed!

2017-03-20 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khotkeys%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Mar 2017 14:52:18 +
Build duration: 2 min 28 sec

CHANGE SET
Revision f5c30177b946cc440a09d43cfb2f6bcf1a1950b7 by Jonathan Riddell: (Update 
version number for 5.8.6 GIT_SILENT)
  change: edit CMakeLists.txt
Revision 28ba5ff22404c859085e3fcb749a5f419cdad45d by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit data/defaults.khotkeys


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages

Jenkins-kde-ci: khotkeys Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 16 - Fixed!

2017-03-20 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khotkeys%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Mar 2017 14:52:18 +
Build duration: 2 min 28 sec

CHANGE SET
Revision f5c30177b946cc440a09d43cfb2f6bcf1a1950b7 by Jonathan Riddell: (Update 
version number for 5.8.6 GIT_SILENT)
  change: edit CMakeLists.txt
Revision 28ba5ff22404c859085e3fcb749a5f419cdad45d by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit data/defaults.khotkeys


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages

D5109: [Kicker/App Entry] Try QIcon with path if no theme icon is found

2017-03-20 Thread David Edmundson

davidedmundson added a comment.


  Note this patch breaks fallback loading in the case where an absolute path 
for an SVG or pixmap is set. 
  It's possibly still worth it?
  
  I think your analysis is right, and QIcon::fromTheme(name, fallback) also 
checks availableSizes because it can't rely on all engines implementing the new 
isNull virtual.
  
  KIconLoader does, but even Qt's own ones QSvgIconEngine and QPixmapIconEngine 
don't currently.

INLINE COMMENTS

> appentry.cpp:107-109
> +if (m_icon.isNull()) {
> +m_icon = QIcon(m_service->icon());
> +}

This should be just:

icon = QIcon::fromTheme(m_service->icon();
if (icon.isNull()) {
icon = QIcon::fromTheme("unknown")
}

you don't need that bit in the middle.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5109

To: broulik, #plasma, hein
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5112: Make archiver ioslave extensible

2017-03-20 Thread Jonathan Marten

marten created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The tar, zip and ar ioslaves are implemented in kio-extras/archive by a 
single plugin (class ArchiveProtocol).  This uses the URL scheme to determine 
which archive decoder to use - KTar, KZip or KAr all from the KArchive (tier 1) 
framework.  Unfortunately, it is not possible to use this ioslave as a base for 
another archive format plugin to be distributed and built outside of the KDE 
source tree, because the supported protocols and their decoders are hardcoded 
in the depths of ArchiveProtocol::checkNewFile().  This means that a new 
ioslave for another archive format would need to copy and adapt the whole of 
the ArchiveProtocol source.
  
  This change makes it possible to do that by moving most of ArchiveProtocol 
into an abstract base class ArchiveProtocolBase, compiled into an library and 
installed along with its supporting files.  This is not a framework library 
(and is not ever intended to be), but a support library similar to libkonq.  It 
calls a virtual function in a derived class to create the KArchive-based 
decoder depending on the URL scheme.  The ioslave plugin for the existing 
archive formats is a single derived class (although it could just as easily be 
three) which is installed in the same way as before.
  
  With this change, it is then possible to build and install an additional 
out-of-tree ioslave plugin, deriving from ArchiveProtocolBase and using its 
installed headers and library, without needing any further changes to 
kio-extras.
  
  The additional files installed are:
  
  lib/cmake/KF5KioArchive/KF5KioArchiveConfig.cmake
  lib/cmake/KF5KioArchive/KF5KioArchiveConfigVersion.cmake
  lib/cmake/KF5KioArchive/KF5KioArchiveTargets.cmake
  lib/cmake/KF5KioArchive/KF5KioArchiveTargets-debug.cmake
  include/KF5/kio_archivebase.h
  include/KF5/libkioarchive_export.h
  lib/libKF5KioArchive.so.5.97.0
  lib/libKF5KioArchive.so.6 -> libKF5KioArchive.so.5.97.0
  lib/libKF5KioArchive.so -> libKF5KioArchive.so.6
  
  The .so versions are set as for libkonq, although they can easily be changed 
if required.

TEST PLAN
  Built kio-extras with this change, all autotests pass.
  Konqueror operates correctly to browse tar and zip archives.
  External archive format plugin builds and works correctly.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5112

AFFECTED FILES
  archive/CMakeLists.txt
  archive/KF5KioArchiveConfig.cmake.in
  archive/kio_archive.cpp
  archive/kio_archive.h
  archive/kio_archivebase.cpp
  archive/kio_archivebase.h

To: marten, #plasma, dfaure
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 671 - Still Unstable!

2017-03-20 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/671/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Mar 2017 11:54:18 +
Build duration: 6 min 4 sec

CHANGE SET
Revision 9d7efed5494763347b00883edfd6b4a43f5968d0 by scripty: (GIT_SILENT made 
messages (after extraction))
  change: edit org.kde.plasmashell.metainfo.xml
Revision db297ab5acb93f88c238778e8682effe3032bf4f by kde: ([Kicker] Fix 
highlighting favorites)
  change: edit applets/kicker/package/contents/ui/SideBarItem.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

D5036: UI fixes for logout dialog

2017-03-20 Thread Sebastian Kügler

sebas added a comment.


  No issues other than the ones Kai pointed out found. Once Kai is happy, you 
got my shipit, too.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5036

To: mart, #plasma, sebas
Cc: graesslin, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 94 - Still Unstable!

2017-03-20 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/94/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Mar 2017 11:47:21 +
Build duration: 6 min 37 sec

CHANGE SET
Revision 9d7efed5494763347b00883edfd6b4a43f5968d0 by scripty: (GIT_SILENT made 
messages (after extraction))
  change: edit org.kde.plasmashell.metainfo.xml
Revision db297ab5acb93f88c238778e8682effe3032bf4f by kde: ([Kicker] Fix 
highlighting favorites)
  change: edit applets/kicker/package/contents/ui/SideBarItem.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1566/3802 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 670 - Still Unstable!

2017-03-20 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/670/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Mar 2017 11:38:16 +
Build duration: 15 min

CHANGE SET
Revision fb10c7fc2db3b93ebf29e4fa5c587f5ec9c42922 by kde: ([Kickoff / App Dash] 
Support quot;locationsquot; runner)
  change: edit applets/kicker/package/contents/config/main.xml
Revision 2fcd8547c3617dba583973fcf5cb6b9ae6877525 by kde: ([Task Manager] Add 
option to toggle grouping on middle click)
  change: edit applets/taskmanager/package/contents/config/main.xml
  change: edit applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  change: edit applets/taskmanager/package/contents/ui/Task.qml
  change: edit applets/taskmanager/plugin/backend.h


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

D5088: Generate plugins.qmltypes files for the plugins we install

2017-03-20 Thread Aleix Pol Gonzalez

apol added a comment.

  In https://phabricator.kde.org/D5088#96296, @davidedmundson wrote:

  > I'm confused.
  >
  > If you're generating the qmltypes with the ecm command, why are they in the 
diff?

  Good point.
  We can't generate them at runtime. Here's how they put it in Qt:

# plugins.qmltypes is used by Qt Creator for syntax highlighting and the 
QML code model.  It needs
# to be regenerated whenever the QML elements exported by the plugin 
change.  This cannot be done
# automatically at compile time because qmlplugindump does not support some 
QML features and it may
# not be possible when cross-compiling.

  Biggest issue is that you need a set up install prefix to generate the 
plugins as it expects the prefix structure. Also it needs to load the plugin so 
it will certainly be a problem on certain setups.

  We could find a workaround where it gets to be generated at build-time, but 
it will feel off. Here at least we're doing the same Qt does with their 
`plugins.qmltypes` files.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5088

To: apol, #plasma, #frameworks
Cc: davidedmundson, hein, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5006: Set the correct desktop file name when in a KDE session.

2017-03-20 Thread Eike Hein

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:f61f9d8c100f: Set the correct desktop file name when in a 
KDE session. (authored by hein).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5006?vs=12364=12639

REVISION DETAIL
  https://phabricator.kde.org/D5006

AFFECTED FILES
  app/main.cpp

To: hein, #plasma, mart, bshah, graesslin
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5009: add functions for locking/unlocking the corona

2017-03-20 Thread David Edmundson

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  fix it then ship it

INLINE COMMENTS

> scriptengine_v1.cpp:934
> +
> +if (immutability == QStringLiteral("systemImmutable")) {
> +env->corona()->setImmutability(Plasma::Types::SystemImmutable);

compare against QLatin1String()

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/immutablescripting

REVISION DETAIL
  https://phabricator.kde.org/D5009

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

2017-03-20 Thread René J . V . Bertin

rjvbb created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This is a continuation/transfer of https://git.reviewboard.kde.org/r/128109/ 
(which still has a few screenshots)
  
  There currently is no "official" cheap way to preview how checked menu items 
are rendered as a function of installed widget style, nor an easy/cheap way to 
compare the look of a given widget style under different colour schemes. I have 
been annoyed by the fact one has to (re)launch often heavy applications to 
assess the impact of changes to these look-and-feel aspects.
  
  This patch explores a straightforward way of adding that missing 
functionality via the most exhaustive look-and-feel preview utility I am aware 
of that is cheap in resource requirements: Oxygen's demo app.
  
  This demo already has menus in the MDI preview. The patch makes the layout 
items checkable and puts them in a QActionGroup so their mutually exclusive 
nature is taken into account. It also adds a "right to left" non-exclusive 
checkable item which is linked to the "Left to Right" checkbox in the demo 
frame.
  
  For colour scheme exploration I adapted a thin wrapper around 
KColorSchemeManager written originally by Alexander Zhigalin for KDevelop; it 
is used to add a button with drop-down menu to the page widget's button box 
which makes it available in all views.

TEST PLAN
  The menu additions have been checked on Linux and Mac OS X with Qt 5.6.0 - 
5.8.0 and frameworks 5.22.0 - 5.32.0; the colour scheme addition with Qt 5.8.0 
and frameworks 5.32.0 .
  
  I looked for an appropriate way to uncheck the Tile/Cascade/Tabbed menu items 
(= when the user moves or resizes one of the MDI windows) but it seems those 
events are not available through signals and would thus require subclassing 
MdiSubWindow .
  
  It would make sense IMHO to separate this demo from Oxygen. It has nothing 
Oxygen-specific and could be provided as a standalone theme explorer or bundled 
with another package that doesn't have too strong connotations of being 
"Plasma-exclusive" (Qt has widget style and palette support on most if not all 
platforms it runs on).

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D5111

AFFECTED FILES
  kstyle/demo/CMakeLists.txt
  kstyle/demo/oxygendemodialog.cpp
  kstyle/demo/oxygendemodialog.h
  kstyle/demo/oxygenmdidemowidget.cpp
  kstyle/demo/oxygenmdidemowidget.h
  kstyle/demo/oxygenschemechooser.cpp
  kstyle/demo/oxygenschemechooser.h

To: rjvbb, hpereiradacosta, jriddell, anthonyfieroni, zhigalin
Cc: kde-mac, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5064: [Kicker] Fix highlighting favorites

2017-03-20 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:db297ab5acb9: [Kicker] Fix highlighting favorites 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5064?vs=12501=12638

REVISION DETAIL
  https://phabricator.kde.org/D5064

AFFECTED FILES
  applets/kicker/package/contents/ui/SideBarItem.qml

To: broulik, #plasma, hein, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5088: Generate plugins.qmltypes files for the plugins we install

2017-03-20 Thread David Edmundson

davidedmundson added a comment.


  I'm confused.
  
  If you're generating the qmltypes with the ecm command, why are they in the 
diff?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5088

To: apol, #plasma, #frameworks
Cc: davidedmundson, hein, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5065: [Task Manager] Add option to toggle grouping on middle click

2017-03-20 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2fcd8547c361: [Task Manager] Add option to toggle 
grouping on middle click (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5065?vs=12505=12636

REVISION DETAIL
  https://phabricator.kde.org/D5065

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/plugin/backend.h

To: broulik, #plasma, hein, #vdg
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5033: [Kickoff / App Dash] Support "locations" runner

2017-03-20 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fb10c7fc2db3: [Kickoff / App Dash] Support "locations" 
runner (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5033?vs=12433=12635

REVISION DETAIL
  https://phabricator.kde.org/D5033

AFFECTED FILES
  applets/kicker/package/contents/config/main.xml

To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5064: [Kicker] Fix highlighting favorites

2017-03-20 Thread Eike Hein

hein added a comment.


  Use of MEL there is pretty legacy, might be work investigating switching 
later.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5064

To: broulik, #plasma, hein, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5064: [Kicker] Fix highlighting favorites

2017-03-20 Thread Eike Hein

hein accepted this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5064

To: broulik, #plasma, hein, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5083: fix compilation with old gcc

2017-03-20 Thread David Edmundson

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  fix it then ship it.

INLINE COMMENTS

> modeltest.cpp:456
>  if ( textAlignmentVariant.isValid() ) {
> -int alignment = textAlignmentVariant.toInt();
> +unsigned int alignment = textAlignmentVariant.toInt();
>  QCOMPARE( alignment, ( alignment & ( Qt::AlignHorizontal_Mask | 
> Qt::AlignVertical_Mask ) ) );

toUInt

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5083

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5109: [Kicker/App Entry] Try QIcon with path if no theme icon is found

2017-03-20 Thread Eike Hein

hein added a comment.


  Please add a comment, and I wonder if the absolutePath check should maybe be 
in the code?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5109

To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5065: [Task Manager] Add option to toggle grouping on middle click

2017-03-20 Thread Eike Hein

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  +1 for adding
  
  -1 for making it default - this is a super jarring "omg what just happened" 
for an uinitiated feature and something they have no hope of reverting without 
understanding it. We don't need to recreae everything 4 did to the t :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5065

To: broulik, #plasma, hein, #vdg
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5088: Generate plugins.qmltypes files for the plugins we install

2017-03-20 Thread Eike Hein

hein added a comment.


  Might be nice to do for p-w as well (libtaskmanager QML plugin).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5088

To: apol, #plasma, #frameworks
Cc: hein, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5033: [Kickoff / App Dash] Support "locations" runner

2017-03-20 Thread Eike Hein

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5033

To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D4960: Pause media players on suspend

2017-03-20 Thread Eike Hein

hein added a comment.


  Personally I prefer the earlier version. I understand the concern about the 
long label, but this 'sentence structure' hurts legibility for me. For a single 
option a topic:option structure a la group box is pretty unusual IMHO.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D4960

To: broulik, #plasma, #vdg, graesslin
Cc: hein, fabianr, andreaska, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Re: Kirigami 1.1 / QML problem (Subsurface-mobile)

2017-03-20 Thread Marco Martin

On Monday 20 March 2017, Dirk Hohndel wrote:
> Hi there,
> 
> After taking a pause for a while, I tried to address a couple of the bug
> reports for Subsurface-mobile on Android and iOS.
> 
> Right now we are building with Kirigami 1.1 and Qt 5.7.1. If we have to
> upgrade to Kirigami 2.0 and/or Qt 5.8 in order to make it easier for
> people to help us, please let me know... I tried with Qt 5.8.0 on the
> desktop and the two problems are still there. But I haven't tried Kirigami
> 2.0.

as far i understood of the problems, the version of kirigami shouldn't really 
matter, as they're related with models and stock qml listviews.

If I'll get around this week i'll try to build subsurface again (do those 
problems happen only since recently or always happened as far you know?)
In the meantime, especially since you say some problems happen with the full 
app as well, I may suspect some problem to the main model of the application? 
(before gets sorted by the qfilterproxymodel)
Have you ever tried ModelTest? https://wiki.qt.io/Model_Test
Not sure how easy to detach that model to make it fully work in a minimal 
application, but having that test that is normally built and ran routinely may 
save quite some future headaches.

-- 
Marco Martin

D4960: Pause media players on suspend

2017-03-20 Thread Fabian Riethmayer

fabianr added a comment.


  Looking good to me.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D4960

To: broulik, #plasma, #vdg, graesslin
Cc: fabianr, andreaska, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D3531: Drop remote ioslave, which is now in KIO 5.32

2017-03-20 Thread Elvis Angelaccio

elvisangelaccio added a comment.


  Ping?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3531

To: elvisangelaccio, #plasma, davidedmundson
Cc: bshah, lbeltrame, davidedmundson, plasma-devel, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 669 - Still Unstable!

2017-03-20 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/669/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Mar 2017 08:51:45 +
Build duration: 21 min

CHANGE SET
Revision a521ac8f8882ae90a31654f8e3d7fdf1393181dd by David Edmundson: (Adjust 
plasma-desktop to the new fallback prefixes)
  change: edit applets/taskmanager/package/contents/ui/TaskProgressOverlay.qml
  change: edit applets/taskmanager/package/contents/ui/Task.qml
  change: edit desktoppackage/contents/views/Panel.qml
  change: edit applets/taskmanager/package/contents/code/tools.js


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

D4990: Update Aurorae Shadow when we copy the buffer, not one frame after painting

2017-03-20 Thread David Edmundson

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:ec4359926b69: Update Aurorae Shadow when we copy the 
buffer, not one frame after painting (authored by davidedmundson).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4990?vs=12332=12633

REVISION DETAIL
  https://phabricator.kde.org/D4990

AFFECTED FILES
  plugins/kdecorations/aurorae/src/aurorae.cpp
  plugins/kdecorations/aurorae/src/aurorae.h

To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D4830: Adjust plasma-desktop to the new fallback prefixes

2017-03-20 Thread David Edmundson

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a521ac8f8882: Adjust plasma-desktop to the new fallback 
prefixes (authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4830?vs=11967=12632

REVISION DETAIL
  https://phabricator.kde.org/D4830

AFFECTED FILES
  applets/taskmanager/package/contents/code/tools.js
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/TaskProgressOverlay.qml
  desktoppackage/contents/views/Panel.qml

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

54 matches

Mail list logo