D4290: [Calculator Runner] Use "approximate" approximation mode

[Burkhard Lück]

lueck added a comment.


  OK from german team

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4290

To: broulik, #plasma_workspaces, mart
Cc: lueck, yurchor, kde-i18n-doc, mart, plasma-devel, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D5209: Load translations from KPackage files if bundled

[David Edmundson]

davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

TEST PLAN
  Installed battery monitor locally with kpackagetool5 -i
  moved x-test .po file from being installed systemwide to only being  inside 
the bundle
  still get xx everywhere

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5209

AFFECTED FILES
  src/plasma/pluginloader.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Re: appstreamrunner in plasma-workspace

[Aleix Pol]

On Mon, Mar 27, 2017 at 12:07 PM, Harald Sitter  wrote:
> Aloha
>
> A while ago Aleix created an appstreamrunner allowing you to find
> applications (from appstream data) via krunner and install them (by
> invoking whatever software center is associated with appstream URIs).
>
> There was some consensus that it would be nice to have but we never
> reached a decision where to put it.
>
> I am proposing that we include appstreamrunner in plasma-workspace and
> enable it by default.
>
> It only depends on appstream and can use any old appstream-enabled
> software center (discover, gnome-software, what have you) and it makes
> sense in pretty much every form factor scenario (e.g. if mobile
> launcher has a search it can equally display apps for installation if
> no installed software matches the query).
> I've been using it since the very first day and simply love it!
> Software at once's fingertips, what more can anyone ask for.
>
> HS

I think it's a good idea.
+1

Note that we're already using AppStream in other places of Plasma,
such as Plasma Desktop and Discover.

Aleix

D3552: Remove quoting from kscreen-console json-output (Bug 354534)

[Albert Astals Cid]

aacid added a comment.


  He can't push it, he doesn't have a devel account.
  
  Sebas can you please push it? Name is Jan-Matthias Braun and e-mail according 
to identity is jan_br...@gmx.net
  
  Or i can commit if if you tell me the repo, which you did not fill out when 
creating the request.

REVISION DETAIL
  https://phabricator.kde.org/D3552

To: jbraun, sebas
Cc: aacid, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5112: Make archiver ioslave extensible

[Jonathan Marten]

marten added a comment.


  Point taken regarding the KF5 prefix, this was based on the installed names 
for libkonq (= libKF5Konq.so etc) although not every application support 
library is named the same way (libkworkspace5.so isn't).
  
  Would the name libKioArchive.so, etc be appropriate, or should it be all 
lower case (libkioarchive.so)?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5112

To: marten, #plasma, dfaure
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5112: Make archiver ioslave extensible

[David Faure]

dfaure added a comment.


  The idea sounds OK to me.

INLINE COMMENTS

> CMakeLists.txt:32
> +FILE KF5KioArchiveTargets.cmake
> +NAMESPACE KF5::
> +)

The KF5 prefix is wrong, this isn't part of KF5.

> CMakeLists.txt:44
> +
> +add_library(KF5KioArchive kio_archivebase.cpp kio_archive_debug.cpp)
> +

The KF5 prefix is wrong, this isn't part of KF5.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5112

To: marten, #plasma, dfaure
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5204: [Folder View] Show pin icon only if really in a popup

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When placed in a wide panel, Folder View would reveal its contents but the 
pin icon was still there

TEST PLAN
  Pin icon no longer shows up when expanded in a panel but still shows when 
placed in narrow panel with popup. Even updates at runtime when I resize the 
panel
  
  F3321184: Screenshot_20170327_200510.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5204

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderViewLayer.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5203: Add support for interactive selection through touch events

[Martin Gräßlin]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  This was forgotten during implementing the interactive window/point
  selection. With this change it is also possible to perform the
  interaction through touch events. In that case KWin takes over any
  existing touch sequence.
  
  This implements https://phabricator.kde.org/T5315.

TEST PLAN
  Added auto test and took a screenshot through touch events

REPOSITORY
  R108 KWin

BRANCH
  interactive-selection-touch

REVISION DETAIL
  https://phabricator.kde.org/D5203

AFFECTED FILES
  autotests/integration/window_selection_test.cpp
  input.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol

D5202: [Default Tooltip] Fix icon size

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5202

To: broulik, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5202: [Default Tooltip] Fix icon size

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  We overwrite implicit size based on the icon loaded nowadays which breaks 
this.

TEST PLAN
  No longer get icon sizes all over the place in systray.
  
  While this is a behavior change, Image for instance always had its implicit 
size based on the loaded image and even has a read-only size, so I think this 
behavior is somewhat expectable.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5202

AFFECTED FILES
  src/declarativeimports/core/private/DefaultToolTip.qml

To: broulik, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5201: [Folder View] Add "home" button

[Kai Uwe Broulik]

broulik updated this revision to Diff 12877.
broulik added a comment.


  - Destroy button again so the label anchoring and all resets properly when 
going home

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5201?vs=12876=12877

REVISION DETAIL
  https://phabricator.kde.org/D5201

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderViewLayer.qml

To: broulik, #plasma, hein, #vdg
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5201: [Folder View] Add "home" button

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This adds an easy way to get back to the preconfigured location.
  While Folder View reverts to the start location automatically when a popup 
closes, if you use it in a sidebar, this can never happen and leaves you with 
tediously clicking "Back" continuously.

TEST PLAN
  F3320619: Screenshot_20170327_194008.png 

  
  The button is shown when:
  
  - The title label is shown (ie. not in cascading popups on the desktop)
  - and the currently viewed at location is not the configured (start) location

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5201

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderViewLayer.qml

To: broulik, #plasma, hein, #vdg
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5200: [Calendar] Shrink and elide week names like is done with day delegate

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  This ensures week names never exceed their cell's boundaries.
  
  BUG: 378020

TEST PLAN
  `LC_ALL=pt_PT plasmashell`
  F3320035: Screenshot_20170327_192625.png 

  
  I don't get why Qt shows such long names although we use `Locale.ShortFormat` 
(also doesn't make a difference whether I used `dayName` or `standaloneDayName` 
(which we probably should have been using to begin with)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5200

AFFECTED FILES
  src/declarativeimports/calendar/qml/DaysCalendar.qml

To: broulik, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D4290: [Calculator Runner] Use "approximate" approximation mode

[Yuri Chornoivan]

yurchor added a comment.


  In https://phabricator.kde.org/D4290#98033, @broulik wrote:
  
  > @kde-i18n-doc I'd like to ask for an exception to backport this fix to 
Plasma 5.8 (due mid of May) and Plasma 5.9 (due 25 April) as it is a rather 
severe, easily triggerable, memory leak/crash fix.
  >  Initially it would have been without a new translation but as silently 
rounding results isn't ideal, I had to add a hint "Approximation" to it.
  
  
  No objections from Ukrainian team.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4290

To: broulik, #plasma_workspaces, mart
Cc: yurchor, kde-i18n-doc, mart, plasma-devel, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D2104: [Task Manager] Close gap when there is no icon

[Kai Uwe Broulik]

broulik abandoned this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2104

To: broulik, hein, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D3743: [Folder View] Show proper trash icon when it points to trash:/

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  Superseded by https://phabricator.kde.org/D5198 and 
https://phabricator.kde.org/D5199

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3743

To: broulik, #plasma, #plasma:_design, mart, hein
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D4290: [Calculator Runner] Use "approximate" approximation mode

[Kai Uwe Broulik]

broulik added a subscriber: kde-i18n-doc.
broulik added a comment.


  @kde-i18n-doc I'd like to ask for an exception to backport this fix to Plasma 
5.8 (due mid of May) and Plasma 5.9 (due 25 April) as it is a rather severe, 
easily triggerable, memory leak/crash fix.
  Initially it would have been without a new translation but as silently 
rounding results isn't ideal, I had to add a hint "Approximation" to it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4290

To: broulik, #plasma_workspaces, mart
Cc: kde-i18n-doc, mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D4761: [Task Manager] Don't delay appearance of audio stream in popup

[Kai Uwe Broulik]

broulik added a comment.


  Ping

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4761

To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D4923: [desktop:/ KIO] Strip superfluous slashes and fixup local root url

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  Somehow I must have screwed up my setup somehow, I can't reproduce the issues 
I had anymore and never had it on my laptop to begin with.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4923

To: broulik, #plasma, hein, dfaure
Cc: anthonyfieroni, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5198: [Folder View] Use KIO::iconNameForUrl

[Mark Gaiser]

markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.


  Fancy!
  I learned something new, thank you :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5198

To: broulik, #plasma, hein, markg
Cc: markg, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D4290: [Calculator Runner] Use "approximate" approximation mode

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:df7f1ed1eb7d: [Calculator Runner] Use "approximate" 
approximation mode (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4290?vs=10979=12873

REVISION DETAIL
  https://phabricator.kde.org/D4290

AFFECTED FILES
  runners/calculator/calculatorrunner.cpp
  runners/calculator/calculatorrunner.h
  runners/calculator/qalculate_engine.cpp
  runners/calculator/qalculate_engine.h

To: broulik, #plasma_workspaces, mart
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D4290: [Calculator Runner] Use "approximate" approximation mode

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4290

To: broulik, #plasma_workspaces, mart
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5002: [oxygen/kstyle] Fix build

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> oxygenanimations.cpp:178
>  // unregister all toolbuttons that belong to a toolbar
> -foreach( QWidget* widget, 
> _widgetStateEngine->registeredWidgets( AnimationHover|AnimationFocus ) )
> +foreach( QWidget* widget, 
> _widgetStateEngine->registeredWidgets( AnimationMode( 
> AnimationHover|AnimationFocus ) ) )
>  {

Looking further into the patch I get more confused.
The argument taken by the Oxygen::WidgetStateEngine::registerWidget() (or 
registeredWidgets() is "Oxygen::AnimationModes" (with an "s"), and not 
"AnimationMode"
The latter is defined via the macros Q_DECLARE_FLAGS(AnimationModes, 
AnimationMode)
and 
Q_DECLARE_OPERATORS_FOR_FLAGS( Oxygen::AnimationModes );

My understanding was that this would allow AnimationsModes to be bitwise or (or 
and, or any operator) of the AnimationMode enum. 
Maybe these macros are now broken.
In any case, at the minimum the correct syntax should be 
"AnimationModes(AnimationHover|AnimationFocus). Right ?

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D5002

To: cfeck, hpereiradacosta
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5198: [Folder View] Use KIO::iconNameForUrl

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  In contrast to KFileItem it also has special fallback mechanisms, such as 
using the protocol icon, if none cound be determined.
  This way my places:/ KIO will use the proper icon and also trash:/ will at 
least show a trash can, even if it doesn't (yet) reflect the actual trash state.

TEST PLAN
  `/home/foo/Desktop`: before *folder*, now *desktop* (QStandardPaths special 
logic)
  `/home/foo/Pictures`: before *images*, now *images*
  `places:/` before *folder*, now *bookmarks icon* defined in protocol file
  `trash:/` before *folder*, now *trash icon* defined in protocol file

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5198

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5157: Add support for emergency message show on Wayland

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R133:565259358ec0: Add support for emergency message show on 
Wayland (authored by graesslin).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5157?vs=12749=12866

REVISION DETAIL
  https://phabricator.kde.org/D5157

AFFECTED FILES
  abstractlocker.cpp
  waylandlocker.cpp
  waylandlocker.h

To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5137: Add support for screenedge touchscreen events through XInput 2.2

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:8672b93bdd14: Add support for screenedge touchscreen 
events through XInput 2.2 (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5137?vs=12767=12865

REVISION DETAIL
  https://phabricator.kde.org/D5137

AFFECTED FILES
  gestures.h
  plugins/platforms/x11/standalone/xinputintegration.cpp

To: graesslin, #plasma, #kwin, davidedmundson
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5097: Add support for global touchpad swipe gestures

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:22c91df2ec6c: Add support for global touchpad swipe 
gestures (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5097?vs=12586=12863

REVISION DETAIL
  https://phabricator.kde.org/D5097

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/mock_effectshandler.h
  autotests/test_gestures.cpp
  autotests/test_screen_edges.cpp
  autotests/test_virtual_desktops.cpp
  effects.cpp
  effects.h
  effects/desktopgrid/desktopgrid.cpp
  effects/presentwindows/presentwindows.cpp
  gestures.cpp
  gestures.h
  globalshortcuts.cpp
  globalshortcuts.h
  input.cpp
  input.h
  libkwineffects/CMakeLists.txt
  libkwineffects/kwineffects.h
  libkwineffects/kwinglobals.h
  virtualdesktops.cpp
  virtualdesktops.h

To: graesslin, #kwin, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol

D5106: Add support for activating screenedges through touch swipe gestures

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:aa6c8f81168e: Add support for activating screenedges 
through touch swipe gestures (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5106?vs=12653=12864

REVISION DETAIL
  https://phabricator.kde.org/D5106

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/test_gestures.cpp
  gestures.cpp
  gestures.h
  input.cpp
  plugins/platforms/x11/standalone/edge.cpp
  plugins/platforms/x11/standalone/edge.h
  screenedge.cpp
  screenedge.h

To: graesslin, #kwin, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol

D5177: Initial support for popup window handling

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D5177#97958, @broulik wrote:
  
  > > Concerning whether or not it should update: I'm not sure. On X11 it's due 
to the pointer grab, but is that a feature or a bug?
  >
  > I think it's a side-effect of the pointer grab which quite effectively 
communicates that clicking the button wouldn't trigger it because a menu's open.
  
  
  I think we have better ways to communicate it. E.g. we could change the 
cursor to indicate that it will close the popup. Or darken all other windows. 
That we are not restricted any more is something I quite like as it allows 
scrolling to work in other windows even if a context menu is open.
  
  > Fwict it's also the case on Wayland for `exec()`d menus within the same 
client.
  
  you mean that is how qt handles it internally. Other toolkits might handle it 
differently ;-)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5177

To: graesslin, #plasma, #kwin
Cc: broulik, subdiff, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5097: Add support for global touchpad swipe gestures

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in gestures.cpp:95
> I think you need to handle delta being zero in both directions and return 
> without cancelling

I think a delta of 0/0 just cannot happen. libinput should not send us an 
update in such a case. We only get updates if the fingers moved. Thus 0/0 is 
just impossible.

> davidedmundson wrote in gestures.cpp:136
> Hypothetical question: Is it possible to have a start and end without an 
> update?

Theoretically yes, practically I doubt that any user would be able to rest four 
fingers on the touchpad, trigger the swipe gesture (which already needs 
movements) and then raise without further movement. Similar for touch screen 
events: it would mean the user clicks a point without moving the finger even a 
little bit.

> davidedmundson wrote in gestures.h:126
> I don't get what this is for.
> 
> You append to the list and you clear it, but it's used for any branch 
> decisions.
> 
> Unless it's a future thing for more advanced swipe analysis later?

It's a future thing and used in the follow up patch for touch screen swipes 
where we need to get the minimum swipe distance.

> davidedmundson wrote in globalshortcuts.cpp:36
> what's this for?
> 
> You don't make a QHash of SwipeDirections anywhere, and even if you did, it 
> should be implicity done for enums.

I do: QHash > 
m_swipeShortcuts;

and no, it's not implicit. I only added because I got a compile error.

BRANCH
  gesture-support

REVISION DETAIL
  https://phabricator.kde.org/D5097

To: graesslin, #kwin, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol

D5177: Initial support for popup window handling

[Kai Uwe Broulik]

broulik added a comment.


  > Concerning whether or not it should update: I'm not sure. On X11 it's due 
to the pointer grab, but is that a feature or a bug?
  
  I think it's a side-effect of the pointer grab which quite effectively 
communicates that clicking the button wouldn't trigger it because a menu's 
open. Fwict it's also the case on Wayland for `exec()`d menus within the same 
client.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5177

To: graesslin, #plasma, #kwin
Cc: broulik, subdiff, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5177: Initial support for popup window handling

[Martin Gräßlin]

graesslin updated this revision to Diff 12861.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  last -> constLast

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5177?vs=12798=12861

BRANCH
  popup-filter

REVISION DETAIL
  https://phabricator.kde.org/D5177

AFFECTED FILES
  CMakeLists.txt
  autotests/integration/pointer_input.cpp
  input.cpp
  pointer_input.cpp
  popup_input_filter.cpp
  popup_input_filter.h
  shell_client.cpp
  shell_client.h
  toplevel.h

To: graesslin, #plasma, #kwin
Cc: broulik, subdiff, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5177: Initial support for popup window handling

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D5177#97950, @broulik wrote:
  
  > A thing to the future might be to consider blocking hover events for other 
clients, too? On X while a menu is opened, buttons in other clients won't 
highlight as the menu grabs. On Wayland they would still highlight.
  
  
  I'm not sure. I read the documentation about 20 times to understand what is 
expected and did not find any hint on whether mouse motion should be 
constrained to the popup. The only hint is about the buttons. So I tried to 
stay as close to the documentation as possible.
  
  Concerning whether or not it should update: I'm not sure. On X11 it's due to 
the pointer grab, but is that a feature or a bug?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5177

To: graesslin, #plasma, #kwin
Cc: broulik, subdiff, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol

D5177: Initial support for popup window handling

[Martin Gräßlin]

graesslin marked an inline comment as done.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5177

To: graesslin, #plasma, #kwin
Cc: broulik, subdiff, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol

D5177: Initial support for popup window handling

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D5177#97858, @subdiff wrote:
  
  > I tried it and compiles fine. Some popups don't yet go away though:
  >
  > - Click on window decoration of window with the popup.
  > - Panel and launcher popups, click on other part of plasmashell.
  
  
  Thanks for testing. I don't really understand the two cases where it doesn't 
work correctly. I assume they are different issues.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5177

To: graesslin, #plasma, #kwin
Cc: broulik, subdiff, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol

D5088: Generate plugins.qmltypes files for the plugins we install

[Aleix Pol Gonzalez]

apol added a comment.


  Can somebody please help review the ECM side of things?
  https://phabricator.kde.org/D5087

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5088

To: apol, #plasma, #frameworks, davidedmundson
Cc: davidedmundson, hein, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5177: Initial support for popup window handling

[Kai Uwe Broulik]

broulik added a comment.


  A thing to the future might be to consider blocking hover events for other 
clients, too? On X while a menu is opened, buttons in other clients won't 
highlight as the menu grabs. On Wayland they would still highlight.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5177

To: graesslin, #plasma, #kwin
Cc: broulik, subdiff, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol

D3805: Per-activity favorites (Final, again?)

[Ivan Čukić]

ivan added a comment.


  p.s. I haven't tested the patch since posting - it is possible that some 
change in plasma broke the thing (like the problematic change that got reverted)

REVISION DETAIL
  https://phabricator.kde.org/D3805

To: ivan, mart, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D3805: Per-activity favorites (Final, again?)

[Ivan Čukić]

ivan added a comment.


  
  
  > Could you document here how to reset all state so I can re-test migration 
on a clean base?
  
  
  
  1. kill plasma and kamd
  2. rm .config/kactivitymanagerd-statsrc
  3. echo "delete from ResourceLink" | sqlite3 
~/.local/share/kactivitymanagerd/resources/database
  4. restart kamd and plasma
  
  This should be it.
  
  > Did you do any work yet on migrating as a superset instead of just the 
first launcher roulette?
  
  Unfortunately, I don't see a valid way to do this without accessing the 
related configuration files directly.

REVISION DETAIL
  https://phabricator.kde.org/D3805

To: ivan, mart, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D4899: [Folder View] Workaround label eliding bug

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  Superseded by 
https://cgit.kde.org/plasma-desktop.git/commit/?id=a03d08a99e86c13ee50407f5189d70bf0a2b37fc

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4899

To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 98 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/98/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 27 Mar 2017 12:05:03 +
Build duration: 17 min

CHANGE SET
Revision f5f685ecdc630fdcd767e2a6f611b8f43e7f8c3e by hein: (Set wrapMode to 
NoWrap when maximumLineCount is 1.)
  change: edit applets/taskmanager/package/contents/ui/Task.qml
Revision a03d08a99e86c13ee50407f5189d70bf0a2b37fc by hein: (Set wrapMode to 
NoWrap when maximumLineCount is 1.)
  change: edit containments/desktop/package/contents/ui/FolderItemDelegate.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1566/3802 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 677 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/677/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 27 Mar 2017 12:06:43 +
Build duration: 6 min 1 sec

CHANGE SET
Revision f5f685ecdc630fdcd767e2a6f611b8f43e7f8c3e by hein: (Set wrapMode to 
NoWrap when maximumLineCount is 1.)
  change: edit applets/taskmanager/package/contents/ui/Task.qml
Revision a03d08a99e86c13ee50407f5189d70bf0a2b37fc by hein: (Set wrapMode to 
NoWrap when maximumLineCount is 1.)
  change: edit containments/desktop/package/contents/ui/FolderItemDelegate.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

D5192: Connect aboutToHide signal from QMenu to relevant libdbusmenu-qt slot

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.


  5.9 branch pls

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5192

To: davidedmundson, #plasma, markg, broulik
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5192: Connect aboutToHide signal from QMenu to relevant libdbusmenu-qt slot

[Mark Gaiser]

markg accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5192

To: davidedmundson, #plasma, markg
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5192: Connect aboutToHide signal from QMenu to relevant libdbusmenu-qt slot

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This sends the close event to the client which then sends aboutToHide to
  the QMenu.
  
  Code was all there, just not hooked up
  
  BUG: 375053

TEST PLAN
  Added qDebug to the test app inside libdbusmenuqt

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5192

AFFECTED FILES
  libdbusmenuqt/dbusmenuimporter.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

appstreamrunner in plasma-workspace

[Harald Sitter]

Aloha

A while ago Aleix created an appstreamrunner allowing you to find
applications (from appstream data) via krunner and install them (by
invoking whatever software center is associated with appstream URIs).

There was some consensus that it would be nice to have but we never
reached a decision where to put it.

I am proposing that we include appstreamrunner in plasma-workspace and
enable it by default.

It only depends on appstream and can use any old appstream-enabled
software center (discover, gnome-software, what have you) and it makes
sense in pretty much every form factor scenario (e.g. if mobile
launcher has a search it can equally display apps for installation if
no installed software matches the query).
I've been using it since the very first day and simply love it!
Software at once's fingertips, what more can anyone ask for.

HS

D3805: Per-activity favorites (Final, again?)

[Eike Hein]

hein added a comment.


  Could you document here how to reset all state so I can re-test migration on 
a clean base?
  
  Did you do any work yet on migrating as a superset instead of just the first 
launcher roulette?

REVISION DETAIL
  https://phabricator.kde.org/D3805

To: ivan, mart, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5085: [DrKonqi] Drop "It is safe to close this dialog if you don't want to report a bug"

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:91deac7c6a19: [DrKonqi] Drop "It is safe to close this 
dialog if you don't want to report a… (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5085?vs=12561=12855

REVISION DETAIL
  https://phabricator.kde.org/D5085

AFFECTED FILES
  drkonqi/drkonqidialog.cpp

To: broulik, #plasma, mart
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5177: Initial support for popup window handling

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> popup_input_filter.cpp:62
> +auto pointerFocus = 
> qobject_cast(input()->findToplevel(event->globalPos()));
> +if (!pointerFocus || 
> !AbstractClient::belongToSameApplication(pointerFocus, 
> qobject_cast(m_popupClients.last( {
> +// a press on a window (or no window) not belonging to the popup 
> window

`constLast()`

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5177

To: graesslin, #plasma, #kwin
Cc: broulik, subdiff, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol

D5097: Add support for global touchpad swipe gestures

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  All good I think, a few questions.

INLINE COMMENTS

> gestures.cpp:95
> +void GestureRecognizer::updateSwipeGesture(const QSizeF )
> +{
> +m_swipeUpdates << delta;

I think you need to handle delta being zero in both directions and return 
without cancelling

> gestures.cpp:136
> +
> +void GestureRecognizer::endSwipeGesture()
> +{

Hypothetical question: Is it possible to have a start and end without an update?

> gestures.h:126
> +QMap m_destroyConnections;
> +QVector m_swipeUpdates;
> +};

I don't get what this is for.

You append to the list and you clear it, but it's used for any branch decisions.

Unless it's a future thing for more advanced swipe analysis later?

> globalshortcuts.cpp:36
>  
> +uint qHash(SwipeDirection direction)
> +{

what's this for?

You don't make a QHash of SwipeDirections anywhere, and even if you did, it 
should be implicity done for enums.

BRANCH
  gesture-support

REVISION DETAIL
  https://phabricator.kde.org/D5097

To: graesslin, #kwin, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol

D5177: Initial support for popup window handling

[Roman Gilg]

subdiff added a comment.


  I tried it and compiles fine. Some popups don't yet go away though:
  
  - Click on window decoration of window with the popup.
  - Panel and launcher popups, click on other part of plasmashell.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5177

To: graesslin, #plasma, #kwin
Cc: subdiff, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol