D6952: Properly render XWayland windows in SceneQPainter
graesslin updated this revision to Diff 17308. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Better special casing for Xwayland case which should not break high dpi REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6952?vs=17296=17308 BRANCH scene-qpainter-fix-xwayland REVISION DETAIL https://phabricator.kde.org/D6952 AFFECTED FILES autotests/integration/scene_qpainter_test.cpp scene_qpainter.cpp To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6957: Add link about additional configuration option to baloo kcm docbook
lueck created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Add link to https://community.kde.org/Baloo/Configuration TEST PLAN checkXML5 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6957 AFFECTED FILES doc/kcontrol/baloo/index.docbook To: lueck, #documentation, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6956: Stop unnecessarily killing IBus when applying keyboard layouts config
achauvel created this revision. achauvel added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY More details here: https://bugs.kde.org/show_bug.cgi?id=379930 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6956 AFFECTED FILES kcms/keyboard/keyboard_daemon.cpp kcms/keyboard/xkb_helper.cpp To: achauvel Cc: plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6952: Properly render XWayland windows in SceneQPainter
graesslin added a comment. In https://phabricator.kde.org/D6952#129558, @davidedmundson wrote: > My window scaling test still works because (in retrospect) it's really stupid. > > I use render an entirely blue square. lol, right. > If you only show the top quarter of that it's still an entirely blue square. > > I should render the Japanese flag or something to be useful. Unfortunately that means forking/extending renderAndWaitForShown. we could have an overload which takes a QImage instead of a QColor REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6952 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D6571: Delete all Wayland connections by plugins prior to own Wayland connection
graesslin updated this revision to Diff 17299. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Updated to master and emit of connectionDied instead of delete REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6571?vs=16348=17299 BRANCH connection-cleanup REVISION DETAIL https://phabricator.kde.org/D6571 AFFECTED FILES wayland_server.cpp To: graesslin, #kwin, #plasma, mart Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6571: Delete all Wayland connections by plugins prior to own Wayland connection
davidedmundson added inline comments. INLINE COMMENTS > graesslin wrote in wayland_server.cpp:99 > Yeah that should work as well. Though of course the documentation of > ConnectionThread says it's not emitted if created from application, but we > can fix that ;-) > > It might mean we leak a few resources, but as we are shutting down anyway... RE: https://phabricator.kde.org/D6727 > That would basically allow us to abandon https://phabricator.kde.org/D6571 > and would also solve the issues we see with the kwayland-integration plugin > which can crash applications on exit. I'd like to see this patch merged (but with the emit connectionDied) It might work without, but it still leaves a window where someone calling foo->destroy() would crash. REPOSITORY R108 KWin BRANCH connection-cleanup REVISION DETAIL https://phabricator.kde.org/D6571 To: graesslin, #kwin, #plasma, mart Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D6952: Properly render XWayland windows in SceneQPainter
davidedmundson added a comment. My window scaling test still works because (in retrospect) it's really stupid. I use render an entirely blue square. If you only show the top quarter of that it's still an entirely blue square. I should render the Japanese flag or something to be useful. Unfortunately that means forking/extending renderAndWaitForShown. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6952 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D6717: Expose base64-encoded favicons to the tabsrunner
fvogt updated this revision to Diff 17287. fvogt added a comment. braces + const A hasOwnProperty check is not needed here, that's accounted for by the if (!favIconUrl) below REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6717?vs=16759=17287 BRANCH favicons (branched from master) REVISION DETAIL https://phabricator.kde.org/D6717 AFFECTED FILES extension/extension.js extension/manifest.json tabsrunner/tabsrunner.cpp To: fvogt, #plasma, broulik, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6946: Emit connectionDied if the QPA is destroyed
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6946 To: davidedmundson, graesslin Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6727: Destroy all kwayland objects created by registry when it is destroyed
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH davidedmundson/xdgv6 REVISION DETAIL https://phabricator.kde.org/D6727 To: davidedmundson, graesslin Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6952: Properly render XWayland windows in SceneQPainter
graesslin added a comment. In https://phabricator.kde.org/D6952#129544, @davidedmundson wrote: > That almost certainly breaks high Dpi support. That's what I feared when doing the change, though the unit test which does high dpi still works. What we can do is check the buffer scale. If it's 1 and the clientSize is different to the bufferSize use the clientSize - in all other cases the bufferSize. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6952 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D6952: Properly render XWayland windows in SceneQPainter
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. That almost certainly breaks high Dpi support. (Though not for xwayland windows which will always be scale 1) I'll take a look at the bug, and see if we can come up with something else. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6952 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D6951: [AppMenu Applet] Pass "ctx" as context instead of "this"
This revision was automatically updated to reflect the committed changes. Closed by commit R120:3ff8c1f65ebe: [AppMenu Applet] Pass "ctx" as context instead of "this" (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6951?vs=17286=17291 REVISION DETAIL https://phabricator.kde.org/D6951 AFFECTED FILES applets/appmenu/lib/appmenuapplet.cpp To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6951: [AppMenu Applet] Pass "ctx" as context instead of "this"
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6951 To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6952: Properly render XWayland windows in SceneQPainter
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The buffer for a XWayland window is larger than the actual size. Thus we need to use the clientSize as reference, not the buffer size. BUG: 382748 TEST PLAN Test passes REPOSITORY R108 KWin BRANCH scene-qpainter-fix-xwayland REVISION DETAIL https://phabricator.kde.org/D6952 AFFECTED FILES autotests/integration/scene_qpainter_test.cpp scene_qpainter.cpp To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
Re: Re: DrKonqi dependencies
This came up during akademy with someone. I've split drkonqi into its own repo. (Not pushed). It's a git-filter branch with all history looking neat. I don't intend to move it outside of workspace as that's always an absolute nightmare. Being a standalone repo will hopefully be enough, and we can always do more later. David On 26 Mar 2017 11:11 a.m., "Andreas Sturmlechner" < andreas.sturmlech...@gmail.com> wrote: > On Sunday, 19 March 2017 at 16:22, Martin Gräßlin wrote: > > Am 2017-03-19 14:19, schrieb Kai Uwe Broulik: > > > I'd be fine with splitting drkonqi into its own repository, René > > > recently brought this up as well. > > > > Ideally it would be part of KF5, e.g. a kcrash-runtime tier-3 repo. > > So how should this be tackled? Is it realistic to prepare it while part of > plasma-workspace or (more likely) split first, then move to KF5 when ready? > >
D6717: Expose base64-encoded favicons to the tabsrunner
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R856 Plasma Browser Integration BRANCH favicons (branched from master) REVISION DETAIL https://phabricator.kde.org/D6717 To: fvogt, #plasma, broulik, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6717: Expose base64-encoded favicons to the tabsrunner
This revision was automatically updated to reflect the committed changes. Closed by commit R856:d435a59b0514: Expose base64-encoded favicons to the tabsrunner (authored by fvogt). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6717?vs=17287=17290 REVISION DETAIL https://phabricator.kde.org/D6717 AFFECTED FILES extension/extension.js extension/manifest.json tabsrunner/tabsrunner.cpp To: fvogt, #plasma, broulik, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6717: Expose base64-encoded favicons to the tabsrunner
broulik added a comment.
Cool!
INLINE COMMENTS
> extension.js:495
> +var sendTabsIfComplete = function() {
> +if (--total > 0)
> +return;
Braces even for single line statements:
if (...) {
...
}
> extension.js:505
> +
> +for (let tabIndex in tabs) {
> +let currentIndex = tabIndex; // Not shared
Does this need a `tabs.hasOwnProperty(...)` check? (cf for in being horrible in
JS)
> tabsrunner.cpp:188
> +
> +QString favIconData =
> tab.value(QStringLiteral("favIconData")).toString();
> +int b64start = favIconData.indexOf(',');
const
> tabsrunner.cpp:191
> +if (b64start != -1) {
> +QByteArray b64 = favIconData.rightRef(favIconData.size() -
> b64start - 1).toLatin1();
> +QByteArray data = QByteArray::fromBase64(b64);
+1 for usage of `ref` :)
> tabsrunner.cpp:224
>
> -match.setIconName(iconName);
> +if (!iconName.isEmpty())
> +match.setIconName(iconName);
Braces
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D6717
To: fvogt, #plasma, broulik, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
D6717: Expose base64-encoded favicons to the tabsrunner
fvogt marked 4 inline comments as done. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D6717 To: fvogt, #plasma, broulik, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6908: Nullptr check for rootInfo when setting active client
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH rootinfo-setActiveWindow-nullptr-check REVISION DETAIL https://phabricator.kde.org/D6908 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D6951: [AppMenu Applet] Pass "ctx" as context instead of "this"
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We copy "ctx" pointer by value into our lambda but by the time our timer fires, it might be gone already. Instead, pass "ctx" as context to QTimer::singleShot so it won't fire when it's gone. BUG: 382386 FIXED-IN: 5.10.5 TEST PLAN I don't have Visual Studio Code but it's probably related to Electron constantly updating the global menu causing us to re-create the buttons all the time. Tested that the function is still called here and seems to have worked fine. It probably will not ungrab for the aforementioned app but I'd rather have QtQuick have a wrong mouse state than having plasma crash ;) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6951 AFFECTED FILES applets/appmenu/lib/appmenuapplet.cpp To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6718: Fix occasional abort in the krunner plugin
broulik added a comment.
@davidedmundson Should we go with this now?
INLINE COMMENTS
> tabsrunner.cpp:103
>
> -if (reply.type() != QDBusMessage::ReplyMessage) {
> +if (reply.type() != QDBusMessage::ReplyMessage ||
> reply.arguments().length() < 1) {
> continue;
Perhaps even check `!= 1` - it shouldn't have more than one argument either.
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D6718
To: fvogt, #plasma, broulik, davidedmundson
Cc: heikobecker, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
D6933: [Component Chooser] Update http(s) scheme handler when changing default browser
broulik added a comment. > I suppose updating the handler for text/html would make sense too, so that clicking on a local HTML file opens the same webbrowser. Well, KRun has a special case for text/html to always open them in the default browser, no matter what. So you cannot actually have Kate as your default app for HTML :D REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6933 To: broulik, #plasma, dfaure Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6933: [Component Chooser] Update http(s) scheme handler when changing default browser
This revision was automatically updated to reflect the committed changes. Closed by commit R119:1193971e9a27: [Component Chooser] Update http(s) scheme handler when changing default browser (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6933?vs=17274=17282 REVISION DETAIL https://phabricator.kde.org/D6933 AFFECTED FILES kcms/componentchooser/componentchooserbrowser.cpp To: broulik, #plasma, dfaure Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6933: [Component Chooser] Update http(s) scheme handler when changing default browser
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I suppose updating the handler for text/html would make sense too, so that clicking on a local HTML file opens the same webbrowser. Some people editing HTML files might prefer that local html files open kate though -- but they can simply set that afterwards... or we could have more advanced logic here like "if the current handler for text/html is a WebBrowser then adjust it otherwise leave it alone"... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6933 To: broulik, #plasma, dfaure Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6933: [Component Chooser] Update http(s) scheme handler when changing default browser
broulik updated this revision to Diff 17274. broulik edited the test plan for this revision. broulik added a comment. - Sync `mimeAppList` instead of `profile`, fixes the change not being reflected immediately REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6933?vs=17236=17274 REVISION DETAIL https://phabricator.kde.org/D6933 AFFECTED FILES kcms/componentchooser/componentchooserbrowser.cpp To: broulik, #plasma, dfaure Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6727: Destroy all kwayland objects created by registry when it is destroyed
davidedmundson updated this revision to Diff 17272. davidedmundson added a comment. Updated docs + unit test REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6727?vs=16758=17272 BRANCH davidedmundson/xdgv6 REVISION DETAIL https://phabricator.kde.org/D6727 AFFECTED FILES autotests/client/test_wayland_registry.cpp src/client/blur.h src/client/contrast.h src/client/datadevice.h src/client/datadevicemanager.h src/client/dataoffer.h src/client/datasource.h src/client/dpms.h src/client/event_queue.h src/client/fakeinput.h src/client/idle.h src/client/output.cpp src/client/output.h src/client/outputconfiguration.h src/client/outputdevice.cpp src/client/outputdevice.h src/client/outputmanagement.h src/client/plasmashell.h src/client/plasmawindowmanagement.h src/client/pointerconstraints.h src/client/pointergestures.h src/client/registry.cpp src/client/registry.h src/client/relativepointer.h src/client/seat.h src/client/server_decoration.h src/client/shadow.h src/client/shm_pool.h src/client/slide.h src/client/surface.h src/client/textinput.h src/client/xdgshell.h To: davidedmundson Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6946: Emit connectionDied if the QPA is destroyed
davidedmundson created this revision. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6946 AFFECTED FILES src/client/connection_thread.cpp To: davidedmundson Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
