D7268: Use new libtm API to enable DND reordering within group dialogs.

2017-08-11 Thread Eike Hein
hein edited the summary of this revision. hein added a dependency: D7267: Add support for moving group members within a group.. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7268 To: hein, #plasma, davidedmundson, argonel Cc: plasma-devel, ZrenBot, progwolff,

D7267: Add support for moving group members within a group.

2017-08-11 Thread Eike Hein
hein added a dependent revision: D7268: Use new libtm API to enable DND reordering within group dialogs.. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7267 To: hein, #plasma, davidedmundson, argonel Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D7268: Use new libtm API to enable DND reordering within group dialogs.

2017-08-11 Thread Eike Hein
hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY BUG:383405 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D7268 AFFECTED FILES applets/taskmanager/package/contents/ui/MouseHandler.qml To: hein,

D7267: Add support for moving group members within a group.

2017-08-11 Thread Eike Hein
hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY BUG:383405 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D7267 AFFECTED FILES libtaskmanager/tasksmodel.cpp libtaskmanager/tasksmodel.h To:

D6549: Look for QtGraphicalEffects, so packagers don't forget it

2017-08-11 Thread Aleix Pol Gonzalez
apol added a comment. I was thinking: should I wait for a month so that ECM has been released with it maybe? Otherwise it will be a hard dependency and people won't be able to use the master branch... REPOSITORY R169 Kirigami BRANCH arcpatch-D6549 REVISION DETAIL

D7255: Remove application directory from QCoreApplication::libraryPaths()

2017-08-11 Thread Fabian Vogt
fvogt added a comment. In https://phabricator.kde.org/D7255#134745, @broulik wrote: > > I'll look whether it's possible to override that in a sane place as well. > > KDeclarative QmlObject, maybe? I think the single QuickViewSharedEngine used in most of Plasma should already give a

D7255: Remove application directory from QCoreApplication::libraryPaths()

2017-08-11 Thread Kai Uwe Broulik
broulik added a comment. > I'll look whether it's possible to override that in a sane place as well. KDeclarative QmlObject, maybe? I think the single QuickViewSharedEngine used in most of Plasma should already give a significant improvement. REPOSITORY R120 Plasma Workspace REVISION

D7260: System tray icon's context menu isn't updated properly in plasma/x11

2017-08-11 Thread Aleksei Nikiforov
i.Dark_Templar created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is a fix for a bug I recently reported at: https://bugs.kde.org/show_bug.cgi?id=383202 Basically, if you make system tray

D7259: Move QPainter compositor into plugin

2017-08-11 Thread Martin Flöser
graesslin retitled this revision from "[autotests] Remove not needed includes for scene_qpainter.h" to "Move QPainter compositor into plugin". REVISION DETAIL https://phabricator.kde.org/D7259 To: graesslin, #kwin, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7232: Move SceneXRender into a plugin

2017-08-11 Thread Martin Flöser
graesslin added a dependent revision: D7259: [autotests] Remove not needed includes for scene_qpainter.h. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7232 To: graesslin, #kwin, #plasma Cc: broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7259: [autotests] Remove not needed includes for scene_qpainter.h

2017-08-11 Thread Martin Flöser
graesslin added a dependency: D7232: Move SceneXRender into a plugin. REVISION DETAIL https://phabricator.kde.org/D7259 To: graesslin, #kwin, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7259: [autotests] Remove not needed includes for scene_qpainter.h

2017-08-11 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Provide a virtual Scene::qpainterRenderBuffer() -> QImage* method Needed by testing of QPainter scene to access the back buffer.

D7257: Set the QtQuick Controls 1 style name explicitly

2017-08-11 Thread Fabian Vogt
fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY It does explicitly what the comment above the export implies. That way this warning on every use of Quick Controls 1 is gone: WARNING: Cannot find style "org.kde.desktop" - fallback:

D7256: emit previously shown notifications after resume from idle

2017-08-11 Thread Julian Wolff
progwolff created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is an attempt to improve the behaviour of notifications that are triggered while the session is idle. This is related to (but not

D7255: Remove application directory from QCoreApplication::libraryPaths()

2017-08-11 Thread Fabian Vogt
fvogt added a comment. In https://phabricator.kde.org/D7255#134678, @graesslin wrote: > Reading through your description I think that KWin must also be affected and many, many more applications. Actually probably everything distributed in the classic "sysadmin style" (to reference a

D7255: Remove application directory from QCoreApplication::libraryPaths()

2017-08-11 Thread Martin Flöser
graesslin added a comment. Reading through your description I think that KWin must also be affected and many, many more applications. Actually probably everything distributed in the classic "sysadmin style" (to reference a today's blog post). I'm wondering whether it would make sense to

D7255: Remove application directory from QCoreApplication::libraryPaths()

2017-08-11 Thread Fabian Vogt
fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY The directory containing the main application (read through argv[0]) is by default added to the list of paths containing libraries. This causes various methods to iterate through all entries of the

D7232: Move SceneXRender into a plugin

2017-08-11 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > broulik wrote in xrender.json:7 > Can we instead query `QMetaEnum` and store the enum's key name as a string? That one was new to me. I had a look today and tried to change it, but face several problems: - The enum is declared in a namespace

D7127: ignore spurious resize events to empty sizes

2017-08-11 Thread Christoph Feck
cfeck added a comment. The commit still says "size != oldSize". Is this correct? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7127 To: mart, #plasma, davidedmundson Cc: cfeck, davidedmundson, broulik, plasma-devel, #frameworks, ZrenBot,

[Powerdevil] [Bug 383307] Brightness level is not remembered/restoring after sleep and levels up to maximum level

2017-08-11 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=383307 Kai Uwe Broulik changed: What|Removed |Added CC|

D7235: [Folder View] Don't process mime data if immutable

2017-08-11 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:d4bd4bfaf701: [Folder View] Don't process mime data if immutable (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7235?vs=17980=18005

D7235: [Folder View] Don't process mime data if immutable

2017-08-11 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7235 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D7248: Microoptimise: don't change fillMode of image just before deleting itIt is still set for when a source is applied for the next transistion.

2017-08-11 Thread Marco Martin
mart accepted this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D7248 To: davidedmundson, #plasma, broulik, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7248: Microoptimise: don't change fillMode of image just before deleting itIt is still set for when a source is applied for the next transistion.

2017-08-11 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D7248 To: davidedmundson, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7248: Microoptimise: don't change fillMode of image just before deleting itIt is still set for when a source is applied for the next transistion.

2017-08-11 Thread David Edmundson
davidedmundson added a comment. To expand on the crash: Killer line is fadeAnim.running = Qt.binding(function() { return currentImage.status !== Image.Loading && otherImage.status !== Image.Loading }) the idea being to delay the loading until both things are

D7248: Microoptimise: don't change fillMode of image just before deleting itIt is still set for when a source is applied for the next transistion.

2017-08-11 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This saves evaluating a new paintedSize and doing a bunch of evaluations for no reason. More importantly it works round a Qt

releasme & plasma 5.10

2017-08-11 Thread Harald Sitter
Ahoy hoy, I am currently in the progress of landing fairly invasive changes to how documentation is handled in releaseme as previously mentioned in 'cmake magic for documentation' thread after Jonathan was nice enough to get rid of some excess code in the plasma repos that was blocking this. As

D7160: Also specify a default StyleName for fonts

2017-08-11 Thread Fabian Vogt
fvogt closed this revision. fvogt added a comment. Didn't get closed automatically again... https://commits.kde.org/plasma-integration/1b21b5977c2068c5bd30c9f9f641f60bdba9ea8e REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL

D7246: Tooltips in Breeze theme

2017-08-11 Thread Kai Uwe Broulik
broulik added a comment. Thanks for your patch, however I think this should rather to into KDecoration itself so every decoration, not just Breeze, takes advantage of it. However, from what I can tell KDecoration is QtGui-only (not QtWidgets), I looked into it once but didn't want to pull

D7246: Tooltips in Breeze theme

2017-08-11 Thread Kai Uwe Broulik
broulik added reviewers: Plasma, graesslin. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7246: Tooltips in Breeze theme

2017-08-11 Thread Oleg Solovyov
McPain created this revision. McPain added projects: Plasma, Breeze. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY https://bugs.kde.org/show_bug.cgi?id=383040 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES