D7268: Use new libtm API to enable DND reordering within group dialogs.

[Eike Hein]

hein edited the summary of this revision.
hein added a dependency: D7267: Add support for moving group members within a 
group..

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7268

To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7267: Add support for moving group members within a group.

[Eike Hein]

hein added a dependent revision: D7268: Use new libtm API to enable DND 
reordering within group dialogs..

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7267

To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7268: Use new libtm API to enable DND reordering within group dialogs.

[Eike Hein]

hein created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  BUG:383405

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7268

AFFECTED FILES
  applets/taskmanager/package/contents/ui/MouseHandler.qml

To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7267: Add support for moving group members within a group.

[Eike Hein]

hein created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  BUG:383405

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7267

AFFECTED FILES
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h

To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6549: Look for QtGraphicalEffects, so packagers don't forget it

[Aleix Pol Gonzalez]

apol added a comment.


  I was thinking: should I wait for a month so that ECM has been released with 
it maybe? Otherwise it will be a hard dependency and people won't be able to 
use the master branch...

REPOSITORY
  R169 Kirigami

BRANCH
  arcpatch-D6549

REVISION DETAIL
  https://phabricator.kde.org/D6549

To: apol, #kirigami, sitter, mart, davidedmundson
Cc: plasma-devel, apol, mart

D7255: Remove application directory from QCoreApplication::libraryPaths()

[Fabian Vogt]

fvogt added a comment.


  In https://phabricator.kde.org/D7255#134745, @broulik wrote:
  
  > > I'll look whether it's possible to override that in a sane place as well.
  >
  > KDeclarative QmlObject, maybe? I think the single QuickViewSharedEngine 
used in most of Plasma should already give a significant improvement.
  
  
  I'd rather not change that in any framework, as applications linking to it 
can be deployed in whatever way they prefer.
  IMO it should be specified by the application itself.
  
  This diff to plasma-framework seems to work for some quick experiments (pun 
not intended) though:
  
diff --git a/src/plasmaquick/appletquickitem.cpp 
b/src/plasmaquick/appletquickitem.cpp
index 39facc613..29f0f7e69 100644
--- a/src/plasmaquick/appletquickitem.cpp
+++ b/src/plasmaquick/appletquickitem.cpp
@@ -66,6 +66,12 @@ void AppletQuickItemPrivate::init()
 PackageUrlInterceptor *interceptor = new 
PackageUrlInterceptor(qmlObject->engine(), Plasma::Package());
 qmlObject->engine()->setUrlInterceptor(interceptor);
 }
+
+// Remove the unnecessary applicationDirPath from the front of the 
import path list
+auto importPathList = qmlObject->engine()->importPathList();
+// Only set the import path if it actually changed, we might have 
removed it already.
+if (importPathList.removeAll(QCoreApplication::applicationDirPath()) > 
0)
+qmlObject->engine()->setImportPathList(importPathList);
 }
 
 void AppletQuickItemPrivate::connectLayoutAttached(QObject *item)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7255

To: fvogt, #plasma
Cc: broulik, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7255: Remove application directory from QCoreApplication::libraryPaths()

[Kai Uwe Broulik]

broulik added a comment.


  > I'll look whether it's possible to override that in a sane place as well.
  
  KDeclarative QmlObject, maybe? I think the single QuickViewSharedEngine used 
in most of Plasma should already give a significant improvement.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7255

To: fvogt, #plasma
Cc: broulik, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7260: System tray icon's context menu isn't updated properly in plasma/x11

[Aleksei Nikiforov]

i.Dark_Templar created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This is a fix for a bug I recently reported at: 
https://bugs.kde.org/show_bug.cgi?id=383202
  
  Basically, if you make system tray menu with multiple levels of nesting, 
browse this menu (making sure plasma fetches all data for menu via dbus) and 
then replace menu by different menu with multiple levels of nesting, plasma 
uses old data for all menu items, usually except of top level menu.
  
  Proposed patch makes sure that no menus are cached, and if top-level menu is 
updated, all nested menus are updated as well (on aboutToShow event).

TEST PLAN
  I've attached test application to the mentioned bug, it started working 
correctly with this patch on plasma-workspace-5.9.5.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7260

AFFECTED FILES
  libdbusmenuqt/dbusmenuimporter.cpp

To: i.Dark_Templar
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7259: Move QPainter compositor into plugin

[Martin Flöser]

graesslin retitled this revision from "[autotests] Remove not needed includes 
for scene_qpainter.h" to "Move QPainter compositor into plugin".

REVISION DETAIL
  https://phabricator.kde.org/D7259

To: graesslin, #kwin, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7232: Move SceneXRender into a plugin

[Martin Flöser]

graesslin added a dependent revision: D7259: [autotests] Remove not needed 
includes for scene_qpainter.h.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7232

To: graesslin, #kwin, #plasma
Cc: broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D7259: [autotests] Remove not needed includes for scene_qpainter.h

[Martin Flöser]

graesslin added a dependency: D7232: Move SceneXRender into a plugin.

REVISION DETAIL
  https://phabricator.kde.org/D7259

To: graesslin, #kwin, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7259: [autotests] Remove not needed includes for scene_qpainter.h

[Martin Flöser]

graesslin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Provide a virtual Scene::qpainterRenderBuffer() -> QImage* method
  
  Needed by testing of QPainter scene to access the back buffer. Exposed
  as a virtual method in Scene, so that the test does not have to cast to
  SceneQPainter.
  
  Move QPainter compositor into plugin
  
  This change is similar to https://phabricator.kde.org/D7232 and moves the 
scene_qpainter into a
  dedicated plugin. Compared to the XRender case it's more complicated as
  the platform plugins need to implement a platform specific backend.
  
  The base implementation for this part used to be in scene_qpainter. As
  the idea is to completly move it away from KWin core it would be point
  less to still have the backend definition in KWin core, but it cannot
  be in the scene plugin as otherwise all platforms need to link the
  plugin.
  
  To solve this a new platformsupport subdirectory is added which contains
  the scene platform backend as a static library. For the OpenGL scene such
  a static library will also be required.

TEST PLAN
  SceneQPainter test still passes, nested compositor still works

BRANCH
  scene-qpainter-plugin

REVISION DETAIL
  https://phabricator.kde.org/D7259

AFFECTED FILES
  CMakeLists.txt
  autotests/integration/effects/fade_test.cpp
  autotests/integration/effects/slidingpopups_test.cpp
  autotests/integration/effects/translucency_test.cpp
  autotests/integration/scene_qpainter_test.cpp
  autotests/integration/x11_client_test.cpp
  composite.cpp
  platformsupport/CMakeLists.txt
  platformsupport/scenes/CMakeLists.txt
  platformsupport/scenes/qpainter/CMakeLists.txt
  platformsupport/scenes/qpainter/backend.cpp
  platformsupport/scenes/qpainter/backend.h
  plugins/platforms/drm/CMakeLists.txt
  plugins/platforms/drm/scene_qpainter_drm_backend.h
  plugins/platforms/fbdev/CMakeLists.txt
  plugins/platforms/fbdev/scene_qpainter_fb_backend.h
  plugins/platforms/virtual/CMakeLists.txt
  plugins/platforms/virtual/scene_qpainter_virtual_backend.h
  plugins/platforms/wayland/CMakeLists.txt
  plugins/platforms/wayland/scene_qpainter_wayland_backend.h
  plugins/platforms/x11/windowed/CMakeLists.txt
  plugins/platforms/x11/windowed/scene_qpainter_x11_backend.h
  plugins/scenes/CMakeLists.txt
  plugins/scenes/qpainter/CMakeLists.txt
  plugins/scenes/qpainter/qpainter.json
  plugins/scenes/qpainter/scene_qpainter.cpp
  plugins/scenes/qpainter/scene_qpainter.h
  scene.cpp
  scene.h
  scene_qpainter.cpp
  scene_qpainter.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7257: Set the QtQuick Controls 1 style name explicitly

[Fabian Vogt]

fvogt created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  It does explicitly what the comment above the export implies.
  That way this warning on every use of Quick Controls 1 is gone:
  
  WARNING: Cannot find style "org.kde.desktop" - fallback: 
"/usr/lib64/qt5/qml/QtQuick/Controls/Styles/Desktop"
  
  Note that I'm not 100% sure that this does not have any
  ill side effects as I don't quite understand what and where
  org.kde.desktop is supposed to be.

TEST PLAN
  Started plasmashell and plasma-discover both with and without 
  the change, no difference except that the warning is now gone.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  warnfix

REVISION DETAIL
  https://phabricator.kde.org/D7257

AFFECTED FILES
  startkde/startkde.cmake
  startkde/startplasma.cmake

To: fvogt, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7256: emit previously shown notifications after resume from idle

[Julian Wolff]

progwolff created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This is an attempt to improve the behaviour of notifications that are 
triggered while the session is idle. This is related to (but not fixing) Bug 
378032.
Notifications that are triggered while the session is idle might be 
missed by the user. With these changes, notifications will be shown again when 
the session resumes from idle.
  
  This behaviour might be controversial. A history of notifications seems to be 
unwanted. I tried to find a way to make missing important notifications less 
likely while not annoying the user too much.

TEST PLAN
  Stay away from the keyboard and the mouse for more than 30 seconds. Then 
remotely trigger a notification and wait until it disappears. It should show up 
again once you move the mouse or hit a key.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7256

AFFECTED FILES
  dataengines/notifications/CMakeLists.txt
  dataengines/notifications/notificationsengine.cpp
  dataengines/notifications/notificationsengine.h

To: progwolff, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7255: Remove application directory from QCoreApplication::libraryPaths()

[Fabian Vogt]

fvogt added a comment.


  In https://phabricator.kde.org/D7255#134678, @graesslin wrote:
  
  > Reading through your description I think that KWin must also be affected 
and many, many more applications. Actually probably everything distributed in 
the classic "sysadmin style" (to reference a today's blog post). I'm wondering 
whether it would make sense to have this in either Qt directly (maybe not?) or 
a wrapper in KCoreAddons which can easily handle situations like run as 
flatpack where it's not needed or not wanted.
  >
  > Anyway: +1 to the change, that sounds awesome improvement.
  
  
  It gets even "better": QQmlEngines have the applicationDirPath set as 
first(!) entry of the importPathList as well by default, so strace gets spammed 
with
  
[pid 21876] stat("/usr/bin/QtQuick.2.1", 0x7f8faf5a42b0) = -1 ENOENT (No 
such file or directory)
[pid 21876] stat("/usr/bin/QtQuick.2", 0x7f8faf5a42b0) = -1 ENOENT (No such 
file or directory)
[pid 21876] stat("/usr/bin/QtQuick/Controls.1.0", 0x7f8faf5a42b0) = -1 
ENOENT (No such file or directory)
[pid 21876] stat("/usr/bin/QtQuick.1.0/Controls", 0x7f8faf5a42b0) = -1 
ENOENT (No such file or directory)
  
  I'll look whether it's possible to override that in a sane place as well.
  
  I would also like to see this fixed directly in Qt as well, but it's not so 
easy IMO.
  The default addition of the path to the various path lists is only useful for 
applications shipped as a single directory,
  not supposed to be installed linux-style. I'm not sure how Qt could 
distinguish those cases... At least I'm against hardcoding
  blacklisted paths inside Qt.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7255

To: fvogt, #plasma
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7255: Remove application directory from QCoreApplication::libraryPaths()

[Martin Flöser]

graesslin added a comment.


  Reading through your description I think that KWin must also be affected and 
many, many more applications. Actually probably everything distributed in the 
classic "sysadmin style" (to reference a today's blog post). I'm wondering 
whether it would make sense to have this in either Qt directly (maybe not?) or 
a wrapper in KCoreAddons which can easily handle situations like run as 
flatpack where it's not needed or not wanted.
  
  Anyway: +1 to the change, that sounds awesome improvement.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7255

To: fvogt, #plasma
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7255: Remove application directory from QCoreApplication::libraryPaths()

[Fabian Vogt]

fvogt created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  The directory containing the main application (read through argv[0]) is
  by default added to the list of paths containing libraries.
  This causes various methods to iterate through all entries of the plasmashell
  install location, usually /usr/bin.
  By explicitly removing the path, those unnecessary lookups can be avoided,
  resulting in around 100ms quicker startup on a system with 4000 entries in
  /usr/bin.

TEST PLAN
  Ran plasmashell with and without this fix, no changes except for a slightly
  quicker startup and much less strace noise.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  libfix

REVISION DETAIL
  https://phabricator.kde.org/D7255

AFFECTED FILES
  shell/main.cpp

To: fvogt, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7232: Move SceneXRender into a plugin

[Martin Flöser]

graesslin added inline comments.

INLINE COMMENTS

> broulik wrote in xrender.json:7
> Can we instead query `QMetaEnum` and store the enum's key name as a string?

That one was new to me. I had a look today and tried to change it, but face 
several problems:

- The enum is declared in a namespace
- Q_NAMESPACE and Q_ENUM_NS are only available in 5.8
- Ignoring that and just adding them results in linker error as the header 
where it's defined is header only

So overall I think the answer is: no we cannot.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7232

To: graesslin, #kwin, #plasma
Cc: broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D7127: ignore spurious resize events to empty sizes

[Christoph Feck]

cfeck added a comment.


  The commit still says "size != oldSize". Is this correct?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D7127

To: mart, #plasma, davidedmundson
Cc: cfeck, davidedmundson, broulik, plasma-devel, #frameworks, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, 
lukas

[Powerdevil] [Bug 383307] Brightness level is not remembered/restoring after sleep and levels up to maximum level

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=383307

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de
Product|plasmashell |Powerdevil
  Component|general |general
   Target Milestone|1.0 |---
   Assignee|k...@davidedmundson.co.uk|plasma-devel@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7235: [Folder View] Don't process mime data if immutable

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d4bd4bfaf701: [Folder View] Don't process mime data if 
immutable (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7235?vs=17980=18005

REVISION DETAIL
  https://phabricator.kde.org/D7235

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7235: [Folder View] Don't process mime data if immutable

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7235

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7248: Microoptimise: don't change fillMode of image just before deleting itIt is still set for when a source is applied for the next transistion.

[Marco Martin]

mart accepted this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7248

To: davidedmundson, #plasma, broulik, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7248: Microoptimise: don't change fillMode of image just before deleting itIt is still set for when a source is applied for the next transistion.

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7248

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7248: Microoptimise: don't change fillMode of image just before deleting itIt is still set for when a source is applied for the next transistion.

[David Edmundson]

davidedmundson added a comment.


  To expand on the crash:
  
  Killer line is
  
  fadeAnim.running = Qt.binding(function() {
  
return currentImage.status !== Image.Loading && otherImage.status !== 
Image.Loading
})
  
  the idea being to delay the loading until both things are loaded.
  
  But scriptAnimation at the end does:
  
  otherImage.fillMode = fillMode;
  otherImage.source = "";
  
  which means from inside the animation we change fillMode - running goes to 
false as it reloads the image with the new fillMode (asynchronously)
  then we unset the source, running goes to true as it's no longer loading
  
  We're completely restarting the animation from within the animation. 
  Qt doesn't like that.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7248

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7248: Microoptimise: don't change fillMode of image just before deleting itIt is still set for when a source is applied for the next transistion.

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This saves evaluating a new paintedSize and doing a bunch of evaluations
  for no reason.
  
  More importantly it works round a Qt animation crash.
  
  CCBUG: 381105

TEST PLAN
  Cloned this code whilst making a tiny reproducible test case
  Found swapping these lines made that go away
  Given it results in less processing we may as well do it.
  
  End user result is the same.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7248

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

releasme & plasma 5.10

[Harald Sitter]

Ahoy hoy,

I am currently in the progress of landing fairly invasive changes to
how documentation is handled in releaseme as previously mentioned in
'cmake magic for documentation' thread after Jonathan was nice enough
to get rid of some excess code in the plasma repos that was blocking
this.

As a result of this Plasma 5.10.5 needs to be created from the
'Plasma/5.10' branch of releaseme. NOT master!

For 5.11 master is good to use again.

(reason is that 5.10.5 will still have the code which releaseme
supports but kdoctools does not, so releasing 5.10.5 with releaseme
from master would change cmake behavior in a point release which is
undesirable)

HS

D7160: Also specify a default StyleName for fonts

[Fabian Vogt]

fvogt closed this revision.
fvogt added a comment.


  Didn't get closed automatically again...
  
  
https://commits.kde.org/plasma-integration/1b21b5977c2068c5bd30c9f9f641f60bdba9ea8e

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7160

To: fvogt, #plasma, davidedmundson
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7246: Tooltips in Breeze theme

[Kai Uwe Broulik]

broulik added a comment.


  Thanks for your patch, however I think this should rather to into KDecoration 
itself so every decoration, not just Breeze, takes advantage of it. However, 
from what I can tell KDecoration is QtGui-only (not QtWidgets), I looked into 
it once but didn't want to pull in widgets just for `QToolTip`.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7246

To: McPain, #breeze
Cc: broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7246: Tooltips in Breeze theme

[Kai Uwe Broulik]

broulik added reviewers: Plasma, graesslin.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7246

To: McPain, #breeze, #plasma, graesslin
Cc: broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7246: Tooltips in Breeze theme

[Oleg Solovyov]

McPain created this revision.
McPain added projects: Plasma, Breeze.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  https://bugs.kde.org/show_bug.cgi?id=383040

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7246

AFFECTED FILES
  kdecoration/breezebutton.cpp
  kdecoration/breezebutton.h

To: McPain, #breeze
Cc: plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas