D7716: Support filepaths with accents

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Our helper runs as root and doesn't have the user's environment (including $LANG). This defaults to one without UTF-8. Without a

[Powerdevil] [Bug 381387] display brightness is increased when come back from closed lid

https://bugs.kde.org/show_bug.cgi?id=381387 --- Comment #2 from Matthias --- Since Bugzilla allows no editing: When i like to reduce the brightness then, is this not possible since plasma think, that this is already on the lowest possible level. WOW, i just

D7715: [WIP] Fix RTL in some plasmacomponents3 widgets.

safaalfulaij added inline comments. INLINE COMMENTS > broulik wrote in ProgressBar.qml:33 > That's pretty clever, actually, > > > A negative scale causes the item to be mirrored when rendered. > > However, not sure we can just blatantly mirror that graphic Actually, it’s used in default QQC2

[Powerdevil] [Bug 381387] display brightness is increased when come back from closed lid

https://bugs.kde.org/show_bug.cgi?id=381387 --- Comment #1 from Matthias --- Happens here as well. And yes, i had this issue back then also. HP 8570p 1) I reduce the display brightness of my laptop to the lowest level. 2) I close the lid, which disables the display

D7715: [WIP] Fix RTL in some plasmacomponents3 widgets.

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in ProgressBar.qml:33 > I don't understand what this is doing? That's pretty clever, actually, > A negative scale causes the item to be mirrored when rendered. However, not sure we can just blatantly mirror that graphic

D7715: [WIP] Fix RTL in some plasmacomponents3 widgets.

davidedmundson added inline comments. INLINE COMMENTS > ProgressBar.qml:33 > contentItem: Item { > +scale: control.mirrored ? -1 : 1 > PlasmaCore.FrameSvgItem { I don't understand what this is doing? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D7715: [WIP] Fix RTL in some plasmacomponents3 widgets.

safaalfulaij added a comment. One widget I didn't know how to fix is the TabBar (The blue line that flows from left to right for the first item.) Other widgets are behaving the same as QQC2 ones, like BusyIndicator and Dial, so I didn't change them. Not sure if they should be flipped or

D7715: [WIP] Fix RTL in some plasmacomponents3 widgets.

safaalfulaij created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Some widgets are missed up in RTL mode, this should fix it. REPOSITORY R242 Plasma Framework (Library) BRANCH master

D7712: Delay syncing internal window geometry to end of cycle

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I don't really like it, there's quite a few other things that edit internal windows whilst they're doing a roundtrip, which puts us in a somewhat weird state. ...but I

D7713: [tabbox] Properly check whether two windows belong to same application

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH tabbox-belong-to-same-application REVISION DETAIL https://phabricator.kde.org/D7713 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, bwowk, ZrenBot,

D7713: [tabbox] Properly check whether two windows belong to same application

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY TabBox implemented a custom way to check whether two windows belong to the same application. KWin internally has API for that which

D7712: Delay syncing internal window geometry to end of cycle

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The syncing of the window geometry to the internal geometry can unfortunately cause a freeze in very special conditions: 1. create

D7711: Add missing imports for attached properties

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL https://phabricator.kde.org/D7711 To: apol, #frameworks, mart, davidedmundson Cc: plasma-devel, ZrenBot, progwolff,

D7711: Add missing imports for attached properties

apol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL https://phabricator.kde.org/D7711 AFFECTED FILES

Re: Plasma 5.11 repos

On Wed, 6 Sep 2017 13:49:16 +0200 Harald Sitter wrote: > On Wed, Sep 6, 2017 at 1:08 PM, Jonathan Riddell > wrote: > > On Wed, Sep 06, 2017 at 01:01:46PM +0200, Harald Sitter wrote: > >> On Wed, Sep 6, 2017 at 12:59 PM, Jonathan Riddell > >>

D7650: Drop XRandR dependency from Options's currentRefreshRate

This revision was automatically updated to reflect the committed changes. Closed by commit R108:536739f09510: Drop XRandR dependency from Options's currentRefreshRate (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7650?vs=19080=19237

D7651: Protect readProperty and deleteProperty in case of no X11

This revision was automatically updated to reflect the committed changes. Closed by commit R108:4db4fa42f7ed: Protect readProperty and deleteProperty in case of no X11 (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7651?vs=19081=19238

D7698: Pass EGL information from AbstractEglBackend to Platform instead of query

graesslin updated this revision to Diff 19236. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Don't unset the EGLDisplay in the platform REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7698?vs=19210=19236 BRANCH

D7273: Use the new ECMQMLModules to specify all of KWin's runtime dependencies

graesslin added a comment. In https://phabricator.kde.org/D7273#143252, @apol wrote: > > I think we first need to get https://phabricator.kde.org/D7543 in, to be able to depend from the ECM version. > > I don't see how it's related ECMFindQMLModule is only available in ECM

D7705: [Task Manager] Strip applications: scheme from launcher URL in MPris source

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d711ff0c357a: [Task Manager] Strip applications: scheme from launcher URL in MPris source (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

Re: Plasma 5.11 repos

On Wed, Sep 6, 2017 at 1:51 PM, Jonathan Riddell wrote: > On 6 September 2017 at 12:49, Harald Sitter wrote: >> Sure, but... 5.38 is tagged already, so it could only become a >> framework for 5.39.. and that is a problem. >> >> KF 5.39 is scheduled for release

D7705: [Task Manager] Strip applications: scheme from launcher URL in MPris source

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7705 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D6359: [Task Manager] Honor "kde:pid" Metadata for when window PID isn't player PID

broulik added a comment. > why did you chose this over overriding InstancePid in the dataengine? Because it's not the actual PID of the process. The mapping is only really needed in TM (media controller applet doesn't care), so I didn't want to "lie" about that and rather have the view

D6359: [Task Manager] Honor "kde:pid" Metadata for when window PID isn't player PID

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d094bd37ea90: [Task Manager] Honor "kde:pid" Metadata for when window PID isn't player PID (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D7705: [Task Manager] Strip applications: scheme from launcher URL in MPris source

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise mapping fails. TEST PLAN I now get media controls in VLC player again REPOSITORY R119 Plasma Desktop REVISION DETAIL

Re: Plasma 5.11 repos

On 6 September 2017 at 12:49, Harald Sitter wrote: > Sure, but... 5.38 is tagged already, so it could only become a > framework for 5.39.. and that is a problem. > > KF 5.39 is scheduled for release on Oct 14. > Plasma 5.11 is schedule for release on Oct 10, which would have no >

Re: Plasma 5.11 repos

On Wed, Sep 6, 2017 at 1:08 PM, Jonathan Riddell wrote: > On Wed, Sep 06, 2017 at 01:01:46PM +0200, Harald Sitter wrote: >> On Wed, Sep 6, 2017 at 12:59 PM, Jonathan Riddell wrote: >> > qqc2-desktop-style will not be included >> >> :O but kirigami/qqc is

Re: qqc2-desktop-style as framework

On Fri, Sep 1, 2017 at 3:02 PM, Marco Martin wrote: > On Thu, Aug 31, 2017 at 5:06 PM, Marco Martin wrote: >> any objection into pulling it into a framework? anything particular for the >> procedure? > > as an update to that, i've update its cmake files and

Re: Plasma 5.11 repos

On Wed, Sep 6, 2017 at 12:08 PM, Jonathan Riddell wrote: > On Wed, Sep 06, 2017 at 01:01:46PM +0200, Harald Sitter wrote: > > On Wed, Sep 6, 2017 at 12:59 PM, Jonathan Riddell > wrote: > > > qqc2-desktop-style will not be included > > > > :O but

Re: Plasma 5.11 repos

On Wed, Sep 6, 2017 at 11:59 AM, Jonathan Riddell wrote: > Repo freeze passed us by so it's time to review what's to be released > with 5.11, which has a beta due in 8 days time. > > There's a new drkonqi repo, should that be released with Plasma? > Yes please.

Re: Plasma 5.11 repos

On Wed, Sep 06, 2017 at 01:01:46PM +0200, Harald Sitter wrote: > On Wed, Sep 6, 2017 at 12:59 PM, Jonathan Riddell wrote: > > qqc2-desktop-style will not be included > > :O but kirigami/qqc is fairly defunct without this The hope is to include is in frameworks. Since kirigami

Re: Plasma 5.11 repos

On Wed, Sep 6, 2017 at 12:59 PM, Jonathan Riddell wrote: > qqc2-desktop-style will not be included :O but kirigami/qqc is fairly defunct without this

Plasma 5.11 repos

Repo freeze passed us by so it's time to review what's to be released with 5.11, which has a beta due in 8 days time. There's a new drkonqi repo, should that be released with Plasma? Should plasma-browser-integration get a release? Is plasma-vault ready for inclusion? qqc2-desktop-style will

D7686: Don't show a region selector when selecting avatars from a gallery

This revision was automatically updated to reflect the committed changes. Closed by commit R128:8defbd16e767: Don't show a region selector when selecting avatars from a gallery (authored by davidedmundson). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE

D7650: Drop XRandR dependency from Options's currentRefreshRate

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH options-no-randr REVISION DETAIL https://phabricator.kde.org/D7650 To: graesslin, #kwin, #plasma, broulik Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,

D7651: Protect readProperty and deleteProperty in case of no X11

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH effects-x11-protection REVISION DETAIL https://phabricator.kde.org/D7651 To: graesslin, #kwin, #plasma, broulik Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,

D7631: [Folder View] Accept and reject Escape event appropriately

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9646aec02c3b: [Folder View] Accept and reject Escape event appropriately (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D7639: [Task Manager] Decode applications URL before dragging

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b293137ed955: [Task Manager] Decode applications URL before dragging (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D7686: Don't show a region selector when selecting avatars from a gallery

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D7686 To: davidedmundson, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,