D7766: make krunner accessible

davidedmundson added inline comments. INLINE COMMENTS > ResultDelegate.qml:50 > +Accessible.name: displayLabel.text > +Accessible.description: i18n("%1, in category %2", > subtextLabel.text.length > 0 ? subtextLabel.text : " ", ListView.section) > property bool __pressed: false

D7766: make krunner accessible

mart updated this revision to Diff 19429. mart added a comment. - Accessible.ListItem as role REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7766?vs=19426=19429 BRANCH accessiblekrunner REVISION DETAIL https://phabricator.kde.org/D7766 AFFECTED FILES

D7765: make krunner accessible

mart updated this revision to Diff 19427. mart added a comment. - remove dead code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7765?vs=19424=19427 BRANCH accessiblekrunner REVISION DETAIL https://phabricator.kde.org/D7765 AFFECTED FILES

D7766: make krunner accessible

mart updated this revision to Diff 19426. mart added a comment. - better syntax on i18n REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7766?vs=19402=19426 BRANCH accessiblekrunner REVISION DETAIL https://phabricator.kde.org/D7766 AFFECTED FILES

D7765: make krunner accessible

gladhorn added a comment. Lovely! Just a bit of nit-picking. INLINE COMMENTS > view.cpp:65 > > +//used only by on screen readers > +setTitle(i18n("KRunner")); I'd remove the "on" :) > RunCommand.qml:120 > } > -Keys.forwardTo: [listView, results] > +

D7766: make krunner accessible

mart added inline comments. INLINE COMMENTS > broulik wrote in ResultsView.qml:140 > Can we perhaps bind the "isCurrentItem" to activeFocus instead of doing this > in addition to incrementing/decrementing the index? what i'm trying to do here is to focus the next item when cycling items with

D7766: make krunner accessible

mart added inline comments. INLINE COMMENTS > broulik wrote in ResultDelegate.qml:50 > So we end up with " , in category foo" if subtextLabel is empty? pretty much, i can make 2 different strings at all, the oddity if if it's a null string, i18n thinks it's a single patameter and complains

D7765: make krunner accessible

mart updated this revision to Diff 19424. mart added a comment. - run current result on enter REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7765?vs=19403=19424 BRANCH accessiblekrunner REVISION DETAIL https://phabricator.kde.org/D7765

Re: kwin_wayland and setWindowIcon()

>From a KDE side we can't use that as we don't have it. There is no icon name part of the specification in either of the shell protocols. The only relevant event is AppId. Qt could base the appId off the window icon but it wouldn't make any sense; (code for this and it's fallbacks if the

kwin_wayland and setWindowIcon()

Hi, kwin_wayland currently sets the application icon only if it can retrieve the .desktop filename of the application. Is there a reason why it doesn't use the icon passed to setWindowIcon() as fallback? This seems to work with weston, so I guess it should be possible with kwin as well?

D7774: [solid/fstab] Add support for x-gvfs style options in fstab

bruns added a dependency: D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7774 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns added a dependent revision: D7774: [solid/fstab] Add support for x-gvfs style options in fstab. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7773 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7774: [solid/fstab] Add support for x-gvfs style options in fstab

bruns created this revision. bruns added projects: Plasma, Frameworks. REVISION SUMMARY This fstab options allows an administrator to specify names and icons intended for the user, shown in a GUI For details, see https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt

D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns removed a dependency: D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7772 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns removed a dependent revision: D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7773 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns added a dependent revision: D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7773 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns added a dependency: D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7772 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns created this revision. bruns added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The fstab backend exposes server and sharename as product and vendor properties, but had the meaning backwards (the product is subordinate

D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns abandoned this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7772 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns created this revision. bruns added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The fstab backend exposes server and sharename as product and vendor properties, but had the meaning backwards (the product is

D7740: Move SceneOpenGL into a dedicated plugin

graesslin added a comment. In https://phabricator.kde.org/D7740#144854, @bshah wrote: > In https://phabricator.kde.org/D7740#144814, @graesslin wrote: > > > done: https://commits.kde.org/kwin/e0f7f58397a613a34312e93b53ade2c72ebc202b > > > Tested this branch, and seems to build

Re: [RFC] kscreen and touchscreen rotation

Am 2017-09-11 17:11, schrieb Sebastian Kügler: On Monday, September 11, 2017 4:49:58 PM CEST Martin Flöser wrote: So go for the simple way and change Wayland first. Do you think the architecture / API approach is sound? I think your API idea covers all cases. What might be important is to

D7766: make krunner accessible

broulik added inline comments. INLINE COMMENTS > ResultDelegate.qml:50 > +Accessible.name: displayLabel.text > +Accessible.description: i18n("%1, in category %2", > subtextLabel.text.length > 0 ? subtextLabel.text : " ", ListView.section) > property bool __pressed: false So we end

D7740: Move SceneOpenGL into a dedicated plugin

bshah added a comment. In https://phabricator.kde.org/D7740#144814, @graesslin wrote: > done: https://commits.kde.org/kwin/e0f7f58397a613a34312e93b53ade2c72ebc202b Tested this branch, and seems to build and work completely fine REPOSITORY R108 KWin REVISION DETAIL

D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data

subdiff added a dependent revision: D7769: [Task Manager] Use Grid for grouped and single tooltips. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7768 To: subdiff, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D7769: [Task Manager] Use Grid for grouped and single tooltips

subdiff added a dependency: D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7769 To: subdiff, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7770: [lookandfeel] Fix GLES incompatibilities in UserDelegate shader code

bruns created this revision. bruns added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 382668 The shader compilation currently fails on GLES with errors like: "0:6(2): error: No precision specified in this scope for type `vec4'"

D7769: [Task Manager] Use Grid for grouped and single tooltips

subdiff created this revision. subdiff added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This fixes the bug that the first tooltip shown after plasmashell launch is larger than needed. Also simplifies the code. BUG: 384600 REPOSITORY

D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data

subdiff edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7768 To: subdiff, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data

subdiff created this revision. subdiff added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Manually moving grouped tool tips together with single ones could mess up the mapping of their data. This patch makes sure that the correct information is

Re: [RFC] kscreen and touchscreen rotation

On Monday, September 11, 2017 4:49:58 PM CEST Martin Flöser wrote: > So go for the simple way and change Wayland first. Do you think the architecture / API approach is sound? -- sebas http://www.kde.org | http://vizZzion.org

Re: qqc2-desktop-style as framework

On Monday, 11 September 2017 16:18:40 CEST Jonathan Riddell wrote: > I've moved qqc2-desktop-style to frameworks from kde/workspace, please > move the translations to follow No translations to move. Ciao -- Luigi

Re: [RFC] kscreen and touchscreen rotation

Am 2017-09-11 12:56, schrieb David Edmundson: On Mon, Sep 11, 2017 at 11:58 AM, Sebastian Kügler wrote: Hi all, One of the things we talked about during Akademy was better support for convertible hardware. I've played around a bit with my Thinkpad X1 Yoga and screen rotation.

Re: [RFC] kscreen and touchscreen rotation

Am 2017-09-11 11:58, schrieb Sebastian Kügler: Hi all, One of the things we talked about during Akademy was better support for convertible hardware. I've played around a bit with my Thinkpad X1 Yoga and screen rotation. I can of course rotate the screen "manually" through XRandR (Wayland is

D7740: Move SceneOpenGL into a dedicated plugin

graesslin added a comment. In https://phabricator.kde.org/D7740#144574, @bshah wrote: > In https://phabricator.kde.org/D7740#144077, @graesslin wrote: > > > @bshah could you please try this patch on hwcomposer platform? I tried to get all required changes into it, but I currently

qqc2-desktop-style as framework

I've moved qqc2-desktop-style to frameworks from kde/workspace, please move the translations to follow Jonathan

D7765: make krunner accessible

mart updated this revision to Diff 19403. mart added a comment. - better navigation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7765?vs=19398=19403 BRANCH accessiblekrunner REVISION DETAIL https://phabricator.kde.org/D7765 AFFECTED FILES

D7766: make krunner accessible

mart updated this revision to Diff 19402. mart added a comment. - reset list position on focus loss REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7766?vs=19399=19402 BRANCH accessiblekrunner REVISION DETAIL https://phabricator.kde.org/D7766 AFFECTED

Re: [RFC] kscreen and touchscreen rotation

On Monday, September 11, 2017 12:56:09 PM CEST David Edmundson wrote: > On Mon, Sep 11, 2017 at 11:58 AM, Sebastian Kügler > wrote: > > Hi all, > > > > One of the things we talked about during Akademy was better support > > for convertible hardware. I've played around a bit with

D7766: make krunner accessible

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY this is the milou part: refine keyboard navigation and semantically mark the entries with the correct text to be read by orca TEST PLAN

Re: [RFC] kscreen and touchscreen rotation

On Mon, Sep 11, 2017 at 11:58 AM, Sebastian Kügler wrote: > Hi all, > > One of the things we talked about during Akademy was better support for > convertible hardware. I've played around a bit with my Thinkpad X1 Yoga > and screen rotation. I can of course rotate the screen

D7765: make krunner accessible

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY enable actual keyboard navigation, as the previous completely manual keyboard navigation in krunner completely broke the screen reader

Minutes Monday Plasma Hangout

Most of the team is in Randa probably high (physically, but also on swiss chocolate). Let's forgive them. ;) Cheers! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Meeting 11 Sept 2017 jensreut: Yeah I am doing visuals for PM so that we can actually reproduce our designs in imagery

[RFC] kscreen and touchscreen rotation

Hi all, One of the things we talked about during Akademy was better support for convertible hardware. I've played around a bit with my Thinkpad X1 Yoga and screen rotation. I can of course rotate the screen "manually" through XRandR (Wayland is another story on that altogether), but that will

D6591: XdgV6 - Kwin side

mart updated this revision to Diff 19394. mart added a comment. Restricted Application edited projects, added Plasma; removed KWin. - Redo popup grab handling - don't ping a window before killing setActive works also for wl_shell - move Ping Reason in own class REPOSITORY R108 KWin