This revision was automatically updated to reflect the committed changes.
Closed by commit R108:e6ca32131733: Drop ENABLE_TRANSIENCY_CHECK related code
as it doesn't compile (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7958?vs=19838&id=
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:9ce651fc309d: Drop unused functions from utils (authored
by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7956?vs=19837&id=19847
REVISION DETAIL
https:
graesslin added a comment.
I really would like to see this go in now into master! But we need to have at
least a few unit tests. If that's too difficult I can write them, but I would
prefer if one of you extends it. It's really not difficult in this case as we
just need to add the basics to
graesslin added a comment.
ping
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7856
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed,
hardening, jensreuterberg, abetts, sebas, apol, mart
graesslin added a comment.
ping
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7853
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed,
hardening, jensreuterberg, abetts, sebas, apol, mart
graesslin added a comment.
ping
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7846
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed,
hardening, jensreuterberg, abetts, sebas, apol, mart
graesslin added a comment.
ping
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7808
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed,
hardening, jensreuterberg, abetts, sebas, apol, mart
https://bugs.kde.org/show_bug.cgi?id=384999
--- Comment #14 from Hugo Pereira Da Costa ---
So like in phab, I disagree with changing the default.
I think this dolphin case is quite a corner case, that should not justify that
_all_ dock panels get a frame around them
(in most cases you only have
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
I don't really see how this needs review. :)
REPOSITORY
R108 KWin
BRANCH
drop-enable-transiency-check
REVISION DETAIL
https://phabricator.kde.org/D7958
To: graesslin, #kwin, #plasma, ap
ngraham added a comment.
As a 24 year Mac refugee, I agree with you that Finder's Tags implementation
is excellent, and I think we should copy it. But the macOS Finder approach
(everything scrollable in the same sidebar) is what was rejected in
https://phabricator.kde.org/D7700. But getting
markg added a comment.
Watch this: https://www.youtube.com/watch?v=T0Jj4lUm_p8
Apple really has done a marvelous job in making tags useful!
Anyhow, we can learn a couple things from there implementation of the sidebar.
1. It doesn't scroll "per panel", it scrolls for the whole sideb
ngraham added a comment.
As I am pointing out, without frames the splitter is invisible, which is a
clear usability issue. It also presents an aesthetic issue since when content
on either side of the splitter is cut off, it looks like a visual glitch:
F3923285: Cut off for no clear reaso
markg added a comment.
-1 for the current version as well.
We've had those frames before. The benefit of locking docks is no frame (for
me that is the benefit).
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D7957
To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, e
ngraham edited the summary of this revision.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D7957
To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck,
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
ab
ngraham edited the test plan for this revision.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D7957
To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck,
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
https://bugs.kde.org/show_bug.cgi?id=384999
Nate Graham changed:
What|Removed |Added
Summary|Default setting of no |Default setting of no
|borders
ngraham updated this revision to Diff 19839.
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7957?vs=19836&id=19839
REVISION DETAIL
https://phabricator.kde.org/D7957
AFFECTED FILES
kstyle/breeze.kcfg
To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisa
ngraham retitled this revision from "Turn on frames around dock widgets and
side panels by default" to "Turn on frames around dock widgets by default".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://p
ngraham added a comment.
I can remove the side panel change from this patch so we can focus on the
usability issues resulting from having Dock frames disabled.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D7957
To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvi
broulik added a comment.
-1 on the side panel frame
This was explicitly done to remove the amount of frames you have. I went
through great lengths to achieve an identical look in Plasma applet config
dialogs...
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D7957
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
The code ifdefed by ENABLE_TRANSIENCY_CHECK does no longer compile and
has not compiled since t
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
utils-drop-dead-functions
REVISION DETAIL
https://phabricator.kde.org/D7956
To: graesslin, #kwin, #plasma, broulik
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, al
https://bugs.kde.org/show_bug.cgi?id=384999
Hugo Pereira Da Costa changed:
What|Removed |Added
CC||hugo.pereira.da.costa@gmail
https://bugs.kde.org/show_bug.cgi?id=384999
Nate Graham changed:
What|Removed |Added
Status|UNCONFIRMED |CONFIRMED
Ever confirmed|0
ngraham created this revision.
ngraham added reviewers: Breeze, VDG.
ngraham added a project: Breeze.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
BUG: 384999
Draw borders around dock widgets and side panels by def
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Not used anywhere in KWin -> can go.
TEST PLAN
Still compiles
REPOSITORY
R108 KWin
BRANCH
https://bugs.kde.org/show_bug.cgi?id=384999
Nate Graham changed:
What|Removed |Added
Summary|QDockWidget's resize handle |Default setting of no
|is invis
https://bugs.kde.org/show_bug.cgi?id=384999
--- Comment #10 from Nate Graham ---
Created attachment 107979
--> https://bugs.kde.org/attachment.cgi?id=107979&action=edit
After: side panel with aesthetically pleasing border in System Settings
--
You are receiving this mail because:
You are the
https://bugs.kde.org/show_bug.cgi?id=384999
--- Comment #9 from Nate Graham ---
Created attachment 107978
--> https://bugs.kde.org/attachment.cgi?id=107978&action=edit
Before: side panel with no border in System Settings
--
You are receiving this mail because:
You are the assignee for the bug
https://bugs.kde.org/show_bug.cgi?id=384999
--- Comment #8 from Nate Graham ---
Created attachment 107977
--> https://bugs.kde.org/attachment.cgi?id=107977&action=edit
After: side panel with aesthetically pleasing border in Dolphin settings window
--
You are receiving this mail because:
You a
https://bugs.kde.org/show_bug.cgi?id=384999
--- Comment #7 from Nate Graham ---
Created attachment 107976
--> https://bugs.kde.org/attachment.cgi?id=107976&action=edit
Before: side panel with no border in Dolphin settings window
Side panels have the same issue, although it's more aesthetic tha
https://bugs.kde.org/show_bug.cgi?id=384999
Nate Graham changed:
What|Removed |Added
Attachment #107971|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=384999
--- Comment #5 from Nate Graham ---
Created attachment 107974
--> https://bugs.kde.org/attachment.cgi?id=107974&action=edit
Before: Two panels are open, each one has cut-off content, and there is no
visible separator
...And that's a user-configurable
graesslin added a dependency: D7846: [tabbox] Drop the passing to Effects in
X11 Filter.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7955
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed,
hardening, jensreuterber
graesslin added a dependent revision: D7955: Move X11-only specific part of
EffectsHandlerImpl to x11 platform plugin.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7846
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-moha
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
The Platform API is extended by a call to create the EffectsHandler. In
X11 standalone Platform
https://bugs.kde.org/show_bug.cgi?id=384999
Nate Graham changed:
What|Removed |Added
Flags||Usability+
--
You are receiving this mail becaus
https://bugs.kde.org/show_bug.cgi?id=384999
Nate Graham changed:
What|Removed |Added
Assignee|dolphin-bugs-n...@kde.org |plasma-devel@kde.org
Summary|When lock
arojas edited the test plan for this revision.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D7953
To: arojas, davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol,
arojas added a comment.
Opened https://phabricator.kde.org/D7953 for the QQuickStyle approach.
Keeping this open in case the new dependency is not acceptable for 5.11 at this
stage.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D79
arojas created this revision.
arojas added reviewers: davidedmundson, Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Use QQuickStyle::setStyle instead of an environment variable to set the QQC2
desktop style. Thi
This revision was automatically updated to reflect the committed changes.
Closed by commit R98:f0ac1407a95c: Don't show scrollbar steppers (authored
by elvisangelaccio).
REPOSITORY
R98 Breeze for Gtk
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7835?vs=19555&id=19823
REVISION DETA
This revision was automatically updated to reflect the committed changes.
Closed by commit R98:0ef85af524bb: Fix background-image warning (authored by
elvisangelaccio).
REPOSITORY
R98 Breeze for Gtk
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7836?vs=19556&id=19824
REVISION DETAI
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R98 Breeze for Gtk
BRANCH
Plasma/5.11
REVISION DETAIL
https://phabricator.kde.org/D7835
To: elvisangelaccio, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moh
elvisangelaccio added a comment.
Ping?
REPOSITORY
R98 Breeze for Gtk
REVISION DETAIL
https://phabricator.kde.org/D7835
To: elvisangelaccio, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:537b36d1cb48: Only try creating X11 shadow if we have an
X11 connection (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7894?vs=19704&id=19822
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:ab7b6757bf32: Properly update the visible (icon) name
when the caption changes (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7871?vs=19646&id
arojas added a comment.
Indeed, replacing the qputenv line with
QQuickStyle::setStyle(QLatin1String("org.kde.desktop")) fixes the inheritance
problem: minuet doesn't crash anymore and systemsettings is correctly themed.
Unfortunately QQC1 (such as kalgebramobile) still crash, is there someth
davidedmundson added a comment.
Edit: given were doing this in c++in process, maybe can we just call
https://doc.qt.io/qt-5/qquickstyle.html#setStyle
Instead of messing about with environment variables?
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https
davidedmundson added a comment.
We shouldn't. It doesn't gain us anything.
More importantly, the one thing this patch doesn't cover is apps that don't
have desktopSettingsAware set as they'll never load the qpt.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
50 matches
Mail list logo
