[Breeze] [Bug 384999] Default setting of no borders drawn around dock widgets causes usability issues with multiple adjacent dock widgets

[Hugo Pereira Da Costa]

https://bugs.kde.org/show_bug.cgi?id=384999

--- Comment #14 from Hugo Pereira Da Costa  ---
So like in phab, I disagree with changing the default. 
I think this dolphin case is quite a corner case, that should not justify that
_all_ dock panels get a frame around them
(in most cases you only have one dock panel per side, and so there is no issue)

For the sidebar pannel, that is completely unrelated

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7958: Drop ENABLE_TRANSIENCY_CHECK related code as it doesn't compile

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  I don't really see how this needs review. :)

REPOSITORY
  R108 KWin

BRANCH
  drop-enable-transiency-check

REVISION DETAIL
  https://phabricator.kde.org/D7958

To: graesslin, #kwin, #plasma, apol
Cc: apol, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, mart

D7957: Turn on frames around dock widgets by default

[Nathaniel Graham]

ngraham added a comment.


  As a 24 year Mac refugee, I agree with you that Finder's Tags implementation 
is excellent, and I think we should copy it. But the macOS Finder approach 
(everything scrollable in the same sidebar) is what was rejected in 
https://phabricator.kde.org/D7700. But getting there by putting all the Panels 
inside a scrollview with titles always visible is an idea I would fully support.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7957: Turn on frames around dock widgets by default

[Mark Gaiser]

markg added a comment.


  Watch this: https://www.youtube.com/watch?v=T0Jj4lUm_p8
  Apple really has done a marvelous job in making tags useful!
  
  Anyhow, we can learn a couple things from there implementation of the sidebar.
  
  1. It doesn't scroll "per panel", it scrolls for the whole sidebar! I'd 
suggest implementing that for Dolphin as well.
  2. Because of point 1, there is no need to display a separator because, well, 
everything is visible.
  3. Every "panel" has a visible title (like places has now).
  
  To elaborate some more on point 1. Yes, that will pose an issue with people 
adding in a folder tree and opening a folder with a _lot_ of sub folders. That 
means a lot of scrolling in the panel.
  I don't think that is really much of an issue.. But even if it is, a panel 
can still choose to have a max height and show a scrollbar if it exceeds it's 
limits.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7957: Turn on frames around dock widgets by default

[Nathaniel Graham]

ngraham added a comment.


  As I am pointing out, without frames the splitter is invisible, which is a 
clear usability issue. It also presents an aesthetic issue since when content 
on either side of the splitter is cut off, it looks like a visual glitch:
  
  F3923285: Cut off for no clear reason.png 

  
  I can't support a change to Dolphin's default layout that has two adjacent 
panels without sorting out the invisible separator issue. If this isn't the 
right way to do it, then so be it, but we will need to resolve it.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7957: Turn on frames around dock widgets by default

[Mark Gaiser]

markg added a comment.


  -1 for the current version as well.
  We've had those frames before. The benefit of locking docks is no frame (for 
me that is the benefit).

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7957: Turn on frames around dock widgets by default

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7957: Turn on frames around dock widgets by default

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

[Breeze] [Bug 384999] Default setting of no borders drawn around dock widgets causes usability issues with multiple adjacent dock widgets

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=384999

Nate Graham  changed:

   What|Removed |Added

Summary|Default setting of no   |Default setting of no
   |borders drawn around side   |borders drawn around dock
   |panels and dock widgets |widgets causes usability
   |causes usability and|issues with multiple
   |aesthetic issues|adjacent dock widgets

--- Comment #13 from Nate Graham  ---
Yep! And I'm advocating making that the default setting, for the reasons I
stated in the Description (I'm dropping Side Panels from this discussion to
focus on the usability issues arising from omitting frames from Dock widgets by
default).

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7957: Turn on frames around dock widgets by default

[Nathaniel Graham]

ngraham updated this revision to Diff 19839.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7957?vs=19836=19839

REVISION DETAIL
  https://phabricator.kde.org/D7957

AFFECTED FILES
  kstyle/breeze.kcfg

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7957: Turn on frames around dock widgets by default

[Nathaniel Graham]

ngraham retitled this revision from "Turn on frames around dock widgets and 
side panels by default" to "Turn on frames around dock widgets by default".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7957: Turn on frames around dock widgets and side panels by default

[Nathaniel Graham]

ngraham added a comment.


  I can remove the side panel change from this patch so we can focus on the 
usability issues resulting from having Dock frames disabled.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7957: Turn on frames around dock widgets and side panels by default

[Kai Uwe Broulik]

broulik added a comment.


  -1 on the side panel frame
  
  This was explicitly done to remove the amount of frames you have. I went 
through great lengths to achieve an identical look in Plasma applet config 
dialogs...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7958: Drop ENABLE_TRANSIENCY_CHECK related code as it doesn't compile

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  The code ifdefed by ENABLE_TRANSIENCY_CHECK does no longer compile and
  has not compiled since the switch to Qt 5 and KF5 as it still uses
  kDebug and (worse) kDBacktrace. There are several other changes which
  broke the code and I failed trying to get it to compile again. It's a
  classic example of bitrot happening to code which is never getting
  compiled.
  
  As this has not been in a state which could compile for at least several
  years, I think it's best to completely remove it.

REPOSITORY
  R108 KWin

BRANCH
  drop-enable-transiency-check

REVISION DETAIL
  https://phabricator.kde.org/D7958

AFFECTED FILES
  client.cpp
  group.cpp
  utils.h
  workspace.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D7956: Drop unused functions from utils

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  utils-drop-dead-functions

REVISION DETAIL
  https://phabricator.kde.org/D7956

To: graesslin, #kwin, #plasma, broulik
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

[Breeze] [Bug 384999] Default setting of no borders drawn around side panels and dock widgets causes usability and aesthetic issues

[Hugo Pereira Da Costa]

https://bugs.kde.org/show_bug.cgi?id=384999

Hugo Pereira Da Costa  changed:

   What|Removed |Added

 CC||hugo.pereira.da.costa@gmail
   ||.com

--- Comment #12 from Hugo Pereira Da Costa  ---
There are two options in breeze configuration that are named 
"draw frame around dockable panels" and
"draw frame around side panels"
that do exactly what you want.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 384999] Default setting of no borders drawn around side panels and dock widgets causes usability and aesthetic issues

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=384999

Nate Graham  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #11 from Nate Graham  ---
Submitted a patch: https://phabricator.kde.org/D7957

Most of the attachments on the bug report depict older versions, FWIW. Newer
pictures using git master are available at the Phabricator patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7957: Turn on frames around dock widgets and side panels by default

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Breeze, VDG.
ngraham added a project: Breeze.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  BUG: 384999
  
  Draw borders around dock widgets and side panels by default, which resolves 
some usability and aesthetic issues, and supports the addition of additional 
default-visible dock panels in the future, e.g. 
https://phabricator.kde.org/D7700 -- when the future Tags panel is added and 
made visible by default, the aesthetic and usability issues from having no 
frames will become much more obvious and user-facing. This fixes that.

TEST PLAN
  Tested in KDE Neon.
  
  Dolphin Settings window before:
  F3922993: Side panel borders off - Dolphin settings window.png 

  
  Dolphin Settings window after:
  F3922994: Side panel borders on - Dolphin settings window.png 

  
  Dolphin main window with multiple vertical panels before:
  F3922996: DockWidget borders off - Dolphin main window.png 

  
  Dolphin main window with multiple vertical panels after:
  F3922997: DockWidget borders on - Dolphin main window.png 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

AFFECTED FILES
  kstyle/breeze.kcfg

To: ngraham, #breeze, #vdg
Cc: emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D7956: Drop unused functions from utils

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Not used anywhere in KWin -> can go.

TEST PLAN
  Still compiles

REPOSITORY
  R108 KWin

BRANCH
  utils-drop-dead-functions

REVISION DETAIL
  https://phabricator.kde.org/D7956

AFFECTED FILES
  utils.cpp
  utils.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

[Breeze] [Bug 384999] Default setting of no borders drawn around side panels and dock widgets causes usability and aesthetic issues

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=384999

Nate Graham  changed:

   What|Removed |Added

Summary|QDockWidget's resize handle |Default setting of no
   |is invisible when locked|borders drawn around side
   ||panels and dock widgets
   ||causes usability and
   ||aesthetic issues

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 384999] QDockWidget's resize handle is invisible when locked

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=384999

--- Comment #10 from Nate Graham  ---
Created attachment 107979
  --> https://bugs.kde.org/attachment.cgi?id=107979=edit
After: side panel with aesthetically pleasing border in System Settings

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 384999] QDockWidget's resize handle is invisible when locked

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=384999

--- Comment #9 from Nate Graham  ---
Created attachment 107978
  --> https://bugs.kde.org/attachment.cgi?id=107978=edit
Before: side panel with no border in System Settings

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 384999] QDockWidget's resize handle is invisible when locked

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=384999

--- Comment #8 from Nate Graham  ---
Created attachment 107977
  --> https://bugs.kde.org/attachment.cgi?id=107977=edit
After: side panel with aesthetically pleasing border in Dolphin settings window

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 384999] QDockWidget's resize handle is invisible when locked

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=384999

--- Comment #7 from Nate Graham  ---
Created attachment 107976
  --> https://bugs.kde.org/attachment.cgi?id=107976=edit
Before: side panel with no border in Dolphin settings window

Side panels have the same issue, although it's more aesthetic than
usability-related.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 384999] QDockWidget's resize handle is invisible when locked

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=384999

Nate Graham  changed:

   What|Removed |Added

 Attachment #107971|0   |1
is obsolete||

--- Comment #6 from Nate Graham  ---
Created attachment 107975
  --> https://bugs.kde.org/attachment.cgi?id=107975=edit
After: each panel is clearly its own separate entity, and cut-off content is
clearly inside a scrollable view

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 384999] QDockWidget's resize handle is invisible when locked

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=384999

--- Comment #5 from Nate Graham  ---
Created attachment 107974
  --> https://bugs.kde.org/attachment.cgi?id=107974=edit
Before: Two panels are open, each one has cut-off content, and there is no
visible separator

...And that's a user-configurable setting: System Settings > Application Style
> Widget style > Breeze > Configure > Frames > Draw frame around [stuff]

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7955: Move X11-only specific part of EffectsHandlerImpl to x11 platform plugin

[Martin Flöser]

graesslin added a dependency: D7846: [tabbox] Drop the passing to Effects in 
X11 Filter.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7955

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D7846: [tabbox] Drop the passing to Effects in X11 Filter

[Martin Flöser]

graesslin added a dependent revision: D7955: Move X11-only specific part of 
EffectsHandlerImpl to x11 platform plugin.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7846

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D7955: Move X11-only specific part of EffectsHandlerImpl to x11 platform plugin

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  The Platform API is extended by a call to create the EffectsHandler. In
  X11 standalone Platform a new EffectsHandlerImplX11 is added which
  contains the X11 only parts of the EffectsHandler, such as grabbing the
  X keyboard and the X11 mouse interception window.
  
  The EffectsHandlerImpl gains some virtual methods for the parts which
  are now done in the X11 specific implementation. In return we get rid of
  lots of if-else structures checking for the operation mode.

TEST PLAN
  Only compile tested.

REPOSITORY
  R108 KWin

BRANCH
  x11-effects-handler

REVISION DETAIL
  https://phabricator.kde.org/D7955

AFFECTED FILES
  CMakeLists.txt
  composite.cpp
  effects.cpp
  effects.h
  effects_mouse_interception_x11_filter.cpp
  effects_mouse_interception_x11_filter.h
  platform.cpp
  platform.h
  plugins/platforms/wayland/wayland_backend.cpp
  plugins/platforms/x11/standalone/CMakeLists.txt
  plugins/platforms/x11/standalone/effects_mouse_interception_x11_filter.cpp
  plugins/platforms/x11/standalone/effects_mouse_interception_x11_filter.h
  plugins/platforms/x11/standalone/effects_x11.cpp
  plugins/platforms/x11/standalone/effects_x11.h
  plugins/platforms/x11/standalone/x11_platform.cpp
  plugins/platforms/x11/standalone/x11_platform.h
  utils.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

[Breeze] [Bug 384999] QDockWidget's resize handle is invisible when locked

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=384999

Nate Graham  changed:

   What|Removed |Added

  Flags||Usability+

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 384999] QDockWidget's resize handle is invisible when locked

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=384999

Nate Graham  changed:

   What|Removed |Added

   Assignee|dolphin-bugs-n...@kde.org   |plasma-devel@kde.org
Summary|When locked panels and  |QDockWidget's resize handle
   |Places and Folder Panels|is invisible when locked
   |both visible, the resizable |
   |separator between them is   |
   |invisible   |
  Component|general |general
Product|dolphin |Breeze

--- Comment #4 from Nate Graham  ---
I see now. The appearance is done in QStyle, which comes from Breeze. With the
Oxygen theme, there is a visible resize handle there when the panels are
locked.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7953: Use QQuickStyle to set the QQC2 style

[Antonio Rojas]

arojas edited the test plan for this revision.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7953

To: arojas, davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7943: Explicitely unset QtQuickControls desktop style for non-QApplications

[Antonio Rojas]

arojas added a comment.


  Opened https://phabricator.kde.org/D7953 for the QQuickStyle approach. 
Keeping this open in case the new dependency is not acceptable for 5.11 at this 
stage.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7943

To: arojas, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7953: Use QQuickStyle to set the QQC2 style

[Antonio Rojas]

arojas created this revision.
arojas added reviewers: davidedmundson, Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Use QQuickStyle::setStyle instead of an environment variable to set the QQC2 
desktop style. This prevent the style from being inherited by plasmashell (or 
krunner) child processes, which makes QGuiApplications crash. The QQC1 style 
still needs to be set via an environment variable, so we explicitely unset it 
for non-QApplications to prevent them from crashing.
  
  This adds a new QtQuickControls dependency, I hope it's OK at this stage (as 
it's already a dependency of other Plasma repos)

TEST PLAN
  Run systemsettings5 -> it is correctly themed
  Run minuet (pure QQC2) -> it doesn't crash
  Run kalgebra-mobile (QQC1 + QQC2) -> it doesn't crash.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7953

AFFECTED FILES
  CMakeLists.txt
  src/platformtheme/CMakeLists.txt
  src/platformtheme/kdeplatformtheme.cpp

To: arojas, davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7835: Don't show scrollbar steppers

[Elvis Angelaccio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R98:f0ac1407a95c: Dont show scrollbar steppers (authored 
by elvisangelaccio).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7835?vs=19555=19823

REVISION DETAIL
  https://phabricator.kde.org/D7835

AFFECTED FILES
  Breeze-gtk/gtk-3.20/gtk.css

To: elvisangelaccio, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7836: Fix background-image warning

[Elvis Angelaccio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R98:0ef85af524bb: Fix background-image warning (authored by 
elvisangelaccio).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7836?vs=19556=19824

REVISION DETAIL
  https://phabricator.kde.org/D7836

AFFECTED FILES
  Breeze-gtk/gtk-3.20/gtk.css

To: elvisangelaccio, davidedmundson, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7835: Don't show scrollbar steppers

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  Plasma/5.11

REVISION DETAIL
  https://phabricator.kde.org/D7835

To: elvisangelaccio, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7835: Don't show scrollbar steppers

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Ping?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D7835

To: elvisangelaccio, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7894: Only try creating X11 shadow if we have an X11 connection

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:537b36d1cb48: Only try creating X11 shadow if we have an 
X11 connection (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7894?vs=19704=19822

REVISION DETAIL
  https://phabricator.kde.org/D7894

AFFECTED FILES
  shadow.cpp

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D7871: Properly update the visible (icon) name when the caption changes

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:ab7b6757bf32: Properly update the visible (icon) name 
when the caption changes (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7871?vs=19646=19821

REVISION DETAIL
  https://phabricator.kde.org/D7871

AFFECTED FILES
  autotests/integration/x11_client_test.cpp
  client.cpp

To: graesslin, #kwin, #plasma, hein, davidedmundson
Cc: grahamperrin, broulik, plasma-devel, kwin, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D7943: Explicitely unset QtQuickControls desktop style for non-QApplications

[Antonio Rojas]

arojas added a comment.


  Indeed, replacing the qputenv line with 
QQuickStyle::setStyle(QLatin1String("org.kde.desktop")) fixes the inheritance 
problem: minuet doesn't crash anymore and systemsettings is correctly themed. 
Unfortunately QQC1 (such as kalgebramobile) still crash, is there something 
equivalent for QQC1?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7943

To: arojas, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7943: Explicitely unset QtQuickControls desktop style for non-QApplications

[David Edmundson]

davidedmundson added a comment.


  Edit: given were doing this in c++in process, maybe can we just call
  https://doc.qt.io/qt-5/qquickstyle.html#setStyle
  
  Instead of messing about with environment variables?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7943

To: arojas, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7943: Explicitely unset QtQuickControls desktop style for non-QApplications

[David Edmundson]

davidedmundson added a comment.


  We shouldn't. It doesn't gain us anything.
  
  More importantly, the one thing this patch doesn't cover is apps that don't 
have desktopSettingsAware set as they'll never load the qpt.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7943

To: arojas, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart