D8077: Fix org.kde.plasma.calendar with Qt 5.10
fvogt added a comment. In https://phabricator.kde.org/D8077#151362, @broulik wrote: > Meh. > > I suspect there are other modules affected as well? I'm not sure, I didn't test anything beyond the default plasma configuration. A quick scan with a script showed mostly false positives, but also > ./qml/org/kde/plasma/components.3/CheckIndicator.qml > ./qml/org/kde/plasma/components.3/RadioIndicator.qml So it probably needs to be fixed for those as well. I'm not sure where those are actually used. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8077 To: fvogt, #plasma, broulik Cc: broulik, #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8077: Fix org.kde.plasma.calendar with Qt 5.10
This revision was automatically updated to reflect the committed changes. Closed by commit R242:4f43c236e34e: Fix org.kde.plasma.calendar with Qt 5.10 (authored by fvogt). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8077?vs=20165=20213 REVISION DETAIL https://phabricator.kde.org/D8077 AFFECTED FILES src/declarativeimports/calendar/qml/qmldir To: fvogt, #plasma, broulik Cc: broulik, #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8077: Fix org.kde.plasma.calendar with Qt 5.10
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Meh. I suspect there are other modules affected as well? REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D8077 To: fvogt, #plasma, broulik Cc: broulik, #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8086: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager
This revision was automatically updated to reflect the committed changes. Closed by commit R108:f988a5f6547b: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8086?vs=20199=20207 REVISION DETAIL https://phabricator.kde.org/D8086 AFFECTED FILES virtualdesktops.h workspace.cpp To: graesslin, #kwin, #plasma, fvogt Cc: fvogt, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8095: Support updating deco for changes of borderless maximize windows config
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far only updated the Clients, now also ShellClient. REPOSITORY R108 KWin BRANCH borderless-maximize-reconfigure REVISION DETAIL https://phabricator.kde.org/D8095 AFFECTED FILES abstract_client.cpp abstract_client.h client.h workspace.cpp To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8086: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager
fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Tested, works! REPOSITORY R108 KWin BRANCH reload-vds-on-x11 REVISION DETAIL https://phabricator.kde.org/D8086 To: graesslin, #kwin, #plasma, fvogt Cc: fvogt, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8094: Port RuleBook::discardUsed from Client to AbstractClient
graesslin added a dependency: D8090: Move WindowRules from Client to AbstractClient. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8094 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8090: Move WindowRules from Client to AbstractClient
graesslin added a dependent revision: D8094: Port RuleBook::discardUsed from Client to AbstractClient. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8090 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8094: Port RuleBook::discardUsed from Client to AbstractClient
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Prepares the Rules update on reconfigure for Wayland windows. REPOSITORY R108 KWin BRANCH rulebook-discardused-abstractclient REVISION DETAIL https://phabricator.kde.org/D8094 AFFECTED FILES rules.cpp rules.h workspace.cpp To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8090: Move WindowRules from Client to AbstractClient
graesslin updated this revision to Diff 20204. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. I noticed I hadn't removed the variable from Client... That turned into another round of refactoring and moving things from Client to AbstractClient. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8090?vs=20188=20204 BRANCH windowrules-to-abstractclient REVISION DETAIL https://phabricator.kde.org/D8090 AFFECTED FILES abstract_client.cpp abstract_client.h client.cpp client.h manage.cpp rules.cpp rules.h shell_client.cpp shell_client.h To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8086: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager
fvogt added a comment. In https://phabricator.kde.org/D8086#151291, @graesslin wrote: > In https://phabricator.kde.org/D8086#151206, @fvogt wrote: > > > I gave it a try, it's slightly better but not enough: The virtual desktop pager is not visible by default as there's only a single virtual desktop now instead of two by default. > > > How does openSUSE set two virtual desktops by default? KWin's default is 1, so this might be completely unrelated... Interesting, I didn't even know that the default deviates here. Indeed, the default specified in /etc/xdg/kwinrc is > [Desktops] > Number=2 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8086 To: graesslin, #kwin, #plasma Cc: fvogt, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8086: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager
graesslin updated this revision to Diff 20199. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. New try: found some more code which syncs the rootinfo. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8086?vs=20184=20199 BRANCH reload-vds-on-x11 REVISION DETAIL https://phabricator.kde.org/D8086 AFFECTED FILES virtualdesktops.h workspace.cpp To: graesslin, #kwin, #plasma Cc: fvogt, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8086: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager
graesslin added a comment. In https://phabricator.kde.org/D8086#151206, @fvogt wrote: > I gave it a try, it's slightly better but not enough: The virtual desktop pager is not visible by default as there's only a single virtual desktop now instead of two by default. How does openSUSE set two virtual desktops by default? KWin's default is 1, so this might be completely unrelated... REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8086 To: graesslin, #kwin, #plasma Cc: fvogt, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8090: Move WindowRules from Client to AbstractClient
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far window rule specific functionality was only implemented in Client and in ShellClient there was only a dummy implementation. This change moves the client_rules member variable from Client to AbstractClient. Areas which would not compile anymore are adjusted. This is a first step to get window rule support for Wayland windows. REPOSITORY R108 KWin BRANCH windowrules-to-abstractclient REVISION DETAIL https://phabricator.kde.org/D8090 AFFECTED FILES abstract_client.cpp abstract_client.h client.cpp client.h manage.cpp rules.cpp rules.h shell_client.cpp shell_client.h To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8086: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager
fvogt added a comment. I gave it a try, it's slightly better but not enough: The virtual desktop pager is not visible by default as there's only a single virtual desktop now instead of two by default. The single virtual desktop had a name now though and it was possible to edit the count of desktops, but only after the second try for some reason. So something is still missing. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8086 To: graesslin, #kwin, #plasma Cc: fvogt, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND
asturmlechner closed this revision. REPOSITORY R572 releaseme REVISION DETAIL https://phabricator.kde.org/D7981 To: asturmlechner, #plasma, sitter, O2 releaseme Cc: palimaka, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND
asturmlechner added a comment. In https://phabricator.kde.org/D7981#149086, @sitter wrote: > Note that ki18n is also currently marked REQUIRED though. thanks, I'm not concerned about ki18n as I have not seen it being optional anywhere. REPOSITORY R572 releaseme BRANCH master REVISION DETAIL https://phabricator.kde.org/D7981 To: asturmlechner, #plasma, sitter, O2 releaseme Cc: palimaka, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8086: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager
fvogt added a comment.
I'll give it a try, currently building. For some reason it fails building for
Leap 42.3 though, with undefined references such as:
>
/home/abuild/rpmbuild/BUILD/kwin-5.10.90git~20171001T152640~https://phabricator.kde.org/R108:252980390d1091ea57e430836708cb766f79aa68/plugins/platforms/virtual/egl_gbm_backend.cpp:174:
undefined reference to `KWin::AbstractEglBackend::createContext()'
> [ 251s] CMakeFiles/KWinWaylandVirtualBackend.dir/egl_gbm_backend.cpp.o:
In function `KWin::EglGbmBackend::init()':
Very likely not related to this diff, probably caused by 42.3 not enabling
wayland ("Could NOT find Wayland_Egl").
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8086
To: graesslin, #kwin, #plasma
Cc: fvogt, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8086: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The load method and updateLayout ensure the virtual desktop information is synced to RootInfo and thus to other X11 applications. Thus we need to call it again when initing X11. BUG: 385260 TEST PLAN Not tested as I'm on Wayland, but given the changes it's obvious. REPOSITORY R108 KWin BRANCH reload-vds-on-x11 REVISION DETAIL https://phabricator.kde.org/D8086 AFFECTED FILES workspace.cpp To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8082: Also send Wayland clients to a new desktop if their desktop was removed
This revision was automatically updated to reflect the committed changes. Closed by commit R108:0d96e60b79a7: Also send Wayland clients to a new desktop if their desktop was removed (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8082?vs=20178=20183 REVISION DETAIL https://phabricator.kde.org/D8082 AFFECTED FILES autotests/integration/CMakeLists.txt autotests/integration/virtual_desktop_test.cpp workspace.cpp To: graesslin, #kwin, #plasma, broulik Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8082: Also send Wayland clients to a new desktop if their desktop was removed
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH virtual-desktop-remove-send-client-5.11 REVISION DETAIL https://phabricator.kde.org/D8082 To: graesslin, #kwin, #plasma, broulik Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8082: Also send Wayland clients to a new desktop if their desktop was removed
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far the method only operated on X11 clients. So when the last desktop got removed Wayland clients were still on it. As the auto test showed: this results in a crash. Credits go to code coverage as it showed that area as red, which made me look on it and realize this must be broken. TEST PLAN New test case added REPOSITORY R108 KWin BRANCH virtual-desktop-remove-send-client-5.11 REVISION DETAIL https://phabricator.kde.org/D8082 AFFECTED FILES autotests/integration/CMakeLists.txt autotests/integration/virtual_desktop_test.cpp workspace.cpp To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
