D8090: Move WindowRules from Client to AbstractClient

2017-10-05 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH windowrules-to-abstractclient REVISION DETAIL https://phabricator.kde.org/D8090 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, ZrenBot, progwolff,

D8145: Update pointer position whenever a window gets (un)minimized

2017-10-05 Thread Thomas Lübking
luebking added a comment. Why should it? The stack remains the same, just one window changes its visibility. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8145 To: graesslin, #kwin, #plasma Cc: luebking, davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff,

D8145: Update pointer position whenever a window gets (un)minimized

2017-10-05 Thread David Edmundson
davidedmundson added a comment. Why isn't the stacking order changing when you minimise the first? Shouldn't it? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8145 To: graesslin, #kwin, #plasma Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff,

D8152: [platforms/drm] Use a shared pointer for gbm_surface

2017-10-05 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D8152#152540, @davidedmundson wrote: > > FIXED-IN: 5.11.0 > > I'm afraid it won't be. Tag was today. Yeah, I already noticed. Basically I arc diffed, opened up my mails and saw that it was tagged. REPOSITORY R108

D8152: [platforms/drm] Use a shared pointer for gbm_surface

2017-10-05 Thread Martin Flöser
graesslin updated this revision to Diff 20375. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Added test case for new class REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8152?vs=20373=20375 BRANCH

D8152: [platforms/drm] Use a shared pointer for gbm_surface

2017-10-05 Thread David Edmundson
davidedmundson added a comment. > FIXED-IN: 5.11.0 I'm afraid it won't be. Tag was today. - Patch makes, sense potentially makes that GBM sharing patch cleaner too.. REPOSITORY R108 KWin BRANCH shared-gbm-surface-5.11 REVISION DETAIL

D8152: [platforms/drm] Use a shared pointer for gbm_surface

2017-10-05 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH shared-gbm-surface-5.11 REVISION DETAIL https://phabricator.kde.org/D8152 To: graesslin, #kwin, #plasma, subdiff, davidedmundson Cc: davidedmundson, plasma-devel, kwin,

D8153: Try to read CPU clock from cpufreq/scaling_cur_freq instead of /proc/cpuinfo

2017-10-05 Thread Fabian Vogt
fvogt added a comment. I could also open all sysfs files only once and then fseek+fscanf when the value is requested, but that would only exchange a continuous fopen+fclose with fseek+more complexity IMO. I'm fine with both approaches, but I favor KISS here. REPOSITORY R106 KSysguard

D8153: Try to read CPU clock from cpufreq/scaling_cur_freq instead of /proc/cpuinfo

2017-10-05 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma. REVISION SUMMARY From kernel 4.13 on, /proc/cpuinfo always reports the static normative CPU clock and not the current one. So try to read the frequency from cpufreq and only fall

D8152: [platforms/drm] Use a shared pointer for gbm_surface

2017-10-05 Thread Martin Flöser
graesslin added a comment. I have no idea why git think I copied from drm_buffer_gbm.h|cpp. I created the files from scratch. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8152 To: graesslin, #kwin, #plasma, subdiff Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff,

D8152: [platforms/drm] Use a shared pointer for gbm_surface

2017-10-05 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma, subdiff. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The gbm_surface is owned by the EglGbmBackend, but it's not the only one using it.

D8149: Add support for gtk3 theme variant feature.

2017-10-05 Thread Xuetian Weng
This revision was automatically updated to reflect the committed changes. Closed by commit R98:59c62319781b: Add support for gtk3 theme variant feature. (authored by xuetianweng). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8149?vs=20363=20371

D7481: RFC: Batch window changes events on XCB

2017-10-05 Thread Eike Hein
hein added a comment. Yes it is, pending rework. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7481 To: davidedmundson, #plasma Cc: ngraham, cfeck, broulik, hein, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8146: Don't try to override label heights - PlasmaComponents

2017-10-05 Thread Nicolas Fella
nicolasfella abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8146 To: nicolasfella, #plasma Cc: mart, davidedmundson, plasma-devel, #frameworks, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

tars up for Plasma 5.11.0

2017-10-05 Thread Jonathan Riddell
Tars are up for Plasma 5.11.0 on racnoss for packagers to package. Release is on Tuesday As with beta new tars are drkonqi and plasma-vault. Plasma vault has runtime dep on encfs. powerdevil has ddcutil dependency turned off on advise of the author. Do have a look over announce and changelog

Please review 5.11 errata

2017-10-05 Thread Jonathan Riddell
Any bugs or nasty gotchas in 5.11? Please review this page before release on Tuesday https://community.kde.org/Plasma/5.11_Errata Jonathan

D8146: Don't try to override label heights - PlasmaComponents

2017-10-05 Thread Marco Martin
mart added a comment. yes, this should stay. this was done in order to have labels automatically vertically align with other controls with just a Row (before RowLayout and Layout.alignment was a thing) as David says, will get rid of those once all is ported to new controls REPOSITORY

D8149: Add support for gtk3 theme variant feature.

2017-10-05 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R98 Breeze for Gtk BRANCH master REVISION DETAIL https://phabricator.kde.org/D8149 To: xuetianweng, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8134: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value with updated coding style

2017-10-05 Thread Thorsten Bonhagen
thorstenb added a comment. What you are missing is the Gui part to store the pin in the network-manager config file. This is correct. I've not implementet a GUI yet. This is just the part for reading the config file values. REPOSITORY R116 Plasma Network Management Applet REVISION

D8077: Fix org.kde.plasma.calendar with Qt 5.10

2017-10-05 Thread Fabian Vogt
fvogt added a comment. In https://phabricator.kde.org/D8077#152371, @broulik wrote: > Despite just having built p-f from git I still get > > > Error loading QML file: file:///usr/share/plasma/plasmoids/org.kde.plasma.fuzzyclock/contents/ui/main.qml:51:34: Type

D8134: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value with updated coding style

2017-10-05 Thread Jan Grulich
jgrulich added a comment. In https://phabricator.kde.org/D8134#152424, @thorstenb wrote: > The openconnect-plugin is not used for parsing this variable. Maybe it was in the past. > I add my pin in "nm-servie-defines.h" near NM_OPENCONNECT_KEY_USERCERT. It was not used. > I try to

D8134: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value with updated coding style

2017-10-05 Thread Thorsten Bonhagen
thorstenb updated this revision to Diff 20364. thorstenb edited the summary of this revision. thorstenb added a comment. fix for pin-value in middle of line REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8134?vs=20328=20364 BRANCH