D8350: Add categories in gallery desktop file

2017-10-17 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R169:68382196a5ef: Add categories in gallery desktop file (authored by arojas). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8350?vs=20924=20930 REVISION DETAIL

D8350: Add categories in gallery desktop file

2017-10-17 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8350 To: arojas, mart, apol Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

2017-10-17 Thread Luigi Toscano
ltoscano added a comment. There is already the "Plasma" tag and the plasma-devel is in the list of subscribers; I don't see the reason to add explicit reviewers, as the changes of the bug are notified in the proper place. REPOSITORY R102 KInfoCenter REVISION DETAIL

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

2017-10-17 Thread Nathaniel Graham
ngraham added a comment. Thanks. Would the "Plasma" review group be appropriate? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham Cc: ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

2017-10-17 Thread Luigi Toscano
ltoscano removed a reviewer: KDE Applications. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

2017-10-17 Thread Luigi Toscano
ltoscano added a comment. Removed the "KDE Applications" group: KInfoCenter is part of Plasma, not KDE Applications. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham Cc: ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot,

D8350: Add categories in gallery desktop file

2017-10-17 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 385430 TEST PLAN The gallery application appears in the Development section instead of "Lost and

D8219: Move the git find_package call to where it's used

2017-10-17 Thread Antonio Rojas
arojas closed this revision. arojas added a comment. Committed in https://phabricator.kde.org/R169:e4bd62964198cea6cb1ac24d8a5200556186edc1 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8219 To: arojas, mart, davidedmundson Cc: plasma-devel, apol,

D8276: [SideBar] enable LayoutMirroring for RTL

2017-10-17 Thread Elkana Bardugo
ttv20 closed this revision. ttv20 added a comment. committed REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8276 To: ttv20, broulik, davidedmundson Cc: davidedmundson,

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

2017-10-17 Thread Nathaniel Graham
ngraham added a reviewer: KDE Applications. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham, #kde_applications Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol,

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

2017-10-17 Thread Nathaniel Graham
ngraham requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8277: Background color for sidebar headers

2017-10-17 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D8277 To: progwolff, #plasma_workspaces, mart Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,

D8344: Add physicalSize to the Screens API

2017-10-17 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH screens-physical-size REVISION DETAIL https://phabricator.kde.org/D8344 To: graesslin, #kwin, #plasma, mart Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,

D8345: [QPA] Implement Screen on top of internal Screens API

2017-10-17 Thread Martin Flöser
graesslin added a dependency: D8344: Add physicalSize to the Screens API. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8345 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts,

D8344: Add physicalSize to the Screens API

2017-10-17 Thread Martin Flöser
graesslin added a dependent revision: D8345: [QPA] Implement Screen on top of internal Screens API. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8344 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening,

D8345: [QPA] Implement Screen on top of internal Screens API

2017-10-17 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The test DontCrashUseractionsMenu (Waylandonly) found an issue in our screen handling

D8344: Add physicalSize to the Screens API

2017-10-17 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Allows to share the implementation in a better way and is a requirement to get the Screen

D8321: Only check for legacy system tray icons if we're going to make one

2017-10-17 Thread David Edmundson
davidedmundson added a comment. Trace is different, so ...progress! I don't think there's anything specifically wrong with this patch in itself. I'll fix that and review the rest of this class. Sorry, Thanks for the quick feedback. REPOSITORY R289 KNotifications REVISION

Re: Bold font rendering

2017-10-17 Thread Julian Wolff
Am Freitag, 6. Oktober 2017, 13:49:07 CEST schrieb Guanpeng Xu: > Hello, > > I found an issue on bold font rendering in KDE Frameworks 5.37.0 using Qt > 5.9.1, on NixOS 17.09.1502.19879836d1. > > The issue was previously discussed here: https://marc.info/?l=kde=150 > 728730630509=2 The

D8338: Set transient parent for system tray menus

2017-10-17 Thread Martin Flöser
graesslin accepted this revision. graesslin added inline comments. INLINE COMMENTS > apol wrote in systemtray.cpp:216 > This looks wrong... nah, it's the common trick to create the windowHandle. Without the next line of code would crash. Don't ask me why Qt doesn't have proper API for it...

D8267: Correcting symlinks between col- and row-resize and split_v and _hBug 384864

2017-10-17 Thread Jack Ostroff
ostroffjh added a comment. Doing 'grep -ir "-resize" *' in the root of the repository returns no hits, I also looked at the results of grepping for resize and for split, and didn't see anything relevant. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D8267

D8321: Only check for legacy system tray icons if we're going to make one

2017-10-17 Thread Martin Flöser
graesslin added a comment. I'm sorry but it still deadlocks, see https://bugs.kde.org/show_bug.cgi?id=385867 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D8321 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, #frameworks, ZrenBot, progwolff,

D8166: Add DBus protocol to virtual keyboard

2017-10-17 Thread Martin Flöser
graesslin added a comment. I'm sorry, but the deadlock is not fixed. I just compiled the latest knotifications, logged out and in and still had the freeze. REPOSITORY R108 KWin BRANCH virt-keyboard-dbus REVISION DETAIL https://phabricator.kde.org/D8166 To: graesslin, #kwin, #plasma,

Plasma 5.11.1

2017-10-17 Thread Jonathan Riddell
https://www.kde.org/announcements/plasma-5.11.1.php Plasma 5.11.1 has been released with important fixes to task manager

"Bold font rendering"

2017-10-17 Thread Guanpeng Xu
I wrote to this list a message 11 days ago, but I do not receive a rejection or see it in the list. Could someone please take a look? Thanks. Best regards, Guanpeng Xu

D8325: kcm baloo: Fix extraction of folder basename for error message

2017-10-17 Thread Alexander Potashev
This revision was automatically updated to reflect the committed changes. Closed by commit R119:5a8691900fea: kcm baloo: Fix extraction of folder basename for error message (authored by aspotashev). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D8338: Set transient parent for system tray menus

2017-10-17 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > systemtray.cpp:216 > KAcceleratorManager::manage(desktopMenu); > +desktopMenu->winId(); > + > desktopMenu->windowHandle()->setTransientParent(appletInterface->window()); This looks wrong... REPOSITORY R120 Plasma Workspace BRANCH

D8163: Move StatusNotifierItem for VirtualKeyboard into a helper process

2017-10-17 Thread Marco Martin
mart added a comment. deadlock fixed in sni, https://phabricator.kde.org/D8166 should replace this REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8163 To: graesslin, #kwin, #plasma, mart Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,

D8320: Dictionary Engine: fix synchronization issues.

2017-10-17 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons BRANCH Plasma/5.11 REVISION DETAIL https://phabricator.kde.org/D8320 To: dfaure, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8286: Port away from PlasmaCore.Units in system settings modules

2017-10-17 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R119:06e2cf0d9771: Port away from PlasmaCore.Units in system settings modules (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D8221: keyboard navigation in systemsettings

2017-10-17 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R124:1b904566ba66: keyboard navigation in systemsettings (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8221?vs=20892=20893#toc REPOSITORY R124 System Settings CHANGES SINCE

D8221: keyboard navigation in systemsettings

2017-10-17 Thread Marco Martin
mart updated this revision to Diff 20892. mart added a comment. - some hacks to improve keyboard navigation for QQuickWidget - focus search field on startup - Merge branch 'master' into randa/accessibility - some keybaord navigation fixes - correctly navigate between the two

D8277: Background color for sidebar headers

2017-10-17 Thread Julian Wolff
progwolff added a comment. @mart ? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8277 To: progwolff, #plasma_workspaces, mart Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8286: Port away from PlasmaCore.Units in system settings modules

2017-10-17 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8286 To: davidedmundson, #plasma, mart Cc: mart, apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8286: Port away from PlasmaCore.Units in system settings modules

2017-10-17 Thread David Edmundson
davidedmundson updated this revision to Diff 20891. davidedmundson added a comment. Change units to Units REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8286?vs=20712=20891 REVISION DETAIL https://phabricator.kde.org/D8286 AFFECTED FILES

D8221: keyboard navigation in systemsettings

2017-10-17 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > SidebarMode.cpp:525 > +if (fe->reason() == Qt::TabFocusReason) { > + > qqw->rootObject()->metaObject()->invokeMethod(qqw->rootObject(), > "focusFirstChild"); > +} else if (fe->reason() ==

D8338: Set transient parent for system tray menus

2017-10-17 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D8338 To: davidedmundson, #plasma, mart Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8166: Add DBus protocol to virtual keyboard

2017-10-17 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH virt-keyboard-dbus REVISION DETAIL https://phabricator.kde.org/D8166 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot,

D8325: kcm baloo: Fix extraction of folder basename for error message

2017-10-17 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH fix-basename REVISION DETAIL https://phabricator.kde.org/D8325 To: aspotashev, plasma-devel, davidedmundson Cc: ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8321: Only check for legacy system tray icons if we're going to make one

2017-10-17 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R289:800908eaec7a: Only check for legacy system tray icons if were going to make one (authored by davidedmundson). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE